Commit Graph

58 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
21744a9708 Bug 1571764 - Subtract combobox display frame border-padding when inferring the height from line-height. r=mats,jfkthame
This fixes it and seems to be an acceptable fix... Should I make it conditional
on box-sizing: border-box for completeness?  The display frame has border-box
box-sizing, and not having it would be a bug, I'd think...

Differential Revision: https://phabricator.services.mozilla.com/D41939

--HG--
extra : moz-landing-system : lando
2019-08-15 09:41:15 +00:00
arthur.iakab
345e583583 Backed out changeset bd44d2dd0c02 (bug 1571764)for causing web platform test failures on select-1-block-size-001.html CLOSED TREE 2019-08-14 21:34:07 +03:00
Emilio Cobos Álvarez
d5c4354d05 Bug 1571764 - Subtract combobox display frame border-padding when inferring the height from line-height. r=mats,jfkthame
This fixes it and seems to be an acceptable fix... Should I make it conditional
on box-sizing: border-box for completeness?  The display frame has border-box
box-sizing, and not having it would be a bug, I'd think...

Differential Revision: https://phabricator.services.mozilla.com/D41939

--HG--
extra : moz-landing-system : lando
2019-08-14 16:06:46 +00:00
Emilio Cobos Álvarez
cf7beea50e Bug 1561794 - Do not crop display text of themed comboboxes due to padding. r=dbaron
This is a potential fix that I thought it was worth doing rather than
implementing Blink's platform-dependent silliness. This ensures that the display
frame always has enough space to display itself.

Note that it may still get clipped, if there's no room for both the display
frame and the button.

Differential Revision: https://phabricator.services.mozilla.com/D37922

--HG--
extra : moz-landing-system : lando
2019-07-20 14:54:33 +00:00
Csoregi Natalia
5c50393ac1 Backed out changeset 05c5e4d30587 (bug 1561794) for multiple failures e.g. test_bug320799.html. CLOSED TREE 2019-07-17 04:24:52 +03:00
Emilio Cobos Álvarez
d146066640 Bug 1561794 - Do not to crop display text of themed comboboxes due to padding. r=dbaron
This is a potential fix that I thought it was worth doing rather than
implementing Blink's platform-dependent silliness. This ensures that the display
frame always has enough space to display itself.

Note that it may still get clipped, if there's no room for both the display
frame and the button.

Differential Revision: https://phabricator.services.mozilla.com/D37922

--HG--
extra : moz-landing-system : lando
2019-07-16 23:11:42 +00:00
Mats Palmgren
c9053c4cfd Bug 1499184 - Add some inline-axis padding after the <select size=1> display frame to avoid the text being flush to the dropdown button when we have a display:none <option>. r=jwatt 2018-11-08 22:15:37 +01:00
L. David Baron
1e88f0f003 Bug 1369941: Replace single integers N in fuzzy() and fuzzy-if() with 0-N ranges. r=dholbert
This patch was written entirely by the following script:

  #!/bin/bash

  if [ ! -d "./.hg" ]
  then
    echo "Not in a source tree." 1>&2
    exit 1
  fi

  find . -regex '.*\(ref\|crash\)test.*\.list' | while read FILENAME
  do
    echo "Processing ${FILENAME}."
    # The following has four substitutions:
    # * The first one replaces the *first* argument to fuzzy() when it doesn't
    #   have a - in it, by replacing it with an explicit 0-N range.
    # * The second one does the same for the *second* argument to fuzzy().
    # * The third does the same for the *second* argument to fuzzy-if().
    # * The fourth does the same for the *third* argument to fuzzy-if().
    #
    # Note that this is using perl rather than sed because perl doesn't
    # support non-greedy matching, which is needed for the first argument to
    # fuzzy-if.
    perl -pi -e 's/(fuzzy\()([^ ,()-]*)(,[^ ,()]*\))/${1}0-${2}${3}/g;s/(fuzzy\([^ ,()]*,)([^ ,()-]*)(\))/${1}0-${2}${3}/g;s/(fuzzy-if\([^ ]*?,)([^ ,()-]*)(,[^ ,()]*\))/${1}0-${2}${3}/g;s/(fuzzy-if\([^ ]*?,[^ ,()]*,)([^ ,()-]*)(\))/${1}0-${2}${3}/g' "${FILENAME}"
  done

Differential Revision: https://phabricator.services.mozilla.com/D2974

--HG--
extra : moz-landing-system : lando
2018-08-09 20:10:21 +00:00
Mats Palmgren
30ae9d36e5 Bug 1246836 part 2 - Reftest. r=me 2018-01-10 20:09:18 +01:00
Jonathan Kew
3727305260 Bug 1318526 - pt 2 - Also remove unnecessary HTTP(../..) from reftest manifests now that tests run with relaxed file-URI origin restrictions. r=dbaron 2017-10-23 23:57:11 +01:00
Jonathan Kew
bf22003a9a Bug 1364714 - (re-landing) Update Freetype to version 2.8, and fix/annotate tests affected by changes to font metrics & rasterization. r=dholbert,jwatt,ryanvm,jfkthame 2017-08-22 09:20:05 +01:00
L. David Baron
af959c6c34 Bug 1380521 - Use a more reliably invalid initial mBSizeOfARow so that we reflow properly if it changes to zero. r=dholbert
This fixes a failure in layout/reftests/bugs/467084-1.html, triggered by
the primary patch in bug 1308876, on Android only (or on all platforms
if I add 'html { overflow: hidden }').

I confirmed locally (on Linux) that, without this patch, both
layout/reftests/bugs/467084-1.html with 'html { overflow: hidden }', and
the reftest added here, fail, but that with the patch they both pass.

MozReview-Commit-ID: 3SjTlnBngBV
2017-07-12 19:37:11 -07:00
Mats Palmgren
297b9d70e1 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz
MozReview-Commit-ID: IbwWM0FL6HF

--HG--
extra : source : bbb688fe1ba3f5201a190c6e25b693ef7272ea2d
2017-05-21 17:15:00 +08:00
Carsten "Tomcat" Book
00d4ea331d Backed out changeset bbb688fe1ba3 (bug 1365614) 2017-05-22 15:45:31 +02:00
Mats Palmgren
e706869580 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
Lee Salzman
ed014c1f54 Bug 1340627 - part 8 - reftest fuzzing for update to Skia m59. r=mchang 2017-05-11 09:54:15 -04:00
Wes Kocher
02015c2300 Merge m-c to autoland a=merge CLOSED TREE
MozReview-Commit-ID: 5T8pxvbfKXv
2017-05-10 17:29:04 -07:00
Wes Kocher
959de6c3e8 Backed out 9 changesets (bug 1340627) for graphical glitches a=backout
Backed out changeset 0b1371055c7f (bug 1340627)
Backed out changeset f152be1fadb7 (bug 1340627)
Backed out changeset c691e2ab6a0c (bug 1340627)
Backed out changeset 3cb4bceb8d79 (bug 1340627)
Backed out changeset 026aadd76d06 (bug 1340627)
Backed out changeset fdbd5d281287 (bug 1340627)
Backed out changeset 75fb0d9858a9 (bug 1340627)
Backed out changeset 0d4ec7d38a00 (bug 1340627)
Backed out changeset af6f19870b2a (bug 1340627)

MozReview-Commit-ID: 9dHr7xMZezY

--HG--
rename : gfx/skia/skia/src/core/SkBlitRow.h => gfx/skia/skia/include/core/SkBlitRow.h
rename : gfx/skia/skia/src/effects/SkGaussianEdgeShader.h => gfx/skia/skia/include/effects/SkGaussianEdgeShader.h
rename : gfx/skia/skia/src/xml/SkXMLParser.h => gfx/skia/skia/include/xml/SkXMLParser.h
rename : gfx/skia/skia/include/private/SkMessageBus.h => gfx/skia/skia/src/core/SkMessageBus.h
rename : gfx/skia/skia/src/gpu/ops/GrAAConvexPathRenderer.h => gfx/skia/skia/src/gpu/batches/GrAAConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/ops/GrAAConvexTessellator.h => gfx/skia/skia/src/gpu/batches/GrAAConvexTessellator.h
rename : gfx/skia/skia/src/gpu/ops/GrAAHairLinePathRenderer.h => gfx/skia/skia/src/gpu/batches/GrAAHairLinePathRenderer.h
rename : gfx/skia/skia/src/gpu/ops/GrAALinearizingConvexPathRenderer.h => gfx/skia/skia/src/gpu/batches/GrAALinearizingConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/ops/GrPathStencilSettings.h => gfx/skia/skia/src/gpu/batches/GrPathStencilSettings.h
rename : gfx/skia/skia/src/gpu/ops/GrStencilAndCoverPathRenderer.h => gfx/skia/skia/src/gpu/batches/GrStencilAndCoverPathRenderer.h
rename : gfx/skia/skia/include/private/GrGLSL_impl.h => gfx/skia/skia/src/gpu/glsl/GrGLSL_impl.h
extra : source : 761b3f55f10f3df16601ce62e4d15b0c558c0cfb
2017-05-10 10:01:18 -07:00
Lee Salzman
8c18901f07 Bug 1340627 - part 8 - reftest fuzzing for update to Skia m59. r=mchang
MozReview-Commit-ID: LN29P1I4EsW
2017-05-09 22:31:07 -04:00
Matt Brubeck
0c70ae6c1d Bug 1349651 - stylo: Implement HasAuthorSpecifiedRules. r=bholley
MozReview-Commit-ID: 8ta5KqKzncZ

--HG--
extra : rebase_source : 3ec29f283dc6bfec4d2a1676ab3f78296893d94b
2017-05-10 13:11:36 -07:00
Shing Lyu
c46f5d5baf Bug 1351548 - Remove reftest-stylo.lists. r=bholley
MozReview-Commit-ID: 8LoQ9xNnDnj
2017-04-28 11:15:58 +08:00
Shing Lyu
435db45b79 Bug 1351548 - Add stylo-vs-gecko expectations to reftest.lists. r=bholley
MozReview-Commit-ID: GOUGBsd05cn
2017-04-28 11:15:50 +08:00
Sebastian Hengst
ceff3b0678 Backed out changeset 1f9d0f8e65b9 (bug 1351548) 2017-04-26 13:13:05 +02:00
Sebastian Hengst
88c73138b1 Backed out changeset 4d8dfee7ebf3 (bug 1351548) 2017-04-26 13:12:59 +02:00
Sebastian Hengst
f46ebb0d94 Backed out changeset aebb0ceeb20a (bug 1351548) 2017-04-26 13:12:53 +02:00
Shing Lyu
96b400c04a Bug 1351548 - Remove reftest-stylo.lists. r=bholley
MozReview-Commit-ID: Gn0fbS4PZ7i
2017-04-26 18:21:52 +08:00
Shing Lyu
0673a3e783 Bug 1351548 - Switch from reftest-stylo.list to reftest.list on linux64-stylo. r=bholley
MozReview-Commit-ID: 3GHNhi3gdg9
2017-04-26 18:21:48 +08:00
Shing Lyu
dae014d9d5 Bug 1351548 - Add stylo-vs-gecko expectations to reftest.lists. r=bholley
MozReview-Commit-ID: GOUGBsd05cn
2017-04-26 18:21:43 +08:00
Manish Goregaokar
ed8b20527d Bug 1341102 - Update test expectations; r=emilio
MozReview-Commit-ID: JyT97bbnyLa
2017-04-25 15:08:02 -07:00
Manish Goregaokar
ff68276c10 Bug 1349417 - Part 9: stylo: Update test expectations; r=xidorn
MozReview-Commit-ID: 5SGrYUIhHOQ
2017-04-21 15:40:49 -07:00
Carsten "Tomcat" Book
d32c8f24cc Backed out changeset 49c8dc08ff64 (bug 1349417) 2017-04-19 08:31:48 +02:00
Manish Goregaokar
f1cf1ffa2a Bug 1349417 - Part 9: stylo: Update test expectations; r=xidorn
MozReview-Commit-ID: 5SGrYUIhHOQ
2017-04-18 21:36:48 -07:00
Iris Hsiao
2f57ea5bb4 Backed out 3 changesets (bug 1349417) for build bustage
Backed out changeset e6a9aaf8c102 (bug 1349417)
Backed out changeset fbdddabe4c8d (bug 1349417)
Backed out changeset c1ead1f0ab71 (bug 1349417)
2017-04-19 11:03:13 +08:00
Manish Goregaokar
cb05d3003e Bug 1349417 - Part 9: stylo: Update test expectations; r=xidorn
MozReview-Commit-ID: 5SGrYUIhHOQ
2017-04-18 19:31:07 -07:00
Xidorn Quan
6e6684128a Bug 1345696 part 8 - Update test expectations. r=heycam
MozReview-Commit-ID: 5zQjzFUKdR8

--HG--
extra : rebase_source : 18d7a9cc76a21ab2d90e75eb4194f61fcd9797de
2017-03-28 16:28:36 +11:00
Mats Palmgren
00b74113a3 Bug 1333482 part 4 - [css-ui] Amend all uses of '-moz-appearance:none' in tests to also specify 'appearance:none' (automated change). r=dholbert
MozReview-Commit-ID: BNOR5VRpV2E
2017-03-23 22:11:22 -07:00
Boris Zbarsky
fccccf142c Bug 1347411 part 5. Change stylo to correctly recompute style on the anonymous boxes that hang off comboboxes. r=heycam
I did manual testing for ::-moz-dropdown-list.  Unfortunately, the only way I
know to test it is to have a combobox in a non-e10s window and dynamically
change its background color, then drop down the dropdown and see whether it
picked up the changed background color.

MozReview-Commit-ID: B2RkW4otv4s
2017-03-15 14:00:43 -04:00
Boris Zbarsky
a16891fa05 Reenable some more stylo reftests. No bug. r=bzbarsky
MozReview-Commit-ID: BbRlPC60tvt
2017-02-24 10:49:37 -05:00
Boris Zbarsky
f35eb2c2a6 Reenable various stylo reftests that are loaded over HTTP. No bug. r=bzbarsky
MozReview-Commit-ID: KrPqplxJJwE
2017-02-23 18:17:56 -05:00
Boris Zbarsky
a11bfd53bd Bug 1341988. Reenable a bunch of stylo reftests that were disabled for reasons that are not relevant anymore. r=bz
MozReview-Commit-ID: CLqLHexhBX3

--HG--
extra : rebase_source : 07dfb89d0651240362395494fdd7ee94363430b6
2017-02-23 02:09:57 -05:00
Cameron McCormack
9c4ea5685f Bug 1334768 - stylo: Back out 800030115d2e and 404506488cfb for being completely wrong due to bug 1334938.
MozReview-Commit-ID: 8CGTqmtlguT
2017-01-30 16:49:54 +08:00
Cameron McCormack
7805d4716e Bug 1334768 - stylo: Test expectation adjustments for 2017-01-29 merge.
MozReview-Commit-ID: FFmvs6SHIwW
2017-01-29 15:31:56 +08:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Shing Lyu
11a1d3e940 Bug 1328825 - Update reftest-stylo.list and expectations. r=heycam
MozReview-Commit-ID: AMwdk5wvM0F
2017-01-10 15:50:59 +08:00
Sebastian Hengst
e5ce97f69a Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/forms. r=dholbert
MozReview-Commit-ID: FWNHc6zuarg
2016-10-09 09:51:29 +02:00
Shing Lyu
db11558e50 Bug 1288350 - Temporary reftest list for Stylo vs Gecko test r=heycam,manishearth
--HG--
extra : rebase_source : 4772418bd2813d4e79643a833eb09e47fe893d84
2016-09-05 11:45:39 +08:00
Lee Salzman
642347dba7 Bug 725119 - fuzz for reftests with Skia content on Android. r=mchang
MozReview-Commit-ID: 9p8ntO7YLQ4
2016-08-31 15:53:33 -04:00
Markus Stange
2e917fb8fa Bug 1236043 - Adjust reftests and reftest annotations for new invalid region simplification. r=jrmuizel
Make the test_transformed_scrolling_repaints* tests taller so that the top and the bottom of the scrolled area don't share the same tile.
Fuzz layout/reftests/text/wordwrap-03.html on Linux because the native textbox gradient is painted in a slightly different position depending on the invalid area.
Mark layout/reftests/forms/select/out-of-bounds-selectedindex.html as fuzzy on Android because some listbox rounded corner pixel differs with the new invalidation behavior.
Mark layout/reftests/bugs/456219-1c.html as fuzzy on Linux, reasons unknown. :-(
Disable flexbox-widget-flex-items-3.html because of bad file input drawing on Linux, see bug 1260965.

MozReview-Commit-ID: B5c1a8D0G8F

--HG--
extra : rebase_source : 3e281d035831c77246d0e439246fdab9395dc884
2016-04-18 14:18:44 -04:00
Mats Palmgren
13ebd582e0 Bug 1256190 - Tweak tests to fix intermittent orange. r=me 2016-03-14 06:56:00 -04:00
Mats Palmgren
70b192860d Bug 1255877 - Fix intermittent failure. r=me 2016-03-12 05:01:00 -05:00