Commit Graph

147 Commits

Author SHA1 Message Date
Andrew Halberstadt
92e089081b Bug 1529048 - Add '--rebuild=5' to the perf preset, DONTBUILD, r=davehunt
Differential Revision: https://phabricator.services.mozilla.com/D24887

--HG--
extra : moz-landing-system : lando
2019-03-28 16:55:56 +00:00
Andrew Halberstadt
574b9b89ea Bug 1523303 - [tryselect] Define 'mozharness_name' key in relevant TEST_SUITE definitions, r=gbrown
Some of these were working with the '<flavor>-<subsuite>' mechanism that was
previously being used, but better to be explicit wherever possible.

Depends on D25077

Differential Revision: https://phabricator.services.mozilla.com/D25078

--HG--
extra : moz-landing-system : lando
2019-03-27 18:42:48 +00:00
Andrew Halberstadt
5d91672933 Bug 1523303 - [mozharness] Normalize '-chunked' out of suite name when reading MOZHARNESS_TEST_PATHS in desktop_unittest.py, r=gbrown
Mozharness appends -chunked/-coverage to some suites, but the build system/test
resolver don't have any concept of these things. We need to normalize these out
for the purposes of MOZHARNESS_TEST_PATHS.

Differential Revision: https://phabricator.services.mozilla.com/D25015

--HG--
extra : moz-landing-system : lando
2019-03-27 15:59:55 +00:00
Andrew Halberstadt
573782c2eb Bug 1523303 - [tryselect] Add test making sure |mach try fuzzy <path>| generates suite names that mozharness recognizes, r=gbrown
It turns out bug 1489100 regressed the ability to specify test paths for most
suites by naively assuming that mozharness uses suite names that look like:

<flavor>-<subsuite>

In reality, there is no consistency to how suite names are generated. This test
does a few things:

1) Patches the moztest.TestResolver to return a list of all possible
suites/subsuites (assuming the lists in moztest.resolve are up to date).

2) Finds all the suites defined in the mozharness configs (e.g
linux_unittest.py), and uses these are parametrized inputs.

3) Checks that for each test suite,
DesktopUnittest._get_mozharness_test_paths() returns something.

I've marked all of the test suites that currently fail as expected. This way I
have a good sense of what needs to be fixed, and can validate my changes as I
move through the list.

Differential Revision: https://phabricator.services.mozilla.com/D25014

--HG--
extra : moz-landing-system : lando
2019-03-27 15:55:31 +00:00
Justin Wood
f45b1ff0aa Bug 1352113 - Shippable Builds - amend debugger tests presets. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D23437

--HG--
extra : moz-landing-system : lando
2019-03-27 13:45:30 +00:00
Cosmin Sabou
a93c1714d4 Backed out 19 changesets (bug 1352113) for causing upload symbol bustages. CLOSED TREE
Backed out changeset 4943b23813fe (bug 1352113)
Backed out changeset 4b9413d05816 (bug 1352113)
Backed out changeset 3e2b6a495e8c (bug 1352113)
Backed out changeset 51ab82722846 (bug 1352113)
Backed out changeset 4b027c970719 (bug 1352113)
Backed out changeset 6b65273fab78 (bug 1352113)
Backed out changeset d7deec98601a (bug 1352113)
Backed out changeset b95b3f4e5243 (bug 1352113)
Backed out changeset 7cefe92f88d5 (bug 1352113)
Backed out changeset f64dfaf86a2e (bug 1352113)
Backed out changeset 686c228e3579 (bug 1352113)
Backed out changeset dd2eddef8b43 (bug 1352113)
Backed out changeset fc16a3ecfe68 (bug 1352113)
Backed out changeset b31cbe91bdf7 (bug 1352113)
Backed out changeset 694eac65a72e (bug 1352113)
Backed out changeset 6044aedac9c4 (bug 1352113)
Backed out changeset 456538d78b36 (bug 1352113)
Backed out changeset 01699fb72384 (bug 1352113)
Backed out changeset 4a2e544fea0d (bug 1352113)
2019-03-26 22:26:29 +02:00
Justin Wood
2666b10daf Bug 1352113 - Shippable Builds - amend debugger tests presets. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D23437

--HG--
extra : moz-landing-system : lando
2019-03-26 17:59:25 +00:00
Andrew Halberstadt
422288906f Bug 1530038 - [tryselect] Move taskgraph cache to new srcdir state location, r=tomprince
Depends on D24187

Differential Revision: https://phabricator.services.mozilla.com/D24188

--HG--
extra : moz-landing-system : lando
2019-03-20 15:33:56 +00:00
Andrew Halberstadt
20deb1451e Bug 1530038 - [tryselect] Use target_task_set instead of target_task_graph, r=tomprince
The graph contains some extra things like toolchains, fetches and packaging
tasks that people will almost never want to run on their own. This change gets
them out of the default fuzzy selection interface, and makes it so --full is
needed to schedule them.

Differential Revision: https://phabricator.services.mozilla.com/D24187

--HG--
extra : moz-landing-system : lando
2019-03-20 19:16:38 +00:00
Andrew Halberstadt
da7628c7e8 Bug 1536621 - [tryselect] Limit the 'sample-suites' preset to a single raptor/talos task, r=jgraham
Differential Revision: https://phabricator.services.mozilla.com/D24097

--HG--
extra : moz-landing-system : lando
2019-03-20 19:16:36 +00:00
Dustin J. Mitchell
f488d1b253 Bug 1534283 - use default parameters for mach try fuzzy r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D23225

--HG--
extra : moz-landing-system : lando
2019-03-14 19:32:05 +00:00
Andrew Halberstadt
52d1bf00c2 Bug 1531360 - [try] Add a 'perf' preset for selecting raptor and talos tasks, r=rwood
Differential Revision: https://phabricator.services.mozilla.com/D22374

--HG--
extra : moz-landing-system : lando
2019-03-13 14:53:24 +00:00
Andrew Halberstadt
15fdaae87b Bug 1534375 - Fix intermittent failure in tools/tryselect/test/test_presets.py, r=gbrown
This makes sure this test doesn't actually generate tasks.

Differential Revision: https://phabricator.services.mozilla.com/D23132

--HG--
extra : moz-landing-system : lando
2019-03-13 14:53:26 +00:00
Andrew Halberstadt
a6193bafa0 Bug 1533043 - [chooser] Add a test for |mach try chooser|, r=gbrown
Depends on D22785

Differential Revision: https://phabricator.services.mozilla.com/D22788

--HG--
extra : moz-landing-system : lando
2019-03-12 13:49:25 +00:00
Andrew Halberstadt
246ff42fac Bug 1533043 - [chooser] Use a requirements file to install |mach try chooser| dependencies, r=davehunt
Not only is it best practice to pin dependencies and check hashes, but this
will allow tests to install these dependencies as well.

Depends on D22784

Differential Revision: https://phabricator.services.mozilla.com/D22785

--HG--
extra : moz-landing-system : lando
2019-03-13 14:44:30 +00:00
Jason Laster
a00df3516c No bug - Add damp tests to debugger-tests.
Differential Revision: https://phabricator.services.mozilla.com/D23305

--HG--
extra : moz-landing-system : lando
2019-03-13 12:49:19 +00:00
Andrew Halberstadt
ea09d14bd4 Bug 1533770 - [fuzzy] Fix query intersection when running presets with multiple queries, r=jgraham
Differential Revision: https://phabricator.services.mozilla.com/D22741

--HG--
extra : moz-landing-system : lando
2019-03-12 19:33:36 +00:00
Jason Laster
b0162f4644 No bug - Add xpcshell tests to the preset. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D23019

--HG--
extra : moz-landing-system : lando
2019-03-11 22:14:31 +00:00
Jason Laster
d0e5e67b0b Bug 1532809 - There should be Try preset debugger tests. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D22724

--HG--
extra : moz-landing-system : lando
2019-03-08 21:40:39 +00:00
Andrew Halberstadt
6df1fbd570 Bug 1533474 - [fuzzy] Fix paths with |mach try fuzzy|, r=gbrown
This fixes a regression from bug 1531886 and adds a test.

Differential Revision: https://phabricator.services.mozilla.com/D22575

--HG--
extra : moz-landing-system : lando
2019-03-08 00:12:41 +00:00
Andrew Halberstadt
5b8dcfd113 Bug 1533157 - [fuzzy] Document how to use -q/--query with various shells, DONTBUILD, r=jgraham
Differential Revision: https://phabricator.services.mozilla.com/D22388

--HG--
extra : moz-landing-system : lando
2019-03-07 10:05:21 +00:00
Andrew Halberstadt
6ee8586201 Bug 1531360 - [fuzzy] Add ability to intersect queries, r=jgraham
Differential Revision: https://phabricator.services.mozilla.com/D22028

--HG--
extra : moz-landing-system : lando
2019-03-06 16:14:00 +00:00
Andrew Halberstadt
029b7b915f Bug 1531886 - [tryselect] Stop allowing **kwargs in subcommand run functions, r=gbrown
This forces us to be more strict with what gets passed into the try selector.
This change means test_preset.py will error if someone makes a typo in an
in-tree preset.

Differential Revision: https://phabricator.services.mozilla.com/D22024

--HG--
extra : moz-landing-system : lando
2019-03-06 16:13:01 +00:00
Andrew Halberstadt
db5e67fdae Bug 1531886 - [tryselect] Delete template context from kwargs, r=gbrown
When we parse template arguments, we stuff them all in kwargs['templates'],
however we don't delete the old argument. This results in all kinds of unused
variables lying around in kwargs. E.g we would have both
kwargs['templates']['env'] and kwargs['env'] (the latter being unused). This is
the main reason why all the selector's run functions need to have a **kwargs at
the end of them.

Depends on D22022

Differential Revision: https://phabricator.services.mozilla.com/D22023

--HG--
extra : moz-landing-system : lando
2019-03-05 23:49:22 +00:00
Andrew Halberstadt
5e06797460 Bug 1531886 - [tryselect] Handle templates in mach_commands.py, r=gbrown
This was previously only in the cli parser because that was the only shared
place that ran for all selectors. Now that we have the 'self.run' function in
mach_commands.py, we can move it there. This move is also needed to allow us to
remove 'templates' from kwargs (which happens in the next commit).

Depends on D22021

Differential Revision: https://phabricator.services.mozilla.com/D22022

--HG--
extra : moz-landing-system : lando
2019-03-05 23:48:31 +00:00
Andrew Halberstadt
fae875eee3 Bug 1531886 - [tryselect] Use consistent 'run' method to kickstart all selectors, r=gbrown
This allows us to refactor mach_commands.py so we can call self.handle_presets
implicitly. This in turn gives us a future place to add shared code and makes
adding new selectors easier.

Differential Revision: https://phabricator.services.mozilla.com/D22021

--HG--
extra : moz-landing-system : lando
2019-03-06 17:34:44 +00:00
Andrew Halberstadt
bbce8d7a3b Bug 1513951 - [tryselect] Add some documentation for presets r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D21431

--HG--
extra : moz-landing-system : lando
2019-02-28 20:15:24 +00:00
Andrew Halberstadt
30fa8f8a4c Bug 1513951 - [tryselect] Implement in-tree try_presets.yml file r=gbrown
This creates a global preset file at:
tools/tryselect/try_presets.yml

Any presets defined here will be available for everyone to use.

Differential Revision: https://phabricator.services.mozilla.com/D21435

--HG--
extra : moz-landing-system : lando
2019-02-28 21:38:26 +00:00
Andrew Halberstadt
b1f7c90d52 Bug 1513951 - [tryselect] Pass preset path into PresetHandler's constructor r=gbrown
This will make it possible to have multiple instances of PresetHandler to
support multiple preset files.

Differential Revision: https://phabricator.services.mozilla.com/D21429

--HG--
extra : moz-landing-system : lando
2019-02-28 18:26:03 +00:00
Andrew Halberstadt
26d3e5b30a Bug 1530775 - [tryselect] Fix bug when migrating try syntax presets, r=kats,a=NPOTB
Differential Revision: https://phabricator.services.mozilla.com/D21250

--HG--
extra : rebase_source : 1688a24623f92134cd91de087d52cf8fc607476c
2019-02-26 14:33:03 -05:00
Andrew Halberstadt
91456de750 Bug 1518572 - [tryselect] Migrate old preset files to the new format r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D20524

--HG--
extra : moz-landing-system : lando
2019-02-22 23:25:54 +00:00
Andrew Halberstadt
5caae33416 Bug 1518572 - [tryselect] Store all arguments when saving a preset r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D20523

--HG--
rename : taskcluster/taskgraph/util/templates.py => tools/tryselect/util/dicttools.py
extra : moz-landing-system : lando
2019-02-25 19:47:29 +00:00
Andrew Halberstadt
b9afd5605b Bug 1518572 - [tryselect] Remove unused 'flask-wtf' dependency from |mach try chooser| r=gbrown
I forgot to remove this after re-implementing without this dependency.

Depends on D20521

Differential Revision: https://phabricator.services.mozilla.com/D20522

--HG--
extra : moz-landing-system : lando
2019-02-22 19:43:56 +00:00
Andrew Halberstadt
80facb6f27 Bug 1528980 - [tryselect] Print host:port before running the trychooser flask app, r=tcampbell
I'm not really sure why Flask isn't printing this for us, but it's not worth
investigating when the alternative is so easy.

Differential Revision: https://phabricator.services.mozilla.com/D20712

--HG--
extra : moz-landing-system : lando
2019-02-21 19:45:57 +00:00
Tom Prince
4ecf218463 Bug 1525736: [taskgraph] Allow looking up parameters by project for trust-domains other than gecko; r=dustin
Previously, this code looked parameters under `gecko.v2`, but that doesn't work
for projects using the out-of-tree taskgraph code, or Thunderbird. This moves
the parameter loading slightly later to vary the index used based on trust domain.

Differential Revision: https://phabricator.services.mozilla.com/D19028

--HG--
extra : moz-landing-system : lando
2019-02-14 21:34:49 +00:00
Andrew Halberstadt
66888b2e2c Bug 1526129 - Fix test failure in tryselect cram tests, r=jmaher
This fixes a regression from bug 1483228. It started printing a message to
stdout whenever the local state dir was generated. This caused a failure in
these cramtests since they depend on the stdout of the shell process being
identical.

To fix, make sure we trigger state dir creation in the setup script and
redirect to /dev/null.

Differential Revision: https://phabricator.services.mozilla.com/D19155

--HG--
extra : moz-landing-system : lando
2019-02-08 15:17:26 +00:00
Tom Prince
7c4e3eb5a8 No bug: [tryselect] Slightly improve the accuracy of the error message on parameter mismatch; r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D19024

--HG--
extra : moz-landing-system : lando
2019-02-07 19:38:13 +00:00
Andrew Halberstadt
4cdb2c3165 Bug 1483228 - [tryselect] Use get_state_dir(srcdir=True) to determine directory to store history state r=nalexander
This was previously implemented by creating the local state dir within the
global state dir (using a hash of the path in the name). This moves the
|mach try again| history state to the new local state dir.

It also updates the migration code to be a little more robust, ensuring we
don't accidentally lose people's history. This migration should be removed
at some point in the future (2020 seemed like a safe enough window).

Differential Revision: https://phabricator.services.mozilla.com/D15725

--HG--
extra : moz-landing-system : lando
2019-02-04 21:07:10 +00:00
Andrew Halberstadt
8bc7850637 Bug 1483228 - [mozboot] Simplify get_state_dir()'s return value r=nalexander
mozboot.util.get_state_dir() returns a tuple of (<path>, <bool). The bool
denotes whether or not the state dir came from an environment variable.

But this value is only used in a single place, and is very easy to test for
anyway. It's not worth the added complexity it imposes on all other consumers
of this function. Let's just make this function return the path.

Differential Revision: https://phabricator.services.mozilla.com/D15723

--HG--
extra : moz-landing-system : lando
2019-02-04 20:52:31 +00:00
Andrew Halberstadt
4222e67eac Bug 1400426 - [try] Add --exact argument to |mach try fuzzy|, r=jgraham
Passing in --exact reverses the behaviour of the ' operator. For example,
take the query "foo 'bar".

By default: foo is a fuzzy match and bar is an exact match.
With --exact: foo is an exact match and bar is a fuzzy match

Differential Revision: https://phabricator.services.mozilla.com/D16734

--HG--
extra : moz-landing-system : lando
2019-01-30 17:09:34 +00:00
Andrew Halberstadt
414d48031e Bug 1499822 - [tryselect] Implement |mach try chooser| r=sclements
Usage:

  $ ./mach try chooser

Will start a local flask server and server a "trychooser-like" page
that is dynamically generated from the taskgraph.

Differential Revision: https://phabricator.services.mozilla.com/D14903

--HG--
extra : moz-landing-system : lando
2019-01-09 17:04:39 +00:00
Andrew Halberstadt
b578a9b3ce Bug 1499822 - [lint] Enable codespell on tools/tryselect, r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D15588

--HG--
extra : moz-landing-system : lando
2019-01-09 17:06:44 +00:00
Andreea Pavel
a7eee8304c Backed out 3 changesets (bug 1499822) for breaking gecko decision task on a CLOSED TREE
Backed out changeset beb286aeae33 (bug 1499822)
Backed out changeset 9a330195eca6 (bug 1499822)
Backed out changeset f4bd2ef9b729 (bug 1499822)
2019-01-09 00:40:16 +02:00
Andrew Halberstadt
0c56961d92 Bug 1499822 - [tryselect] Implement |mach try chooser| r=sclements
Usage:

  $ ./mach try chooser

Will start a local flask server and server a "trychooser-like" page
that is dynamically generated from the taskgraph.

Differential Revision: https://phabricator.services.mozilla.com/D14903

--HG--
extra : moz-landing-system : lando
2019-01-08 16:46:57 +00:00
Andrew Halberstadt
6ac5500593 Bug 1499822 - [lint] Enable codespell on tools/tryselect, r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D15588

--HG--
extra : moz-landing-system : lando
2019-01-08 16:45:10 +00:00
Andrew Halberstadt
c8b2301a9f Bug 1517621 - [tryselect] Mock out entire vcs object in python tests, r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D15695

--HG--
extra : moz-landing-system : lando
2019-01-04 10:40:35 +00:00
Sebastian Hengst
767c971623 Backed out 21 changesets (bug 1492664) for breaking cron task for nightlies. a=backout
Backed out changeset a7d50dbb2c8e (bug 1492664)
Backed out changeset 2d876c4ece8b (bug 1492664)
Backed out changeset c82285d253de (bug 1492664)
Backed out changeset bf6d089640eb (bug 1492664)
Backed out changeset d9a7f2ce49c3 (bug 1492664)
Backed out changeset 06c466ab4323 (bug 1492664)
Backed out changeset c1ea4a10cc8d (bug 1492664)
Backed out changeset 4c63a04fdd47 (bug 1492664)
Backed out changeset 742b038bb1dd (bug 1492664)
Backed out changeset 911b4b0fb683 (bug 1492664)
Backed out changeset 870c8cec99e5 (bug 1492664)
Backed out changeset 77699b51336b (bug 1492664)
Backed out changeset 29f33f22fd8b (bug 1492664)
Backed out changeset e7f305408708 (bug 1492664)
Backed out changeset 335a92b1f424 (bug 1492664)
Backed out changeset c566f1c8dcdf (bug 1492664)
Backed out changeset c77ae59aba41 (bug 1492664)
Backed out changeset 9c35dd209c6b (bug 1492664)
Backed out changeset a972d6b4434e (bug 1492664)
Backed out changeset 5ea6f03f845e (bug 1492664)
Backed out changeset 0699d3873e44 (bug 1492664)

--HG--
extra : histedit_source : 5cb1f7e50f25d4a875c1a58c86b7dce902e1a89c%2C20f1ab1a843b612cfcc67cf5c6ff745d65abf076
2018-12-20 12:43:22 +02:00
Dustin J. Mitchell
4a0a6eae05 Bug 1492664 - set TASKCLUSTER_ROOT_URL and TASKCLUSTER_PROXY_URL; r=tomprince,glandium
Eventually, workers will provide these variables directly
(https://bugzilla.mozilla.org/show_bug.cgi?id=1460015).  But for now, this
ensures that TASKCLUSTER_ROOT_URL is set everywhere, and TASKCLUSTER_PROXY_URL
is set wherever the proxy is active.

The setup for the mach commands defaults to https://taskcluster.net for user
convenience.  When the production instance's URL changes, we can simply change
that default.

This changes the docker build process propagate TASKCLUSTER_ROOT_URL into the
docker images where necessary (using %ARG), specifically to create URLs for
debian repo paths.

--HG--
extra : rebase_source : 0626ebdb66a9f4078cb75ab71be256c334297363
2018-09-25 20:18:19 +00:00
Margareta Eliza Balazs
2e5e28f518 Backed out 16 changesets (bug 1492664) for breaking developer artifact builds, requested by standard8 a=backout
Backed out changeset 31e500489665 (bug 1492664)
Backed out changeset f4945658d45f (bug 1492664)
Backed out changeset 6d17291b8b92 (bug 1492664)
Backed out changeset 90f3faa36137 (bug 1492664)
Backed out changeset 0b229b00818a (bug 1492664)
Backed out changeset 5eb2c77d70a9 (bug 1492664)
Backed out changeset e1ebad5d89c5 (bug 1492664)
Backed out changeset 3017e5890739 (bug 1492664)
Backed out changeset c8b7e620eabf (bug 1492664)
Backed out changeset d3dfbd848236 (bug 1492664)
Backed out changeset 5c92bb5ac895 (bug 1492664)
Backed out changeset fb7cfca6ebc3 (bug 1492664)
Backed out changeset 0c4101230d4d (bug 1492664)
Backed out changeset b93a0fcc86f3 (bug 1492664)
Backed out changeset 6dc9522ee0bf (bug 1492664)
Backed out changeset 85d7f8b330eb (bug 1492664)
2018-12-19 11:45:29 +02:00
Dustin J. Mitchell
211a6cf5e3 Bug 1492664 - set TASKCLUSTER_ROOT_URL and TASKCLUSTER_PROXY_URL; r=tomprince,glandium
Eventually, workers will provide these variables directly
(https://bugzilla.mozilla.org/show_bug.cgi?id=1460015).  But for now, this
ensures that TASKCLUSTER_ROOT_URL is set everywhere, and TASKCLUSTER_PROXY_URL
is set wherever the proxy is active.

The setup for the mach commands defaults to https://taskcluster.net for user
convenience.  When the production instance's URL changes, we can simply change
that default.

This changes the docker build process to propagate TASKCLUSTER_ROOT_URL into
the docker images, and for good measure includes some code to use that value to
generate debian repo paths.

Differential Revision: https://phabricator.services.mozilla.com/D14196

--HG--
extra : moz-landing-system : lando
2018-12-18 05:37:41 +00:00