The autocomplete popup contains information about the context
it was opened in. If the context changes, the content of the
popup might be outdated, or plainly wrong.
Closing the popup seems like a safe way to handle this.
We take this as an opportunity to move the willNavigate handler
to webconsole-output-wrapper, where we can dispatch a new
WILL_NAVIGATE action to which reducers might react.
A test is added to make sure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D14153
--HG--
extra : moz-landing-system : lando
The functions needed to build the autocomplete request are moved
to the serviceContainer so it can be called from everywhere in
the code, and not only from the JsTerm.
Differential Revision: https://phabricator.services.mozilla.com/D12939
--HG--
extra : moz-landing-system : lando
The trait was added in 37 to handle older server,
but given how old it is now, I think it's safe
to remove it.
Differential Revision: https://phabricator.services.mozilla.com/D14424
--HG--
extra : moz-landing-system : lando
The autocomplete popup contains information about the context
it was opened in. If the context changes, the content of the
popup might be outdated, or plainly wrong.
Closing the popup seems like a safe way to handle this.
We take this as an opportunity to move the willNavigate handler
to webconsole-output-wrapper, where we can dispatch a new
WILL_NAVIGATE action to which reducers might react.
A test is added to make sure this works as expected.
Depends on D12939
Differential Revision: https://phabricator.services.mozilla.com/D14153
--HG--
extra : moz-landing-system : lando
The functions needed to build the autocomplete request are moved
to the serviceContainer so it can be called from everywhere in
the code, and not only from the JsTerm.
Differential Revision: https://phabricator.services.mozilla.com/D12939
--HG--
extra : moz-landing-system : lando
Depends on D14077
This test is a conversion of devtools/client/aboutdebugging/test/browser_service_workers_push.js
It turns out I forgot to file a bug to migrate this test, so doing it here.
Differential Revision: https://phabricator.services.mozilla.com/D14078
--HG--
rename : devtools/client/aboutdebugging/test/service-workers/push-sw.html => devtools/client/aboutdebugging-new/test/browser/resources/service-workers/push-sw.html
rename : devtools/client/aboutdebugging/test/service-workers/push-sw.js => devtools/client/aboutdebugging-new/test/browser/resources/service-workers/push-sw.js
extra : moz-landing-system : lando
Depends on D14075.
allowChromeProcess will allow to retrieve workers from children processes
Differential Revision: https://phabricator.services.mozilla.com/D14077
--HG--
extra : moz-landing-system : lando
Depends on D14074
The current code using request works now that actor points to a real
actor ID, so this doesn't really fix anything. It is a cleanup because we should
move away from using the request API. Also the current about:debugging uses
front.push() so this is better for consistency.
Differential Revision: https://phabricator.services.mozilla.com/D14075
--HG--
extra : moz-landing-system : lando
This is a followup to Bug 1506549 where some of the frontend
code was migrated to listen to worker updates on the content process fronts.
The current about:debugging was migrated, but not the new one.
Differential Revision: https://phabricator.services.mozilla.com/D14074
--HG--
extra : moz-landing-system : lando
This cleanup will help next refactorings.
Note that attachTestThread and attachTestTabAndResume are still using the callback style
as it is still being used by tests that aren't using threadClientTest helper.
MozReview-Commit-ID: 6FvoDtzEBmL
Depends on D13901
Differential Revision: https://phabricator.services.mozilla.com/D13902
--HG--
extra : moz-landing-system : lando
This isn't removing listTabs calls as these tests were using attachTestTab,
but all these tests are using testGlobal helper whereas they don't have to if they were using threadClientTest helper.
MozReview-Commit-ID: FPtYlDvYUeD
Depends on D13900
Differential Revision: https://phabricator.services.mozilla.com/D13901
--HG--
extra : moz-landing-system : lando
This isn't thread client test, but here we could share some more code with the memory tests
and use Target objects to retrieve the fronts.
MozReview-Commit-ID: C9S1VjTLrSF
Depends on D13899
Differential Revision: https://phabricator.services.mozilla.com/D13900
--HG--
extra : moz-landing-system : lando
All these tests are clearly copy pasting existing threadClientTest helper.
They might run as well against workers but today we don't run them there, so I used the doNotRunWorker flag.
MozReview-Commit-ID: 7k1lJ06WeGZ
Differential Revision: https://phabricator.services.mozilla.com/D13899
--HG--
extra : moz-landing-system : lando
This test is broken for a while as it doesn't wait for resumeDebuggerThenCloseAndFinish to finish...
If was trying to ensure that resumeDebuggerThenCloseAndFinish wasn't throwing.
The test is most about testing old debugger test helper rather than test a particular STR.
MozReview-Commit-ID: 3gAWOSxjFet
Depends on D13823
Differential Revision: https://phabricator.services.mozilla.com/D13824
--HG--
extra : moz-landing-system : lando
