Commit Graph

118 Commits

Author SHA1 Message Date
sotaro
e615d8edf3 Bug 1557257 - Rename KnowsCompositor* aForwarder to aKnowsCompositor r=nical
Differential Revision: https://phabricator.services.mozilla.com/D33928

--HG--
extra : moz-landing-system : lando
2019-06-07 12:27:05 +00:00
Markus Stange
da2dce5cff Bug 1544478 - Respect SharedRGBImage's stride during YUV->RGBA conversion. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D27600

--HG--
extra : moz-landing-system : lando
2019-04-16 17:02:59 +00:00
Alastor Wu
f076a8ece9 Bug 1540740 - part2 : using TimeUnit as input parameter for 'AdjustForStartTime()'. r=jya
There is no need to cast to `TimeUnit` to `int64` and then cast to `TimeUnit` again.

Differential Revision: https://phabricator.services.mozilla.com/D26758

--HG--
extra : moz-landing-system : lando
2019-04-11 17:32:54 +00:00
alwu
aebb6d8617 Bug 1540740 - part1 : let the return value of 'AdjustForStartTime()' to tell whether the adjustment is succeeded r=jya
Now the caller of `AdjustForStartTime()` should check the return value to know whether the adjustment is succeeded.

If the error happens the caller should handle it and return an error.

Differential Revision: https://phabricator.services.mozilla.com/D26756

--HG--
extra : moz-landing-system : lando
2019-04-11 20:43:00 +00:00
Bryce Van Dyk
e8c6250244 Bug 1542539 - MediaData::ValidateBufferAndPicture warns on 0 by 0 dimension data instead of asserting. r=jya
Warn instead of asserting since it's possible for decoders to give us 0 by 0
frames here.

Differential Revision: https://phabricator.services.mozilla.com/D26612

--HG--
extra : moz-landing-system : lando
2019-04-09 09:56:13 +00:00
Ryan Hunt
00e98538aa Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D21106

--HG--
extra : rebase_source : ea3f51c2c11247114deccbc86e90fb02b8a97257
2019-02-25 16:05:29 -06:00
Jean-Yves Avenard
85e13542f9 Bug 1531286 - Temporarily make an error a strong assertion to determine the root cause of various crashes. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D21513

--HG--
extra : moz-landing-system : lando
2019-02-28 11:18:18 +00:00
Jean-Yves Avenard
dc992b8658 Bug 1530322 - Abort trim if an overflow occurred during earlier time calculation. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D21209

--HG--
extra : moz-landing-system : lando
2019-02-26 17:32:54 +00:00
Jean-Yves Avenard
04019bde46 Bug 1530322 - P3. Add temporary diagnostics. r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D21173

--HG--
extra : moz-landing-system : lando
2019-02-26 09:10:04 +00:00
Narcis Beleuzu
06e372323d Backed out 3 changesets (bug 1530322) for bustages on Assertions.h . CLOSED TREE
Backed out changeset 65870fec6eea (bug 1530322)
Backed out changeset d5159dfc6d86 (bug 1530322)
Backed out changeset 68fd0947b767 (bug 1530322)
2019-02-26 09:39:14 +02:00
Jean-Yves Avenard
120c38f502 Bug 1530322 - P3. Add diagnostics. r=gerald
Depends on D21172

Differential Revision: https://phabricator.services.mozilla.com/D21173

--HG--
extra : moz-landing-system : lando
2019-02-26 06:39:57 +00:00
Jean-Yves Avenard
68176b56c7 Bug 1524890 - P13. [MSE] Mark frames as truncated when needed. r=bryce
There's two cases to handle.
1- A Frame isn't entirely contained between appendWindowStart and appendWindowEnd
2- A new frame is appended which overlaps partially an existing frame.

To achieve this we tweak the start time and duration of the sample added (case 1), or the frame about to be partially covered (case 2). We then set a flag that will indicate to the decoder that the decompressed frame will have to be truncated.

Differential Revision: https://phabricator.services.mozilla.com/D20172

--HG--
extra : moz-landing-system : lando
2019-02-22 09:21:05 +00:00
Jean-Yves Avenard
4377bd3b8b Bug 1524890 - P11. Remove duration from AudioData construction parameter. r=bryce
It can be determined from the size of the buffer and the number of audio frames. Additionally, it ensures that the duration of the frame is always exactly what the AudioData contains.

Differential Revision: https://phabricator.services.mozilla.com/D20170

--HG--
extra : moz-landing-system : lando
2019-02-22 09:19:47 +00:00
Jean-Yves Avenard
ca21a59533 Bug 1524890 - P10. Add AudioData::SetTrimWindow. r=bryce
Don't re-create a new trimmed AudioData when we want to remove some content. This remove the need for some copies.

Differential Revision: https://phabricator.services.mozilla.com/D20168

--HG--
extra : moz-landing-system : lando
2019-02-22 09:19:32 +00:00
Jean-Yves Avenard
dd3c534de5 Bug 1524890 - P6. Remove mFrames member from MediaData. r=bryce
The number of frames is only meaningful with audio as a VideoData always contain a single frame.
So we only have this member in AudioData, which will simplify the logic in a future commit where the number of frames present depends on the trimming filter applied.

Differential Revision: https://phabricator.services.mozilla.com/D20164

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:33 +00:00
Jean-Yves Avenard
964cc95e13 Bug 1524890 - P5. Make MediaData::Type an enum class. r=bryce
Make its use more explicit and less likely to be incorrect.

Differential Revision: https://phabricator.services.mozilla.com/D20163

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:18 +00:00
Jean-Yves Avenard
afe04d2952 Bug 1524890 - P3. Add AudioData::Data method that returns a Span. r=bryce
So that we never access the underlying buffer directly.

Differential Revision: https://phabricator.services.mozilla.com/D20161

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:04 +00:00
Jean-Yves Avenard
d41a4fc09b Bug 1524890 - P1. Remove unused method. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D20159

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:03 +00:00
Ehsan Akhgari
e5e885ae31 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset

--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
John Lin
80a3c5aa13 Bug 1425277 - p5: add Append() to MediaRawDataWriter. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D7561

--HG--
extra : moz-landing-system : lando
2018-11-26 18:28:31 +00:00
Sylvestre Ledru
804b8b8883 Bug 1204606 - Reformat of dom/media r=jya
# skip-blame

Differential Revision: https://phabricator.services.mozilla.com/D12251

--HG--
extra : moz-landing-system : lando
2018-11-19 13:25:37 +00:00
Jean-Yves Avenard
34eeec152b Bug 1495025 - P5. Add Windows P010 and P016 support for software decoder r=cpearce
As we do not have an IMF nor D3D11 NV12 image, we always require a full copy of the data that will deinterleave the chroma channels.

Depends on D7316

Differential Revision: https://phabricator.services.mozilla.com/D7318
2018-10-08 15:52:01 +02:00
Narcis Beleuzu
18849ef0ae Backed out 6 changesets (bug 1495025) for webgl2 failures on test_2_conformance2__textures__misc__npot-video-sizing.html
Backed out changeset 24d67618f6b9 (bug 1495025)
Backed out changeset 68efa7588ba8 (bug 1495025)
Backed out changeset 9f59a50dcc6d (bug 1495025)
Backed out changeset 7fd1f6103294 (bug 1495025)
Backed out changeset f1afe7e2a9e3 (bug 1495025)
Backed out changeset c62823871aca (bug 1495025)
2018-10-07 02:03:46 +03:00
Jean-Yves Avenard
8acdf2fe0e Bug 1495025 - P5. Add Windows P010 and P016 support for software decoder r=cpearce
As we do not have an IMF nor D3D11 NV12 image, we always require a full copy of the data that will deinterleave the chroma channels.

Depends on D7316

Differential Revision: https://phabricator.services.mozilla.com/D7318
2018-10-06 21:31:22 +02:00
Brindusan Cristian
070df1d4c1 Backed out 6 changesets (bug 1495025) for mochitest-webgl2 failures in test_2_conformance2__textures__misc__npot-video-sizing.html. CLOSED TREE
Backed out changeset 263d4f722174 (bug 1495025)
Backed out changeset 528dbc463c22 (bug 1495025)
Backed out changeset 25895d283d47 (bug 1495025)
Backed out changeset c3b43ee1092e (bug 1495025)
Backed out changeset c548d816019d (bug 1495025)
Backed out changeset 208624601a18 (bug 1495025)
2018-10-04 15:16:07 +03:00
Jean-Yves Avenard
6450a31107 Bug 1495025 - P5. Add Windows P010 and P016 support for software decoder r=cpearce
As we do not have an IMF nor D3D11 NV12 image, we always require a full copy of the data that will deinterleave the chroma channels.

Depends on D7316

Differential Revision: https://phabricator.services.mozilla.com/D7318

--HG--
extra : moz-landing-system : lando
2018-10-04 09:41:58 +00:00
Jean-Yves Avenard
b10364a15f Bug 1493198 - P2. Use enum for describing color depth. r=mattwoodrow
Depends on D6662

Differential Revision: https://phabricator.services.mozilla.com/D6663

--HG--
extra : moz-landing-system : lando
2018-09-25 20:44:55 +00:00
Emilio Cobos Álvarez
fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Nathan Froyd
a31fa9e19c Bug 1453437 - return UniquePtr from MediaRawData::CreateWriter; r=gerald
Returning UniquePtr is nicer than returning raw pointers, and has the
nice side effect of forcing us to clean up the uses of nsAutoPtr that
were hanging about.
2018-04-12 15:28:21 -04:00
Jean-Yves Avenard
5a631a5822 Bug 1432779 - P3. Properly set channel map layout after seeking. r=padenot
MozReview-Commit-ID: 5FY9hdaijhf
2018-03-24 10:57:58 +01:00
Dorel Luca
f41b03eca9 Backed out changeset 38577c007450 (bug 1424371) for Marionett test failure on testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py. CLOSED TREE 2018-02-19 22:15:23 +02:00
Milan Sreckovic
7571df7e7c Bug 1424371: Use BaseRect access methods instead of member variables in dom/ r=qdot
MozReview-Commit-ID: HXWhggOMIEK

--HG--
extra : rebase_source : 9c9eacf80d2b7f78faa82a1549170b98d12cdaa8
2018-02-19 12:56:10 -05:00
Dan Glastonbury
35b53a22df Bug 1428947 - Check plane width & stride constraints. r=mattwoodrow
MozReview-Commit-ID: HEcMG4JoEl3
2018-02-19 11:41:41 +10:00
Chris Pearce
b37bd17a56 Bug 1433344 - Convert encrypted AAC to ADTS before decryption. r=jya
MozReview-Commit-ID: IGmBfJtYsCi

--HG--
extra : rebase_source : d066644e848f8fb379607d0168960132881d7df8
2018-01-30 14:39:09 +13:00
Cosmin Sabou
b35f58da34 Backed out changeset 1fea6030657b (bug 1433344) for mda failures on EMEDecoderModule.cpp on a CLOSED TREE 2018-02-01 03:05:53 +02:00
Chris Pearce
328670db16 Bug 1433344 - Convert encrypted AAC to ADTS before decryption. r=jya
MozReview-Commit-ID: IGmBfJtYsCi

--HG--
extra : rebase_source : a0752ed6c85faf4333ae84a3e5b20695b5bf26a6
2018-01-30 14:39:09 +13:00
sotaro
901877f7a7 Bug 1405562 - Enable D3D11YCbCrImage usage with WebRender r=mattwoodrow 2017-12-01 18:01:35 +09:00
Cosmin Sabou
82ee4aee12 Backed out changeset 994147e6fd70 (bug 1405562) for build bustages on obj-firefox/dist/include/mozilla/layers/KnowsCompositor.h💯75 r=backout on a CLOSED TREE 2017-12-01 07:35:36 +02:00
sotaro
58de17aca4 Bug 1405562 - Enable D3D11YCbCrImage usage with WebRender r=mattwoodrow 2017-11-30 20:39:20 -08:00
Jean-Yves Avenard
557904d18a Bug 1409141 - Disable D3D11 YUV buffer copy on Windows 7. r=mattwoodrow
The crashes on Windows 7 appear to occur due to the D3D11 device being used on two different threads simultaneously. We do query the driver to determine if multithreaded access is supported, but they obviously aren't that cluey about it.

MozReview-Commit-ID: GZIk1Zf9xKQ

--HG--
extra : rebase_source : d5dacbb8244021397bbaee81fb51569b06c88736
2017-10-16 22:03:18 +02:00
Jean-Yves Avenard
0de5aed9f7 Bug 1405110 - P2. Never attempts to upload to D3D11 surface in parent process. r=mattwoodrow
Accessing the graphic device driver from the parent process, should the drivers crash have serious consequences (the whole browser dies).

MozReview-Commit-ID: EXXRBnDobQw

--HG--
extra : rebase_source : d5609f1e088c7bbe92d6e46e66e1fb5538d5caac
2017-10-09 11:10:18 +02:00
Jean-Yves Avenard
72e08420b1 Bug 1215089 - P3: Add mBitDepth member to YCbCr data structure. r=kamidphish,mattwoodrow
MozReview-Commit-ID: BNLawJOfj3w

--HG--
extra : rebase_source : f538373e317e3e1e5452c0a0d6e00e810148ea87
2017-06-29 23:09:20 +02:00
Sebastian Hengst
46807fbb50 Backed out changeset 3fc22c028eab (bug 1215089) 2017-10-04 16:26:09 +02:00
Jean-Yves Avenard
89b1091f27 Bug 1215089 - P2: Add mDepth member to YCbCr data structure. r=kamidphish
MozReview-Commit-ID: BNLawJOfj3w

--HG--
extra : rebase_source : 6cd0336506a8feda874f6bd6525da73a745d5100
2017-06-29 23:09:20 +02:00
Jean-Yves Avenard
9349efba14 Bug 1396515: Fix incorrect && and || operator placements. r=sylvestre
Includes some side 80 columns fix.

MozReview-Commit-ID: IXRoQfM0Hjc

--HG--
extra : rebase_source : 918cf87b2ce82c8de245dcb23cc359289ac5f21f
2017-09-04 11:27:43 +02:00
Alastor Wu
d5273690a3 Bug 1388660 - part1 : AudioData::IsAudible() should return false when its data is super small and near to zero. r=jwwang
When the value of data is too small to be heard, AudioData::IsAudible() should return false so that we won't show the sound indicator for silent media.

In this case, the loudness of reported video is -673 dBFS, it's impossible to be heard.

MozReview-Commit-ID: Ewiko7RpkeX

--HG--
extra : rebase_source : 692e1af570648546deabc3fe4ae4c4b36bf8f356
2017-08-17 11:02:11 +08:00
Nicholas Nethercote
90eaa02ea0 Bug 1382099 - Remove MOZ_WIDGET_GONK from dom/media/. r=gerald.
As well as the obvious #ifdefs, this allows DOMHwMediaStream to be
removed, and also the "phone-state-changed" observer.

--HG--
extra : rebase_source : 373280183e228bd4b9bd9d866959409f2444c77e
2017-07-24 10:08:55 +10:00
Kaku Kuo
4175fed6b6 Bug 1378691 P3 - return next key frame time back to MDSM; r=jwwang
MozReview-Commit-ID: LVhJ0DpM24c

--HG--
extra : rebase_source : 4aefd89a2cc2243538c248977bfff79731fc2946
2017-07-11 10:15:33 +08:00
Jean-Yves Avenard
de2ba98442 Bug 1223270: P3. Remove extra copy of YUV buffer on Windows. r=mattwoodrow,nical
MozReview-Commit-ID: JgbAwtLNr9e

--HG--
extra : rebase_source : 72bc0cd32d95fc6eadc0604c00b9f53227135557
2017-05-03 23:25:54 +02:00
Jean-Yves Avenard
10d2da1b08 Bug 1374596: P7. Fix includes as per coding style. r=padenot
MozReview-Commit-ID: 5WfOWcOoxg0

--HG--
extra : rebase_source : 988c09623e83a0d9188d9ff5d705314e2c43e756
2017-06-20 17:56:55 +02:00