Sebastian Hengst
95a418ca5b
Backed out changeset e0f9c56c15f0 (bug 1362947) for linting failures, e.g. at accessible/tests/mochitest/jsat/doc_content_text.html:15. r=backout
2017-05-11 10:15:55 +02:00
Mark Banner
256aeb441c
Bug 1362947 - Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support. r=jaws
...
MozReview-Commit-ID: 5fVG7akPnGM
--HG--
extra : rebase_source : f1b9eeb1b2048b551ee8c0a596e6395d0031cc4d
2017-05-08 10:29:47 +01:00
Mark Hammond
9761a9f6b7
Bug 1361965 - Provide access to a formautofill storage singleton. r=lchang
...
MozReview-Commit-ID: 6IbeuOmONxb
--HG--
extra : rebase_source : 44c5c1536b41457e945ab3e00466489929e163ff
2017-05-04 18:25:46 +10:00
Frederik Braun
cd1cbcef0f
Bug 1359350: Add no-eval rule to eslint config (and whitelist failures in tests) r=standard8
...
MozReview-Commit-ID: 4nYlX4sSdbF
--HG--
extra : rebase_source : cf610e7d8bf2b8dbd5a0d40c5b835bc6620c3bba
2017-05-08 14:50:50 +02:00
Kit Cambridge
5fc76a861d
Bug 1361171 - Remove CloudSync. r=markh
...
MozReview-Commit-ID: CjBsEZa6oIP
--HG--
extra : rebase_source : 965db37197242acf63e77dbcca74a2984532b4ff
2017-05-01 14:43:00 -07:00
Wes Kocher
4e89a77541
Merge m-c to autoland, a=merge
...
MozReview-Commit-ID: F7qkNALe0WT
2017-05-03 13:52:24 -07:00
Wes Kocher
21203b47b5
Merge inbound to m-c a=merge
...
MozReview-Commit-ID: JgXkqrOwl3N
2017-05-03 13:40:24 -07:00
Mark Banner
72059d82da
Bug 1360595 - Add a git pre-commit hook for running ESLint. r=mossop
...
MozReview-Commit-ID: 1YJL5Sd4dlb
--HG--
rename : tools/mercurial/eslintvalidate.py => tools/lint/eslint/hook_helper.py
extra : rebase_source : eec3ee2761dd7178de1562229bfda24c0859b4ae
2017-04-28 12:19:15 +01:00
Mark Banner
046debbc74
Bug 1360595 - Make the ESLint Mercurial pre-commit hook be run in and pass flake8 validation. r=mossop
...
MozReview-Commit-ID: 1GW59lKpVrI
--HG--
extra : rebase_source : bad1919b52fc29a9874090f314ad682e72840f70
2017-04-28 12:15:56 +01:00
Kershaw Chang
e8df9986bf
Bug 1351281 - Remove NetworkPrioritizer.jsm, r=dao
...
Since Necko has already given higher priority to http transactions from the focused window, we don't need NetworkPrioritizer.jsm anymore.
2017-05-03 03:28:00 +02:00
Dan Banner
f2a6a685fe
Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh
...
MozReview-Commit-ID: D6qH5XtEtHO
--HG--
extra : rebase_source : 8e4c319c7fb8b727ac0193e5dd78411e1ec2785c
2017-04-27 17:24:18 +01:00
Edouard Oger
b80261a3ec
Bug 1358648 part 3 - Remove Async, Services and XPCOMUtils from util.js. r=markh
...
MozReview-Commit-ID: 8na204K9cXp
--HG--
extra : rebase_source : 96e7738aa6612cf67543d50053f50c2bccf1ab7e
2017-05-02 16:57:37 -04:00
Edouard Oger
abba8c5b31
Bug 1358648 part 2 - Remove util.js Svc.{DefaultPrefs,Session,Idle, FormHistory} and Str. r=markh
...
MozReview-Commit-ID: Jc1th8Snvhv
--HG--
extra : rebase_source : dd950a5d7bb0f2cb2ea4f32c7b61eb2a15ae327d
2017-05-02 18:30:23 -04:00
Carsten "Tomcat" Book
8cb9279791
Backed out changeset e6177d883f37 (bug 1359540) for eslint failures
2017-05-02 09:25:45 +02:00
Dan Banner
0c2aa823c9
Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh
...
MozReview-Commit-ID: D6qH5XtEtHO
--HG--
extra : rebase_source : 3d8d878810c60dc339e196eaac0215f9f72cc829
2017-04-27 17:24:18 +01:00
Mark Banner
c49949be34
Bug 1359739 - Fix eslint-plugin-mozilla's globals import function to correctly handle 'importScripts(url)' cases. r=jaws
...
MozReview-Commit-ID: 30Ki21DYvzm
--HG--
extra : rebase_source : 076270b0475fb1e9694d5ab13918d5b877bee39b
2017-04-26 10:20:57 +01:00
Mark Banner
c4c1dd7179
Bug 1348997 - When ESLint checks for reinstall, check the file diffs rather than a version number. r=mossop
...
This should make it unnecessary to bump the version number of our self-built modules, by comparing the actual files.
MozReview-Commit-ID: GFbxBs4bc4Z
--HG--
extra : rebase_source : d96d465615254655ce0fa7af29503a534e795428
2017-04-24 10:52:10 +01:00
Carsten "Tomcat" Book
d9cce3c040
merge autoland to mozilla-central a=merge
2017-04-26 08:40:02 +02:00
Wes Kocher
5e8bdb175d
Merge inbound to m-c a=merge
...
MozReview-Commit-ID: A85cs7Yriqj
2017-04-25 13:53:00 -07:00
Mike Cooper
2440f29f89
Bug 1358310
- eslint-plugin-mozilla: Fix infinite loop when finding repo root. r=mossop
...
MozReview-Commit-ID: KrOH7qtiLwS
--HG--
extra : rebase_source : 7d3ec6e407c0096e45afc23e6e117533cb4b6522
2017-04-25 14:12:31 -07:00
Chris Peterson
7b85322694
Bug 1358949 - Lower eslint cyclomatic complexity threshold in some directories. r=standard8
...
We can lower the eslint cyclomatic complexity threshold in some directories without adding eslint suppression comments in any .js source files. We need to specify the complexity rule in accessible/.eslintrc because it doesn't inherit the mozilla/recommended rules. eslint's default complexity threshold is 20.
Also bump the eslint-plugin-mozilla version because we modified the mozilla/recommended rules.
MozReview-Commit-ID: 57T4gAjPH7z
--HG--
extra : rebase_source : 4565abfa722b9459cfb4e006e843da13ed7cffd4
extra : intermediate-source : 658588564c08c9fd5e60633d1457f24087de8570
extra : source : 7e0526e3b943419a80c0cd2fa462cabbf8925eb1
2017-04-23 19:23:18 -07:00
Chris Peterson
893e00d283
Bug 1358947 - Make eslint "max-nested-callbacks" rule an error. r=standard8
...
eslint's default max-nested-callbacks threshold is 10, but now we make it an error. We could further lower the max-nested-callbacks threshold globally to 8, like browser/.eslintrc.js, but that would require adding suppression comments in (two) more .js test files. 10 seems good enough for now since it's the eslint default.
We need to specify max-nested-callbacks in accessible/.eslintrc because it doesn't inherit the mozilla/recommended rules.
Also bump the eslint-plugin-mozilla version because we modified the mozilla/recommended rules.
MozReview-Commit-ID: JA41vsi4U7j
--HG--
extra : rebase_source : 2dd211ebd3b8cf83f67f26cac5244bec8978f0e2
extra : intermediate-source : 6f5e75502be394038543029e3cfd474c5b1c2e98
extra : source : a13437d73c97fabd073ab8a6f93e85a5084b7405
2017-04-21 23:00:26 -07:00
Mark Banner
580ed9c407
Bug 1358484 - Add an autofix option to ESLint's no-useless-parameters. r=florian
...
MozReview-Commit-ID: B8mQteJ1CzF
--HG--
extra : rebase_source : 7fa31b6c0a73529693f0a936d66f55651f0fd3b7
2017-04-21 14:34:37 +01:00
Mark Banner
021f1ff90a
Bug 1358540 - Change the *.lint files to be *.lint.py to better support editor integration & flake8 linting. r=smacleod
...
MozReview-Commit-ID: 4KK2GZK7xul
--HG--
rename : python/mozlint/test/linters/badreturncode.lint => python/mozlint/test/linters/badreturncode.lint.py
rename : python/mozlint/test/linters/explicit_path.lint => python/mozlint/test/linters/explicit_path.lint.py
rename : python/mozlint/test/linters/external.lint => python/mozlint/test/linters/external.lint.py
rename : python/mozlint/test/linters/invalid_exclude.lint => python/mozlint/test/linters/invalid_exclude.lint.py
rename : python/mozlint/test/linters/invalid_include.lint => python/mozlint/test/linters/invalid_include.lint.py
rename : python/mozlint/test/linters/invalid_type.lint => python/mozlint/test/linters/invalid_type.lint.py
rename : python/mozlint/test/linters/missing_attrs.lint => python/mozlint/test/linters/missing_attrs.lint.py
rename : python/mozlint/test/linters/missing_definition.lint => python/mozlint/test/linters/missing_definition.lint.py
rename : python/mozlint/test/linters/raises.lint => python/mozlint/test/linters/raises.lint.py
rename : python/mozlint/test/linters/regex.lint => python/mozlint/test/linters/regex.lint.py
rename : python/mozlint/test/linters/string.lint => python/mozlint/test/linters/string.lint.py
rename : python/mozlint/test/linters/structured.lint => python/mozlint/test/linters/structured.lint.py
rename : tools/lint/eslint.lint => tools/lint/eslint.lint.py
rename : tools/lint/flake8.lint => tools/lint/flake8.lint.py
rename : tools/lint/wpt.lint => tools/lint/wpt.lint.py
rename : tools/lint/wpt_manifest.lint => tools/lint/wpt_manifest.lint.py
extra : rebase_source : 97de88e0328e91347192672b848b286df1904ade
2017-04-21 17:31:15 +01:00
Carsten "Tomcat" Book
1dd975c180
Backed out changeset eec770d062b4 (bug 1358540) for bustage
...
--HG--
rename : tools/lint/eslint.lint.py => tools/lint/eslint.lint
rename : tools/lint/flake8.lint.py => tools/lint/flake8.lint
rename : tools/lint/wpt.lint.py => tools/lint/wpt.lint
rename : tools/lint/wpt_manifest.lint.py => tools/lint/wpt_manifest.lint
2017-04-25 10:15:07 +02:00
Mark Banner
7cad8fd464
Bug 1358418 - Be more informative about which file ESLint is failing on when getASTSource() hits a computed member expression. r=Mossop
...
MozReview-Commit-ID: GA4bEvJXH3O
--HG--
extra : amend_source : 1fc5729343f29e429a20e787eab13125ca3c91a2
2017-04-21 10:10:54 +01:00
Carsten "Tomcat" Book
be39101bce
Backed out changeset 93bf1142be38 (bug 1358418) for ml failure
2017-04-25 09:31:09 +02:00
Mark Banner
05789c2819
Bug 1358418 - Be more informative about which file ESLint is failing on when getASTSource() hits a computed member expression. r=mossop
...
MozReview-Commit-ID: GA4bEvJXH3O
--HG--
extra : rebase_source : 49fefac7e7ae224872cf121681d9cb2bf6f15eb8
2017-04-21 10:10:54 +01:00
Mark Banner
8e42062ea3
Bug 1358540 - Change the *.lint files to be *.lint.py to better support editor integration & flake8 linting. r=smacleod
...
MozReview-Commit-ID: 4KK2GZK7xul
--HG--
rename : tools/lint/eslint.lint => tools/lint/eslint.lint.py
rename : tools/lint/flake8.lint => tools/lint/flake8.lint.py
rename : tools/lint/wpt.lint => tools/lint/wpt.lint.py
rename : tools/lint/wpt_manifest.lint => tools/lint/wpt_manifest.lint.py
extra : rebase_source : 66e4b4f95109c2645d0fb7be273de343408b9406
2017-04-21 17:31:15 +01:00
Dan Banner
cbf1ee25cc
Bug 1351099 - Remove unused AddonLogging.jsm file r=rhelmer
...
MozReview-Commit-ID: B1mxqNZhpB
--HG--
extra : rebase_source : 02abddd18ec98fdd2d74eda053d161625fd96d3e
2017-04-19 16:28:41 +01:00
Frederik Braun
777b70a929
Bug 1358050: Add no-implied-eval rule to eslint config r=standard8
...
MozReview-Commit-ID: KdmpXq2rg1q
--HG--
extra : rebase_source : fc89233a590604e1035be4aebfee9cda894ee07e
2017-04-20 10:33:22 +02:00
Mark Banner
fbd29db04b
Bug 1357702 - Make eslint-plugin-spidermonkey-js handle paths correct on Windows to avoid Unexpected character issues on ESLint. r=mossop
...
MozReview-Commit-ID: LsQCgBOgceY
--HG--
extra : rebase_source : 337037ad78c223139a3531a8ca9a68b13dbcb013
2017-04-19 12:17:14 +01:00
Mark Banner
6419084416
Bug 1357502
- Change eslint-plugin-mozilla tests to use the mocha test harness to improve the output. r=mossop
...
MozReview-Commit-ID: 1xI0tBpbSgM
--HG--
extra : rebase_source : 227dc315767083e88ec88219771d66fade3072b2
2017-04-18 20:06:02 +01:00
Mark Banner
58e3fafe78
Bug 1357546 - Fix how relative paths are handled in Windows for the ESLint import-browser-window-globals rule. r=mossop
...
MozReview-Commit-ID: Q8YcLRSpkQ
2017-04-18 22:11:54 +01:00
Mark Banner
2e1696e256
Bug 1357393 - Correct getting the rootDir in createExports - used for publishing eslint-plugin-mozilla. r=mossop
...
Bump the version number to match what is currently published.
MozReview-Commit-ID: 8r8otQQBqBo
--HG--
extra : rebase_source : 1b7daac6b2852117ae08927fd5a09b2a7650d683
2017-04-18 13:56:19 +01:00
Sebastian Hengst
a7334b2896
Bug 1347709 and Bug 1356569 - Bump eslint plugin version to resolve conflict. r=instruction-by-florian a=bustage-fix
...
MozReview-Commit-ID: 2zp9hXqxT26
--HG--
extra : amend_source : 465b881899a40cf29d0f3d7dbdd883d8a61edb2c
2017-04-15 20:05:51 +02:00
Sebastian Hengst
8bd051237a
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: JpAhOPjgvkF
2017-04-15 19:59:24 +02:00
Mark Banner
f515ecdff3
Bug 1347709 - Allow modules.json to be loaded from a local version for out-of-tree uses of eslint-plugin-mozilla. r=mossop
...
MozReview-Commit-ID: 7RzAUqNJQ15
--HG--
extra : rebase_source : c71873fd9864032345fb48047f2c272c2703a210
2017-04-13 12:03:30 +01:00
Mark Banner
4ef57a002d
Bug 1347709 - Add a prepublish script to save the current globals for the published version of eslint-plugin-mozilla, and use that when not in mozilla-central. r=mossop
...
MozReview-Commit-ID: GHD7GQ0Pjnp
--HG--
extra : rebase_source : 8a8deeb0544799426baa820fa91a22eb9e1d3526
2017-04-12 18:02:53 +01:00
Mark Banner
b624a1a95b
Bug 1347709 - Add a .npmignore file to stop publishing unnecessary files for eslint-plugin-mozilla. r=mossop
...
MozReview-Commit-ID: BcZBIFM1Ugu
--HG--
extra : rebase_source : ca8cbc2e04cb96e98da5febdd82d8ac7393ebc8b
2017-04-06 12:04:52 +01:00
Mark Banner
d12d56b126
Bug 1355778 - Manual fix of ESLint issues in eslint-plugin-* due to the rule changes. r=mossop
...
MozReview-Commit-ID: Ieh4qkSORjW
--HG--
extra : rebase_source : 9ad2b0257d578eac6106ee16b97394b4f69d1ef3
2017-04-12 12:19:14 +01:00
Mark Banner
c8c632d328
Bug 1355778 - Autofix ESLint issues in eslint-plugin-* due to the rule changes. r=mossop
...
MozReview-Commit-ID: AGnEkeNuxhx
--HG--
extra : rebase_source : 668e5f11679c909b25d15da08c32ce8a1d05fef2
2017-04-12 12:15:13 +01:00
Mark Banner
6bf4da0caf
Bug 1355778 - Unify some of the eslint-plugin-* rules to match the Mozilla recommended configuration. r=mossop
...
MozReview-Commit-ID: IyLtlZCtMtH
--HG--
extra : rebase_source : cb7beeea5d6e59a4cb6503c3d80c65a206679315
2017-04-12 12:14:43 +01:00
Mark Banner
3dd96b34b3
Bug 1355776 - Upgrade ESLint to version 3.19.0 to pick up autofix improvements and other fixes. r=mossop
...
Pick up autofix improvements in 3.19.0. Upgrade eslint-plugin-react. Also fix issues with the package.json file and the ESLint node_modules upload script.
MozReview-Commit-ID: IDZ1n4qTTuv
--HG--
extra : rebase_source : aa97cd6f314ce10d16d12446e50a27d6f994a9f1
2017-04-12 12:07:01 +01:00
Florian Queze
457e21bc53
Bug 1356569 - Update the no-useless-parameters eslint rule to report trailing optional parameters for addObserver, appendElement and notifyObservers, r=jaws.
2017-04-14 21:51:40 +02:00
Sebastian Hengst
608dc9589d
Backed out changeset c724e1485608 (bug 1356569)
2017-04-14 23:39:15 +02:00
Florian Queze
9b6b71947a
Bug 1356569 - Update the no-useless-parameters eslint rule to report trailing optional parameters for addObserver, appendElement and notifyObservers, r=jaws.
2017-04-14 21:51:40 +02:00
Mark Banner
92c422a2d6
Bug 1342459 - Add a rule to automatically detect ContentTask.spawn and inject the relevant globals. r=mossop
...
This reduces the amount of places where we need to specify the mozilla/frame-script environment. It does have
the side effect of allowing those globals in the whole file, but that is what specifying the environment would
do, and this is also for mochitest test files only.
MozReview-Commit-ID: 1LLFbn6fFJR
--HG--
extra : rebase_source : 82a6934d90bbbbd25f91b7b06bf4f9354e38865a
2017-04-05 10:00:25 +01:00
Mark Banner
427e3b23dc
Bug 1342459 - Fix various no-undef issues in browser/base. r=mossop
...
MozReview-Commit-ID: CRYxu7copKb
--HG--
extra : rebase_source : bc176c5e6890ffc6a4e26cb9bc9d441d9486ce7b
2017-04-04 13:42:33 +01:00
Andrew McCreight
2f83bee3a7
Bug 1353174, part 1 - Turn ContentObservers.jsm into a process script. r=Gijs
...
This retains the advantage of running only once per process, while
avoiding the per-process overhead of a jsm.
MozReview-Commit-ID: 1N53MvRwUpg
--HG--
rename : browser/modules/ContentObservers.jsm => browser/modules/ContentObservers.js
extra : rebase_source : 6a502cff26fcb55526f97385274bbae871f5cc6c
2017-04-04 11:21:48 -07:00