With extended attribute attribution using exactly the same attribution strings as Windows (eg: no URLs), this turns out to be quite straightforward. Once we've pulled in the attribution string from the extended attribute, the existing parsing, validation, etc. just works.
The only wrinkle is that the extended attributes may have nul bytes or tabs that we need to strip away. (Tabs may be present because we use them to pad the attribution area when we prepare the DMG for attribution. Nul bytes may be present because we overwrite the entire attribution before updating the attribution data.)
Differential Revision: https://phabricator.services.mozilla.com/D189258
- Ensure that we hold a strong reference to the APZ event state before
calling ProcessSingleTap, as ProcessSingleTap fires events.
- Mark ProcessSingleTap as MOZ_CAN_RUN_SCRIPT since it can fire events.
Differential Revision: https://phabricator.services.mozilla.com/D190228
This patch lands an initial GeckoView session API for using toolkit
translations. This patch adds an initial session translate delegate,
functions to translate, detect languages, and restore to an original
page. The runtime API will follow in bug 1852313 and additional session
API changes are planned.
Differential Revision: https://phabricator.services.mozilla.com/D189228
This patch detects inband change for the HEVC playback so that we can
recreate decoder if the new config is different from the previous one.
Differential Revision: https://phabricator.services.mozilla.com/D187805
`READ_IN_RANGE_OR_RETURN` causes incorrectly reading bits multiple
times,so we remove it and modify the other macros to ensure that reading
bits should only be triggered once.
Differential Revision: https://phabricator.services.mozilla.com/D189871
When we call `nextEventMatchingMask` we send a "did launch app" notification to the OS workspace. If we do that before we call `[NSApp run]` accessibility isn't hooked up yet internally in AppKit and we fail to respond to a11y API queries.
Pumping Apple events is currently used for getting url requests in order to launch Firefox with the URLs loading correctly in a browser window. We can achieve the same result by using `application:openURLs:` in the delegate and calling `run` on the NSApp earlier and then stopping the loop in order to build the command line and finish initializing Firefox.
Also pumping the apple event queue should be deferred in `ProcessNextNativeEvent` until `[NSApp run]` is called.
Differential Revision: https://phabricator.services.mozilla.com/D184524
Automatic update from web-platform-tests
Make navigation-api/navigate-event/ resilient to starting with extra NavigationHistoryEntries
When WPT are run in-browser or via wptrunner, there may be additional
session history entries when the test starts, so the tests shouldn't
assume that they start with navigation.entries().length == 1 or
navigation.currentEntry.index == 0.
This is a workaround for https://github.com/web-platform-tests/wpt/issues/33590.
Change-Id: I978d492d5d31d110716d6a1d84732aff792aca14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4904223
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204863}
--
wpt-commits: 4cd570dc80fec7b17cad121e7ac866badf62df38
wpt-pr: 42233
Automatic update from web-platform-tests
gamepad: Check that the DocumentLoader is not null
Gamepad timestamps are reported relative to the navigationStart
timestamp, accessed from the DocumentLoader's DocumentLoadTiming.
In some scenarios the document may have been detached before the
NavigatorGamepad is initialized, causing the DocumentLoader to be
nullptr.
This CL checks that the DocumentLoader is non-null, and uses the
current time in place of navigationStart if it is null.
Bug: 1483777
Change-Id: Ib3efcf3a612cd4c1c543218fa5fb8568c7129dcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4899018
Reviewed-by: Alvin Ji <alvinji@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204813}
--
wpt-commits: 3ae2cb8c5b5ba61809da15318821a6c1fe54829f
wpt-pr: 42227
Automatic update from web-platform-tests
Optimize several things about DOM Parts [1/2]
See [1] for details. This CL makes these changes:
- Stop maintaining “live” parts lists across DOM mutations. This is
controlled by a new feature flag, DOMPartsAPIActivePartTracking,
that when disabled, short-circuits all of the part list maintenance
code during DOM mutations. This means that if DOM nodes that are
connected to parts are moved around in the DOM, including being
removed from the document, the cached parts list does not change.
- Update ToV8HelperSequence to work directly with Deques, and get
rid of getParts() code to convert to a HeapVector.
- Optimize ToV8HelperSequence to use iterators instead of array
indexing, which should also speed up all sequence bindings. (TBD)
- Change from FrozenArray<Part> to sequence<Part>. This eliminated
the overhead of Object::SetIntegrityLevel(), which was ~29% of the
total getParts() time.
- Add a fast path for PartRoot.replaceChildren when all children
are being removed.
- Inline IsValid().
- Call InsertBefore() instead of before() to avoid some extra
validity checks. This required making ConvertNodeUnionsIntoNode
public.
- Add PartRoot.getPartNode(n), which allows direct access to a
single Part's Node, to avoid wrapping up the entire parts list.
[1] https://docs.google.com/document/d/1wSbBV6tS-KLlHWxaK_FmEJFOwkY-pb8_YDoFJgDrbMg/edit
Bug: 1453291
Change-Id: I3df15b2a552fe9c2793a7f7f2095d632bcea8326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4878048
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204772}
--
wpt-commits: 27ccadd96797aec13652caaeaab3a428c06ab2d3
wpt-pr: 42083
Automatic update from web-platform-tests
Parse and use different reporting endpoints per feature in permissions policy
Change-Id: I1cc8a1ea185500d44ddb2718803c22f2038f66c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4473627
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204761}
--
wpt-commits: 592f7b1cf7c9fb40c514940950ae2120339d4251
wpt-pr: 42252
Automatic update from web-platform-tests
[FLEDGE]: Subdivide WPT tests.
FLEDGE tests tend to be fairly slow, since they can spawn a bunch of
processes. This CL subdivides most FLEDGE WPT tests into sets of 5
(one larger file into sets of 10), which should hopefully reduce flake
on the bots.
Fixed: 1481290
Change-Id: If708b33d0713e783cc53f014d9fbfe127ec1dc9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4909551
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204664}
--
wpt-commits: f6d8468144f5f9f8fe2e6b8ecdb1846ce08c3700
wpt-pr: 42312
Automatic update from web-platform-tests
Add test that "maintain-framerate" does what it says.
Adds a test that measures the bandwidth, cuts the bandwidth in half,
and then measures that framerate is maintained, but resolution is not.
Also adds more entropy to the "getNoiseStream()" video signal; the old
version generated a video stream of 8 Kbits/second in 640x480.
Bug: none
Change-Id: Iefe0a44b9686f1bb4bdd13ab63922c3d460c775e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3117645
Reviewed-by: Philipp Hancke <phancke@microsoft.com>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204584}
--
wpt-commits: 1af7ffeb926a3644c33bcbf7ab0a1bb6c2f0a824
wpt-pr: 30173
Automatic update from web-platform-tests
Fix WPT CSS Counters test
As per:
https://drafts.csswg.org/css-contain/#example-6932a400
and
https://github.com/w3c/csswg-drafts/issues/9116
counter() and counters() can cross the style containment boundary,
so the result should be 13 from the body's counter-reset.
Bug: 990657
Change-Id: Iee313a5ed6f487865b1b7c754aa45b736f6b8f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4836162
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204571}
--
wpt-commits: dcb79ca1856efaa5ac6b455d1f96f63e3038e663
wpt-pr: 41799
Automatic update from web-platform-tests
Update dependencies in HTML idlharness test
--
wpt-commits: 039581da9bf12f29ecd4a9915a04601def843278
wpt-pr: 42284
Automatic update from web-platform-tests
Ignore complex relative expression in css atan2()
Currently, we use the double values if the parameter is relative type.
However, if the parameter is an expression that includes the relative
value it cannot be resolved as a simple double value.
It causes a crash because trying to use the value that is not
resolved.
Therefore, parsing a failure if ResolvedUnitType() function returns
kUnknown which means complex relative expression at the parsing time
until supporting "Involving relative values in Non-Length CSS Math
Expressions" [1]
[1] https://crbug.com/1436612
Bug: 1476829
Change-Id: If920388de96d2838eccf4d76fecb050e414d29dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835559
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Seokho Song <seokho@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204500}
--
wpt-commits: 78701298a872dc884f7bd341108d0a5ff8c41bf2
wpt-pr: 42050
Automatic update from web-platform-tests
Update webcodecs decoder test as error callback is now executed before flush promise callbacks (#42285)
--
wpt-commits: 68cfc233182799e3c4edc2e6d7c43b7f795c1a2f
wpt-pr: 42285
Automatic update from web-platform-tests
Paint background invalidation when deleting the last element of TableRow
When the last element in a TableRow is deleted, it does not trigger
a redraw of the background,causing the background to persist.
After removing the last element of a row in a Table,
the size of the TableRow remains unchanged because it does not affect
the layout of the preceding elements.
Therefore, caching is used during rendering.
We should proactively trigger a redraw of this row when deleting
the last element of a table row.
Bug: 1487554
Change-Id: Ia45f5abf8ccd54781e8f0c1de04aebfa5cad552c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4900123
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204290}
--
wpt-commits: 6447f83eae831c2470b4e8eb5cd6af6fbbe0103e
wpt-pr: 42217
Automatic update from web-platform-tests
Revert "[fetch-later] Force sending when BackgroundSync permission is off"
This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
Original change's description:
> [fetch-later] Force sending when BackgroundSync permission is off
>
> The [privacy decision][1] suggests: after user navigates away from
> a page, any pending requests left in the page should not be sent
> if [BackgroundSync permission][2] is off (default is on in Chrome).
>
> This CL forces sending out deferred requests on entering
> BackForwardCache if the page's BackgroundSync permission is off.
>
> [1]: https://github.com/WICG/pending-beacon/issues/3#issuecomment-1286397825
> [2]: https://wicg.github.io/background-sync/spec/
>
> Bug: 1465781
> Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204080}
Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Auto-Submit: Jian Li <jianli@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204260}
--
wpt-commits: 34e3a8a6cd3df89182ceea8c7b6e34a2b41c57d2
wpt-pr: 42294
Automatic update from web-platform-tests
[FedCM] Rename signin_url to login_url in the config file
For now, we also accept the old name for compatibility with existing
partner deployments, but we will remove this before shipping.
See updated spec PR:
https://github.com/fedidcg/FedCM/pull/436/filesR=npm@chromium.org
Bug: 1487726
Change-Id: If8e8a00c51bd7665fbdff9950315ec17d2054716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4905870
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204212}
--
wpt-commits: 904e94814db7a120917258b2f2dbea19b2e02b2c
wpt-pr: 42257
Automatic update from web-platform-tests
VT: Scale the inline boxes by dfs
When not using resize observer, we get the sizes in layout space.
We need to adjust to get to CSS space.
R=bokan@chromium.org, khushalsagar@chromium.org
Fixed: 1487948
Change-Id: Icddb7a53d169412e59c63db55a5f6d5ff825930e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4902698
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204179}
--
wpt-commits: 1a55dfeb09c159e4716d26ab671d5974b1646b7d
wpt-pr: 42260
Automatic update from web-platform-tests
Shared Storage: Change from per-origin to per-site budgets
We update to using per-site privacy budgets instead of per-origin
privacy budgets. This will align with enrollment enforcement, which is
per-site.
See also https://github.com/WICG/shared-storage/pull/112 and
https://github.com/WICG/shared-storage/pull/118.
To accomplish this, we migrate the `SharedStorageDatabase` to version
4, where the `budget_mapping` table's `context_origin` column has been
renamed to `context_site`, and any existing data for version 3
databases will have each serialized origin in that column replaced by
the corresponding serialization of the origin's site.
We also update the names and types of other members and parameters as
needed.
Bug: 1218540,1485598
Change-Id: I3d956f5f2cd54a5da76a20e7d63411b3b7fc51ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4879582
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204170}
--
wpt-commits: 25ddb07c3be61b730b94a7ff1bc17f5a4c7c1be2
wpt-pr: 42224
