Commit Graph

749 Commits

Author SHA1 Message Date
Kris Maglione
0962c2b731 Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00
harry
4399f1cef6 Bug 1551233 - Remove legacy urlbar mochitests. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D36346

--HG--
extra : moz-landing-system : lando
2019-07-09 21:48:05 +00:00
Jonathan Kingston
31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Henri Sivonen
a3c5e94b3e Bug 1549930 test adjustment - Disable browser_privatebrowsing_about.js due to perma-orange. r=r1cky
Differential Revision: https://phabricator.services.mozilla.com/D34993

--HG--
extra : moz-landing-system : lando
2019-06-14 13:39:24 +00:00
Ricky Rosario
c93b7f1009 Bug 1556867 - Remove the old about:private browsing code and pref r=fluent-reviewers,Mardak,Pike,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D33711

--HG--
extra : moz-landing-system : lando
2019-06-10 17:01:54 +00:00
Andrea Marchesini
7b8a38ee05 Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer
This patch reverts the second part of bug 1548432.

Differential Revision: https://phabricator.services.mozilla.com/D31267

--HG--
extra : moz-landing-system : lando
2019-05-22 06:31:22 +00:00
Mihai Alexandru Michis
68421ffba4 Backed out changeset 754426d70d28 (bug 1551729) for causing wpt failures. CLOSED TREE 2019-05-21 15:17:37 +03:00
Andrea Marchesini
32c1b6bb89 Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer
This patch reverts the second part of bug 1548432.

Differential Revision: https://phabricator.services.mozilla.com/D31267

--HG--
extra : moz-landing-system : lando
2019-05-21 08:57:21 +00:00
Dorel Luca
06b2e4e9d2 Backed out changeset 41c511d9528c (bug 1551729) for causing WPT failures in cookies/http-state/mozilla-tests.html. CLOSED TREE 2019-05-20 23:40:10 +03:00
Andrea Marchesini
b2c76acaf1 Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer
This patch reverts the second part of bug 1548432.

Differential Revision: https://phabricator.services.mozilla.com/D31267

--HG--
extra : moz-landing-system : lando
2019-05-20 15:16:06 +00:00
Ehsan Akhgari
782c6b7440 Bug 1548432 - Part 2: Ignore cookie name-value-pair strings without a "=" character; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29619

--HG--
extra : moz-landing-system : lando
2019-05-02 17:12:55 +00:00
Ehsan Akhgari
035a56f22c Bug 1481771 - Fix a race condition in browser_privatebrowsing_favicon.js by ensuring the promises that wait on conditions that happen during opening a tab are created before starting to open the tab; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29717

--HG--
extra : moz-landing-system : lando
2019-05-02 21:26:11 +00:00
Brian Grinstead
08992fb8e8 Bug 1546501 - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags r=mossop
This is an autogenerated commit, generated with https://bug1546501.bmoattachments.org/attachment.cgi?id=9060222

Differential Revision: https://phabricator.services.mozilla.com/D28559

--HG--
extra : moz-landing-system : lando
2019-04-24 19:43:57 +00:00
Arpit
474e467436 Bug 1483077 - Replaced reference to getBrowser with gBrowser r=robwu,dao
Differential Revision: https://phabricator.services.mozilla.com/D27418

--HG--
extra : moz-landing-system : lando
2019-04-17 00:04:54 +00:00
Mark Banner
dba6983e75 Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850

--HG--
extra : moz-landing-system : lando
2019-03-28 09:38:14 +00:00
Mark Banner
e91d6aa165 Bug 1531693 - For the PrivateBrowsing about page test, ensure we wait for autocomplete to finish. r=mak
This ensures test stability, and avoids leaking browser windows when we're closing the private browsing window in the test.

Differential Revision: https://phabricator.services.mozilla.com/D24530

--HG--
extra : moz-landing-system : lando
2019-03-26 18:01:05 +00:00
Oana Pop Rus
3bd8930fc3 Backed out 2 changesets (bug 1531693) for bc failures browser_privatebrowsing_about.js on a CLOSED TREE
Backed out changeset 4d2429507163 (bug 1531693)
Backed out changeset bf5460df1909 (bug 1531693)
2019-03-25 12:16:46 +02:00
Mark Banner
9ae7d04cfd Bug 1531693 - For the PrivateBrowsing about page test, ensure we wait for autocomplete to finish. r=mak
This ensures test stability, and avoids leaking browser windows when we're closing the private browsing window in the test.

Depends on D24529

Differential Revision: https://phabricator.services.mozilla.com/D24530

--HG--
extra : moz-landing-system : lando
2019-03-22 22:40:33 +00:00
Nicholas Cowles
81ddec3340 Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=Gijs,jaws,zbraniecki,flod
Differential Revision: https://phabricator.services.mozilla.com/D19250

--HG--
extra : moz-landing-system : lando
2019-03-18 18:05:13 +00:00
Ian Moody
7f284be66e Bug 1536653 - browser/ manual ESLint no-throw-literal fixes. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D24111

--HG--
extra : moz-landing-system : lando
2019-03-20 10:15:03 +00:00
Gurzau Raul
1dd267df2b Backed out changeset f73f629e8cca (bug 1517528) on request from jaws, CLOSED TREE. 2019-03-14 07:54:17 +02:00
Nicholas Cowles
2381e5849f Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=Gijs,jaws,zbraniecki,flod
Differential Revision: https://phabricator.services.mozilla.com/D19250

--HG--
extra : moz-landing-system : lando
2019-03-11 17:56:36 +00:00
Sebastian Hengst
d8f882a055 Backed out changeset 40ddf7d53eaa (bug 1517528) for flake8 failures 2019-03-01 11:42:02 +01:00
Nicholas Cowles
3de44bae14 Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=Gijs,jaws,zbraniecki,flod
Differential Revision: https://phabricator.services.mozilla.com/D19250

--HG--
extra : moz-landing-system : lando
2019-03-01 09:41:07 +00:00
Coroiu Cristina
dee1f146c8 Backed out changeset f4094fd9e1df (bug 1517528) for mochitest failures on a CLOSED TREE 2019-02-19 22:25:55 +02:00
Nicholas Cowles
6cab4dbf63 Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=jaws,zbraniecki,flod
Differential Revision: https://phabricator.services.mozilla.com/D19250

--HG--
extra : moz-landing-system : lando
2019-02-19 19:17:14 +00:00
Mark Banner
5f9fbe5d58 Bug 1522516 - Port browser_privatebrowsing_about.js to QuantumBar. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D20128

--HG--
extra : moz-landing-system : lando
2019-02-18 14:45:50 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Ricky Rosario
541c57ef5c Bug 1522486 - Perma-failing TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out when Gecko 66 merges to Beta on 2019-01-21 r=nanj
MozReview-Commit-ID: EuTmKnnYZtr

Differential Revision: https://phabricator.services.mozilla.com/D17513

--HG--
extra : moz-landing-system : lando
2019-01-24 20:35:24 +00:00
Ricky Rosario
11e3a9d15e Bug 1521984 - Can't drag downloaded PDF into about:privatebrowsing r=andreio
MozReview-Commit-ID: FQvRmltnss7

Differential Revision: https://phabricator.services.mozilla.com/D17304

--HG--
extra : moz-landing-system : lando
2019-01-23 18:21:26 +00:00
Ricky Rosario
bbd0796d2c Bug 1508364 - New UI for Private Browsing with Search r=andreio
MozReview-Commit-ID: 4WSGpL5Gvde

Differential Revision: https://phabricator.services.mozilla.com/D16854

--HG--
extra : moz-landing-system : lando
2019-01-21 20:14:26 +00:00
arthur.iakab
2ad2d8287a Backed out changeset 13f379946829 (bug 1508364) for functional ui test failures on private_browsing/test_about_private_browsing.py CLOSED TREE 2019-01-21 21:38:29 +02:00
Ricky Rosario
562d5578fe Bug 1508364 - New UI for Private Browsing with Search r=andreio
MozReview-Commit-ID: 4WSGpL5Gvde

Differential Revision: https://phabricator.services.mozilla.com/D16854

--HG--
extra : moz-landing-system : lando
2019-01-21 17:05:08 +00:00
Florens Verschelde
8c99a974e4 Bug 1505687 - Visual tweaks to about:privatebrowsing; r=johannh
- Fix bullet list margins.
- Improve :hover:active style for links.
- Improve narrow width layout: flexible list item width, more reasonable line-heights, move content blocking icon inline.

Differential Revision: https://phabricator.services.mozilla.com/D11579

--HG--
extra : moz-landing-system : lando
2018-11-12 13:35:38 +00:00
Ehsan Akhgari
f7ea96d531 Remove an unused variable, no bug 2018-10-30 20:29:40 -04:00
Johann Hofmann
ac88585965 Bug 1502361 - Remove Content Blocking toggle from about:privatebrowsing. r=Ehsan
This simply removes the content blocking section when TP is not enabled to avoid overpromising.
We may update this UI to alert the user that TP is off after the UX team comes back with a new design.

Differential Revision: https://phabricator.services.mozilla.com/D10071

--HG--
extra : rebase_source : 6cf70948a142309edf06da3a53874bde2d7372e5
2018-10-29 17:10:24 +01:00
Ehsan Akhgari
1590b70886 Bug 1501286 - Part 3: Remove support for tracking protection UI in about:privatebrowsing r=johannh
Depends on D9520

Differential Revision: https://phabricator.services.mozilla.com/D9521

--HG--
extra : moz-landing-system : lando
2018-10-25 16:46:49 +00:00
Dorel Luca
9529a31c66 Backed out 5 changesets (bug 1501286) for browser-chrome failures in browser/components/uitour/test/browser_trackingProtection.js
Backed out changeset cac0d4aa79d1 (bug 1501286)
Backed out changeset 578d395f555e (bug 1501286)
Backed out changeset d9940451c373 (bug 1501286)
Backed out changeset ca6c3139bdd2 (bug 1501286)
Backed out changeset 93d6f4d54f78 (bug 1501286)

--HG--
extra : rebase_source : 04083c456cd0df6243861cf53e5c39c08888c5ad
2018-10-25 17:52:59 +03:00
Ehsan Akhgari
df7b68e39e Bug 1501286 - Part 3: Remove support for tracking protection UI in about:privatebrowsing r=johannh
Depends on D9520

Differential Revision: https://phabricator.services.mozilla.com/D9521

--HG--
extra : moz-landing-system : lando
2018-10-25 13:35:22 +00:00
vinoth
7b887cfbbc Bug 1498885 - Assertion added in ContentSecurityPolicyPermitsJSAction() to not allow eval with SystemPrincipal r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D8683

--HG--
extra : moz-landing-system : lando
2018-10-15 08:02:04 +00:00
Bogdan Tara
9f17cab93a Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-20 01:03:35 +03:00
savvysiddharth
6c60223ffe Bug 1442845 - Added firefox will save clipboard in private browsing r=jdm
Before this patch, default home page of private sessions didn't inform about saving clipboard text. Now it informs that "copied text" will be saved in private session.

Differential Revision: https://phabricator.services.mozilla.com/D5941

--HG--
extra : moz-landing-system : lando
2018-09-17 20:48:28 +00:00
Jonathan Kingston
555f89c8d7 Bug 1485305 - browser/ tests Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4552

--HG--
extra : source : 2cf17e4974823d09d0fdd1aef64e69e840b288a1
extra : intermediate-source : 4771e6948a78507aa95a56e5b324d87dc82e9009
2018-08-29 15:44:56 +01:00
Brindusan Cristian
1db0587c0e Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
2018-09-19 18:47:27 +03:00
Jonathan Kingston
f57a3dbfb5 Bug 1485305 - browser/ tests Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4552

--HG--
extra : source : 2cf17e4974823d09d0fdd1aef64e69e840b288a1
2018-08-29 15:44:56 +01:00
Johann Hofmann
5c79352649 Bug 1490729 - Ensure that we send variation=0 for the TP UI on about:privatebrowsing. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D5680

--HG--
extra : moz-landing-system : lando
2018-09-12 18:12:45 +00:00
Jason Chapin
cb1b9f3b61 Bug 1457786 - Remove question-32.png. r=dao 2018-09-10 16:54:18 +02:00
Gijs Kruitbosch
2f2f4771a7 Bug 1488412 - make sure we wait for the right loads in browser_privatebrowsing_concurrent.js, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D5173

--HG--
extra : moz-landing-system : lando
2018-09-07 14:27:27 +00:00