Commit Graph

6549 Commits

Author SHA1 Message Date
Myk Melez
041a03ca0d Bug 1538372 - migrate revocations in single transaction r=keeler
cert_storage migrates revocations.txt via one transaction per entry, which can be expensive.  This change uses a single transaction to migrate all entries.

Differential Revision: https://phabricator.services.mozilla.com/D24579

--HG--
extra : moz-landing-system : lando
2019-03-22 23:16:43 +00:00
monikamaheshwari
d0003fb1d7 Bug 1533485 - nsNSSCertificateDB::handleCACertDownload shouldn't assert that it got a non-zero number of certificates r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D23921

--HG--
extra : moz-landing-system : lando
2019-03-22 17:29:48 +00:00
Brian Grinstead
a797a66d25 Bug 1531119 - Remove editMenuCommands.inc.xul and make editMenuOverlay.js in charge of constructing the relevant commandset DOM r=bdahl,NeilDeakin
This allows us to drop preprocessing and makes it simpler to add edit menu functionality to any type of document.

Differential Revision: https://phabricator.services.mozilla.com/D21446

--HG--
extra : moz-landing-system : lando
2019-03-21 14:18:48 +00:00
ffxbld
ead4572bc7 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D24335

--HG--
extra : moz-landing-system : lando
2019-03-21 12:29:05 +00:00
shindli
12c0629a98 Merge mozilla-central to inbound. a=merge CLOSED TREE
--HG--
rename : js/src/tests/non262/fields/basic.js => js/src/jit-test/tests/fields/basic.js
rename : js/src/tests/non262/fields/literal.js => js/src/jit-test/tests/fields/literal.js
rename : js/src/tests/non262/fields/mixed_methods.js => js/src/jit-test/tests/fields/mixed_methods.js
rename : js/src/tests/non262/fields/quirks.js => js/src/jit-test/tests/fields/quirks.js
2019-03-21 06:36:37 +02:00
Jeff Walden
44f0e9ca5f Bug 1533640 - Attempt to parse empty OCSP responses and let the parse attempt signal malformedness, instead of letting an empty response's |Vector<uint8_t>::begin() == nullptr| be the trigger of that signal. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D22656

--HG--
extra : rebase_source : 47afff90c0a07330664b95fbdd7d5cc7e8b5bb4d
2019-03-07 15:28:00 -08:00
Dana Keeler
2cf1772b43 bug 1535851 - proactively check for mixed content in nsSecureBrowserUIImpl r=Ehsan
If nsSecureBrowserUIImpl::GetState is never called, it never checks for mixed
content (this can happen when loading a page from the BF cache). To ensure that
we properly set the security state (via OnLocationChange -> OnSecurityChange),
nsSecureBrowserUIImpl must check for mixed content more proactively.

Differential Revision: https://phabricator.services.mozilla.com/D23945

--HG--
extra : moz-landing-system : lando
2019-03-19 23:56:55 +00:00
Andreea Pavel
c3cd918c5c Backed out 2 changesets (bug 1429796) for failing xperf on a CLOSED TREE
Backed out changeset b0d08863f7a5 (bug 1429796)
Backed out changeset 1bd54f8dfd9e (bug 1429796)
2019-03-20 00:03:49 +02:00
Dana Keeler
4ac9f8c38c Bug 1429796 - cert_storage: create rkv environment and store only once to avoid races r=mgoodwin,jcj
This patch also base64-decodes the API inputs before storing in the DB in
anticipation of being able to pass binary data directly (bug 1535752).

Differential Revision: https://phabricator.services.mozilla.com/D23430

--HG--
extra : moz-landing-system : lando
2019-03-18 20:08:30 +00:00
Mark Goodwin
59e0c373c3 Bug 1429796 Cleanup storage in CertBlocklist to allow easy addition of new types of pair (e.g. whitelist entries) r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D17668

--HG--
extra : moz-landing-system : lando
2019-03-19 17:48:04 +00:00
Dana Keeler
6110b2c67a bug 1515608 - allow end-entity certificates to be trust anchors for compatibility r=jcj
Differential Revision: https://phabricator.services.mozilla.com/D23240

--HG--
extra : moz-landing-system : lando
2019-03-18 20:01:02 +00:00
ffxbld
828e9e8e28 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D23842

--HG--
extra : moz-landing-system : lando
2019-03-18 13:15:59 +00:00
Trushita
89f80adb85 Bug 1534337: Add _ separator in certificate export filename. r=keeler
The certificate when exported had filename with no separator. Now added "_" separator to filename.

Differential Revision: https://phabricator.services.mozilla.com/D23492

--HG--
extra : moz-landing-system : lando
2019-03-14 16:43:50 +00:00
Dorel Luca
0e9ffb4c4f Merge mozilla-inbound to mozilla-central. a=merge 2019-03-14 18:25:40 +02:00
ffxbld
666a1bf678 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D23482

--HG--
extra : moz-landing-system : lando
2019-03-14 13:21:23 +00:00
Sylvestre Ledru
4aa92e3091 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D22514
2019-03-13 10:19:06 +01:00
ffxbld
87c6809c86 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D22957

--HG--
extra : moz-landing-system : lando
2019-03-11 12:32:36 +00:00
Alex Gaynor
da1241536a Bug 1513911 - Part 1 - added a missing include; r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D18995

--HG--
extra : moz-landing-system : lando
2019-02-27 19:53:15 +00:00
Dana Keeler
b3666e5fd0 Bug 1429796 - cert_storage: create rkv environment and store only once to avoid races r=mgoodwin,jcj
This patch also base64-decodes the API inputs before storing in the DB in
anticipation of being able to pass binary data directly (bug 1535752).

This patch additionally whitelists the DB backing file in talos.

Differential Revision: https://phabricator.services.mozilla.com/D23430

--HG--
extra : moz-landing-system : lando
2019-03-20 00:01:47 +00:00
Mark Goodwin
50887394d6 Bug 1429796 Cleanup storage in CertBlocklist to allow easy addition of new types of pair (e.g. whitelist entries) r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D17668

--HG--
extra : moz-landing-system : lando
2019-03-20 17:00:47 +00:00
arthur.iakab
77aa564189 Merge mozilla-central to autoland 2019-03-08 06:41:04 +02:00
arthur.iakab
013bbfceb8 Merge inbound to mozilla-central a=merge 2019-03-08 06:39:50 +02:00
Neil Deakin
3a201a0072 Bug 1512474, repaint arrow when certificate item in tree is opened or closed, r=mconley
--HG--
extra : rebase_source : 249c4990c412fa2c2a73039335d444c424e118ef
2019-03-07 17:57:24 -05:00
ffxbld
98f0be7a1d No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM,keeler
Differential Revision: https://phabricator.services.mozilla.com/D22489

--HG--
extra : moz-landing-system : lando
2019-03-07 18:17:56 +00:00
J.C. Jones
129044424e Bug 1523175 - land NSS a306d84e4c70 UPGRADE_NSS_RELEASE, r=me
--HG--
extra : rebase_source : bef6e6945c8f62707a5daa51bd1a1092769c9c20
2019-03-06 21:10:05 +00:00
Valentin Gosu
24a1ef834b Bug 1435141 - Check for user certificates on a background thread to avoid main thread IO r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D22488

--HG--
extra : moz-landing-system : lando
2019-03-07 20:34:12 +00:00
Tim Nguyen
48966022b4 Bug 1532632 - Followup: replace readonly="true" with readonly="readonly" in certViewer.xul's second textarea. r=me 2019-03-06 23:38:06 +01:00
m.boselli
df39ef8647 Bug 1532632 - Use readonly="readonly" instead of readonly="true" for textareas. r=ntim
--HG--
extra : amend_source : 52a13b4f2885dda845a284890accebe9d38baca4
2019-03-06 00:26:38 -03:00
Jorg K
2f9e653606 Bug 1434567 - Remove exception for Thunderbird from test_nonascii_path.js (bug 1433903, rev b76a1f5e05dc). r=emk 2019-03-05 15:23:00 +02:00
Tim Nguyen
fa021187df Bug 1513343 - Remove textarea binding and replace usages with html:textarea. r=bgrins,dao
Differential Revision: https://phabricator.services.mozilla.com/D15001

--HG--
extra : moz-landing-system : lando
2019-03-05 11:41:42 +00:00
Dana Keeler
1d52fa21dd bug 1521983 - remove some unused certificate pinning telemetry probes r=jcj,ulfr
Differential Revision: https://phabricator.services.mozilla.com/D19731

--HG--
extra : moz-landing-system : lando
2019-03-04 20:30:47 +00:00
J.C. Jones
718d652cc9 Bug 1520278 - Disable Intermediate Preloading on Android (and non-Nightly) r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D21952

--HG--
extra : moz-landing-system : lando
2019-03-04 18:06:55 +00:00
Kai Engert
e576732f18 Bug 1526302 - remove MD2 support from nsICryptoHash, clarifiy hash IDs must be synchronized with NSS hasht.h r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D19150

--HG--
extra : moz-landing-system : lando
2019-03-02 15:37:30 +00:00
Gurzau Raul
6b94d177d1 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-03-01 09:28:28 +02:00
J.C. Jones
bdd913c095 Bug 1520278 - Enable Intermediate Preloading on Nightly r=keeler
Maintain standard 100 certs/day rate.

Differential Revision: https://phabricator.services.mozilla.com/D21581

--HG--
extra : moz-landing-system : lando
2019-02-28 19:11:50 +00:00
ffxbld
935685c37a No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D21520

--HG--
extra : moz-landing-system : lando
2019-02-28 13:18:54 +00:00
Boris Zbarsky
9c5da5f234 Bug 1489308 part 9. Remove now-unused wyciwyg bits. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D17327

--HG--
rename : dom/html/test/browser_refresh_wyciwyg_url.js => dom/html/test/browser_refresh_after_document_write.js
rename : dom/html/test/file_refresh_wyciwyg_url.html => dom/html/test/file_refresh_after_document_write.html
extra : moz-landing-system : lando
2019-02-28 01:09:48 +00:00
Boris Zbarsky
2e5c884144 Bug 1489308 part 5. Align the work we do on document.open with the spec. r=mccr8,smaug
The main behavior changes are:

1) We no longer create a new Window when doing document.open().  We use the
same Window but remove all the event listeners on it and on the existing DOM
tree before removing the document's existing kids.

2) We no longer create a new session history entry.  The existing one always
gets replaced instead.

3) We now support document.open on documents that are not in a Window.

The reasons for the various test changes are as follows:

The change to browser_modifiedclick_inherit_principal.js is because we no
longer set the docshell to a wyciwyg URL when document.open() happens and the
test was depending on that to terminate.

browser_wyciwyg_urlbarCopying.js is being removed because it's trying to test
wyciwyg URIs, which no longer exist.

The changes in docshell/test/navigation are because document.open() no longer
affects session history.  One of the tests was testing the interactions there
and is being removed; another is being repurposed to just test that
document.open() does not affect history.length.

The change to test_x-frame-options.html is because document.open() now removes
event listeners on the window, which it didn't use to do (and in the specific
case in this test reused the existing inner too, so the listener was still
around in practice).  The new behavior matches other browsers.

The removal of test_bug172261.html is because document.open() no longer affects
session history, so you can't go back across it or forward to the "opened"
state, so the situation that test is trying to test no longer exists.

The changes to test_bug255820.html are because reloading a document after
document.open() will now just load the URL of the document that was the entry
document for the open() call, not reload the written content.  So there's not
much point testing reload behavior, and in this test it was just reloading the
toplevel test file inside the frames.

The change to test_bug346659.html is because now we no longer create a new
Window on document.open().

The change to test_bug1232829.html is because document.open() (implicit in this
test) no longer adds history entries, so the back() was just leaving the test
page instead of going back across the document.open().  The test is a
crashtest in practice, so might still be testing something useful about how
document.open() interacts with animations.

The change to test_bug715739.html is because the URL of the document after
document.open() is now the URL of the entry document, not a wyciwyg URL, so
reload() has different behavior than it used to.

The change to test_bug329869.html is because now when we go back we're
reloading the original document we had, not doing a wyciwyg load, and the
security info now doesn't include the untrusted script.

The changes to the wpt expectations are removing a bunch of expected failures
now that we pass those tests and disabling some tests that are fundamentally
racy and hence fail randomly.  The latter all have github issues filed for the
test problem.

The change to testing/web-platform/tests/common/object-association.js is fixing
tests that were not matching the spec (and were failing in other browsers).

The change to parser-uses-registry-of-owner-document.html is fixing tests that
were not matching the spec (and were failing in other browsers).

The change to document-write.tentative.html is because the test was buggy: it
was using the same iframe element for all its tests and racing loads from some
tests against API calls from other tests, etc.  It's a wonder it ever managed
to pass, independent of these patches (and in fact it doesn't pass according to
wpt.fyi data, even in Firefox).

The changes in html/browsers/history/the-history-interface are because
document.open() no longer adds history entries.  The test was failing in all
other browsers for the same reason.

The changes in html/browsers/history/the-location-interface are because
reloading a document.open()-created thing now loads the URL of the page that
was the entry document for the open() call.  The test was failing in all other
browsers.

The change to reload_document_open_write.html is because we now reload the url
of the document that entered the script that called open() when we reload, not
the written content.  Other browsers were failing this test too; Gecko with
the old document.open implementation was the only one that passed.

The change to http-refresh.py is to fix a test bug: it was not returning a
Content-Type header, so we were putting up helper app dialogs, etc.

The change to test_ext_contentscript.js is because we no create a new global
for document.open() calls.  Kris Maglione OKed this part.

Differential Revision: https://phabricator.services.mozilla.com/D17323

--HG--
extra : moz-landing-system : lando
2019-02-27 23:24:48 +00:00
Jonathan Kingston
f6680698bd Bug 1525319 - Removing context from OnDataAvailable r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
2019-02-27 23:42:27 +00:00
Jonathan Kingston
c4853316e7 Bug 1525319 - Removing context from OnStopRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20770

--HG--
extra : moz-landing-system : lando
2019-02-27 23:41:31 +00:00
Jonathan Kingston
f7e35ae39e Bug 1525319 - Removing context from OnStartRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20769

--HG--
extra : moz-landing-system : lando
2019-02-27 23:41:04 +00:00
Ryan Hunt
a6457a95be Bug 1523969 part 21 - Move method definition inline comments to new line in 'security/'. r=ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21122

--HG--
extra : rebase_source : cceafd5ad497236b2ce532727ad3435b8ea49fa7
extra : histedit_source : 630de35708f3a312d4b286a94d92536d086c4c9c
2019-02-25 16:12:13 -06:00
Dana Keeler
b330bb1c4c bug 1435858 - add a canary test that will fail before all of the test certificates expire r=Alex_Gaynor,jcj
This test should remind us to regenerate the test certificates next year before they actually expire.

Differential Revision: https://phabricator.services.mozilla.com/D21065

--HG--
extra : moz-landing-system : lando
2019-02-25 22:51:47 +00:00
Mathieu Leplatre
d19b2d9d78 Bug 1529584 - Distinguish Remote Settings errors when reporting uptake r=glasserc
Distinguish Remote Settings errors when reporting uptake

Differential Revision: https://phabricator.services.mozilla.com/D20836

--HG--
extra : moz-landing-system : lando
2019-02-25 20:22:16 +00:00
Nika Layzell
f3274c2fd2 Bug 1522579 - Part 1: Remove PContentBridge, r=mccr8
This actor won't be being used anymore, and acts only as a maintenance burden
for people working on this code (which we're doing pretty often these days!).

Differential Revision: https://phabricator.services.mozilla.com/D20549

--HG--
extra : moz-landing-system : lando
2019-02-25 20:04:45 +00:00
Alex Gaynor
0e903787da Bug 1415508 - use Span in constructing a byte input stream; r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D20687

--HG--
extra : moz-landing-system : lando
2019-02-25 19:11:20 +00:00
Andreea Pavel
cd1b27ad4d Backed out 6 changesets (bug 1522579) for build bustages on a CLOSED TREE
Backed out changeset 3c8320baa230 (bug 1522579)
Backed out changeset 0a288a3d85cd (bug 1522579)
Backed out changeset ecfd27e7d150 (bug 1522579)
Backed out changeset eda40fca0758 (bug 1522579)
Backed out changeset 5c7aafa32a0a (bug 1522579)
Backed out changeset a3c5a2c16411 (bug 1522579)
2019-02-25 18:19:38 +02:00
Nika Layzell
7924bfa435 Bug 1522579 - Part 1: Remove PContentBridge, r=mccr8
This actor won't be being used anymore, and acts only as a maintenance burden
for people working on this code (which we're doing pretty often these days!).

Differential Revision: https://phabricator.services.mozilla.com/D20549

--HG--
extra : moz-landing-system : lando
2019-02-25 15:51:10 +00:00
ffxbld
16c1dcf80f No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D20998

--HG--
extra : moz-landing-system : lando
2019-02-25 14:21:37 +00:00
Dorel Luca
4a4dcd57fa Backed out 4 changesets (bug 1525319) for Android failures in dom/base/test/test_progress_events_for_gzip_data.html
Backed out changeset b73f033efb41 (bug 1525319)
Backed out changeset 1d318d5c6b98 (bug 1525319)
Backed out changeset 6d73418988d4 (bug 1525319)
Backed out changeset 84ca79bd2dc3 (bug 1525319)
2019-02-25 04:06:11 +02:00