Commit Graph

662327 Commits

Author SHA1 Message Date
Boris Chiou
0d2240d1bd Bug 1568615 - Accept percentage for shape-image-threshold. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D39241

--HG--
extra : moz-landing-system : lando
2019-07-24 21:37:22 +00:00
Mike Shal
ff39c620e5 Bug 1560164 - Pull out common variables in instrumented-build/kind.yml; r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D39240

--HG--
extra : moz-landing-system : lando
2019-07-24 23:28:12 +00:00
Alexis Beingessner
e64ad7178d Bug 1568395 - Add more useful error messages to webrender_api. r=kamidphish
Differential Revision: https://phabricator.services.mozilla.com/D39236

--HG--
extra : moz-landing-system : lando
2019-07-24 22:55:51 +00:00
Timothy Nikkel
3bd09021a9 Bug 1562184. Have a regular nsRegion for the window opaque region for non-retained cases. r=mattwoodrow
Not sure if we need this, but the window dragging regions have it, so in case we need to turn off retained display lists we have this and there will be no difference to before the patches in this bug.

Depends on D38589

Differential Revision: https://phabricator.services.mozilla.com/D38590

--HG--
extra : moz-landing-system : lando
2019-07-24 21:09:42 +00:00
Mike Hommey
05ba1d00a3 Bug 1568349 - Remove FetchesMixin. r=nalexander
With all mozharness-based jobs now using run-task (except aarch64
windows, see bug 1557614), and thus fetch-content, the FetchesMixin
mixin should not be required anymore.

Differential Revision: https://phabricator.services.mozilla.com/D39108

--HG--
extra : moz-landing-system : lando
2019-07-24 22:41:59 +00:00
Paul Bone
8666bb3c7d Bug 1568406 - Rename parameters in Memory.h r=sfink
I didn't notice that clang-tidy had flagged some issues with Bug 1564674.
This patch renames these parameters to to match those in the definitions of
these functions.

Differential Revision: https://phabricator.services.mozilla.com/D38973

--HG--
extra : moz-landing-system : lando
2019-07-24 18:32:13 +00:00
Andreea Pavel
14071390d5 Backed out 2 changesets (bug 1567892) for build bustages on a CLOSED TREE
Backed out changeset edcdfaa8a2b1 (bug 1567892)
Backed out changeset 3aef1ee02e9b (bug 1567892)
2019-07-25 08:26:29 +03:00
Edouard Oger
684e965f89 Bug 1556276 p2 - Build metrics-flow and legal FxA URLs. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D39033

--HG--
extra : moz-landing-system : lando
2019-07-25 01:12:31 +00:00
Edouard Oger
1c060fbfab Bug 1556276 p1 - Allow extraParams to be passed when constructing FxA URLs. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D39032

--HG--
extra : moz-landing-system : lando
2019-07-24 18:34:06 +00:00
Andrea Marchesini
00f3ae963f Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 2 - PProxyConfigLookup IPC protocol, r=bwc,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D39010

--HG--
extra : moz-landing-system : lando
2019-07-25 04:51:00 +00:00
Andrea Marchesini
6b1b4929af Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 1 - nsProtocolProxyService on parent process only, r=bwc,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D39009

--HG--
extra : moz-landing-system : lando
2019-07-24 18:32:26 +00:00
Nicholas Nethercote
d8d32dfe97 Bug 1563139 - Update comments mentioning StaticPrefs.h. r=glandium
StaticPrefs.h will be removed two commits from now, so update these comments.

The patch removes the comment above SetUsesContainerScrolling() because it's
wrong -- it did use static prefs when introduced by bug 1181832 but then
stopped using static prefs in bug 1470504 -- and makes it inlinable.

Differential Revision: https://phabricator.services.mozilla.com/D39133

--HG--
extra : moz-landing-system : lando
2019-07-25 04:08:23 +00:00
Nicholas Nethercote
cbaaacf6ae Bug 1563139 - Remove StaticPref{s,List}_accessibility.h. r=glandium
These files exist because they were the proof-of-concept first step for
splitting the static prefs header files. Now that those header files can be
generated from a script, we need to move the `accessibility.*` prefs into the
YAML file.

Differential Revision: https://phabricator.services.mozilla.com/D39132

--HG--
extra : moz-landing-system : lando
2019-07-25 04:08:14 +00:00
Bob Clary
0e4603dbfd Bug 1568623 - [test isolation] Add web-platform-tests support, r=jmaher.
Differential Revision: https://phabricator.services.mozilla.com/D39242

--HG--
extra : moz-landing-system : lando
2019-07-25 01:23:45 +00:00
Nicholas Nethercote
2c71663c5e Bug 1568516 - Allow a uint32_t static pref with a mirror value of never. r=KrisWright
There was a missing setter function for this combination, which hasn't been
used before.

Differential Revision: https://phabricator.services.mozilla.com/D39263

--HG--
extra : moz-landing-system : lando
2019-07-25 02:26:14 +00:00
Rob Lemley
437d692c12 Bug 1525373 - Support comm-checkout when using generic-worker with run-task. r=glandium
Fixes Thunderbird builds on Windows.

Differential Revision: https://phabricator.services.mozilla.com/D39269

--HG--
extra : moz-landing-system : lando
2019-07-25 02:24:24 +00:00
Daniel Varga
291822d4fb Backed out changeset 70404a86aea8 (bug 1568673) for gv-unit6 failure at org.mozilla.geckoview.test.MediaElementTest.webmFullscreenMedia 2019-07-25 05:15:58 +03:00
Dan Glastonbury
7041df5d0b Bug 1568107 - Collect nsRefreshDriver::Tick phase weighted telemetry. r=mattwoodrow,heycam
For a slow tick, where the processing time takes longer than 1/60th sec, record
telemetry for the percentage of that time spent in each sub-system processing
Events, Style), Reflow, Display and Paint.

Differential Revision: https://phabricator.services.mozilla.com/D38962

--HG--
extra : moz-landing-system : lando
2019-07-25 01:31:41 +00:00
Oana Pop Rus
15a4017037 Backed out changeset a1a4f3976b34 (bug 1564638) for wrench-deps bustages. on a CLOSED TREE 2019-07-25 04:26:08 +03:00
Bryce Van Dyk
7d4f2e2fa9 Bug 1566700 - Add tests for OS.File extended attribute MacOS functions. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D38965

--HG--
extra : moz-landing-system : lando
2019-07-25 01:13:03 +00:00
Bryce Van Dyk
69eee89b05 Bug 1566700 - Add functions to OS.File to set and get extended attributes on MacOS. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D38964

--HG--
extra : moz-landing-system : lando
2019-07-24 16:14:42 +00:00
James Teh
1ace808723 Bug 1568163: Don't return proxy wrappers from OuterDocAccessible::ChildAtPoint with eDeepestChild to prevent crashes when hit testing via XPCOM. r=yzen
On Windows, OuterDocAccessible::GetChildAt can return a proxy wrapper for a remote document.
These aren't real Accessibles and shouldn't be returned except to the Windows a11y code (which doesn't use eDeepestChild).
Calling ChildAtPoint on these will crash!
Therefore, just return null in this case.

Differential Revision: https://phabricator.services.mozilla.com/D39135

--HG--
extra : moz-landing-system : lando
2019-07-24 13:32:22 +00:00
Mike Hommey
791dd339ba Bug 1567739 - Update rust libc crate to 0.2.60. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D38816

--HG--
rename : third_party/rust/libc/src/unix/bsd/netbsdlike/openbsdlike/openbsd/aarch64.rs => third_party/rust/libc/src/unix/bsd/netbsdlike/openbsd/aarch64.rs
rename : third_party/rust/libc/src/unix/bsd/netbsdlike/openbsdlike/mod.rs => third_party/rust/libc/src/unix/bsd/netbsdlike/openbsd/mod.rs
rename : third_party/rust/libc/src/unix/bsd/netbsdlike/openbsdlike/openbsd/x86.rs => third_party/rust/libc/src/unix/bsd/netbsdlike/openbsd/x86.rs
rename : third_party/rust/libc/src/unix/bsd/netbsdlike/openbsdlike/openbsd/x86_64.rs => third_party/rust/libc/src/unix/bsd/netbsdlike/openbsd/x86_64.rs
rename : third_party/rust/libc/src/unix/notbsd/android/b32/arm.rs => third_party/rust/libc/src/unix/linux_like/android/b32/arm.rs
rename : third_party/rust/libc/src/unix/notbsd/android/b32/mod.rs => third_party/rust/libc/src/unix/linux_like/android/b32/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/android/b32/x86.rs => third_party/rust/libc/src/unix/linux_like/android/b32/x86.rs
rename : third_party/rust/libc/src/unix/notbsd/android/b64/aarch64.rs => third_party/rust/libc/src/unix/linux_like/android/b64/aarch64.rs
rename : third_party/rust/libc/src/unix/notbsd/android/b64/mod.rs => third_party/rust/libc/src/unix/linux_like/android/b64/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/android/b64/x86_64.rs => third_party/rust/libc/src/unix/linux_like/android/b64/x86_64.rs
rename : third_party/rust/libc/src/unix/notbsd/android/mod.rs => third_party/rust/libc/src/unix/linux_like/android/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/emscripten/align.rs => third_party/rust/libc/src/unix/linux_like/emscripten/align.rs
rename : third_party/rust/libc/src/unix/notbsd/emscripten/mod.rs => third_party/rust/libc/src/unix/linux_like/emscripten/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/emscripten/no_align.rs => third_party/rust/libc/src/unix/linux_like/emscripten/no_align.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/align.rs => third_party/rust/libc/src/unix/linux_like/linux/align.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/mips/align.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/align.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b32/arm.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b32/arm.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/mips/mips32.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b32/mips.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b32/mod.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b32/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b32/powerpc.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b32/powerpc.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b32/x86.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b32/x86.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b64/aarch64.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b64/aarch64.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/mips/mips64.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b64/mips64.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b64/mod.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b64/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b64/powerpc64.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b64/powerpc64.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/s390x/mod.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b64/s390x.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b64/sparc64.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b64/sparc64.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b64/x86_64.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b64/x86_64/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b64/not_x32.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b64/x86_64/not_x32.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/b64/x32.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/b64/x86_64/x32.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/other/mod.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/mips/no_align.rs => third_party/rust/libc/src/unix/linux_like/linux/gnu/no_align.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/mod.rs => third_party/rust/libc/src/unix/linux_like/linux/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/musl/b32/arm.rs => third_party/rust/libc/src/unix/linux_like/linux/musl/b32/arm.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/musl/b32/mips.rs => third_party/rust/libc/src/unix/linux_like/linux/musl/b32/mips.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/musl/b32/mod.rs => third_party/rust/libc/src/unix/linux_like/linux/musl/b32/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/musl/b32/powerpc.rs => third_party/rust/libc/src/unix/linux_like/linux/musl/b32/powerpc.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/musl/b32/x86.rs => third_party/rust/libc/src/unix/linux_like/linux/musl/b32/x86.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/musl/b64/aarch64.rs => third_party/rust/libc/src/unix/linux_like/linux/musl/b64/aarch64.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/musl/b64/mod.rs => third_party/rust/libc/src/unix/linux_like/linux/musl/b64/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/musl/b64/powerpc64.rs => third_party/rust/libc/src/unix/linux_like/linux/musl/b64/powerpc64.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/musl/b64/x86_64.rs => third_party/rust/libc/src/unix/linux_like/linux/musl/b64/x86_64.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/musl/mod.rs => third_party/rust/libc/src/unix/linux_like/linux/musl/mod.rs
rename : third_party/rust/libc/src/unix/notbsd/linux/no_align.rs => third_party/rust/libc/src/unix/linux_like/linux/no_align.rs
rename : third_party/rust/libc/src/unix/notbsd/mod.rs => third_party/rust/libc/src/unix/linux_like/mod.rs
extra : moz-landing-system : lando
2019-07-24 22:33:21 +00:00
Bryce Van Dyk
6b33621140 Bug 1566700 - Add File.OS macRemoveXAttr. r=Yoric
Add functionality to remove an extended attribute from a file. This
functionality is currently MacOS specific due to that being the only use case we
currently have (see bug 1566523).

Differential Revision: https://phabricator.services.mozilla.com/D38523

--HG--
extra : moz-landing-system : lando
2019-07-23 23:12:36 +00:00
Makoto Kato
f8907645db Bug 1568452 - Move ANDROID and ANDROID_PLATFORM to moz.configure r=froydnj
ANDROID_SOURCE is for gonk, so it is unnecessary now.

Differential Revision: https://phabricator.services.mozilla.com/D39149

--HG--
extra : moz-landing-system : lando
2019-07-24 13:41:20 +00:00
Eric Rahm
de3cb80766 Bug 1564638 - Update Linux to Rust beta 1.37. r=froydnj,glandium
Differential Revision: https://phabricator.services.mozilla.com/D37775

--HG--
extra : moz-landing-system : lando
2019-07-25 00:36:16 +00:00
Daniel Holbert
c3ae5a39a6 Bug 1568673: Add a few more assertions to validate that mobile viewport zoom factors are positive. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D39244

--HG--
extra : moz-landing-system : lando
2019-07-25 00:14:43 +00:00
Nick Alexander
dd80e00527 Bug 1564282 - Extract Perftest abstract base class. r=rwood,perftest-reviewers
This mechanical transform lays the foundation for generalizing the
underlying test runner.

Differential Revision: https://phabricator.services.mozilla.com/D37132

--HG--
extra : moz-landing-system : lando
2019-07-25 00:44:40 +00:00
Nick Alexander
07f31a8dc3 Bug 1564282 - Pre: Make it easier to work with mozbase in Raptor locally. r=ahal
This is the equivalent of .pth in virtualenv declarations.  It sets up
a .egg file with a `sys.path` addition, as far as I can tell.

Differential Revision: https://phabricator.services.mozilla.com/D37131

--HG--
extra : moz-landing-system : lando
2019-07-25 00:46:36 +00:00
Michael Kaply
bc25be866e Bug 1568246 - Disable Exceptions button if popup pref is locked. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D39058

--HG--
extra : moz-landing-system : lando
2019-07-23 19:25:15 +00:00
Emily Toop
5c825f981a Bug 1560641: Add a lock around mCapturePixelsResults. @geckoview-reviewers r=geckoview-reviewers,snorp
This is to ensure that multiple completions cannot be attempted on the same `GeckoResult`, resulting in crashes.

Differential Revision: https://phabricator.services.mozilla.com/D36929

--HG--
extra : moz-landing-system : lando
2019-07-24 16:23:30 +00:00
Emily Toop
8a99efca37 Bug 1553135 - Lock LayerViewSupport during detach so that other methods cannot be called during this time. r=geckoview-reviewers,snorp
This is caused by a race condition when the compositor is detached. Because the actual detachment happens in a new thread, `detach` can complete and release the lock on `mLayerViewSupport`, and `RecvScreenPixels` can obtain the lock, before `mLayerViewSupport` is properly cleaned up. We therefore check to ensure that `lvs` is not null before calling a method on it.

Differential Revision: https://phabricator.services.mozilla.com/D36928

--HG--
extra : moz-landing-system : lando
2019-07-24 15:26:31 +00:00
Andreea Pavel
fc92f585e2 Backed out 3 changesets (bug 1559244) for causing bug 1370046
Backed out changeset de76712278a6 (bug 1559244)
Backed out changeset 467caef2ef9c (bug 1559244)
Backed out changeset 17ab0c52dca0 (bug 1559244)
2019-07-25 17:42:32 +03:00
Gijs Kruitbosch
f114ac3f4a Bug 1567095 - fix styling of address inputs in preferences, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D39160

--HG--
extra : moz-landing-system : lando
2019-07-25 14:35:34 +00:00
Andreea Pavel
08dfeb92cf Backed out changeset b80d14f72e5b (bug 1563204) build bustges on a CLOSED TREE 2019-07-25 17:13:14 +03:00
Chris Hartjes
cedcaf443c Bug 1554758 - Add convenience methods for setting browser preferences; r=raphael
Differential Revision: https://phabricator.services.mozilla.com/D35851

--HG--
extra : moz-landing-system : lando
2019-07-25 14:04:45 +00:00
Julian Descottes
0ab30c1e08 Bug 1568823 - Simplify parser.js and rename to parser-helper r=nchevobbe
Depends on D39335
Looking in details at get(), the implementation can also be simplified

Differential Revision: https://phabricator.services.mozilla.com/D39338

--HG--
rename : devtools/shared/webconsole/parser.js => devtools/shared/webconsole/parser-helper.js
extra : moz-landing-system : lando
2019-07-25 13:21:03 +00:00
Julian Descottes
5689ca6238 Bug 1568823 - Move Parser.jsm to a regular module in devtools/shared/webconsole r=nchevobbe
Depends on D39333

Differential Revision: https://phabricator.services.mozilla.com/D39335

--HG--
rename : devtools/shared/Parser.jsm => devtools/shared/webconsole/parser.js
extra : moz-landing-system : lando
2019-07-25 13:17:11 +00:00
Julian Descottes
999495e12c Bug 1568823 - Stop exporting reflectionAPI from Parser.jsm r=nchevobbe
Depends on D39332

Differential Revision: https://phabricator.services.mozilla.com/D39333

--HG--
extra : moz-landing-system : lando
2019-07-25 13:15:12 +00:00
Julian Descottes
3920fcb9e9 Bug 1568823 - Remove all unused methods from Parser.jsm r=nchevobbe
Depends on D39321

Differential Revision: https://phabricator.services.mozilla.com/D39332

--HG--
extra : moz-landing-system : lando
2019-07-25 14:05:41 +00:00
Nicolas Chevobbe
14505fb3ac Bug 1559717 - Fix displaying getter value for getter returning falsy values. r=davidwalsh.
We were displaying result.value.throw if result.value.return
was falsy. But it can happen that a getter does return a
falsy value, and we want to display it.
So now we turn the expression the other way around, we first
check result.value.throw, and then default to result.value.return.
A mochitest is added to ensure we hav expected value for different
getters returning falsy values.

Differential Revision: https://phabricator.services.mozilla.com/D39136

--HG--
extra : moz-landing-system : lando
2019-07-25 13:55:14 +00:00
Nathan Froyd
6112863ed7 Bug 1563204 - diagnose issues on Mac with cross-language LTO early; r=dmajor
...rather than people running into peculiar crashes running their tests
because functions are pointing at the wrong thing.

It would be more robust to version-check `ld`, but I figure people
wanting to do local cross-language LTO builds is rare enough that
setting an environment variable and rerunning configure is not a huge
hardship.

Differential Revision: https://phabricator.services.mozilla.com/D36742

--HG--
extra : moz-landing-system : lando
2019-07-25 13:16:59 +00:00
ffxbld
b7828720b0 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D39331

--HG--
extra : moz-landing-system : lando
2019-07-25 13:20:25 +00:00
Julian Descottes
d55d46038c Bug 1563474 - Remove unused getScriptInfo from Parser.jsm r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D39321

--HG--
extra : moz-landing-system : lando
2019-07-25 11:38:59 +00:00
Mike Hommey
2e9a3adec2 Bug 1567739 - Stop using deprecated rust libc integer types in xpidl. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D38942

--HG--
extra : moz-landing-system : lando
2019-07-23 13:42:44 +00:00
Mike Hommey
39839d7b40 Bug 1567739 - Stop using deprecated rust libc integer types in bookmark_sync. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D38941

--HG--
extra : moz-landing-system : lando
2019-07-23 00:00:07 +00:00
Mike Hommey
103c1bec20 Bug 1567739 - Stop using deprecated rust libc integer types in storage_variant and kvstore. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D38940

--HG--
extra : moz-landing-system : lando
2019-07-23 00:13:43 +00:00
Mike Hommey
baf04d4ceb Bug 1567739 - Stop using deprecated rust libc integer types in rsdparsa_capi. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D38939

--HG--
extra : moz-landing-system : lando
2019-07-24 22:15:55 +00:00
Emilio Cobos Álvarez
eb7d8bffd8 Bug 1567237 - Only use scroll range to select scrollable frames to scroll to, don't use scrollbar visibility. r=tnikkel
This is what other browsers do, and it does make sense to me, it's useless to
try to scroll a frame with no scroll range in a given direction.

I think all callers of this function should be treated like this, so this is
more like a RFC / feedback request than a patch per se.

The wheel handling code already checks scroll range, so there's no difference of
behavior in that case, if I'm reading the code right.

There are a few other functions that check the result of
GetPerceivedScrollingDirections(), but I think if we change this we should
change this consistently.

I also think that if we do this we should rename the method to something like
GetAvailableScrollingDirections() or such.

Anyhow, wdyt? I should also add a test for this if we go with this.

Differential Revision: https://phabricator.services.mozilla.com/D38991

--HG--
extra : moz-landing-system : lando
2019-07-24 22:33:57 +00:00
Johann Hofmann
4098176939 Bug 1568492 - Add default parameter to RPMGetIntPref. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D39173

--HG--
extra : moz-landing-system : lando
2019-07-24 22:07:12 +00:00