Commit Graph

1643 Commits

Author SHA1 Message Date
Matt Woodrow
98b902004c Bug 1637487 - Store mixed content security flags as a flags word on Document instead of bools. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D75026
2020-05-14 01:27:42 +00:00
Matt Woodrow
2f85a514ca Bug 1637487 - Compute broken flag when we need to use it. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D75025
2020-05-14 01:27:24 +00:00
Matt Woodrow
861c02747c Bug 1637487 - Factor out calls to log changes to mixed content security state. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D75024
2020-05-14 01:27:11 +00:00
Matt Woodrow
6438ccaaf7 Bug 1637487 - Factor out updating root Document security flags. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D75023
2020-05-14 01:27:03 +00:00
Matt Woodrow
7c1f4443d0 Bug 1637487 - Factor out setting of the broken security state flags. r=ckerschb
Factor out broken flag clearing

Differential Revision: https://phabricator.services.mozilla.com/D75022
2020-05-14 01:26:50 +00:00
Matt Woodrow
1b984fae62 Bug 1637487 - Fold the branches for each pref together, since they do the same thing. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D75021
2020-05-14 01:26:38 +00:00
Matt Woodrow
8645f20d35 Bug 1637487 - Flatten the mixed content event runner into the calling code, so it's no longer needed. r=ckerschb
This looks like it was necessary a long time ago, but now just runs the same calls as the calling code, so unnecessarily splits the logic into two.

Differential Revision: https://phabricator.services.mozilla.com/D75020
2020-05-14 01:26:25 +00:00
Matt Woodrow
f88593276e Bug 1637487 - Refactor calls to OnSecurityChange to all be a single call at the end of ShouldLoad. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D75019
2020-05-14 01:26:17 +00:00
Matt Woodrow
c47de00726 Bug 1637487 - GetState is infallible, so rely on the result. r=ckerschb
We previously were checking the nsresult inconsistently.

Differential Revision: https://phabricator.services.mozilla.com/D75018
2020-05-14 01:26:05 +00:00
Narcis Beleuzu
53167b2819 Backed out 9 changesets (bug 1637487) for bustages on nsMixedContentBlocker.cpp . CLOSED TREE
Backed out changeset 5633cc2aaa9b (bug 1637487)
Backed out changeset c4f0c757cae0 (bug 1637487)
Backed out changeset 65bb1114df87 (bug 1637487)
Backed out changeset 1a64ef10e773 (bug 1637487)
Backed out changeset d1709ebb7f46 (bug 1637487)
Backed out changeset 286e5ee6517f (bug 1637487)
Backed out changeset 83362625c297 (bug 1637487)
Backed out changeset ab9df2f2d11f (bug 1637487)
Backed out changeset b83f49bc11b0 (bug 1637487)
2020-05-14 02:41:40 +03:00
Matt Woodrow
4f25f45f1f Bug 1637487 - Store mixed content security flags as a flags word on Document instead of bools. r=ckerschb
Depends on D75025

Differential Revision: https://phabricator.services.mozilla.com/D75026
2020-05-13 17:50:34 +00:00
Matt Woodrow
e20645053d Bug 1637487 - Compute broken flag when we need to use it. r=ckerschb
Depends on D75024

Differential Revision: https://phabricator.services.mozilla.com/D75025
2020-05-13 17:50:01 +00:00
Matt Woodrow
7701a47ec5 Bug 1637487 - Factor out calls to log changes to mixed content security state. r=ckerschb
Depends on D75023

Differential Revision: https://phabricator.services.mozilla.com/D75024
2020-05-13 17:49:41 +00:00
Matt Woodrow
c29977cc47 Bug 1637487 - Factor out updating root Document security flags. r=ckerschb
Depends on D75022

Differential Revision: https://phabricator.services.mozilla.com/D75023
2020-05-13 17:49:02 +00:00
Matt Woodrow
4cd51b2599 Bug 1637487 - Factor out setting of the broken security state flags. r=ckerschb
Factor out broken flag clearing

Depends on D75021

Differential Revision: https://phabricator.services.mozilla.com/D75022
2020-05-13 17:48:09 +00:00
Matt Woodrow
d724ad70cf Bug 1637487 - Fold the branches for each pref together, since they do the same thing. r=ckerschb
Depends on D75020

Differential Revision: https://phabricator.services.mozilla.com/D75021
2020-05-13 17:47:36 +00:00
Matt Woodrow
ebf31467af Bug 1637487 - Flatten the mixed content event runner into the calling code, so it's no longer needed. r=ckerschb
This looks like it was necessary a long time ago, but now just runs the same calls as the calling code, so unnecessarily splits the logic into two.

Depends on D75019

Differential Revision: https://phabricator.services.mozilla.com/D75020
2020-05-13 17:46:44 +00:00
Matt Woodrow
fb1d15c15e Bug 1637487 - Refactor calls to OnSecurityChange to all be a single call at the end of ShouldLoad. r=ckerschb
Depends on D75018

Differential Revision: https://phabricator.services.mozilla.com/D75019
2020-05-13 17:46:05 +00:00
Matt Woodrow
6de805897c Bug 1637487 - GetState is infallible, so rely on the result. r=ckerschb
We previously were checking the nsresult inconsistently.

Differential Revision: https://phabricator.services.mozilla.com/D75018
2020-05-13 17:45:52 +00:00
Christoph Kerschbaumer
026a7442f3 Bug 1636900: Remove TYPE_XBL from nsIContentPolicy. r=remote-protocol-reviewers,emilio,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D74835
2020-05-13 06:53:28 +00:00
Logan Smyth
c218b3011f Bug 1637288 - Allow the development build of react to use innerHTML. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D74967
2020-05-12 22:19:53 +00:00
Johann Hofmann
b59132460a Bug 1632474 - Consider src in unsafe allow all checks for feature policy. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D73147
2020-05-12 19:43:23 +00:00
Honza Bambas
96b6a3c36c Bug 1623953 - Provide comparative method on SRIMetadata to allow trust delegation to a stronger or identical SRI, r=emilio,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D74481
2020-05-12 12:40:00 +00:00
Christoph Kerschbaumer
9b6415635d Bug 1637193: Warn not only once but every time we are loading mixed object subrequest including the soon to be blocked URI. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D74824
2020-05-12 10:16:52 +00:00
Christoph Kerschbaumer
2c610ecc1f Bug 1582115: Exempt pdf.js from being subject to CSP from page. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D74614
2020-05-12 08:51:08 +00:00
Honza Bambas
bc388980de Bug 1618322 - Merge network.preload.experimental pref to network.preload, r=dragana
Depends on D70235

Differential Revision: https://phabricator.services.mozilla.com/D70526
2020-05-11 14:15:30 +00:00
Honza Bambas
ef0d4e6dd1 Bug 1618536 - Introduce nsIContentPolicy::TYPE_INTERNAL_FONT_PRELOAD representing preload of font, mapping to TYPE_FONT externally, r=baku
Depends on D69628

Differential Revision: https://phabricator.services.mozilla.com/D72118
2020-05-11 14:13:16 +00:00
Simon Giesecke
e6422e2afd Bug 1626570 - Remove obsolete copy enabling machinery. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D72176
2020-05-11 08:23:03 +00:00
Christoph Kerschbaumer
c65e97cd1c Bug 1635365: Move field mixed content IsSecure from BrowsingContext to WindowContext. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D74269
2020-05-11 08:11:17 +00:00
Csoregi Natalia
cd28d94be1 Backed out changeset 59a45d8c0fbb (bug 1635365) for browser-chrome failures on browser_bug902156.js. CLOSED TREE 2020-05-08 19:09:20 +03:00
Christoph Kerschbaumer
1470386f05 Bug 1635365: Move field mixed content IsSecure from BrowsingContext to WindowContext. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D74269
2020-05-08 14:05:18 +00:00
Matt Woodrow
3d6e4f24c6 Bug 1635995 - Allow CSP service to do redirect checks on documents in the parent, rather than doing it manually. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D74170
2020-05-08 02:53:57 +00:00
Matt Woodrow
66e1e333d1 Bug 1635992 - Use LoadInfo and WindowContext in nsMixedContentBlocker instead of the docshell and Document. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D74169
2020-05-08 02:53:44 +00:00
Matt Woodrow
fce5746949 Bug 1635992 - Pass LoadInfo into nsMixedContentBlocker::ShouldLoad. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D74168
2020-05-08 02:53:42 +00:00
Christoph Kerschbaumer
43baaddaab Bug 1632160: Remove GetAllowMixedContentAndConnectionData from nsIDocShell and expose similar functionality on BrowsingContext. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D72901
2020-05-07 07:22:17 +00:00
Christoph Kerschbaumer
b7be38ab70 Bug 1635788: Use WindowID instead of rootDoc when logging mixed content messages to the console.r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D74047
2020-05-07 05:53:41 +00:00
Simon Giesecke
84c5dada84 Bug 1626570 - Improve handling of copying arrays in dom/security/. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D73663
2020-05-06 11:16:49 +00:00
Narcis Beleuzu
d262ef72aa Backed out changeset 9da3ff68132f (bug 1632160) for bc failures on browser_bug1045809.js . CLOSED TREE 2020-05-06 12:12:59 +03:00
Frederik Braun
1fcb39e3a3 Bug 1633374 - disallow eval in parent process r=ckerschb,tjr
Changing isEvalAllowed to default to false in nightly builds.
As a ride-along, we adjust how we get the script filename
for telemetry, to get better results.

Differential Revision: https://phabricator.services.mozilla.com/D72644
2020-05-05 14:57:53 +00:00
Christoph Kerschbaumer
3bf440d570 Bug 1632160: Remove GetAllowMixedContentAndConnectionData from nsIDocShell and expose similar functionality on BrowsingContext. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D72901
2020-05-06 07:15:40 +00:00
Dorel Luca
83d5bcb017 Backed out changeset 4d5b82209f5a (bug 1633374) for Mochitest failures in gecko/mfbt/Assertions.cpp. CLOSED TREE 2020-05-04 22:47:00 +03:00
Frederik Braun
7d7fa35941 Bug 1633374 - disallow eval in parent process r=ckerschb,tjr
Changing isEvalAllowed to default to false in nightly builds.
As a ride-along, we adjust how we get the script filename
for telemetry, to get better results.

Differential Revision: https://phabricator.services.mozilla.com/D72644
2020-04-30 06:13:09 +00:00
Emilio Cobos Álvarez
761e9dfe4c Bug 1635094 - Cleanup the ReferrerInfo code. r=ckerschb
The cast in InitWithNode is wrong. AsElement() asserts instead of
checking the flag, so we always pass an element (and if we didn't we'd
have type confusion problems). I audited the callers and we're fine.

Anyhow, always require an element, and add two convenience constructors
for C++ code.

Differential Revision: https://phabricator.services.mozilla.com/D73636
2020-05-04 18:50:20 +00:00
Cosmin Sabou
71a40eae48 Backed out 2 changesets (bug 1635094) for build bustages on nsMacShellService.cpp. CLOSED TREE
Backed out changeset 0a2b0c6ea19a (bug 1635094)
Backed out changeset ead4f26f76ee (bug 1635094)
2020-05-04 20:04:06 +03:00
Emilio Cobos Álvarez
6dde680742 Bug 1635094 - Cleanup the ReferrerInfo code. r=ckerschb
The cast in InitWithNode is wrong. AsElement() asserts instead of
checking the flag, so we always pass an element (and if we didn't we'd
have type confusion problems). I audited the callers and we're fine.

Anyhow, always require an element, and add two convenience constructors
for C++ code.

Differential Revision: https://phabricator.services.mozilla.com/D73636
2020-05-04 16:26:51 +00:00
Liang-Heng Chen
ec09ea6a84 Bug 1633546 - update testing results for network.cookie.cookieBehavior; r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D73036
2020-04-30 06:54:37 +00:00
Liang-Heng Chen
669c9d13fc Bug 1633538 - allow referrer for STATE_COOKIES_PARTITIONED_FOREIGN; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D72744
2020-04-29 13:02:08 +00:00
Nika Layzell
4a32e81e04 Bug 1633941 - Re-disable test_main.html on fission, r=kmag
This test will no longer crash since bug 1580565, but was accidentally set as
passing in https://hg.mozilla.org/integration/autoland/rev/9555dcc88ac9, despite
still perma-failing due to bug 1580771.

Differential Revision: https://phabricator.services.mozilla.com/D73054
2020-04-29 17:49:30 +00:00
julianwels
00925bd53b Bug 1631384 - Added upgrade exceptions for HTTPS Only Mode. r=ckerschb,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D72002
2020-04-29 15:52:19 +00:00
Bogdan Tara
fe228746b1 Backed out changeset 8e7b6ae8e18d (bug 1631384) for browser_upgrade_exceptions.js failure CLOSED TREE 2020-04-29 13:32:29 +03:00