This cleanup will help next refactorings.
Note that attachTestThread and attachTestTabAndResume are still using the callback style
as it is still being used by tests that aren't using threadClientTest helper.
MozReview-Commit-ID: 6FvoDtzEBmL
Depends on D13901
Differential Revision: https://phabricator.services.mozilla.com/D13902
--HG--
extra : moz-landing-system : lando
This isn't removing listTabs calls as these tests were using attachTestTab,
but all these tests are using testGlobal helper whereas they don't have to if they were using threadClientTest helper.
MozReview-Commit-ID: FPtYlDvYUeD
Depends on D13900
Differential Revision: https://phabricator.services.mozilla.com/D13901
--HG--
extra : moz-landing-system : lando
This isn't thread client test, but here we could share some more code with the memory tests
and use Target objects to retrieve the fronts.
MozReview-Commit-ID: C9S1VjTLrSF
Depends on D13899
Differential Revision: https://phabricator.services.mozilla.com/D13900
--HG--
extra : moz-landing-system : lando
All these tests are clearly copy pasting existing threadClientTest helper.
They might run as well against workers but today we don't run them there, so I used the doNotRunWorker flag.
MozReview-Commit-ID: 7k1lJ06WeGZ
Differential Revision: https://phabricator.services.mozilla.com/D13899
--HG--
extra : moz-landing-system : lando
This test is broken for a while as it doesn't wait for resumeDebuggerThenCloseAndFinish to finish...
If was trying to ensure that resumeDebuggerThenCloseAndFinish wasn't throwing.
The test is most about testing old debugger test helper rather than test a particular STR.
MozReview-Commit-ID: 3gAWOSxjFet
Depends on D13823
Differential Revision: https://phabricator.services.mozilla.com/D13824
--HG--
extra : moz-landing-system : lando
Currently, when `about:debugging` is displaying, even if move to another URL on
Android, its update does not reflect to `about:debugging` page. Because the `DOMTitleChanged` event on message manager comes from only in case of remote browser. In this patch, get the event on even not remote browser, then notify to clients.
Differential Revision: https://phabricator.services.mozilla.com/D12094
--HG--
extra : moz-landing-system : lando
We already have a fallback for items that aren't in a worker scope, we should have the same for ones that are. This means we don't need single maps (foo.js -> foo) in modules.json, and also we can identify more as explicit variables, so that no-unused-vars can detect them.
Differential Revision: https://phabricator.services.mozilla.com/D13299
--HG--
extra : moz-landing-system : lando
This also adds a console test to make sure we don't regress
this in the future.
Differential Revision: https://phabricator.services.mozilla.com/D13762
--HG--
extra : moz-landing-system : lando
This also adds a console test to make sure we don't regress
this in the future.
Differential Revision: https://phabricator.services.mozilla.com/D13762
--HG--
extra : moz-landing-system : lando
We used to re-render the component each time the sourcemapService
would give us a result for a single frame.
Combined with the frame grouping system, this could trigger
weird re-layout and might confuse user.
What's done in this patch is that when mounting, if a sourcemapService
is passed, we don't render anything, and start a race between
a delay of 300ms and the sourcemap results for *all* the frames.
If we don't have the original frames within 300ms, we render the
bundled frames. But, whenever we have the sourcemap results, we
trigger a re-render of the component.
This gives some room for the sourcemapService to fetch map files
without re-ordering things on the screen.
A test case is added to ensure we have the expected renders
when the sourcemap service takes more time than the inital delay.
We already have a case where the sourcemap service resuls are
received before the initial delay.
We also take this as an opportunity to fix minor CSS issues.
Differential Revision: https://phabricator.services.mozilla.com/D12037
--HG--
extra : moz-landing-system : lando
