Commit Graph

2840 Commits

Author SHA1 Message Date
Julian Descottes
9aafb9457c Bug 1627270 - Return TabDescriptors from RootFront::getTab r=ochameau
Depends on D73780

Differential Revision: https://phabricator.services.mozilla.com/D73905
2020-05-08 13:34:31 +00:00
Daisuke Akatsuka
cca27059d5 Bug 1620098: Show HTMLTooltip in html document as XUL popup. r=bgrins,jdescottes,mtigley,yzen,bdahl,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D67983
2020-05-07 23:33:57 +00:00
Cosmin Sabou
6a31abf429 Backed out 3 changesets (bug 1620098) for devtools jtest failures. CLOSED TREE
Backed out changeset a3a8244860bc (bug 1620098)
Backed out changeset 2996bd22bd97 (bug 1620098)
Backed out changeset 6b397048940f (bug 1620098)
2020-05-07 05:40:50 +03:00
Daisuke Akatsuka
26439c714e Bug 1620098: Show HTMLTooltip in html document as XUL popup. r=bgrins,jdescottes,mtigley,yzen,bdahl
Differential Revision: https://phabricator.services.mozilla.com/D67983
2020-05-07 02:04:17 +00:00
Hubert Boma Manilla
98b0dbdad3 Bug 1634643 - Make sure array is passed to stacktrace r=Honza
Default set stacktrace to [] if its falsy
Added check for empty array ahead to return early

Differential Revision: https://phabricator.services.mozilla.com/D73452
2020-05-04 10:48:15 +00:00
Ria agnes Jose
580f131b44 Bug 1633696 - Rename isVariableInUse to getVariableValue. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D73589
2020-05-04 11:06:42 +00:00
Julian Descottes
a9ef06b786 Bug 1594402 - Add comments about the supported activeSwatch markup in SwatchColorPickerTooltip.js r=ladybenko,rcaliman
Depends on D68971

Until have a shared component to build to color swatch, some additional comments.

Differential Revision: https://phabricator.services.mozilla.com/D71315
2020-04-29 10:05:49 +00:00
Julian Descottes
a97d7642d9 Bug 1594402 - Support setting the data-color attribute on the swatch directly r=ladybenko,rcaliman
Depends on D68849

Differential Revision: https://phabricator.services.mozilla.com/D68971
2020-04-29 10:05:37 +00:00
Julian Descottes
d13658bff7 Bug 1594402 - Display a color swatch for CSS variables in CSS autocomplete r=ladybenko,rcaliman
Depends on D68963

Differential Revision: https://phabricator.services.mozilla.com/D61063
2020-04-29 10:03:31 +00:00
Julian Descottes
ef20d9d88f Bug 1594402 - Store the swatchcolorpicker color in a data attribute instead of textcontent r=ladybenko,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68963
2020-04-29 10:03:24 +00:00
Logan Smyth
bfe7013db8 Bug 1607639 - Part 4: Convert introductionUrl into sourceMapBaseURL to match actual usage. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D72115
2020-04-27 02:17:02 +00:00
Cosmin Sabou
c7b157939a Backed out 6 changesets (bug 1470768, bug 1607639) for causing xpc failures on xpcshell/test_objectgrips-13.js. CLOSED TREE
Backed out changeset 15642af7fdbd (bug 1607639)
Backed out changeset 53565f45e275 (bug 1607639)
Backed out changeset 9f1749c622fe (bug 1607639)
Backed out changeset 747efa62d7d6 (bug 1607639)
Backed out changeset 10d0aed39069 (bug 1607639)
Backed out changeset 70aa92ce25b7 (bug 1470768)
2020-04-24 10:27:28 +03:00
Logan Smyth
2cdc9b1bbb Bug 1607639 - Part 4: Convert introductionUrl into sourceMapBaseURL to match actual usage. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D72115
2020-04-24 06:15:13 +00:00
Emilio Cobos Álvarez
d36c96ab4c Bug 1612068 - Move zoom from the content viewer to the browsing context. r=nika
We need it to live in BrowsingContext instead of WindowContext, because
we need to preserve the zoom level across same-origin navigation.

It'd be nice if it only lived in the top BC, but that's not possible at
the moment because a lot of tests rely on zooming only iframes. Some of
them can be adjusted for scaling the top instead, but not sure it's
worth it's worth fixing them and moving the zoom to be top-only, as it'd
be a bunch of effort, and the complexity and overhead of propagating the
zoom is not so big.

The print-preview-specific code in nsContentViewer is from before we did
the document cloning setup, and it seems useless. I've tested print
preview scaling before and after my patch and both behave the same.

The rest is just various test changes to use the SpecialPowers APIs or
BrowsingContext as needed instead of directly poking at the content
viewer.

I named the pres context hook RecomputeBrowsingContextDependentData, as
more stuff should move there like overrideDPPX and other media emulation
shenanigans.

I also have some ideas to simplify or even remove ZoomChild and such,
but that's followup work.

Differential Revision: https://phabricator.services.mozilla.com/D71969
2020-04-22 19:32:52 +00:00
Daisuke Akatsuka
74dbb630d2 Bug 1625815: Add a feedback button. r=mtigley,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D70285
2020-04-22 00:23:21 +00:00
Julian Descottes
138168a3c9 Bug 1616250 - Wait for next tick after show/hide tooltip in DevTools tooltip tests r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D71554
2020-04-20 15:57:44 +00:00
Gijs Kruitbosch
8e9361fe24 Bug 1614468, r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D71078
2020-04-16 18:00:49 +00:00
Brindusan Cristian
8b3ca7fd70 Backed out changeset 05ccd03beb2f (bug 1528288) as requested by rcaliman on Bug 1629043 for failing with Beta configuration. CLOSED TREE 2020-04-16 18:57:51 +03:00
Brindusan Cristian
0a91a74439 Backed out changeset 9780a50735c6 (bug 1628787) as requested by rcaliman on bug 1629043 for failing with Beta configuration. CLOSED TREE 2020-04-16 18:56:14 +03:00
Razvan Caliman
af81e97e25 Bug 1627795 - Remove unused getCssProperties() helper r=gl
Differential Revision: https://phabricator.services.mozilla.com/D70048
2020-04-07 19:39:25 +00:00
Nicolas Chevobbe
ead46def06 Bug 1628698 - Expand Error object when logged with console.dir. r=bomsy.
This will allow user to actually inspect the properties of an error object,
which isn't possible at the moment.
This is because we apply a custom format on error, to only print the error
message and the stacktrace, as that's probably what the user is looking for.
But in some cases, it might still be valuable to be able to check the object
properties.
In order to do that, we add a new "customFormat" prop in Reps and ObjectInspector,
which need to be explicitely set if the consumers do want the custom format.
In the console, it will always be the case, except when the object is
in a console.dir call.
This will also open the door to have a way to switch between the custom format
and the regular view in the future.
Jest tests are modified to take this new prop into account, and the existing
console.dir mochitest is modified to add a specific case about error objects.

Differential Revision: https://phabricator.services.mozilla.com/D70392

--HG--
extra : moz-landing-system : lando
2020-04-16 13:13:43 +00:00
janelledement
851e55a3df Bug 1580585 - Adds set or get watchpoint option. r=jlast
Adds a set or get watchpoint option.

Differential Revision: https://phabricator.services.mozilla.com/D70284

--HG--
extra : moz-landing-system : lando
2020-04-15 17:53:52 +00:00
Hubert Boma Manilla
1363c353aa Bug 1615471 - Escape dollar sign for curl on windows r=Honza
Escape dollar sign for curl on windows,to fix a security issue
where commands such as $(cmd.exe) can be executed.

Differential Revision: https://phabricator.services.mozilla.com/D69776

--HG--
extra : moz-landing-system : lando
2020-04-07 08:43:31 +00:00
Julian Descottes
9b57f6f875 Bug 1618691 - Use tab descriptor in about:debugging r=ochameau
Depends on D69545

Differential Revision: https://phabricator.services.mozilla.com/D65693

--HG--
extra : moz-landing-system : lando
2020-04-14 13:16:55 +00:00
Julian Descottes
5938de5878 Bug 1618691 - Return selected as property of the TabDescriptorActor form r=ochameau
Depends on D69543
There are no actual call sites for selected, but we have a test checking the feature.
Alternatively we could get rid of the feature.

Differential Revision: https://phabricator.services.mozilla.com/D69544

--HG--
extra : moz-landing-system : lando
2020-04-14 13:15:24 +00:00
Razvan Caliman
c46abd10c3 Bug 1628787 - Fix toggling of RulePreviewTooltip on hover. r=gl
Relying on [TooltipToggle to automatically handle mouse events](https://searchfox.org/mozilla-central/rev/06985b12a4abe393c02c6bf14d86bf3d25c33337/devtools/client/shared/widgets/tooltip/TooltipToggle.js#36-38) to show/hide the tooltip in order to avoid the tooltip flickering.
Ideally, we should control `RulePreviewTooltip` via [TooltipsOverlay](https://searchfox.org/mozilla-central/rev/06985b12a4abe393c02c6bf14d86bf3d25c33337/devtools/client/inspector/shared/tooltips-overlay.js#88), but, for now, this fix seems to address the intermittent test failure.

Differential Revision: https://phabricator.services.mozilla.com/D70536

--HG--
extra : moz-landing-system : lando
2020-04-13 16:52:51 +00:00
Hubert Boma Manilla
db3a463592 Bug 1613884 - New headers panel using accordion r=Honza
- New accordion based headers panel
 - Remove old Properties View
 - Updated tests

Differential Revision: https://phabricator.services.mozilla.com/D69186

--HG--
rename : devtools/client/netmonitor/src/components/HeadersPanel.js => devtools/client/netmonitor/src/components/request-details/HeadersPanel.js
extra : moz-landing-system : lando
2020-04-14 11:38:01 +00:00
Jacqueline
c6d7e0ebde Bug 1528288 - Introduce a tooltip when hovering over box-model values to show the rule where a value is coming from r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68708

--HG--
rename : devtools/client/inspector/boxmodel/test/browser_boxmodel_jump-to-rule-on-hover.js => devtools/client/inspector/boxmodel/test/browser_boxmodel_jump-to-rule-on-click.js
extra : moz-landing-system : lando
2020-04-09 13:43:23 +00:00
Bogdan Tara
81711eec26 Backed out changeset 8d307ddf5bcf (bug 1613884) for many browser_accessibility* tests timeouts CLOSED TREE
--HG--
rename : devtools/client/netmonitor/src/components/request-details/HeadersPanel.js => devtools/client/netmonitor/src/components/HeadersPanel.js
2020-04-09 15:09:06 +03:00
Hubert Boma Manilla
1923ef40f7 Bug 1613884 - New headers panel using accordion r=Honza
- New accordion based headers panel
 - Remove old Properties View
 - Updated tests

Differential Revision: https://phabricator.services.mozilla.com/D69186

--HG--
rename : devtools/client/netmonitor/src/components/HeadersPanel.js => devtools/client/netmonitor/src/components/request-details/HeadersPanel.js
extra : moz-landing-system : lando
2020-04-09 10:14:41 +00:00
Andrew Nicols
b54179e426 Bug 1556903 - Return null when source not found. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D33755

--HG--
extra : moz-landing-system : lando
2020-04-09 03:12:44 +00:00
Logan Smyth
3f76247abc Bug 1598309 - Part 2: Avoid leaking memory for sourcemap loading. r=jlast
Depends on D69930

Differential Revision: https://phabricator.services.mozilla.com/D69931

--HG--
extra : moz-landing-system : lando
2020-04-07 17:06:15 +00:00
Logan Smyth
083033cd6c Bug 1598309 - Part 1: Update bundles with recent Boolean changes. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D69930

--HG--
extra : moz-landing-system : lando
2020-04-07 17:06:38 +00:00
Logan Smyth
d256d771ed Bug 1607559 - Part 2: Avoid perf issue with data: URLs for inlined source-maps. r=jlast
Depends on D69933

Differential Revision: https://phabricator.services.mozilla.com/D69934

--HG--
extra : moz-landing-system : lando
2020-04-07 17:06:56 +00:00
Logan Smyth
b8acb33b40 Bug 1607559 - Part 1: Do not replace the global URL with whatwg-url. r=jlast
By loading whatwg-url like this, we replace the worker global URL property
(among others), which means that code that uses `URL` and expects it to be the
version that is built into Firefox may not get what they expect.

Differential Revision: https://phabricator.services.mozilla.com/D69933

--HG--
extra : moz-landing-system : lando
2020-04-07 16:46:37 +00:00
Jason Laster
db85ee3240 Bug 1605331 - Watch expressions should be evaluated in the right context. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D67701

--HG--
extra : moz-landing-system : lando
2020-04-07 20:05:32 +00:00
Dace Jansone
5f3ee39984 Bug 1553795 - Fix preset input in filter tooltip. r=rcaliman
Fixed the problem that part of preset input field in filter widget was vissible
when it shouldn't be.

Differential Revision: https://phabricator.services.mozilla.com/D69375

--HG--
extra : moz-landing-system : lando
2020-04-07 19:15:06 +00:00
Brindusan Cristian
ed2dea237d Backed out changeset 185a33dcfa94 (bug 1605331) for devtools failures at browser_dbg-windowless-workers.js. CLOSED TREE 2020-04-04 04:03:41 +03:00
Jason Laster
df29502fe7 Bug 1605331 - Watch expressions should be evaluated in the right context. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D67701

--HG--
extra : moz-landing-system : lando
2020-04-03 22:23:11 +00:00
Julian Descottes
7addf56289 Bug 1625906 - Remove backward compatibility message dedicated to debugger regression for Firefox 67 r=daisuke,fluent-reviewers
Depends on D69003

This backward compatibility message was only relevant for Firefox 67.
We can remove it.

Differential Revision: https://phabricator.services.mozilla.com/D69007

--HG--
extra : moz-landing-system : lando
2020-04-01 11:19:37 +00:00
Julian Descottes
4b80b1e82e Bug 1625906 - Add dedicated warning message for users trying to debug firefox for android 68 r=Harald,daisuke,fluent-reviewers,flod
Depends on D68987

Differential Revision: https://phabricator.services.mozilla.com/D69003

--HG--
extra : moz-landing-system : lando
2020-04-02 13:43:23 +00:00
Julian Descottes
68b8fef105 Bug 1626210 - Add a test for devtools prepare-tcp-connection r=daisuke
Depends on D68982

Differential Revision: https://phabricator.services.mozilla.com/D68987

--HG--
extra : moz-landing-system : lando
2020-04-01 09:10:08 +00:00
Brad Werth
16927141b8 Bug 1619836 Part 4: Re-enable the test. r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D65413

--HG--
extra : moz-landing-system : lando
2020-03-24 18:33:33 +00:00
Brad Werth
9ec7da3d13 Bug 1619836 Part 3: Make the test browser_layoutHelpers_getBoxQuads2.js more informative and forgiving. r=hiro
This patch makes several improvements to the test:

1) It forces the test to run in Fission window. Primarily, this helps the
test generate precise CSS pixel results. For some reason, those are less
reliable in non-Fission windows. Secondarily, this API only exists to
support a fission-enabled browser, so it is a better match for its intended
usage.

2) It uses isfuzzy with an epsilon of 1 to compensate for any sub-pixel
imprecision.

3) It checks all four sides of each quad; not just the origin.

Differential Revision: https://phabricator.services.mozilla.com/D65411

--HG--
extra : moz-landing-system : lando
2020-03-31 22:35:02 +00:00
Julian Descottes
045c5d903d Bug 1626210 - Import Cc,Ci in devtools prepare-tcp-connection.js r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D68982

--HG--
extra : moz-landing-system : lando
2020-03-31 11:49:22 +00:00
Julian Descottes
fdec3e7197 Bug 1625495 - Remove devtools/shared/client folder r=daisuke,ochameau,nchevobbe
Depends on D68599

This changeset moves devtools-client.js and constants.js to devtools/client and removes devtools/shared/client

Differential Revision: https://phabricator.services.mozilla.com/D68600

--HG--
rename : devtools/shared/client/constants.js => devtools/client/constants.js
rename : devtools/shared/client/devtools-client.js => devtools/client/devtools-client.js
extra : moz-landing-system : lando
2020-03-31 08:36:29 +00:00
Logan Smyth
0d172217ca Bug 1624507 - Part 5: Make AMD support an opt-in feature of the loader. r=ochameau
Since base-loader's job is to handle this kind of thing, and it already
requires a special case to populate the descriptor anyway, so it seems a lot
easier to provide this as builtin optional feature of base-loader.

Differential Revision: https://phabricator.services.mozilla.com/D67979

--HG--
extra : moz-landing-system : lando
2020-03-30 08:24:05 +00:00
Julian Descottes
33a9959898 Bug 1515008 - Move connection-manager from devtools/shared to devtools/client/shared/remote-debugging r=daisuke
Depends on D68598

Differential Revision: https://phabricator.services.mozilla.com/D68599

--HG--
extra : moz-landing-system : lando
2020-03-30 06:56:39 +00:00
Julian Descottes
1ce70ac1b0 Bug 1515008 - Move adb from devtools/shared to devtools/client/shared/remote-debugging r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D68598

--HG--
rename : devtools/shared/adb/adb-addon.js => devtools/client/shared/remote-debugging/adb/adb-addon.js
rename : devtools/shared/adb/adb-binary.js => devtools/client/shared/remote-debugging/adb/adb-binary.js
rename : devtools/shared/adb/adb-client.js => devtools/client/shared/remote-debugging/adb/adb-client.js
rename : devtools/shared/adb/adb-device.js => devtools/client/shared/remote-debugging/adb/adb-device.js
rename : devtools/shared/adb/adb-process.js => devtools/client/shared/remote-debugging/adb/adb-process.js
rename : devtools/shared/adb/adb-running-checker.js => devtools/client/shared/remote-debugging/adb/adb-running-checker.js
rename : devtools/shared/adb/adb-runtime.js => devtools/client/shared/remote-debugging/adb/adb-runtime.js
rename : devtools/shared/adb/adb-socket.js => devtools/client/shared/remote-debugging/adb/adb-socket.js
rename : devtools/shared/adb/adb.js => devtools/client/shared/remote-debugging/adb/adb.js
rename : devtools/shared/adb/commands/index.js => devtools/client/shared/remote-debugging/adb/commands/index.js
rename : devtools/shared/adb/commands/list-devices.js => devtools/client/shared/remote-debugging/adb/commands/list-devices.js
rename : devtools/shared/adb/commands/moz.build => devtools/client/shared/remote-debugging/adb/commands/moz.build
rename : devtools/shared/adb/commands/prepare-tcp-connection.js => devtools/client/shared/remote-debugging/adb/commands/prepare-tcp-connection.js
rename : devtools/shared/adb/commands/run-command.js => devtools/client/shared/remote-debugging/adb/commands/run-command.js
rename : devtools/shared/adb/commands/shell.js => devtools/client/shared/remote-debugging/adb/commands/shell.js
rename : devtools/shared/adb/commands/track-devices.js => devtools/client/shared/remote-debugging/adb/commands/track-devices.js
rename : devtools/shared/adb/moz.build => devtools/client/shared/remote-debugging/adb/moz.build
rename : devtools/shared/adb/xpcshell/.eslintrc.js => devtools/client/shared/remote-debugging/adb/xpcshell/.eslintrc.js
rename : devtools/shared/adb/xpcshell/adb.py => devtools/client/shared/remote-debugging/adb/xpcshell/adb.py
rename : devtools/shared/adb/xpcshell/test_adb.js => devtools/client/shared/remote-debugging/adb/xpcshell/test_adb.js
rename : devtools/shared/adb/xpcshell/xpcshell-head.js => devtools/client/shared/remote-debugging/adb/xpcshell/xpcshell-head.js
rename : devtools/shared/adb/xpcshell/xpcshell.ini => devtools/client/shared/remote-debugging/adb/xpcshell/xpcshell.ini
extra : moz-landing-system : lando
2020-03-30 06:56:57 +00:00
Dickson Tan
d684f54703 Bug 1545727 - make the JSON tree viewer more accessible. r=Honza
Make the JSON tree view more accessible.

1. Automatically set focus to the first node on initial focus. Previously, the only way to interact with the tree view through the keyboard was to click on a node so that subsequent key presses would register.
2. Fix inaccurate aria-level and aria-expanded attributes causing confusing announcements for screen reader users.
3. Previously, pressing left arrow the first time on a leaf child node would not move focus to its parent, but subsequent tries would work. This has been fixed.
4. Implement first-letter navigation for quick movement via keyboard.

Differential Revision: https://phabricator.services.mozilla.com/D28274

--HG--
extra : moz-landing-system : lando
2020-03-29 09:32:58 +00:00