We need it to live in BrowsingContext instead of WindowContext, because
we need to preserve the zoom level across same-origin navigation.
It'd be nice if it only lived in the top BC, but that's not possible at
the moment because a lot of tests rely on zooming only iframes. Some of
them can be adjusted for scaling the top instead, but not sure it's
worth it's worth fixing them and moving the zoom to be top-only, as it'd
be a bunch of effort, and the complexity and overhead of propagating the
zoom is not so big.
The print-preview-specific code in nsContentViewer is from before we did
the document cloning setup, and it seems useless. I've tested print
preview scaling before and after my patch and both behave the same.
The rest is just various test changes to use the SpecialPowers APIs or
BrowsingContext as needed instead of directly poking at the content
viewer.
I named the pres context hook RecomputeBrowsingContextDependentData, as
more stuff should move there like overrideDPPX and other media emulation
shenanigans.
I also have some ideas to simplify or even remove ZoomChild and such,
but that's followup work.
Differential Revision: https://phabricator.services.mozilla.com/D71969
This will allow user to actually inspect the properties of an error object,
which isn't possible at the moment.
This is because we apply a custom format on error, to only print the error
message and the stacktrace, as that's probably what the user is looking for.
But in some cases, it might still be valuable to be able to check the object
properties.
In order to do that, we add a new "customFormat" prop in Reps and ObjectInspector,
which need to be explicitely set if the consumers do want the custom format.
In the console, it will always be the case, except when the object is
in a console.dir call.
This will also open the door to have a way to switch between the custom format
and the regular view in the future.
Jest tests are modified to take this new prop into account, and the existing
console.dir mochitest is modified to add a specific case about error objects.
Differential Revision: https://phabricator.services.mozilla.com/D70392
--HG--
extra : moz-landing-system : lando
Escape dollar sign for curl on windows,to fix a security issue
where commands such as $(cmd.exe) can be executed.
Differential Revision: https://phabricator.services.mozilla.com/D69776
--HG--
extra : moz-landing-system : lando
Depends on D69543
There are no actual call sites for selected, but we have a test checking the feature.
Alternatively we could get rid of the feature.
Differential Revision: https://phabricator.services.mozilla.com/D69544
--HG--
extra : moz-landing-system : lando
By loading whatwg-url like this, we replace the worker global URL property
(among others), which means that code that uses `URL` and expects it to be the
version that is built into Firefox may not get what they expect.
Differential Revision: https://phabricator.services.mozilla.com/D69933
--HG--
extra : moz-landing-system : lando
Fixed the problem that part of preset input field in filter widget was vissible
when it shouldn't be.
Differential Revision: https://phabricator.services.mozilla.com/D69375
--HG--
extra : moz-landing-system : lando
Depends on D69003
This backward compatibility message was only relevant for Firefox 67.
We can remove it.
Differential Revision: https://phabricator.services.mozilla.com/D69007
--HG--
extra : moz-landing-system : lando
This patch makes several improvements to the test:
1) It forces the test to run in Fission window. Primarily, this helps the
test generate precise CSS pixel results. For some reason, those are less
reliable in non-Fission windows. Secondarily, this API only exists to
support a fission-enabled browser, so it is a better match for its intended
usage.
2) It uses isfuzzy with an epsilon of 1 to compensate for any sub-pixel
imprecision.
3) It checks all four sides of each quad; not just the origin.
Differential Revision: https://phabricator.services.mozilla.com/D65411
--HG--
extra : moz-landing-system : lando
Depends on D68599
This changeset moves devtools-client.js and constants.js to devtools/client and removes devtools/shared/client
Differential Revision: https://phabricator.services.mozilla.com/D68600
--HG--
rename : devtools/shared/client/constants.js => devtools/client/constants.js
rename : devtools/shared/client/devtools-client.js => devtools/client/devtools-client.js
extra : moz-landing-system : lando
Since base-loader's job is to handle this kind of thing, and it already
requires a special case to populate the descriptor anyway, so it seems a lot
easier to provide this as builtin optional feature of base-loader.
Differential Revision: https://phabricator.services.mozilla.com/D67979
--HG--
extra : moz-landing-system : lando
Make the JSON tree view more accessible.
1. Automatically set focus to the first node on initial focus. Previously, the only way to interact with the tree view through the keyboard was to click on a node so that subsequent key presses would register.
2. Fix inaccurate aria-level and aria-expanded attributes causing confusing announcements for screen reader users.
3. Previously, pressing left arrow the first time on a leaf child node would not move focus to its parent, but subsequent tries would work. This has been fixed.
4. Implement first-letter navigation for quick movement via keyboard.
Differential Revision: https://phabricator.services.mozilla.com/D28274
--HG--
extra : moz-landing-system : lando