Commit Graph

8048 Commits

Author SHA1 Message Date
Geoff Brown
cb19f2147e Bug 1647362 - Improve py3 compat in fix_stacks.py; r=bc
Use universal_newlines as a convenient way of treating the process I/O as text,
so string read/writes continue to succeed under python 3.

Differential Revision: https://phabricator.services.mozilla.com/D81774
2020-06-30 22:17:38 +00:00
Jim Porter
632c7aa9aa Bug 1613496 - Add IPC profiler markers to track when messages are processed by the IO thread queues r=gerald,froydnj
This adds 3 new profiler markers for each IPC message:

 * One just before the first byte is sent over the IPC channel
 * One just after the last byte is sent over the IPC channel
 * One just after the last byte is received from the IPC channel

With the already-existing IPC markers (for when SendXXX and RecvXXX are
called), this allows us to calculate the following statistics:

 * Send thread latency
 * IPC send duration
 * IPC recv latency
 * Recv thread latency

For more information on how this is presented in the UI, see:
<https://github.com/firefox-devtools/profiler/pull/2535>.

Differential Revision: https://phabricator.services.mozilla.com/D70790
2020-06-30 18:39:42 +00:00
Myeongjun Go
20bcc8c1aa Bug 1633418 - [Perfdocs] Add the ability to include static content into perfdocs r=sparky,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D80031
2020-06-30 16:35:00 +00:00
Paul Adenot
ee148dcec6 Bug 1649233 - Add a new ProfilerMarkerPayload that is just a time duration. r=gerald,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D81592
2020-06-30 14:25:09 +00:00
Gerald Squelart
c1fe2ae51c Bug 1649056 - Pre-record some meta information before locking the profiler mutex - r=canaltinova
Some profile meta information can be gathered before the profiler mutex must be locked.
This reduces the main-thread locking when capturing.
Most importantly, it prevents deadlocking in case any of the data-gathering operation would itself rely on profiler-locking functions (e.g., starting a thread, which requires the lock to register the new thread with the profiler).

Differential Revision: https://phabricator.services.mozilla.com/D81491
2020-06-30 13:40:13 +00:00
Narcis Beleuzu
3de598d4a7 Backed out 2 changesets (bug 1649233) for bustages on ProfilerMarkerPayload.h . CLOSED TREE
Backed out changeset 399e54895a75 (bug 1649233)
Backed out changeset 3955edb371cf (bug 1649233)
2020-06-30 16:36:06 +03:00
Paul Adenot
d9cb2a1db6 Bug 1649233 - Add a new ProfilerMarkerPayload that is just a time duration. r=gerald,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D81592
2020-06-30 12:10:00 +00:00
Gerald Squelart
3fbe4a7b38 Bug 1648972 - Fix profiler non-unified build - r=canaltinova
Mostly missing includes, and missing namespace qualifiers.

Differential Revision: https://phabricator.services.mozilla.com/D81451
2020-06-30 05:07:21 +00:00
Narcis Beleuzu
3700aab557 Backed out 7 changesets (bug 1634846, bug 1647628, bug 1649294, bug 1647112) for webgl-conf crashes. CLOSED TREE
Backed out changeset 4441d06e96c3 (bug 1647628)
Backed out changeset 4efaf32bc8f7 (bug 1647112)
Backed out changeset 2d24ad813039 (bug 1647112)
Backed out changeset fda262d73a13 (bug 1649294)
Backed out changeset 5863f9c5229f (bug 1634846)
Backed out changeset bca79526745d (bug 1634846)
Backed out changeset d539408a0048 (bug 1634846)
2020-06-30 09:50:00 +03:00
Narcis Beleuzu
51f0465656 Backed out 2 changesets (bug 1648972, bug 1649056) for assertion failure on ExtensionPolicyService.cpp . CLOSED TREE
Backed out changeset 6a8b446a95a0 (bug 1649056)
Backed out changeset 56b166e41900 (bug 1648972)
2020-06-30 08:00:31 +03:00
Gerald Squelart
4962aa68cc Bug 1649056 - Pre-record some meta information before locking the profiler mutex - r=canaltinova
Some profile meta information can be gathered before the profiler mutex must be locked.
This reduces the main-thread locking when capturing.
Most importantly, it prevents deadlocking in case any of the data-gathering operation would itself rely on profiler-locking functions (e.g., starting a thread, which requires the lock to register the new thread with the profiler).

Differential Revision: https://phabricator.services.mozilla.com/D81491
2020-06-30 01:43:36 +00:00
Gerald Squelart
b7307aabfe Bug 1648972 - Fix profiler non-unified build - r=canaltinova
Mostly missing includes, and missing namespace qualifiers.

Differential Revision: https://phabricator.services.mozilla.com/D81451
2020-06-30 01:43:24 +00:00
Jean-Yves Avenard
35101e741b Bug 1634846 - P2. Make ipc's MessageChannel works with TaskQueue, r=nika
We no longer rely of having a message loop for the worker thread.

Differential Revision: https://phabricator.services.mozilla.com/D80655
2020-06-26 09:34:47 +00:00
Kris Maglione
59b6d97296 Bug 1648270: Follow-up: Fix botched rebase.
Differential Revision: https://phabricator.services.mozilla.com/D81360
2020-06-26 16:41:39 +00:00
Kris Maglione
c04b0a1b46 Bug 1648270: Get rid of unused ContentParent 'opener' field. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D80971
2020-06-26 16:26:50 +00:00
Simon Fraser
e75d5918a7 Bug 1392914 Remove updatev2.manifest r=mhowell
I've left the mention of updatev2.manifest in list_files and list_dirs for now, similar to how v1 has been left.

Differential Revision: https://phabricator.services.mozilla.com/D80011
2020-06-18 07:42:21 +00:00
Mike Hommey
77976c2cc1 Bug 1463035 - Remove MOZ_SIGNAL_TRAMPOLINE. r=gerald
This was previously r=jchen and landed, but was backed out because some
Android tests were running on an unrealistically old Linux kernel. These
tests have been retired, so this can reland.

Differential Revision: https://phabricator.services.mozilla.com/D81278
2020-06-26 03:48:49 +00:00
Mike Hommey
219d10e7ce Bug 1648654 - Remove AutoObjectMapperFaultyLib. r=gerald
Bug 1486524 disabled the features from the custom linker that required
AutoObjectMapperFaultyLib. We can now rely on AutoObjectMapperPOSIX
instead.

Differential Revision: https://phabricator.services.mozilla.com/D81264
2020-06-26 01:26:56 +00:00
Mike Hommey
a1386ca439 Bug 1648340 - Set LOCAL_INCLUDES properly for AutoObjectMapper.h. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D81023
2020-06-25 10:59:32 +00:00
Nazım Can Altınova
8e7aefa97e Bug 1624993 - Transfer all the Android markers to platform side while capturing the profile r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D79124
2020-06-25 14:29:29 +00:00
Nazım Can Altınova
738659e709 Bug 1624993 - Add StoreMarker function to unify the marker insertion points. r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D79423
2020-06-25 14:28:54 +00:00
Nazım Can Altınova
a74d238798 Bug 1624993 - Add PutObjects method inside the ProfilerBuffer class as well. r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D79122
2020-06-25 14:28:41 +00:00
Gerald Squelart
665b0d71d2 Bug 1630448 - MOZ_PROFILER_STARTUP_NO_BASE=1 prevents Base Profiler from running when MOZ_PROFILER_STARTUP is set - r=canaltinova
The Base Profiler is still recent and barely used, so it may contain some bugs.
With bug 1586939, the Base Profiler is now used more often because it is controlled the same way as the Gecko Profiler.
This has surfaced some intermittent issues, which pollute existing tests.

Until the root cause is found (see bug 1648325), setting `MOZ_PROFILER_STARTUP_NO_BASE=1` prevents the Base Profiler from running. This may be used where problems are visible, to diagnostic them and/or reduce them where needed.

Differential Revision: https://phabricator.services.mozilla.com/D81018
2020-06-25 07:13:43 +00:00
Matt Woodrow
ea21b3dd8e Bug 1646582 - Remove RemoteWebProgressManager. r=nika,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D80129
2020-06-24 19:59:04 +00:00
Jared Wein
7639e4f712 Bug 1643093 - Remove references to 'whitelist' in browser/components/urlbar. r=jaws
Depends on D78124

Differential Revision: https://phabricator.services.mozilla.com/D78122
2020-06-24 15:59:04 +00:00
Gijs Kruitbosch
b4623ffd8b Bug 1647787 - remove use of whitelist/blacklist from front-end performance tests, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D80697
2020-06-24 14:23:49 +00:00
Kartikaya Gupta
6c36ed2c70 Bug 1647265 - Follow-up to fix merge error with bug 1647225. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D80872
2020-06-24 13:32:30 +00:00
Dorel Luca
90a64f0da1 Backed out 4 changesets (bug 1646582) for Browser-chrome failures on nsIWebProgress.addProgressListener. CLOSED TREE
Backed out changeset 2111dd0d6dc0 (bug 1646582)
Backed out changeset e6c496c5a4b1 (bug 1646582)
Backed out changeset 49b4ae8c8be0 (bug 1646582)
Backed out changeset 9d42ec89240c (bug 1646582)
2020-06-24 07:50:07 +03:00
Matt Woodrow
acd97f7b2c Bug 1646582 - Remove RemoteWebProgressManager. r=nika,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D80129
2020-06-24 03:25:09 +00:00
Sylvestre Ledru
c0c079aa46 Bug 1647265 - mozlint/rejected-word - refresh the exclude list ignore-case: true r=Gijs
and update the list with this change

Depends on D80477

Differential Revision: https://phabricator.services.mozilla.com/D80478
2020-06-23 21:18:49 +00:00
Sylvestre Ledru
56fbafd822 Bug 1647265 - mozlint: when type is 'regex', add the capability to ignore the case r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D80477
2020-06-23 21:45:16 +00:00
Sonia Singla
2d8647fd24 Bug 1643819 - Prevent Firefox Docs to copy $ while copying using copy button.r=championshuttler,ahal
Differential Revision: https://phabricator.services.mozilla.com/D80643
2020-06-23 15:03:30 +00:00
Kartikaya Gupta
ba550838cd Bug 1647225 - Update exclude list in rejected-words filter. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D80453
2020-06-23 15:14:34 +00:00
Narcis Beleuzu
b894acb874 Backed out 4 changesets (bug 1646582) for mochitest failures on test_ext_tabs_create.html . CLOSED TREE
Backed out changeset ce5cdfc5d7cf (bug 1646582)
Backed out changeset 2ac69a2b6708 (bug 1646582)
Backed out changeset 74d89cb24414 (bug 1646582)
Backed out changeset 7de0ff1af560 (bug 1646582)
2020-06-23 06:30:03 +03:00
Matt Woodrow
f851c6be5b Bug 1646582 - Remove RemoteWebProgressManager. r=nika,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D80129
2020-06-23 01:23:59 +00:00
Narcis Beleuzu
1f50773a6e Backed out 8 changesets (bug 1647225) for xpcshell failures on test_gfxBlacklist_Version.js CLOSED TREE
Backed out changeset b6f88195da61 (bug 1647225)
Backed out changeset a5b3f54cb5f2 (bug 1647225)
Backed out changeset 6a1025189b0e (bug 1647225)
Backed out changeset b95de94b444e (bug 1647225)
Backed out changeset ed2c7dfd8373 (bug 1647225)
Backed out changeset 1adc99494bcb (bug 1647225)
Backed out changeset 5d0cf22c335a (bug 1647225)
Backed out changeset 956b43a8636f (bug 1647225)
2020-06-23 04:34:12 +03:00
Gerald Squelart
8b62df9f8d Bug 1642726 - Abort profiler_add_native_allocation_marker if profiler mutex is already locked - r=gregtatum
To avoid deadlocks between the profiler mutex and another mutex that may be locked when an allocation is intercepted, we now abort this interception if the profiler mutex is already locked.

Differential Revision: https://phabricator.services.mozilla.com/D79413
2020-06-22 21:30:10 +00:00
Gerald Squelart
8c64fc6990 Bug 1642726 - maybelocked_profiler_add_marker_for_thread - r=gregtatum
This function can be called whether the profiler mutex is locked or not. If locked, the provided pointer to the profiler mutex is used internally, otherwise the mutex will be locked as needed.

Differential Revision: https://phabricator.services.mozilla.com/D79412
2020-06-22 14:36:18 +00:00
Gerald Squelart
b834db3337 Bug 1642726 - locked_profiler_get_backtrace - r=gregtatum
`locked_profiler_get_backtrace` can be used internally from places that already hold the profiler lock.

Differential Revision: https://phabricator.services.mozilla.com/D79411
2020-06-22 14:36:16 +00:00
Gerald Squelart
ddbeeb188c Bug 1642726 - PSAutoTryLock - r=gregtatum
PSAutoTryLock attempts to lock the mutex, but gives up immediately if it's already locked.
This can be used in profiler functions that may be called from unknown code, to avoid deadlocks involving the profiler mutex and another mutex that could be indirectly used by the profiler itself.

Differential Revision: https://phabricator.services.mozilla.com/D79410
2020-06-22 21:30:06 +00:00
Kartikaya Gupta
7bf3988124 Bug 1647225 - Update exclude list in rejected-words filter. r=jrmuizel
Depends on D80452

Differential Revision: https://phabricator.services.mozilla.com/D80453
2020-06-22 14:06:33 +00:00
Sylvestre Ledru
46af48052b Bug 1646421 - flake8 Fix a bunch of actual errors r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D80078
2020-06-20 09:46:45 +00:00
Sylvestre Ledru
3ff66789b4 Bug 1646421 - Update to flake8 3.8.3 (requires toml now) r=linter-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D80076
2020-06-20 10:24:29 +00:00
Sylvestre Ledru
45c363c275 Bug 1646421 - mozlint/flake8 remove the force-removal of the exclude list r=linter-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D80075
2020-06-20 09:45:59 +00:00
Matthew Gregan
943cc5de15 Bug 1646579 - media/audioipc/client/src/ missing from rustfmt exclude list. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D80126
2020-06-19 06:22:28 +00:00
Ricky Stewart
09750d5dab Bug 1646190 - Remove pymake from tree r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D79920
2020-06-18 21:06:32 +00:00
Sylvestre Ledru
f47f1968a4 Bug 1623024 - mozlint: Add pylint as new linter r=linter-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D79076
2020-06-18 20:04:50 +00:00
Simon Sapin
7c14e4e23e Bug 1633410 - Back out bug 1631721.
Rebased and squashed.

Differential Revision: https://phabricator.services.mozilla.com/D78174
2020-06-18 15:25:33 +00:00
Gijs Kruitbosch
272fe15123 Bug 1644863 - include CSS, HTML and localization (ftl, properties, dtd) files in the whitespace linter, r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D79204
2020-06-17 22:46:42 +00:00
Chris AtLee
212d6bc5f7 Bug 1643810: Use -T1 -7e for update generation r=sfraser
Differential Revision: https://phabricator.services.mozilla.com/D78808
2020-06-16 13:58:47 +00:00