Commit Graph

8640 Commits

Author SHA1 Message Date
Rob Wu
4a505cf223 Bug 1557792 - Show missing private browsing rows in about:addons r=mixedpuppy,mstriemer
For parity with the XUL about:addons page, this commit adds missing rows
to the details view:

- Bug 1557792 - incognito not_allowed should show "Not Allowed in Private Windows"

- Bug 1551947 - extensions with locked private browsing flag should not
  show inputs to control the flag, but "Requires Access to Private Windows"

Differential Revision: https://phabricator.services.mozilla.com/D34936

--HG--
extra : moz-landing-system : lando
2019-06-14 15:49:07 +00:00
Luca Greco
1c8f2694dc Bug 1559124 - Set initialViewSelected to true when loadViewInternal has been called. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D35031

--HG--
extra : moz-landing-system : lando
2019-06-14 19:19:25 +00:00
Narcis Beleuzu
d8ed2da007 Backed out changeset 1eba4a29505b (bug 1557792) for bc failures on browser_html_detail_view.js 2019-06-14 05:18:50 +03:00
Rob Wu
f404754f4b Bug 1557792 - Show missing private browsing rows in about:addons r=mixedpuppy
For parity with the XUL about:addons page, this commit adds missing rows
to the details view:

- Bug 1557792 - incognito not_allowed should show "Not Allowed in Private Windows"

- Bug 1551947 - extensions with locked private browsing flag should not
  show inputs to control the flag, but "Requires Access to Private Windows"

Differential Revision: https://phabricator.services.mozilla.com/D34936

--HG--
extra : moz-landing-system : lando
2019-06-13 22:27:30 +00:00
Luca Greco
8628f0f273 Bug 1558540 - Show report checkbox in uninstall addon dialog only for supported addon types. r=jaws,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D34643

--HG--
extra : moz-landing-system : lando
2019-06-13 18:25:45 +00:00
Luca Greco
023205187f Bug 1549290 - Set AbuseReport addon_signature as "curated" in AbuseReport on recommended addon. r=robwu,aswan
Differential Revision: https://phabricator.services.mozilla.com/D34849

--HG--
extra : moz-landing-system : lando
2019-06-13 16:44:44 +00:00
Rob Wu
f499a668f4 Bug 1559112 - Do not check recommendations for builtin addons r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D34862

--HG--
extra : moz-landing-system : lando
2019-06-13 15:28:05 +00:00
Rob Wu
b95feeba82 Bug 1559131 - Add skip-if=require_signing to test_recommendations.js r=rpl
test_recommendations.js has one test that verifies that an unsigned
add-on is not recommended. In order to load an unsigned add-on, it
needs to disable signing. Signing can however not be disabled when
MOZ_REQUIRE_SIGNING=1. So skip the test if require_signing is set.

Differential Revision: https://phabricator.services.mozilla.com/D34891

--HG--
extra : moz-landing-system : lando
2019-06-13 15:14:34 +00:00
Gijs Kruitbosch
d48b3702d3 Bug 1519434 - remove 'always activate' and 'remember this decision' UI options, r=aswan,johannh
Differential Revision: https://phabricator.services.mozilla.com/D34215

--HG--
extra : moz-landing-system : lando
2019-06-13 08:42:47 +00:00
Gijs Kruitbosch
7936fd6350 Bug 1519434 - make nsPluginTag and the addon manager agree about what is and isn't flash, r=jmathies,aswan
Differential Revision: https://phabricator.services.mozilla.com/D34214

--HG--
extra : moz-landing-system : lando
2019-06-13 08:41:43 +00:00
Gijs Kruitbosch
a8bd1715ab Bug 1519434 - only allow perma-enabling non-flash plugins, r=jmathies,aswan
Differential Revision: https://phabricator.services.mozilla.com/D34213

--HG--
extra : moz-landing-system : lando
2019-06-13 08:41:28 +00:00
Gijs Kruitbosch
38159f5246 Bug 1519434 - remove plugin click to play pref as running without it won't make sense anymore, r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D34212

--HG--
extra : moz-landing-system : lando
2019-06-13 08:40:59 +00:00
Mark Striemer
fd0cb8542e Bug 1544950 - Part 2: Global add-on warnings for HTML about:addons r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D34452

--HG--
extra : moz-landing-system : lando
2019-06-13 03:09:45 +00:00
Mark Striemer
3804bf6135 Bug 1544950 - Part 1: Add-on warning messages for HTML about:addons r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D34449

--HG--
extra : moz-landing-system : lando
2019-06-13 03:08:59 +00:00
Mark Striemer
a7dbfced1c Bug 1539699 - Show a recommended badge for recommended add-ons (HTML) r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D34780

--HG--
extra : moz-landing-system : lando
2019-06-13 01:57:07 +00:00
Rob Wu
ffa0534666 Bug 1540253 - Define an isRecommended property for add-ons r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D34667

--HG--
extra : moz-landing-system : lando
2019-06-12 21:39:01 +00:00
Luca Greco
b0ca6a0f20 Bug 1558784 - Truncate abuse report properties that may be longer than allowed by the API endpoint. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D34768

--HG--
extra : moz-landing-system : lando
2019-06-12 20:39:53 +00:00
Ehsan Akhgari
b3c4267b3c Bug 1557887 - Part 6: Pass a storage principal to the rest of the call sites for createAboutBlankContentViewer(); r=baku
Differential Revision: https://phabricator.services.mozilla.com/D34460

--HG--
extra : moz-landing-system : lando
2019-06-12 09:07:33 +00:00
Andreea Pavel
f66f9762a5 Backed out 7 changesets (bug 1519434) for mochiest failures e.g test_bug1165981.html on a CLOSED TREE
Backed out changeset 1314623831ad (bug 1519434)
Backed out changeset 6dd4fa67e209 (bug 1519434)
Backed out changeset b241c580b293 (bug 1519434)
Backed out changeset b48dca2f487f (bug 1519434)
Backed out changeset 49c64ed2e67b (bug 1519434)
Backed out changeset dd009a001c6c (bug 1519434)
Backed out changeset 5b6ec4d2f0ab (bug 1519434)
2019-06-12 23:31:16 +03:00
Gijs Kruitbosch
c4f72aca27 Bug 1519434 - remove 'always activate' and 'remember this decision' UI options, r=aswan,johannh
Differential Revision: https://phabricator.services.mozilla.com/D34215

--HG--
extra : moz-landing-system : lando
2019-06-12 18:50:14 +00:00
Gijs Kruitbosch
96c829b0db Bug 1519434 - make nsPluginTag and the addon manager agree about what is and isn't flash, r=jmathies,aswan
Differential Revision: https://phabricator.services.mozilla.com/D34214

--HG--
extra : moz-landing-system : lando
2019-06-12 18:49:56 +00:00
Gijs Kruitbosch
fa4c2a54c9 Bug 1519434 - only allow perma-enabling non-flash plugins, r=jmathies,aswan
Differential Revision: https://phabricator.services.mozilla.com/D34213

--HG--
extra : moz-landing-system : lando
2019-06-12 18:49:42 +00:00
Gijs Kruitbosch
7a17996536 Bug 1519434 - remove plugin click to play pref as running without it won't make sense anymore, r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D34212

--HG--
extra : moz-landing-system : lando
2019-06-12 18:49:30 +00:00
Luca Greco
51f4010b77 Bug 1558305 - Fix sideload and file-url install_method values in AbuseReporter.getReportData method. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D34414

--HG--
extra : moz-landing-system : lando
2019-06-12 18:24:39 +00:00
Andrew Swan
c70deb1b4b Bug 1540368 Fix XPIDatabase migration when skipping schema versions r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D34424

--HG--
extra : moz-landing-system : lando
2019-06-12 16:56:04 +00:00
Boris Zbarsky
cd725846b9 Bug 1558651. Stop using [array] in amIWebInstallPrompt. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D34633

--HG--
extra : moz-landing-system : lando
2019-06-11 22:28:59 +00:00
Rob Wu
87c294932a Bug 1557944 - Fix intermittent browser_html_plugins.js r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D34616

--HG--
extra : moz-landing-system : lando
2019-06-11 21:26:14 +00:00
Masatoshi Kimura
7f2a5cd53d Bug 1558095 - Remove useless waitpid from updater. r=rstrong
Differential Revision: https://phabricator.services.mozilla.com/D34503

--HG--
extra : moz-landing-system : lando
2019-06-11 17:34:05 +00:00
Gijs Kruitbosch
01a67ca408 Bug 1557790 - fix initialization of blocklist clients, r=aswan
In order for the remote settings blocklist to sync, we need to ensure that
the corresponding remote settings clients are created (see also
https://bugzilla.mozilla.org/show_bug.cgi?id=1557790#c2 ). This is
necessary because the blocklist clients are not in the `main` bucket.

This would otherwise happen as soon as any consumer asked the blocklist
for any block data, but that's not going to happen unless the list of
add-ons or plugins changes. Even if there are no changes to the local
lists of installed things, we do need blocklist updates because
otherwise already-installed items would never get blocked even if/when
they are added to the blocklist.

The client initialization should have no other side effects (in terms of
performance/cost) beyond ensuring they get included in things we ask for
when the update-timer fires.

Differential Revision: https://phabricator.services.mozilla.com/D34550

--HG--
extra : moz-landing-system : lando
2019-06-11 18:39:45 +00:00
Barret Rennie
0bd4d6512b Bug 1553200 - Do not receive unwanted nsIWebProgress events in addon discovery view r=mconley
Depends on D33996

Differential Revision: https://phabricator.services.mozilla.com/D33997

--HG--
extra : moz-landing-system : lando
2019-06-11 17:47:52 +00:00
Boris Zbarsky
9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Luca Greco
3c296fbc6f Bug 1556389 - Show report action only on currently supported addon types. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D34341

--HG--
extra : moz-landing-system : lando
2019-06-10 18:38:57 +00:00
Luca Greco
0da35261b6 Bug 1551490 - Fix browser_reinstall.js with HTML about:addons r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D31496

--HG--
extra : moz-landing-system : lando
2019-06-10 00:03:42 +00:00
Rob Wu
6e4fdcf355 Bug 1551490 - Hide add-on preferences when not allowed in private windows, fix browser_webext_incognito.js r=rpl
Fix browser_webext_incognito.js to work with both XUL and HTML about:addons.

This patch also ensures that (inline) options UI is only shown in HTML
about:addons in private windows if add-ons are allowed access to it.
browser_webext_incognito.js serves as a unit test for this.

Differential Revision: https://phabricator.services.mozilla.com/D34277

--HG--
extra : moz-landing-system : lando
2019-06-10 00:03:36 +00:00
Rob Wu
17aef30266 Bug 1551490 - Fix browser_webext_icon.js when HTML about:addons is enabled by default r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D34183

--HG--
extra : moz-landing-system : lando
2019-06-07 18:33:52 +00:00
Rob Wu
cda23bce99 Bug 1551490 - Fix tests when abuse reporting is enabled by default r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D34174

--HG--
extra : moz-landing-system : lando
2019-06-09 11:18:56 +00:00
Rob Wu
349969e334 Bug 1551490 - Fix test failures with inline options in HTML about:addons r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D34078

--HG--
extra : moz-landing-system : lando
2019-06-09 11:18:54 +00:00
Luca Greco
f7e77e86fa Bug 1551490 - Disable HTML about:addons on legacy XUL about:addons tests. r=kmag,rpl
Depends on  D31782

Differential Revision: https://phabricator.services.mozilla.com/D31789

--HG--
extra : moz-landing-system : lando
2019-06-08 16:03:59 +00:00
Luca Greco
aad3f5c459 Bug 1551490 - Rename browser_bug562797 to browser_history_navigation and run on XUL and HTML about:addons. r=kmag,rpl
Depends on D31780

Differential Revision: https://phabricator.services.mozilla.com/D31782

--HG--
rename : toolkit/mozapps/extensions/test/browser/browser_bug562797.js => toolkit/mozapps/extensions/test/browser/browser_history_navigation.js
extra : moz-landing-system : lando
2019-06-09 23:50:18 +00:00
Luca Greco
083817496e Bug 1551490 - Fix browser_dragdrop.js and fold browser_dragdrop_incompat into it. r=kmag
Depends on D31779

Differential Revision: https://phabricator.services.mozilla.com/D31780

--HG--
extra : moz-landing-system : lando
2019-05-24 16:07:07 +00:00
Luca Greco
e01108444d Bug 1551490 - Fix browser_gmpProvider and run tests on XUL and HTML about:addons. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D31778

--HG--
extra : moz-landing-system : lando
2019-06-08 19:59:55 +00:00
Luca Greco
c93bf0f614 Bug 1551490 - Run browser_CTP_plugins.js on both XUL and HTML about:addons page. r=aswan,rpl
Depends on D31776

Differential Revision: https://phabricator.services.mozilla.com/D31777

--HG--
extra : moz-landing-system : lando
2019-06-07 18:40:13 +00:00
Joseph Jalbert
36994eb6d0 Bug 1542351: Allow 'edge' and non-gecko browser specific settings in the extensions schema manifest r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D32819

--HG--
extra : moz-landing-system : lando
2019-06-09 15:38:20 +00:00
Boris Zbarsky
bb35ab7a20 Bug 1557963. Stop using [array] in nsIUpdateService. r=rstrong
Differential Revision: https://phabricator.services.mozilla.com/D34278

--HG--
extra : moz-landing-system : lando
2019-06-08 19:04:47 +00:00
Narcis Beleuzu
bba1aa3876 Merge mozilla-central to autoland. CLOSED TREE 2019-06-08 12:47:41 +03:00
Narcis Beleuzu
e360889d62 Merge inbound to mozilla-central. a=merge 2019-06-08 12:41:03 +03:00
Sylvestre Ledru
f1fbd2ff00 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D33456

--HG--
extra : moz-landing-system : lando
2019-06-08 08:26:37 +00:00
Mike Conley
9ba27e9b5e Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag
Differential Revision: https://phabricator.services.mozilla.com/D33166

--HG--
extra : moz-landing-system : lando
2019-06-08 01:11:14 +00:00
Mark Striemer
371337e885 Bug 1525185 - Telemetry for HTML about:addons r=mixedpuppy,rpl
Differential Revision: https://phabricator.services.mozilla.com/D31726

--HG--
extra : moz-landing-system : lando
2019-06-07 23:16:57 +00:00
Noemi Erli
ea35f4b13b Backed out 6 changesets (bug 1505909) for failures in browser_ext_webNavigation_onCreatedNavigationTarget_contextmenu.js CLOSED TREE
Backed out changeset 57336967a6c7 (bug 1505909)
Backed out changeset 8adcacadd689 (bug 1505909)
Backed out changeset bcca6bb913ef (bug 1505909)
Backed out changeset afc11a5ebb6d (bug 1505909)
Backed out changeset 40f0a56ed3af (bug 1505909)
Backed out changeset 3e31f9726798 (bug 1505909)
2019-06-07 19:19:14 +03:00