837 Commits

Author SHA1 Message Date
Hiroyuki Ikezoe
9b165804d8 Bug 1586986 - Deliver 'fixed-bottom' offset to the top of the pres context on the foreground tab. r=geckoview-reviewers,tnikkel,snorp
The dynamic toolbar transition doesn't affect on background tabs since to
switch tabs the dynamic toolbar should be restored to its original state (i.e.,
completely visible state).

Differential Revision: https://phabricator.services.mozilla.com/D52336

--HG--
extra : moz-landing-system : lando
2019-11-21 21:15:46 +00:00
Hiroyuki Ikezoe
2a51338a5a Bug 1586144 - Introduce an API to set the dynamic toolbar maximum height in GeckoView. r=geckoview-reviewers,tnikkel,snorp
And deliver the value to the top content pres context, but it's not used in
this commit. The value will be used in the next commit.

One caveat is that areas covered by the dynamic toolbar will be outside
of the content area, which means implementers of GeckoView needs to call
setVerticalClipping with _negative_ values.

Depends on D50416

Differential Revision: https://phabricator.services.mozilla.com/D50417

--HG--
extra : moz-landing-system : lando
2019-11-14 05:59:47 +00:00
Brendan Dahl
eafc9e3293 Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486

--HG--
rename : xpfe/appshell/nsXULWindow.cpp => xpfe/appshell/AppWindow.cpp
rename : xpfe/appshell/nsXULWindow.h => xpfe/appshell/AppWindow.h
rename : xpfe/appshell/nsIXULWindow.idl => xpfe/appshell/nsIAppWindow.idl
extra : moz-landing-system : lando
2019-11-05 17:56:28 +00:00
Elliot Stirling
1c3c845ad9 Bug 1577192 - Adds a screenshot api using ScreenshotBuilder. r=geckoview-reviewers,snorp,rbarker
Differential Revision: https://phabricator.services.mozilla.com/D49293

--HG--
extra : moz-landing-system : lando
2019-11-05 16:15:09 +00:00
Mihai Alexandru Michis
b819bd25aa Backed out 2 changesets (bug 1470510) for causing bustages in widget/cocoa/nsChildView.mm CLOSED TREE
Backed out changeset a343f30c34a3 (bug 1470510)
Backed out changeset 4da64790094d (bug 1470510)

--HG--
rename : xpfe/appshell/nsIAppWindow.idl => xpfe/appshell/nsIXULWindow.idl
rename : xpfe/appshell/AppWindow.cpp => xpfe/appshell/nsXULWindow.cpp
rename : xpfe/appshell/AppWindow.h => xpfe/appshell/nsXULWindow.h
2019-11-05 09:24:26 +02:00
Brendan Dahl
0c0da7791e Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486

--HG--
rename : xpfe/appshell/nsXULWindow.cpp => xpfe/appshell/AppWindow.cpp
rename : xpfe/appshell/nsXULWindow.h => xpfe/appshell/AppWindow.h
rename : xpfe/appshell/nsIXULWindow.idl => xpfe/appshell/nsIAppWindow.idl
extra : moz-landing-system : lando
2019-11-04 23:37:31 +00:00
Dorel Luca
0207ce5451 Backed out 2 changesets (bug 1470510) for build bustage on /build/src/widget/cocoa/nsChildView.mm. CLOSED TREE
Backed out changeset 5967bf633574 (bug 1470510)
Backed out changeset 067a556bb614 (bug 1470510)

--HG--
rename : xpfe/appshell/nsIAppWindow.idl => xpfe/appshell/nsIXULWindow.idl
rename : xpfe/appshell/AppWindow.cpp => xpfe/appshell/nsXULWindow.cpp
rename : xpfe/appshell/AppWindow.h => xpfe/appshell/nsXULWindow.h
extra : amend_source : 752d828c6a0726c3f2df57a25741e38b36b75d6b
2019-11-04 19:18:56 +02:00
Brendan Dahl
247b257cfa Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486

--HG--
rename : xpfe/appshell/nsXULWindow.cpp => xpfe/appshell/AppWindow.cpp
rename : xpfe/appshell/nsXULWindow.h => xpfe/appshell/AppWindow.h
rename : xpfe/appshell/nsIXULWindow.idl => xpfe/appshell/nsIAppWindow.idl
extra : moz-landing-system : lando
2019-11-04 16:52:35 +00:00
Cosmin Sabou
9e72c49d49 Backed out changeset bb34b6826ada (bug 1577192) for geckoview failures on VerticalClippingTest. 2019-11-01 23:27:41 +02:00
Elliot Stirling
92d1839a67 Bug 1577192 - Adds a screenshot api using ScreenshotBuilder. r=geckoview-reviewers,snorp,rbarker
Differential Revision: https://phabricator.services.mozilla.com/D49293

--HG--
extra : moz-landing-system : lando
2019-11-01 20:31:18 +00:00
Csoregi Natalia
5f86f24e67 Backed out changeset da311583ecc1 (bug 1583575) for gv-junit failures. CLOSED TREE 2019-11-01 11:27:17 +02:00
Aaron Klotz
77bedb6124 Bug 1583575: Retain window size between instances and use it to set the size when opening a new window; r=snorp
This obviously only improves the situation when a subsequent window is the
same size as the last window that was opened.

Differential Revision: https://phabricator.services.mozilla.com/D50527

--HG--
extra : moz-landing-system : lando
2019-10-25 22:16:15 +00:00
Daniel Varga
e4a9bb6a6b Backed out changeset 1d8e31bd28db (bug 1577192) for geckoview failure org.mozilla.geckoview.test.ScreenshotTest... On a CLOSED TREE 2019-10-30 19:35:44 +02:00
Elliot Stirling
abb32d1aeb Bug 1577192 - Adds a screenshot api using ScreenshotBuilder. r=geckoview-reviewers,snorp,rbarker
Differential Revision: https://phabricator.services.mozilla.com/D49293

--HG--
extra : moz-landing-system : lando
2019-10-29 22:28:45 +00:00
Andreea Pavel
dd6c574455 Backed out changeset 10e1c85b13b0 (bug 1583575) for android geckoview failures on a CLOSED TREE 2019-10-26 01:11:23 +03:00
Aaron Klotz
4d0bd40e2e Bug 1583575: Retain window size between instances and use it to set the size when opening a new window; r=snorp
This obviously only improves the situation when a subsequent window is the
same size as the last window that was opened.

Differential Revision: https://phabricator.services.mozilla.com/D50527

--HG--
extra : moz-landing-system : lando
2019-10-25 20:27:46 +00:00
Sylvestre Ledru
f12b9fa5c3 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D47737

--HG--
extra : moz-landing-system : lando
2019-10-06 18:29:55 +00:00
Nick Alexander
c46ec74815 Bug 1580356 - Remove Fennec (Firefox for Android). r=snorp,mshal
This does many things:

1) stops producing (and consuming) `FennecJNI*` JNI wrappers
2) removes the :app and :thirdparty Gradle projects
3) removes relevant pieces of the Gradle target configuration
4) updates lints
5) purges old configurations

After this commit, the `mobile/android` project/application builds
only GeckoView.

Differential Revision: https://phabricator.services.mozilla.com/D46536

--HG--
extra : moz-landing-system : lando
2019-10-04 20:55:11 +00:00
Emilio Cobos Álvarez
a966f41d5c Bug 1574004 - Ensure not to leak disposer if UI thread is shot down. r=snorp,agi
I've hit this in one of my try runs and looks trivial to fix.

The already_AddRefed destructor asserts when leaked.

We should just not allow to let it go out of scope without moving the pointer.

Differential Revision: https://phabricator.services.mozilla.com/D46942

--HG--
extra : moz-landing-system : lando
2019-09-24 16:50:02 +00:00
James Willcox
ec2812da2f Bug 1557411 - Add GeckoView API to expose how touch events are handled. r=geckoview-reviewers,botond,agi
Differential Revision: https://phabricator.services.mozilla.com/D46601

--HG--
extra : moz-landing-system : lando
2019-09-23 21:00:44 +00:00
Botond Ballo
a61744ca91 Bug 1564195 - Group the results of APZInputBridge::ReceiveInputEvent() into a struct. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D46376

--HG--
extra : moz-landing-system : lando
2019-09-19 02:45:21 +00:00
Emily Toop
19b04db5a0 Bug 1565466 - Lock Window in LayerViewSupport::OnDetach r=snorp
Move lock of window inside thread in `LayerViewSupport::OnDetach` and pop the `GeckoResult` from list of waiting results while we still have the initiallock in `LayerViewSupport::RecvScreenPixels`.

This passes try, but then so did the last patch.

Differential Revision: https://phabricator.services.mozilla.com/D44800

--HG--
extra : moz-landing-system : lando
2019-09-05 14:22:15 +00:00
Agi Sferro
2ad08f6d15 Bug 1576204 - Set remote flag in nsWindow for e10s. r=kmag,snorp
Chrome flags need to be set both on the `window` and the `browser` object.
Right now we only set them on the `browser` objects and that could lead to
unintended consequences. This patch sets the flags to the `window` accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D43523

--HG--
extra : moz-landing-system : lando
2019-08-28 18:11:08 +00:00
kriswright
533fc20279 Bug 1573992 - Convert android.widget_paints_background to static pref. r=njn
Converts android.widget_paints_background to a static pref. From my understanding, this pref only matters on android, and the overridden function in nsIWidget defaults to `false`. Based on that I replaced the entire WidgetPaintsBackground() function with a static pref.

Differential Revision: https://phabricator.services.mozilla.com/D42395

--HG--
extra : moz-landing-system : lando
2019-08-26 20:25:43 +00:00
kriswright
c99009c207 Bug 1573992 - Convert ui.scrolling.negate_wheel_scroll to static pref. r=njn
Converts ui.scrolling.negate_wheel_scroll to a static pref and updates its usages. This one is only enabled on android, so I used the IS_ANDROID value to fill it.

Differential Revision: https://phabricator.services.mozilla.com/D42394

--HG--
extra : moz-landing-system : lando
2019-08-26 20:25:43 +00:00
Emily Toop
5c825f981a Bug 1560641: Add a lock around mCapturePixelsResults. @geckoview-reviewers r=geckoview-reviewers,snorp
This is to ensure that multiple completions cannot be attempted on the same `GeckoResult`, resulting in crashes.

Differential Revision: https://phabricator.services.mozilla.com/D36929

--HG--
extra : moz-landing-system : lando
2019-07-24 16:23:30 +00:00
Emily Toop
8a99efca37 Bug 1553135 - Lock LayerViewSupport during detach so that other methods cannot be called during this time. r=geckoview-reviewers,snorp
This is caused by a race condition when the compositor is detached. Because the actual detachment happens in a new thread, `detach` can complete and release the lock on `mLayerViewSupport`, and `RecvScreenPixels` can obtain the lock, before `mLayerViewSupport` is properly cleaned up. We therefore check to ensure that `lvs` is not null before calling a method on it.

Differential Revision: https://phabricator.services.mozilla.com/D36928

--HG--
extra : moz-landing-system : lando
2019-07-24 15:26:31 +00:00
Bobby Holley
fe3f8ed5bb Bug 1566583 - Factor primitive conversion logic out of EventDispatcher. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D38435

--HG--
extra : moz-landing-system : lando
2019-07-24 21:10:09 +00:00
Coroiu Cristina
f3386dea34 Backed out 4 changesets (bug 1566583) for apilint and checkstyle failure at geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java on a CLOSED TREE
Backed out changeset 3700ef585384 (bug 1566583)
Backed out changeset fbc829be6c4f (bug 1566583)
Backed out changeset 14ea9c84bb0e (bug 1566583)
Backed out changeset 92f3b1bb34a4 (bug 1566583)
2019-07-24 22:59:54 +03:00
Bobby Holley
b9d662007c Bug 1566583 - Factor primitive conversion logic out of EventDispatcher. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D38435

--HG--
extra : moz-landing-system : lando
2019-07-24 19:19:29 +00:00
sotaro
1b3de0879f Bug 1533296 - Make WebRender error as to Fallback to Compositor rendering during disabling WebRender on android r=nical
On android, android's nsWindow creates LayerManaer only in nsWindow::Create(). When WebRender error happened, gecko just stopped rendering by disabling Webrender.
The nsWindow needs to re-create LayerManager during disabling Webrender. Further, during disabling WebRender, All GeckoSurfaceTextures should not be attached to GLContext. It is for preventing a conflict with AttachToGLContext() call in SurfaceTextureHost::EnsureAttached().

Differential Revision: https://phabricator.services.mozilla.com/D26687

--HG--
extra : moz-landing-system : lando
2019-06-19 16:14:56 +00:00
Emilio Cobos Álvarez
21d5c25734 Bug 1553769 - Make nsIWidget::SetFocus infallible, and make it take an enum class. r=NeilDeakin
Only gtk returns failure ever, and nobody checks the result anyway.

Use an enum class so that it's clear from the caller what it means.

Differential Revision: https://phabricator.services.mozilla.com/D32353

--HG--
extra : moz-landing-system : lando
2019-05-31 22:13:56 +00:00
Brindusan Cristian
bfa0a8a991 Backed out changeset c0895e6c7343 (bug 1553769) for causing build bustages at PluginWidgetProxy.cpp. CLOSED TREE 2019-05-30 01:00:20 +03:00
Emilio Cobos Álvarez
748cc8584f Bug 1553769 - Make nsIWidget::SetFocus infallible, and make it take an enum class. r=NeilDeakin
Only gtk returns failure ever, and nobody checks the result anyway.

Use an enum class so that it's clear from the caller what it means.

Differential Revision: https://phabricator.services.mozilla.com/D32353

--HG--
extra : moz-landing-system : lando
2019-05-29 14:37:26 +00:00
Eitan Isaacson
160a13b668 Bug 1516048 - Introduce GeckoView.setVerticalClipping. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D15240

--HG--
extra : moz-landing-system : lando
2019-04-26 22:38:10 +00:00
Srujana Peddinti
b44e48bff4 Bug 1259660 - Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag r=masayuki
Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag so that any referer in header files do not need to include MouseEvents.h only for referring them. Instead, they just need to include EventForwards.h. Now when MouseEvents.h is changed, the rebuild speed becomes faster.

Differential Revision: https://phabricator.services.mozilla.com/D25325

--HG--
extra : moz-landing-system : lando
2019-04-21 20:13:34 +00:00
Srujana Peddinti
0260a4f6e1 Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::inputSource to WidgetMouseEventBase::mInputSource r=masayuki
Renamed all class member instances from WidgetMouseEventBase::inputSource to WidgetMouseEventBase::mInputSource

Differential Revision: https://phabricator.services.mozilla.com/D25322

--HG--
extra : moz-landing-system : lando
2019-04-21 18:19:43 +00:00
Srujana Peddinti
aa45d8b79b Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::hitCluster to WidgetMouseEventBase::mHitCluster r=masayuki
Renamed all class member instances from WidgetMouseEventBase::hitCluster to WidgetMouseEventBase::mHitCluster

Differential Revision: https://phabricator.services.mozilla.com/D25318

--HG--
extra : moz-landing-system : lando
2019-04-21 18:19:20 +00:00
Sylvestre Ledru
7f60810d86 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D27245

--HG--
extra : moz-landing-system : lando
2019-04-12 13:14:25 +00:00
Agi Sferro
9530edb8c2 Bug 1540790 - [api] Remove all org.mozilla.gecko references. r=snorp
Depends On D26027

Differential Revision: https://phabricator.services.mozilla.com/D26028

--HG--
extra : moz-landing-system : lando
2019-04-10 01:51:07 +00:00
Eitan Isaacson
3c8da1a00e Bug 1540305 - Notify content of position change. r=geckoview-reviewers,esawin
Differential Revision: https://phabricator.services.mozilla.com/D25488

--HG--
extra : moz-landing-system : lando
2019-04-02 17:15:39 +00:00
Sylvestre Ledru
4aa92e3091 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D22514
2019-03-13 10:19:06 +01:00
Emily Toop
02ade4a8a2 Bug 1462018 - Add API for taking screenshot of visible page.
Invert screen pixels in `nsWindow`.

Update `RequestScreenPixels` in `nsWindow` to accept a `GeckoResult` as an argument and save as a `GlobalRef`.
Update `RecvScreenPixels` in `nsWindow` in order to invert the image before sending over JNI rather than requiring callers to invert the image themselves.
Complete the `GeckoResult` if there is one in `RecvScreenPixels` instead of making a callback to the compositor.

Remove `RecvScreenPixels` from `GeckoSession` and `GeckoSession.Compositor`.
Move `RecvScreenPixels` and `getPixels` to `GeckoDisplay`
Rename `getPixels` to `capturePixels`

Return Bitmap from `RecvScreenPixels`.

Return `GeckoResult` from `capturePixels`.

Add doc comments to new methods and classes.
Update FennecNativeDriver to use `GeckoView` and `GeckoResult`.

Update API docs and Changelog

Add tests

Differential Revision: https://phabricator.services.mozilla.com/D21833

--HG--
extra : moz-landing-system : lando
2019-03-02 10:09:08 +00:00
Ryan Hunt
63c8e0660c Bug 1523969 part 26 - Move method definition inline comments to new line in 'widget/'. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D21130

--HG--
extra : rebase_source : 83867879cf33ddd2cc1b19c20dff8cef6a51d1a9
extra : histedit_source : 67979b7a263223c1e48421f382ed1e78d6264cf9
2019-02-25 16:13:48 -06:00
Kartikaya Gupta
35b16df12a Bug 1428158 - Fix static analysis errors in Android widgetry code. r=snorp
Just a few implicit constructors that need to be made explicit.

Differential Revision: https://phabricator.services.mozilla.com/D20400

--HG--
extra : moz-landing-system : lando
2019-02-20 19:58:15 +00:00
Hiroyuki Ikezoe
b8cb200990 Bug 1523692 - Set the prefers-reduce-motion value for test to the instance of nsLookAndFeel in child processes. r=snorp
So that we can query the test value in the child process properly.

Note that the APIs used for setting the prefers-reduced-motion value for testing
are only used on Android and MacOSX.  As for MacOSX we have a different
machinery (see bug 1486971) to deliver the test value without spinning native
event loop in the child process so the change here is valid only for Android.

Differential Revision: https://phabricator.services.mozilla.com/D18311

--HG--
extra : moz-landing-system : lando
2019-02-01 22:07:26 +00:00
Eitan Isaacson
35028de560 Bug 1515774 - Pass current GeckoView position with touch events to APZC. r=geckoview-reviewers,snorp
Differential Revision: https://phabricator.services.mozilla.com/D17044

--HG--
extra : moz-landing-system : lando
2019-01-31 16:46:15 +00:00
Brindusan Cristian
e17de7336e Backed out 4 changesets (bug 1515774) for mochitest failrues at test_group_touchevents-3.html and test_touch_action.html.
Backed out changeset 45c6f07160d9 (bug 1515774)
Backed out changeset 3d97f1e46c1a (bug 1515774)
Backed out changeset 69c8787c67d6 (bug 1515774)
Backed out changeset 8e17cc234256 (bug 1515774)
2019-01-30 04:39:55 +02:00
Eitan Isaacson
d7b9a2b61f Bug 1515774 - Pass current GeckoView position with touch events to APZC. r=geckoview-reviewers,snorp
Differential Revision: https://phabricator.services.mozilla.com/D17044

--HG--
extra : moz-landing-system : lando
2019-01-29 23:18:41 +00:00
James Willcox
269f751ce7 Bug 1514253 - Create PanZoomController immediately in GeckoSession r=geckoview-reviewers,droeh#geckoview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D14562

--HG--
extra : moz-landing-system : lando
2019-01-17 14:17:50 +00:00