Commit Graph

35018 Commits

Author SHA1 Message Date
Dzmitry Malyshau
1cc5f88f07 Bug 1558167 - Force 256 alignment for texture uploads on AMD on macOS r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D48862

--HG--
extra : moz-landing-system : lando
2019-10-10 15:25:57 +00:00
sotaro
2df9cdb3b4 Bug 1587695 - Fix redundant SwapChain re-creation r=nical
Since Bug 1570879, SwapChain is created with alpha at first, then the SwapChain is typically re-created at first RenderCompositorANGLE::BeginFrame() calle, since non Glass window is common since Windows 10. The re-creation is redundant.

Differential Revision: https://phabricator.services.mozilla.com/D48800

--HG--
extra : moz-landing-system : lando
2019-10-10 08:58:00 +00:00
John Lin
aeb8b64dbe Bug 1509316 - p1: move composite listening out of VideoData/VideoSink. r=jya,mattwoodrow
On Android, decoded buffers need to be send back to MediaCodec in order to be
rendered and/or recycled. The current mechanism introduced in bug 1299068 only
works for playback(VideoData/VideoSink) but not WebRTC(VideoFrame/VideoOutput).
Move the callback to SurfaceTextureImage because VideoData and VideoFrame both
own that when using MediaCodec, and move the notification to VideoFrameContainer
for both VideoSink and VideoOutput pass frames there for compositing.

Differential Revision: https://phabricator.services.mozilla.com/D45771

--HG--
extra : moz-landing-system : lando
2019-10-09 23:08:12 +00:00
Emilio Cobos Álvarez
b320aa695c Bug 1587468 - Add syn/quote/etc to the list of allowed duplicated WR dependencies for now. r=bustage
MANUAL PUSH: bustage
2019-10-09 23:06:09 +02:00
Jeff Muizelaar
487b155e34 Bug 1586573. Don't use the visibleRect for non blob images. r=aosmond
This reverts to the previous behaviour for non-blob fallback images.

Differential Revision: https://phabricator.services.mozilla.com/D48631

--HG--
extra : moz-landing-system : lando
2019-10-09 16:54:34 +00:00
Emilio Cobos Álvarez
3a4be043a8 Bug 1587468 - Update syn / quote / synstructure in peek-poke-derive. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D48732

--HG--
extra : moz-landing-system : lando
2019-10-09 17:10:12 +00:00
Jeff Muizelaar
88c6d9a1dc Bug 1587210. Always clear mInvalidRect. r=mstange
In the future mInvalidRect and some other state should move out of DIGroup
and into a non-persistant struct that's only used during Group building.
This will allow us to completely avoid errors like this.

Differential Revision: https://phabricator.services.mozilla.com/D48706

--HG--
extra : moz-landing-system : lando
2019-10-09 18:10:54 +00:00
Markus Stange
f2eaddfc8f Bug 1577566 - Enforce appropriate output channel clamping in D2D1 ColorMatrix filters. r=bas
Differential Revision: https://phabricator.services.mozilla.com/D45142

--HG--
extra : moz-landing-system : lando
2019-10-09 15:38:21 +00:00
Jamie Nicol
51410a091e Bug 1584109 - Rename WR_RENDER_TIME to WR_FRAMEBUILD_TIME. r=jrmuizel
It is actually measuring frame building time, not rendering.

Differential Revision: https://phabricator.services.mozilla.com/D48343

--HG--
extra : moz-landing-system : lando
2019-10-09 10:52:22 +00:00
sotaro
3546b3c622 Bug 1585278 - Add option of enabling performance debugging counters of DirectComposition r=nical,jrmuizel
IDCompositionDevice is replaced by IDCompositionDevice2. It is necessary for IDCompositionDeviceDebug usage. And for using IDCompositionDevice2, _WIN32_WINNT and NTDDI_VERSION is updated from Windows 8 to Windows 8.1.

Workaround MinGW build failure.

Differential Revision: https://phabricator.services.mozilla.com/D47742

--HG--
extra : moz-landing-system : lando
2019-10-07 20:09:17 +00:00
Glenn Watson
b4d8e0c7ca Bug 1587084 - Restore the picture caching enabled preference. r=nical
The previous patch fixed the bug in the non-picture caching code
path, so we can re-enable the preference now.

Differential Revision: https://phabricator.services.mozilla.com/D48639

--HG--
extra : moz-landing-system : lando
2019-10-09 08:07:36 +00:00
Brendan Dahl
237d762715 Bug 1510785 - Skip all XBL related tests when XBL is disabled. r=bzbarsky
XBL will be disabled on android, so these tests must be skipped. Where possible
tests are copied to create shadow DOM tests.

Depends on D45615

Differential Revision: https://phabricator.services.mozilla.com/D45616

--HG--
rename : layout/inspector/tests/test_bug522601.xhtml => layout/inspector/tests/test_bug522601-shadow.xhtml
rename : layout/inspector/tests/test_bug609549.xhtml => layout/inspector/tests/test_bug609549-shadow.xhtml
rename : layout/reftests/bugs/334829-1a.xhtml => layout/reftests/bugs/334829-1a-shadow.xhtml
rename : layout/reftests/bugs/334829-1b.xhtml => layout/reftests/bugs/334829-1b-shadow.xhtml
rename : layout/reftests/bugs/386310-1b.html => layout/reftests/bugs/386310-1b-shadow.html
rename : layout/reftests/bugs/386310-1c.html => layout/reftests/bugs/386310-1c-shadow.html
rename : layout/reftests/bugs/386310-1d.html => layout/reftests/bugs/386310-1d-shadow.html
rename : layout/reftests/bugs/482592-1a.xhtml => layout/reftests/bugs/482592-1a-shadow.xhtml
rename : layout/reftests/bugs/482592-1b.xhtml => layout/reftests/bugs/482592-1b-shadow.xhtml
rename : layout/reftests/css-selectors/sibling-combinators-on-anon-content-1.xhtml => layout/reftests/css-selectors/sibling-combinators-on-anon-content-1-shadow.xhtml
rename : layout/reftests/css-selectors/sibling-combinators-on-anon-content-2.xhtml => layout/reftests/css-selectors/sibling-combinators-on-anon-content-2-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-appendmultiple.xhtml => layout/reftests/dom/multipleinsertionpoints-appendmultiple-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-appendsingle-1.xhtml => layout/reftests/dom/multipleinsertionpoints-appendsingle-1-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-appendsingle-2.xhtml => layout/reftests/dom/multipleinsertionpoints-appendsingle-2-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-insertmultiple.xhtml => layout/reftests/dom/multipleinsertionpoints-insertmultiple-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-insertsingle-1.xhtml => layout/reftests/dom/multipleinsertionpoints-insertsingle-1-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-insertsingle-2.xhtml => layout/reftests/dom/multipleinsertionpoints-insertsingle-2-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-ref2.xhtml => layout/reftests/dom/multipleinsertionpoints-ref2-shadow.xhtml
rename : layout/reftests/ib-split/insert-into-split-inline-5.html => layout/reftests/ib-split/insert-into-split-inline-5-shadow.html
extra : moz-landing-system : lando
2019-10-08 23:52:46 +00:00
Jamie Nicol
523db48f57 Bug 1587047 - Update wrench reftest expectations. r=gw
Depends on D48541

Differential Revision: https://phabricator.services.mozilla.com/D48542

--HG--
extra : moz-landing-system : lando
2019-10-08 20:18:50 +00:00
Jamie Nicol
fb307f9307 Bug 1587047 - Ensure PBO is at least height * stride size to avoid emulator error. r=gw
When uploading texture data with a PBO we currently ensure the PBO
is the size of `(height - 1) * stride + (width * bpp)`, ie the final row
only contains the width's worth of data, not the stride. This should
be okay, and works fine on other implementations, but the android
emulator thinks it is invalid and emits a GL_INVALID_OPERATION error
in the glTexSubImage* call. To avoid this, ensure that the PBO is the
full `height * stride` size.

Differential Revision: https://phabricator.services.mozilla.com/D48541

--HG--
extra : moz-landing-system : lando
2019-10-08 20:18:28 +00:00
Glenn Watson
59f6ac9ee1 Bug 1587084 - Fix non-picture-caching path on webrender. r=kvark
The framebuffer clear was accidentally removed due to a rebase
error. We need to clear the framebuffer (and z) here when the
non-picture caching path is active.

Differential Revision: https://phabricator.services.mozilla.com/D48600

--HG--
extra : moz-landing-system : lando
2019-10-08 20:44:56 +00:00
Jeff Muizelaar
c572d06005 Bug 1516286. WR Fallback: Do the empty check later. r=aosmond
What we actually care about here is whether itemRect is empty bceause that's
the what we'll use for the actual surface size.

Differential Revision: https://phabricator.services.mozilla.com/D48548

--HG--
extra : moz-landing-system : lando
2019-10-08 14:20:40 +00:00
Nicolas Silva
a68a1fa1cd Bug 1587084 - Prevent disabling picture caching temporarily. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D48555

--HG--
extra : moz-landing-system : lando
2019-10-08 15:47:46 +00:00
Bob Owen
003b93beee Bug 1580511: Check size is allowed in DrawTargetRecording::CreateSourceSurfaceFromData. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D48317

--HG--
extra : moz-landing-system : lando
2019-10-07 14:38:06 +00:00
sotaro
fb4696fe6d Bug 1570879 - Fix high contrast theme handling with DirectComposition and WebRender r=nical
When high contrast mode is enabled, title bar is drawn as transparent and on-client area rendering by DWM is shown. But when compositor window in GPU process is used, the on-client area rendering was not shown. To address the proboem, window needs to be cleard as transparent and SwapChain of compositor window needs to be DXGI_ALPHA_MODE_PREMULTIPLIED.

WinCompositorWidget::mTransparencyMode is changed to atomic, since it is accessed from compositor thread and render thread.

Differential Revision: https://phabricator.services.mozilla.com/D48302

--HG--
extra : moz-landing-system : lando
2019-10-08 10:07:47 +00:00
Bob Owen
b6cee86eff Bug 1583337: Return null in CanvasChild::WrapSurface if we don't have a recorder. r=jrmuizel
The CanvasChild must be in the process of being destroyed at this point anyway.

Differential Revision: https://phabricator.services.mozilla.com/D47443

--HG--
extra : moz-landing-system : lando
2019-10-07 14:37:13 +00:00
alwu
d832456285 Bug 1579127 - only count the frame dropping due to system overload. r=mattwoodrow
When user adjusts the video playback rate, which might cause we sending images in a speed that is faster than the speend we composite images.

In this situation, the frame dropping actually won't cause any visual defect and we also don't want to report this frame dropping to user, because it's not caused by system overloading, it's just our compositor doesn't support compositing images in such a high rate.

Therefore, we should check if the dropped images are caused by system overload or high update rate, and only report the former to user.

Differential Revision: https://phabricator.services.mozilla.com/D46236

--HG--
extra : moz-landing-system : lando
2019-10-08 08:06:13 +00:00
Botond Ballo
1e691d370f Bug 1552608 - Handle fixed layer margins in ReceiveInputEvent. r=tnikkel
Only touch events are handled at this time.

Differential Revision: https://phabricator.services.mozilla.com/D48385

--HG--
extra : moz-landing-system : lando
2019-10-07 22:22:08 +00:00
Botond Ballo
0e413c9b53 Bug 1552608 - Include the fixed-position sides in HitTestResult. r=tnikkel
Populating them is hooked up for non-WebRender, with a comment outlining
possible implementation strategies for WebRender.

Differential Revision: https://phabricator.services.mozilla.com/D48384

--HG--
extra : moz-landing-system : lando
2019-10-07 22:16:51 +00:00
Botond Ballo
ba2a3dd77a Bug 1552608 - Introduce a HitTestResult structure for grouping the results of APZ hit testing. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48383

--HG--
extra : moz-landing-system : lando
2019-10-07 22:47:17 +00:00
Botond Ballo
429e12e60f Bug 1552608 - Allow HitTestingTreeNodeAutoLock to be moved. r=tnikkel
Also remove the MOZ_RAII annotation, as that inhibits moving.

Differential Revision: https://phabricator.services.mozilla.com/D48382

--HG--
extra : moz-landing-system : lando
2019-10-07 22:04:23 +00:00
Botond Ballo
f7a776d631 Bug 1552608 - Remove the unused function APZCTreeManager::HitTestAPZC(). r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48381

--HG--
extra : moz-landing-system : lando
2019-10-07 22:01:52 +00:00
Botond Ballo
9649f2e747 Bug 1552608 - Remove the 'aNode' parameter of GetAPZCAtPoint(). r=tnikkel
This is a relic from earlier times when GetAPZCAtPoint() was recursive.

Differential Revision: https://phabricator.services.mozilla.com/D48380

--HG--
extra : moz-landing-system : lando
2019-10-07 22:00:59 +00:00
Botond Ballo
f8900bc22d Bug 1552608 - Handle fixed layer margins in ComputeTransformForNode(). r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48379

--HG--
extra : moz-landing-system : lando
2019-10-07 22:00:31 +00:00
Botond Ballo
c747ab0102 Bug 1552608 - Add a helper APZCTreeManager::IsFixedToRootContent(node). r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48378

--HG--
extra : moz-landing-system : lando
2019-10-07 21:56:36 +00:00
Botond Ballo
194efdc5a5 Bug 1552608 - Make APZCTreeManager::GetTargetAPZC(layersId, scrollId) const. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48377

--HG--
extra : moz-landing-system : lando
2019-10-07 21:54:54 +00:00
Botond Ballo
7b097cc92f Bug 1552608 - Factor out a helper AsyncCompositionManager::ComputeFixedMarginsOffset(). r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48376

--HG--
extra : moz-landing-system : lando
2019-10-07 21:52:49 +00:00
Botond Ballo
4268dbf031 Bug 1552608 - Propagate the fixed-position sides to the hit testing tree. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48375

--HG--
extra : moz-landing-system : lando
2019-10-07 21:41:20 +00:00
Botond Ballo
a3395bb518 Bug 1552608 - Use SideBits rather than int32_t to represent fixed-position sides in the Layers API. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48374

--HG--
extra : moz-landing-system : lando
2019-10-07 21:03:52 +00:00
Botond Ballo
6dece52944 Bug 1552608 - Define bitwise operators for SideBits. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48373

--HG--
extra : moz-landing-system : lando
2019-10-07 21:01:53 +00:00
Botond Ballo
3feabc5f87 Bug 1552608 - Fix include-what-you-use violations in LayerAttributes.h. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48372

--HG--
extra : moz-landing-system : lando
2019-10-07 21:04:24 +00:00
Botond Ballo
5f774c598e Bug 1552608 - Store fixed layer margins in APZCTreeManager. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48371

--HG--
extra : moz-landing-system : lando
2019-10-07 20:44:29 +00:00
Botond Ballo
89a90da007 Bug 1552608 - Factor out a helper CompositorBridgeParent::SetFixedLayerMargins(). r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48370

--HG--
extra : moz-landing-system : lando
2019-10-07 20:43:23 +00:00
Botond Ballo
1273d512eb Bug 1552608 - Define AsyncCompositionManager::mFixedLayerMargins and its getter/setter on all platforms. r=tnikkel
It's still only used on Android, but keeping it and all code that interacts
with it inside an #ifdef is too much trouble for a tiny amount of space
saving.

Differential Revision: https://phabricator.services.mozilla.com/D48369

--HG--
extra : moz-landing-system : lando
2019-10-07 20:37:09 +00:00
Jeff Muizelaar
f5e2385e64 Bug 1582210. Support splitting blob images into different sizes. r=nical
This makes things better especially when the bounds of the combined blob
is changing but the bound of the separate ones are not.

The current implementation is a bit ugly, but it's simple and
can be cleaned up in the cleanups I have in mind for the future.

Differential Revision: https://phabricator.services.mozilla.com/D47983

--HG--
extra : moz-landing-system : lando
2019-10-07 21:27:41 +00:00
Ricky Stewart
c010710916 Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=firefox-build-system-reviewers,mshal
(Same content as bad revision https://phabricator.services.mozilla.com/D48230, but with a very small change to config/external/icu/data/moz.build to fix the build breakage.)

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=833f6a69fcac689488a640b43e8e0bdaa086a56c

Differential Revision: https://phabricator.services.mozilla.com/D48409

--HG--
extra : moz-landing-system : lando
2019-10-07 21:15:19 +00:00
Daniel Varga
052ef806b5 Backed out changeset 8d95f2c8867b (bug 1586358) for build bustage with FATAL ERROR PROCESSING MOZBUILD FILE. On a CLOSED TREE
--HG--
extra : rebase_source : 325fbad2455afc7f693087e75fa57dba79f4d86b
2019-10-07 20:22:08 +03:00
Ricky Stewart
940d91af38 Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=nalexander
This patch doesn't remove all references to GENERATED_FILES, but does remove most of them, leaving only those which can't be trivially translated to the new template.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a25230c3992b9c5519ceb351fb37f6b2bf605e

Differential Revision: https://phabricator.services.mozilla.com/D48230

--HG--
extra : moz-landing-system : lando
2019-10-07 15:31:05 +00:00
Glenn Watson
d98231a231 Bug 1582624 - Add partial present API for webrender. r=nical
Differential Revision: https://phabricator.services.mozilla.com/D47732

--HG--
extra : moz-landing-system : lando
2019-10-06 20:59:36 +00:00
Emilio Cobos Álvarez
da1a862fc2 Bug 1569744 - Ensure that lock is held even with smooth scrolling disabled. r=botond
See comment 5 in the bug for the diagnostic.

Differential Revision: https://phabricator.services.mozilla.com/D48254

--HG--
extra : moz-landing-system : lando
2019-10-06 01:36:05 +00:00
Sylvestre Ledru
f12b9fa5c3 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D47737

--HG--
extra : moz-landing-system : lando
2019-10-06 18:29:55 +00:00
Doug Thayer
5a64723655 Bug 1550108 - Eliminate large buffer copies from StartupCache r=froydnj
The signatures were updated in the previous patch to hand us the raw,
uncopied buffers. This just adjusts the callsites to match.

Differential Revision: https://phabricator.services.mozilla.com/D34653

--HG--
extra : moz-landing-system : lando
2019-10-04 20:45:09 +00:00
Lee Salzman
24fe539478 Bug 1585845 - silence UBSan warning about tt_segment_t in Cairo. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D48095

--HG--
extra : moz-landing-system : lando
2019-10-04 10:30:05 +00:00
Tom Ritter
f19cbdfb39 Bug 1585351 - Bug 1460357 disabled AVX instructions for the mingw build; this is no longer needed r=lsalzman
Bug 1460357 disabled AVX because gcc was generating unaligned instructions. But clang doesn't seem
to do that.

Differential Revision: https://phabricator.services.mozilla.com/D48072

--HG--
extra : moz-landing-system : lando
2019-10-03 21:02:16 +00:00
Glenn Watson
d170ede903 Bug 1585898 - Fix broken tab bar with picture caching on mac. r=mstange
Promote clear primitives to be picture cache slices that can
be drawn during the composite step. Without this, the clear
primitive is not correct since it only operates on the slice
it is assigned to, not the entire background before it.

Differential Revision: https://phabricator.services.mozilla.com/D48139

--HG--
extra : moz-landing-system : lando
2019-10-04 01:20:49 +00:00
Kris Taeleman
3bd0cbdc09 Bug 1578506 - Add better monitor information to about:support. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D47110

--HG--
extra : moz-landing-system : lando
2019-10-03 23:43:35 +00:00