Commit Graph

55 Commits

Author SHA1 Message Date
Sylvestre Ledru
9bce072e44 Bug 1588458 - Replace dxr by searchfox in the rst doc r=ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D49140
2020-10-08 08:13:15 +00:00
Sylvestre Ledru
6be67c14c4 Bug 1667831 - doc: refresh links as many pages moved in-tree r=firefox-source-docs-reviewers,ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D91619
2020-09-29 17:53:54 +00:00
Evan Welsh
2e8ba0e06f Bug 1654696 - Implement code coverage JSAPI. r=nbp,jwalden
Differential Revision: https://phabricator.services.mozilla.com/D85808
2020-08-08 03:23:31 +00:00
David Major
4950130b02 Bug 1657391 - Update CodeCoverageHandler.cpp for clang-12 r=marco
In clang-12, 5809a32e7c split `__gcov_flush` into `__gcov_dump` and `__gcov_reset`. We have to make a corresponding update in CodeCoverageHandler.cpp to avoid build errors.

Differential Revision: https://phabricator.services.mozilla.com/D86026
2020-08-05 22:00:39 +00:00
Sylvestre Ledru
260f01d445 no bug - mozlint/codespell - Add two docs directories in the list + fix typos r=marco DONTBUILD
Depends on D65911

Differential Revision: https://phabricator.services.mozilla.com/D65912

--HG--
extra : moz-landing-system : lando
2020-03-09 10:43:14 +00:00
Sylvestre Ledru
5c0647fe0a Bug 1619159 - Refresh the code coverage doc r=marco
Depends on D64902

Differential Revision: https://phabricator.services.mozilla.com/D64903

--HG--
extra : moz-landing-system : lando
2020-03-02 15:43:20 +00:00
Sylvestre Ledru
30bee79d50 Bug 1619159 - Import the code coverage doc from mdn to in-tree r=marco
No change:
$ pandoc -trst https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Testing/Measuring_Code_Coverage_on_Firefox\?raw\=1 > index.rst

Differential Revision: https://phabricator.services.mozilla.com/D64902

--HG--
extra : moz-landing-system : lando
2020-03-02 15:42:14 +00:00
Perry Jiang
dfe4262aaf Bug 1611046 - avoid using namespace declaration r=dom-workers-and-storage-reviewers,sg
In particular this avoids unqualified name lookup ambiguity between
::Request and mozilla::dom::Request (imported into the global namespace by
using namespace mozilla::dom).

Differential Revision: https://phabricator.services.mozilla.com/D61212

--HG--
extra : moz-landing-system : lando
2020-01-29 12:05:47 +00:00
Dorel Luca
e070fba60f Backed out changeset 870b38a3dc28 (bug 1602482) for as per dev's request. a=backout 2019-12-10 13:47:12 +02:00
Calixte Denizet
0232caa2b6 Bug 1602482 - Remove use of ___custom_llvm_gcov_flush r=marco
Because of conflicts between gcov_flush from gcc and the one from llvm, we renamed llvm one into ___custom_llvm_gcov_flush.
Since we switched to clang for ccov builds, this workaround is now useless.

Differential Revision: https://phabricator.services.mozilla.com/D56394

--HG--
extra : moz-landing-system : lando
2019-12-09 17:07:00 +00:00
Ted Campbell
62565b25fc Bug 1578730 - Add js::GetCodeCovergeSummaryAll API. r=nbp,marco
Split the GetCodeCoverageSummary API into a variant for a specific realm
vs checking all realms. This restores the original behaviour of the
getLcovInfo testing function to only return info on current realm. This
makes testing OOM behaviour much more predictable.

Differential Revision: https://phabricator.services.mozilla.com/D46167

--HG--
extra : moz-landing-system : lando
2019-09-19 00:08:39 +00:00
Victor Porof
5c7cdbd4ba Bug 1561435 - Format tools/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35940

--HG--
extra : source : d214f0c82813e5a8d3987debc490a2c11f1308ff
2019-07-05 11:18:19 +02:00
Brian Grinstead
ede8c44ef2 Bug 1544322 - Part 2.1 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in everything except for dom/ r=bzbarsky
This excludes dom/, otherwise the file size is too large for phabricator to handle.

This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 2` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27456

--HG--
extra : moz-landing-system : lando
2019-04-16 03:50:44 +00:00
Mike Hommey
d89350611b Bug 1543009 - Move code coverage xpcom component to static registration. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D26893
2019-04-11 16:23:52 +09:00
Mike Hommey
071a2fe984 Bug 1541792 - Replace linker magic with manual component registration. r=froydnj
Before bug 938437, we had a rather large and error-prone
nsStaticXULComponents.cpp used to register all modules. That was
replaced with clever use of the linker, which allowed to avoid the mess
that maintaining that file was.

Fast forward to now, where after bug 1524687 and other work that
preceded it, we have a much smaller number of remaining static xpcom
components, registered via this linker hack, and don't expect to add
any new ones. The list should eventually go down to zero.

Within that context, it seems to be the right time to get rid of the
magic, and with it the problems it causes on its own.

Some of those components could probably be trivially be converted to
static registration via .conf files, but I didn't want to deal with the
possible need to increase the number of dummy modules in XPCOMInit.cpp.
They can still be converted as a followup.

Differential Revision: https://phabricator.services.mozilla.com/D26076

--HG--
extra : moz-landing-system : lando
2019-04-05 02:30:56 +00:00
Mike Hommey
fc4f272cd4 Followup for bug 1538060 again. More bustage fix. r=me,a=CristianB 2019-04-02 23:48:01 +09:00
Mark Banner
dba6983e75 Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850

--HG--
extra : moz-landing-system : lando
2019-03-28 09:38:14 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Ehsan Akhgari
e5e885ae31 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset

--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Jean-Yves Avenard
48517afae6 Bug 1512298 - Make IPDL MozPromise exclusive. r=gerald,froydnj
MozPromise most common use is to have an single or exclusive listener. By making the MozPromise generated by IPDL exclusive we can also use move semantics.

While at it, we also use move semantics for the ResponseRejectReason and via the callback's reject method so that the lambda used with the MozPromise::Then can be identical to the one used by the IPDL callback.
As it currently is, it provides no advantage over a copy as it's just an enum; however, this will facilitate future changes where it may not be.

Differential Revision: https://phabricator.services.mozilla.com/D13906

--HG--
extra : moz-landing-system : lando
2018-12-11 19:22:26 +00:00
Tooru Fujisawa
7983faeb5d Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Marco Castelluccio
3a820232fa Bug 1502021 - Keep renaming __gcov_flush in LLVM to avoid naming clashes with builds mixing GCC and LLVM coverage instrumentation. r=decoder
--HG--
rename : build/build-clang/rename_gcov_flush.patch => build/build-clang/rename_gcov_flush_.patch
extra : rebase_source : 68be58d4fa714c79a6a384fd2b1660e5eb8e7f4a
2018-11-14 01:41:22 +01:00
Marco Castelluccio
b70c36e059 Bug 1504073 - Close output stream for flushing JS coverage data after we're done writing. r=froydnj
--HG--
extra : rebase_source : b7dfc0c21419a8fa24831d2d5346cccc8de176b9
extra : source : a85127941344e9a18610eabd3c0bc10a0a8efd93
2018-11-02 01:03:11 +01:00
Cosmin Sabou
6933921ac8 Backed out 2 changesets (bug 1504073) for spidermonkey build bustages on functionnames.js
Backed out changeset 8d667ad8e5aa (bug 1504073)
Backed out changeset 3d14a1201277 (bug 1504073)
2018-11-05 15:47:07 +02:00
Marco Castelluccio
58cff813e0 Bug 1504073 - Close output stream for flushing JS coverage data after we're done writing. r=froydnj
--HG--
extra : rebase_source : a85127941344e9a18610eabd3c0bc10a0a8efd93
2018-11-02 01:03:11 +01:00
Marco Castelluccio
a1f8d401aa Bug 1380661 - Make use of JS engine coverage flushing functionality to reset/dump counters in per-test mode. r=jmaher
--HG--
extra : rebase_source : 689c756696fde514859fe8f249d0e36c81f4ba49
2018-10-24 21:33:01 +02:00
Marco Castelluccio
46eea092e8 Bug 1380661 - Test JS counters are being flushed. r=nbp
--HG--
extra : rebase_source : 6717a51b9b4821ba50c336ecb3f6e170d335a6de
2018-10-24 21:33:14 +02:00
Marco Castelluccio
9d11e91a0b Bug 1380661 - Flush JS counters too when flushing GCOV counters. r=froydnj
--HG--
extra : rebase_source : 5f29d856b3eb3f246c9bf62e6095c0294a281f3c
2018-10-24 21:32:41 +02:00
Marco Castelluccio
2c9d05cea0 Bug 1498637 - Use __gcov_flush to implement dumping and resetting instead of __gcov_dump and __gcov_reset. r=froydnj
--HG--
extra : rebase_source : 7c23ca15e09d367458b2f78d9b9b2c0674bd9d0d
2018-10-15 10:36:45 +02:00
Jan de Mooij
84036b8de4 Bug 1474272 part 4 - Stop using js::GetGlobalForObjectCrossCompartment in xpc::NativeGlobal. r=bholley 2018-08-01 11:25:50 +02:00
Marco Castelluccio
3603b9498e Bug 1476213 - Include process.h on Windows and define getpid as _getpid. r=me
--HG--
extra : rebase_source : 6d9d998248243be8b9f7dda9230450017117d2a6
2018-07-17 12:09:16 +02:00
Marco Castelluccio
ef1bf74fc5 Bug 1476213 - Be more verbose when resetting/dumping counters. r=calixte
--HG--
extra : source : 485052453b4c0a1556c7e416b3b17b7078d5b793
2018-07-17 10:05:45 +02:00
Marco Castelluccio
49c0576523 Bug 1471573 - Make SpecialPowers RequestDumpCoverageCounters and RequestResetCoverageCounters async messages that wait on the dumping/resetting to actually happen. r=jmaher
--HG--
extra : rebase_source : 5e7814abb8761cbf5ab44b4c9d2f1c456b2ed912
extra : intermediate-source : e7272b60f48f1e97d557c490eed44404daba4e85
extra : source : eb34fd6b8ce3b9e9fdf8d4610530b7d6ec693765
2018-06-28 09:40:32 +01:00
Marco Castelluccio
e81fe5afe7 Bug 1472688 - Remove any gcda file left in GCOV_PREFIX when resetting counters, and make it possible to accumulate counters. r=jmaher
--HG--
extra : rebase_source : 765ba8df0d55c2b5cec208b8e34f06b2352940e7
extra : source : 9fe7964b9a3a8fda16726f7ab18cacc59d086289
2018-07-02 14:53:07 +01:00
Calixte Denizet
9aabc7f563 Bug 1471882 - Fix build bustage on nsCodeCoverage.cpp r=marco
Summary:
- Add explicit keyword on ProcessCount ctor
- Fix an unused variable in a loop

Reviewers: marco

Reviewed By: marco

Bug #: 1471882

Differential Revision: https://phabricator.services.mozilla.com/D1864

--HG--
extra : rebase_source : be0ae98ba0b54fc626b6857336c59d114be1e6f3
2018-06-30 01:14:21 +03:00
Marco Castelluccio
84a9d2852d Bug 1471769 - Make sure PerTestCoverageUtils doesn't do anything unless per-test mode is enabled. r=jmaher
--HG--
extra : rebase_source : bc11f6bad8ca4392e02c8d736dfb388eec7ffc56
2018-06-28 09:35:45 +01:00
Marco Castelluccio
41d0c90dd9 Bug 1470151 - Add a PerTestCoverageUtils JavaScript module to manage resetting/dumping coverage counters for tests. r=jmaher
--HG--
extra : rebase_source : 9b7051f9b607bd205a9519e124688c7710a4c241
extra : source : 3579431e03dc89c5e09b069acdd45e15bd640fe6
2018-06-21 14:40:20 +01:00
Marco Castelluccio
1f679b4e78 Bug 1470151 - Make dumpCoverage and resetCoverage return a Promise that is resolved when the parent process and all content processes are done with dumping or resetting coverage counters. r=froydnj
--HG--
extra : rebase_source : a393fb7eddfad3be12162791c864fa7f2dad7f1b
extra : source : ddde7dd347d451798becc0615468dd9acc5e609c
2018-06-22 14:31:59 +01:00
Coroiu Cristina
a2ea371c3c Backed out 3 changesets (bug 1470151) for build bustage at testing/xpcshell/selftest.py on a CLOSED TREE
Backed out changeset c73f394a4bef (bug 1470151)
Backed out changeset 3579431e03dc (bug 1470151)
Backed out changeset ddde7dd347d4 (bug 1470151)
2018-06-27 16:57:10 +03:00
Marco Castelluccio
a5007cf994 Bug 1470151 - Add a PerTestCoverageUtils JavaScript module to manage resetting/dumping coverage counters for tests. r=jmaher
--HG--
extra : rebase_source : cab07616038e535e8bc5ba2cf268a4f292b384aa
2018-06-21 14:40:20 +01:00
Marco Castelluccio
2a4568f6f1 Bug 1470151 - Make dumpCoverage and resetCoverage return a Promise that is resolved when the parent process and all content processes are done with dumping or resetting coverage counters. r=froydnj
--HG--
extra : rebase_source : 1c6e668346b49a409b6271b9b51b731784a57cf5
2018-06-22 14:31:59 +01:00
Marco Castelluccio
75ddbd8927 Bug 1465737 - Make CodeCoverageHandler constructor explicit. r=froydnj 2018-05-30 01:52:55 +02:00
Mark Banner
606beee3f2 Bug 1230369 - Manually fix some remaining instances of Ci/Cc/Cu definitions and switch Components.* to using the shorthand in some places. r=florian
MozReview-Commit-ID: 9SmoR9RlvZE

--HG--
extra : rebase_source : 054e14150921615ed67415ddb91b45169cc868d4
2018-02-07 09:24:15 +00:00
Andrew McCreight
754a4bcd3c Bug 1432992, part 2 - Manually remove some empty blocks. r=florian
Also, remove a now-obsolete comment from placesOverlay.xul and remove
some now-empty XPCShell test head files.

MozReview-Commit-ID: 6kKVQu8FAL3

--HG--
extra : rebase_source : 7dd05818d68a15bd170af734078db4ba45029d80
2018-01-25 16:52:25 -08:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Marco Castelluccio
0590afed91 Bug 1416199 - Don't try to set signal handlers in Windows coverage build. r=froydnj
--HG--
extra : rebase_source : f74f90bf0e146d674044eeef2c2e9b546335a564
2017-11-10 12:50:14 +01:00
Marco Castelluccio
5a55204eb5 Bug 1403143 - Remove useless 'using namespace mozilla::ipc' from CodeCoverageHandler. r=jmaher
--HG--
extra : rebase_source : b004bf77bf9b334586b29cbfdce1bc383a739925
2017-09-26 13:48:17 +02:00
Marco Castelluccio
ebceaf00d0 Bug 1397505 - Only support dumping/resetting coverage counters with GCC builds. r=froydnj
--HG--
extra : rebase_source : c6f8662eaac48a5d6941db5e582686ce5c6b8a47
2017-09-07 00:31:03 +02:00
Christian Holler
5efd41fcce Bug 1390945 - Make GCOV signal handlers work in --disable-debug mode. r=froydnj
MozReview-Commit-ID: Lm8IhokH3ns

--HG--
extra : rebase_source : 370f499b45da8884cf654f72dd25f344b44dbd7c
2017-08-16 20:39:26 +02:00