2193 Commits

Author SHA1 Message Date
Byron Campen [:bwc]
308d7b4f16 Bug 1504252: Remove the dead code in signaling/src/media. r=drno
Differential Revision: https://phabricator.services.mozilla.com/D10738

--HG--
extra : moz-landing-system : lando
2018-11-02 18:18:31 +00:00
Gabriele Svelto
266ef73c96 Bug 1503207 - Remove nsWeakPtr.h and cleanup all files including weak reference-related headers r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D10251

--HG--
extra : moz-landing-system : lando
2018-10-31 20:39:03 +00:00
Byron Campen [:bwc]
41541e64f6 Bug 1494301: Single API for mtransport. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D7212

--HG--
extra : moz-landing-system : lando
2018-10-26 00:39:07 +00:00
Byron Campen [:bwc]
fa137d19c2 Bug 1496245: Fix bugs where transceivers could be associated with m-sections of another type. r=mjf,jib
Bug 1496245 - Part 0: web-platform-test for rollback followed by SRD with different media type.

Bug 1496245 - Part 1: Allow SRD(offer) to stomp un-negotiated level mappings on our transceivers.

Bug 1496245 - Part 2: Don't create extra datachannel transceivers, just reuse (and possibly re-enable) the one we have.

Differential Revision: https://phabricator.services.mozilla.com/D8259

--HG--
extra : moz-landing-system : lando
2018-10-25 15:53:20 +00:00
Byron Campen [:bwc]
37b133bd26 Bug 1495569: Create answers with a=mid even if the offer did not have a=mid r=mjf,jib
Bug 1495569 - Part 0: web-platform-test that verifies handling of offer without mid.
Bug 1495569 - Part 1: Ensure that answers are created with the transceiver's mid when the offer did not have a mid.

Differential Revision: https://phabricator.services.mozilla.com/D8853

--HG--
extra : moz-landing-system : lando
2018-10-17 18:50:45 +00:00
Nils Ohlmeier [:drno]
dedc2f2c81 Bug 1498068: fixed SRTP key length assertion for GCM 128 bit. r=mt
Differential Revision: https://phabricator.services.mozilla.com/D8324

--HG--
extra : moz-landing-system : lando
2018-10-16 03:30:57 +00:00
Andreas Pehrson
7561a1fdef Bug 1258143 - Remove LocalMediaStream. r=jib,smaug
Differential Revision: https://phabricator.services.mozilla.com/D8064

--HG--
extra : moz-landing-system : lando
2018-10-15 08:17:07 +00:00
Philipp Hancke
c0cf9f10eb Bug 1435789: implement relayProtocol for localcandidate stats r=smaug,ng
relayProtocol is the standardized variant of mozLocalTransport.
Spec:
  https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-relayprotocol

IDL:
  https://w3c.github.io/webrtc-stats/#icecandidate-dict*

Differential Revision: https://phabricator.services.mozilla.com/D3428

--HG--
extra : moz-landing-system : lando
2018-10-07 07:42:48 +00:00
Ciure Andrei
26b40a4469 Merge inbound to mozilla-central. a=merge 2018-10-13 12:36:04 +03:00
Sylvestre Ledru
dd5741407b Bug 1498586 - Add clang-format off to avoid the reformatting of the data structures r=Ehsan
Too hard/impossible for the tool to format correctly these structs

Differential Revision: https://phabricator.services.mozilla.com/D8569

--HG--
extra : moz-landing-system : lando
2018-10-12 20:48:24 +00:00
Paul Adenot
e9769f1597 Bug 1487057 - Part 5 - Remove MediaEngineWebRTCMicrophoneSource::mStarted. r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D5439

--HG--
extra : rebase_source : 31a0b36e2bc6431a6c7aa387baddfd9d3e35f8f8
2018-09-03 11:10:32 +02:00
Paul Adenot
3f4724fcbb Bug 1487057 - Part 4 - Remove AsyncLatencyLogger and associated code. r=pehrsons
It's not maintained and probably does not work anymore.

Differential Revision: https://phabricator.services.mozilla.com/D5438

--HG--
extra : rebase_source : ccd622e40844dda5d16266e49991462d4ea94224
2018-08-30 17:11:57 +02:00
Bogdan Tara
db185e5d31 Backed out 2 changesets (bug 1258143) for dom/media/tests/crashtests/791330.html failures CLOSED TREE
Backed out changeset 514420f15a67 (bug 1258143)
Backed out changeset 905c871bcf03 (bug 1258143)
2018-10-12 17:42:26 +03:00
Andreas Pehrson
ecdb48777f Bug 1258143 - Remove LocalMediaStream. r=jib,smaug
Differential Revision: https://phabricator.services.mozilla.com/D8064

--HG--
extra : moz-landing-system : lando
2018-10-11 12:43:34 +00:00
Jean-Yves Avenard
ab78780c77 Bug 1496529 - P8. Add media.navigator.mediadatadecoder_h264_enabled preference. r=drno
For now, the H264 decoding support is rather sturdy. It handles change of resolution and content smoothly thanks to the H264Converter.
The VP8/VP9 one however, not so much.

So we make a preference to only enable H264 for now.

Depends on D7895

Differential Revision: https://phabricator.services.mozilla.com/D7908

--HG--
extra : moz-landing-system : lando
2018-10-09 20:36:18 +00:00
Jean-Yves Avenard
26ace1a1c9 Bug 1496529 - P5. Don't unnecessarily wait on decoder to shutdown r=bryce
Depends on D7864

Differential Revision: https://phabricator.services.mozilla.com/D7865

--HG--
extra : moz-landing-system : lando
2018-10-09 16:59:14 +00:00
Jean-Yves Avenard
2ae449a166 Bug 1496529 - P4. Remove unnecessary code. r=bryce
TaskQueue no longer requires explicit shutdown

Depends on D7862

Differential Revision: https://phabricator.services.mozilla.com/D7864

--HG--
extra : moz-landing-system : lando
2018-10-09 16:59:12 +00:00
Byron Campen [:bwc]
c88e11cbd1 Bug 1495160: Count datachannel "tracks" properly again. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D7494

--HG--
extra : moz-landing-system : lando
2018-10-03 14:07:12 +00:00
Byron Campen [:bwc]
8e84dcb778 Bug 1493765: Stop using NrIce* in PeerConnectionImpl. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D6767

--HG--
extra : moz-landing-system : lando
2018-09-27 18:27:25 +00:00
Byron Campen [:bwc]
846bdbd571 Bug 1493146: Lengthen ice-pwd r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D6490

--HG--
extra : moz-landing-system : lando
2018-09-21 15:48:52 +00:00
Andreea Pavel
c8f8e2da0d Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2018-09-21 01:00:46 +03:00
Andreea Pavel
f5f6c0b588 Merge mozilla-inbound to mozilla-central. a=merge 2018-09-21 00:54:47 +03:00
Byron Campen [:bwc]
93985b16c9 Bug 1486012: Rework ICE restart. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D5897

--HG--
rename : dom/media/tests/mochitest/test_peerConnection_restartIceLocalAndRemoteRollback.html => dom/media/tests/mochitest/test_peerConnection_restartIceLocalAndRemoteRollbackNoSubsequentRestart.html
rename : dom/media/tests/mochitest/test_peerConnection_restartIceLocalRollback.html => dom/media/tests/mochitest/test_peerConnection_restartIceLocalRollbackNoSubsequentRestart.html
extra : moz-landing-system : lando
2018-09-20 16:07:51 +00:00
Byron Campen [:bwc]
9331177d4f Bug 1492248: Remove AAL2 profile stuff from the sipcc parser. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D6296

--HG--
extra : moz-landing-system : lando
2018-09-20 15:06:43 +00:00
Andrew Johnson
0b06a3bc82 Bug 1489757 - Bug 1448863 causes video streams to take a very long time to recover from packet loss; r=bwc
This patch sets mDecoderStatus from the GMPThread so we can eventually report
an error back to the caller. Since this done during an asynchronous call, there
is no guarantee that the error will be associated with the correct frame, but
this workaround should eventually cause an error to be signalled, so that a
PLI can be requested and video will not freeze.

--HG--
extra : rebase_source : 2c32de4218b97ce1a47c5ec118cc864fff786060
2018-09-20 08:23:32 -04:00
Andreas Pehrson
ac369ba83b Bug 1253499 - Break out VideoStreamFactory to separate file. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D6263

--HG--
extra : moz-landing-system : lando
2018-09-19 15:51:46 +00:00
Andreas Pehrson
6f26c10cda Bug 1253499 - Don't lock the conduit's mutex in VideoStreamFactory to avoid deadlocks. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D6152

--HG--
extra : moz-landing-system : lando
2018-09-19 15:01:28 +00:00
Andreas Pehrson
6bb6b7df2d Bug 1253499 - Fix VideoConduit's maxFps gtest. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D6151

--HG--
extra : moz-landing-system : lando
2018-09-19 15:01:03 +00:00
Andreas Pehrson
a47bf6c705 Bug 1253499 - Keep a single video codec config in MockCall. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D6150

--HG--
extra : moz-landing-system : lando
2018-09-19 15:00:57 +00:00
Andreas Pehrson
c09f5af6aa Bug 1253499 - Make RTPSender.setParameters reconfigure the encoder. r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D4134

--HG--
extra : moz-landing-system : lando
2018-09-19 15:00:51 +00:00
Andreas Pehrson
a677f0bd40 Bug 1253499 - Implement a new scaling algorithm for simulcast. r=bwc,dminor
webrtc.org is picky about resolutions for simulcasst layers.
As of current it will assert that all layers have identical aspect ratio.
We handle this by ignoring layers where the aspect ratio is not the same as
the highest layer's.

The new algorithm will, when simulcast is requested and at least one layer
is scaled to something other than 1.0, try to remedy this by:
- The highest resolution layer is cropped to 16-pixel alignment, to ensure
  that scaling options exist.
- A separate VideoAdapter is used for simulcast layers, with the highest
  layer's resolution as an aspect ratio requirement. This forces the
  simulcast adapter to retain that aspect ratio in any scaling decisions.

This doesn't make scaling decisions spec-compliant (floor the width and
height respectively) but it does allow for control of scaling via
setParameters and keeps scaling decisions in upstream code to ensure
good compat with upstream's part of the pipe; encoders, etc.

Differential Revision: https://phabricator.services.mozilla.com/D4133

--HG--
extra : moz-landing-system : lando
2018-09-19 15:00:45 +00:00
Andreas Pehrson
bfcb6bed9f Bug 1253499 - Add gtest for scaling all layers. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D4132

--HG--
extra : moz-landing-system : lando
2018-09-19 15:00:39 +00:00
Andreas Pehrson
05c3bdc366 Bug 1253499 - Update gtests to cover live-updates to codec config and new algorithm. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D4131

--HG--
extra : moz-landing-system : lando
2018-09-19 15:00:33 +00:00
Andreas Pehrson
2e9aea732c Bug 1253499 - Add simulcast scaleDownBy encoding gtest. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D4130

--HG--
extra : moz-landing-system : lando
2018-09-19 15:00:27 +00:00
Andreas Pehrson
952d6a8d56 Bug 1253499 - Add scaleDownBy encoding gtest. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D4129

--HG--
extra : moz-landing-system : lando
2018-09-19 15:00:21 +00:00
Andreas Pehrson
b6fba2b5ad Bug 1253499 - Assert that chrome-only RID methods are succesful. r=bwc
A failure here typically indicates a test error, so it's useful for debugging.

Differential Revision: https://phabricator.services.mozilla.com/D4124

--HG--
extra : moz-landing-system : lando
2018-09-19 14:59:44 +00:00
Andreas Tolfsen
4eb1661657 bug 1490674: rsdparsa: relax log crate dependency version; r=drno
Because all Rust crates in the tree are vendored, using the wildcard
"*" version dependency could have unintended reprecussions on
rsdparsa if another crate changes its log version dependency.

This patch, along with the others associated with this bug, upgrades
the log crate to 0.4.* throughout.  This has the benefit that we
can get rid of the duplicate vendored log crates in third_party/rust.
2018-09-14 12:28:00 +01:00
Nils Ohlmeier [:drno]
3dab079c7c Bug 1479665: add GCM ciphers to SrtpFlow. r=bwc
add GCM ciphers to SrtpFlow

Differential Revision: https://phabricator.services.mozilla.com/D5731

--HG--
extra : moz-landing-system : lando
2018-09-14 03:12:05 +00:00
Andreas Pehrson
36b18d1b4e Bug 1404992 - Recreate the VideoConduit's video adapter when setting the send codec config. r=dminor
This enables us to configure it for cropping to a certain resolution alignment in a future patch.
For instance with simulcast, so we don't have to skip a layer because it is impossible to scale
the highest layer any further without losing the aspect ratio.

--HG--
extra : rebase_source : 4560c60dfa95213b2f3357d0b279c07835402b33
extra : source : e80af22a3bf37ad8fa5762d9a16d677d2befd470
2018-09-11 14:51:39 +02:00
Andreas Pehrson
cddafa728d Bug 1404992 - Don't rely on VideoAdapter in VideoConduit unittests. r=dminor
--HG--
extra : rebase_source : 267a182c709ff1777b02d455f2a6f3309260c397
extra : source : db576775e6fcb18ab3546550a60e57482c91f68d
2018-09-11 14:51:37 +02:00
Andreas Pehrson
d226723e37 Bug 1404992 - Audit, document, assert and fix threading policy of VideoConduit. r=dminor, r=bwc
--HG--
extra : rebase_source : 281771b96a3f0c2a95d6a7c7ccf0556c1a869001
extra : source : 7d1e74f3e80158dbb71adc5d1c036941e7ab8da9
2018-09-11 14:51:32 +02:00
Andreas Pehrson
2e19da61da Bug 1404992 - Make VideoConduit scaling use a buffer pool. r=dminor
--HG--
extra : rebase_source : 52d5e5b6519a32119bca44ff685782ad244552d6
extra : source : b3f5796ab356f19763759d4eeb21df1b443de33f
2018-09-11 14:51:29 +02:00
Andreas Pehrson
c30f9f1367 Bug 1404992 - Refactor incoming frames' scaling path. r=dminor
--HG--
extra : rebase_source : 3282c6d8a20d4fd7450e99c03bde821aff06b66e
extra : source : 823952d81821d65a6a8c3a0031e532fc3dffb825
2018-09-11 14:51:26 +02:00
Andreas Pehrson
8865bbcbfe Bug 1404992 - Initialize VideoConduit members in declarations. r=dminor
--HG--
extra : rebase_source : e552430cc47444800c06d445b2e49941c488057c
extra : source : 7a06d3a9341ada35c1336f5bdf899c3817baff61
2018-09-11 14:51:24 +02:00
Andreas Pehrson
793fde35a0 Bug 1404992 - Reduce bitrate selection paths. r=dminor
--HG--
extra : rebase_source : bd1202ed1389d10c4c3162ab01e168007e535872
extra : source : a45420fb1dd0cc7971b7fe6e170bfd88c96db6d2
2018-09-11 14:51:21 +02:00
Andreas Pehrson
16fdd518b3 Bug 1404992 - Use common code to convert images to I420. r=dminor
--HG--
extra : rebase_source : 7cb2c551870e06f4929da3366a523eaff9b86b2c
extra : source : f37bd9a9f4af84a6068d0b030427dab47bed7eb8
2018-09-11 14:51:16 +02:00
Andreas Pehrson
4525ecf9db Bug 1404992 - Remove unused/unnecessary code and do some cleanup. r=dminor
--HG--
extra : rebase_source : 75c9dd16a4a98d7c7e35e2fb350bb2744401e63b
extra : source : ee698a8bb92c2570b91ac65a2c8fe9fb7f680b71
2018-09-11 14:51:13 +02:00
Nils Ohlmeier [:drno]
e88a043618 Bug 1480869: define SRTP ciphers suites inside mtransport r=mt
define SRTP cipher suites inside mtransport

Differential Revision: https://phabricator.services.mozilla.com/D5490

--HG--
extra : moz-landing-system : lando
2018-09-11 03:58:34 +00:00
Dan Minor
51b2f38d60 Bug 1486817 - Use separate log modules for mediapipeline and rtplogger; r=bwc
This restores the separate mediapipeline and RtpLogger lazy log modules that
were unified with the Signaling log module in Bug 1402334.

Differential Revision: https://phabricator.services.mozilla.com/D4478

--HG--
extra : moz-landing-system : lando
2018-08-29 17:10:17 +00:00
Byron Campen [:bwc]
2a2903b7fe Bug 1483338: Stop using level as the identifier for media transports. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D3448

--HG--
extra : moz-landing-system : lando
2018-08-28 19:45:58 +00:00