Commit Graph

103 Commits

Author SHA1 Message Date
Marcos Cáceres
69d2abd930 Bug 1540695 - Omit credentials when fetching web manifest r=baku
Credentials should be excluded when requesting a web manifest.

Differential Revision: https://phabricator.services.mozilla.com/D29607

--HG--
extra : moz-landing-system : lando
2019-08-06 15:33:02 +00:00
Edwin Gao
b270bb1353 Bug 1561046 - remove API 17 from manifest files r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D39809

--HG--
extra : moz-landing-system : lando
2019-08-02 20:10:06 +00:00
André Bargull
1fe1b5271f Bug 1522070 - Part 18: Update 'lang' member test for Web manifest to match latest ECMA-402. r=marcosc
ECMA-402 changed the language tag specification from RFC-5646 BCP-47 language
tags to UTS 35 Unicode BCP-47 locale identifiers. Update the expected
canonicalisation results accordingly.

Depends on D37450

Differential Revision: https://phabricator.services.mozilla.com/D38642

--HG--
extra : moz-landing-system : lando
2019-07-19 13:37:47 +00:00
Marcos Cáceres
4d6c019baa Bug 1566018 - Return the URL of the manifest from manifest validation in object r=Ola,baku
returns a moz_manifest_url member when `{checkConformance: true}`

Differential Revision: https://phabricator.services.mozilla.com/D38311

--HG--
extra : moz-landing-system : lando
2019-07-17 14:04:19 +00:00
Marcos Cáceres
1118e89526 Bug 1563460 - Collect console messages generated by processing manifest for Dev Tools r=baku
This gets rid  of the sending warnings to the browser console. Instead, when the processor is explicitly asked to do so, it now collects spec violations into a `moz_validation` member.

To access the new manifest member, you can now pass a second argument to `ManifestObtainer.contentObtainManifest()` like so:

```
const manifest = await ManifestObtainer.contentObtainManifest(
      this.targetActor.window,
      { checkConformance: true }
);
manifest. moz_validation; // 🎉
```

Differential Revision: https://phabricator.services.mozilla.com/D36885

--HG--
extra : moz-landing-system : lando
2019-07-09 02:33:39 +00:00
Victor Porof
0a8ff0ad85 Bug 1561435 - Format dom/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35951

--HG--
extra : source : 62f3501af4bc1c0bd1ee1977a28aee04706a6663
2019-07-05 10:44:55 +02:00
Boris Zbarsky
9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Brian Grinstead
0d460e3432 Bug 1544322 - Part 2.2 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in dom/ r=bzbarsky
This is split from the previous changeset since if we include dom/ the file size is too
large for phabricator to handle.

This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 2` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27457

--HG--
extra : moz-landing-system : lando
2019-04-16 03:53:28 +00:00
Marcos Cáceres
6a3953940b Bug 1534756 - Don't throw exception in ManifestObtainer if a document has no manifest r=snorp
We now return null when the manifest lacks a href or is missing.

Differential Revision: https://phabricator.services.mozilla.com/D26873

--HG--
extra : moz-landing-system : lando
2019-04-10 12:46:41 +00:00
Marcos Cáceres
f78caebcd5 Bug 1534677 - Verify lang member in ManifestProcessor.jsm r=snorp
Implement language tag validation and canonicalization for lang member

Differential Revision: https://phabricator.services.mozilla.com/D25713

--HG--
extra : moz-landing-system : lando
2019-04-11 01:35:21 +00:00
Brindusan Cristian
369ab2687e Backed out changeset ea2baf2c9ae7 (bug 1534756) for mochitest failures at test_ManifestProcessor_JSON.html. 2019-04-10 05:29:46 +03:00
Marcos Cáceres
585f841266 Bug 1534756 - Don't throw exception in ManifestObtainer if a document has no manifest r=snorp
We now return null when the manifest lacks a href or is missing.

Differential Revision: https://phabricator.services.mozilla.com/D26448

--HG--
extra : moz-landing-system : lando
2019-04-09 20:32:54 +00:00
Cosmin Sabou
e4a2cb3ab3 Backed out changeset c0394b2d9173 (bug 1534677) for m-e10s failures on test_ManifestProcessor_lang.html CLOSED TREE 2019-04-09 08:54:41 +03:00
Marcos Cáceres
e64738e122 Bug 1534677 - Verify lang member in ManifestProcessor.jsm r=snorp
Implement language tag validation and canonicalization for lang member

Differential Revision: https://phabricator.services.mozilla.com/D25713

--HG--
extra : moz-landing-system : lando
2019-04-08 17:08:51 +00:00
James Willcox
cf8b03cc76 Bug 1522451 - Resolve named CSS colors to RGB in Web Manifests r=marcosc
Differential Revision: https://phabricator.services.mozilla.com/D23025

--HG--
extra : moz-landing-system : lando
2019-03-20 14:44:29 +00:00
Sebastian Hengst
cee711baf9 Bug 1535353 - update Core :: DOM: * bugzilla product and component meta data in moz.build files after reorganization in bug 1533440 r=hsinyi
Differential Revision: https://phabricator.services.mozilla.com/D23546

--HG--
extra : moz-landing-system : lando
2019-03-17 23:13:22 +00:00
Andreea Pavel
d6a864b0c0 Backed out 4 changesets (bug 1533840, bug 1522451) for failing dom/manifest/test/test_ManifestProcessor_background_color.html on a CLOSED TREE
Backed out changeset 4fd7ce83efe1 (bug 1533840)
Backed out changeset 5a892aa56e37 (bug 1522451)
Backed out changeset 2ddf151f9535 (bug 1522451)
Backed out changeset 49ebb69e8893 (bug 1522451)
2019-03-14 23:02:15 +02:00
James Willcox
be6df29c13 Bug 1522451 - Resolve named CSS colors to RGB in Web Manifests r=marcosc
Differential Revision: https://phabricator.services.mozilla.com/D23025

--HG--
extra : moz-landing-system : lando
2019-03-14 16:46:38 +00:00
Dorel Luca
2d22ab9308 Backed out 3 changesets (bug 1522451) for eslint failure
Backed out changeset bd7007ecd0db (bug 1522451)
Backed out changeset d291cd16ef76 (bug 1522451)
Backed out changeset 6fbcde5da1c1 (bug 1522451)
2019-03-14 18:07:15 +02:00
James Willcox
b15047799a Bug 1522451 - Resolve named CSS colors to RGB in Web Manifests r=marcosc
Differential Revision: https://phabricator.services.mozilla.com/D23025

--HG--
extra : moz-landing-system : lando
2019-03-14 15:43:52 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Julia
7e1563241b Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes) r=Standard8,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D13208

--HG--
extra : moz-landing-system : lando
2018-12-18 20:39:42 +00:00
Julia
d252be35ef Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes) r=Standard8,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D13207

--HG--
extra : moz-landing-system : lando
2018-12-18 20:38:43 +00:00
Mark Banner
b1c872942c Bug 1508980 - Add more .eslintrc.js files for dom/ and update .eslintignore. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D12529

--HG--
extra : moz-landing-system : lando
2018-11-21 14:27:27 +00:00
Julian Descottes
73e3a16c0d Bug 1499096 - Use ok() with 2 arguments instead of 3 when possible;r=Standard8
Depends on D8740.
This changeset replaces calls to ok with 3 arguments to calls with 2 arguments
in situations where the switch does not have a significant impact on the assert.

Differential Revision: https://phabricator.services.mozilla.com/D8741

--HG--
extra : moz-landing-system : lando
2018-10-23 07:13:35 +00:00
Joel Maher
50b91c0a14 Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Kris Maglione
7b7264f453 Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8
MozReview-Commit-ID: 9APGewiDDYB

--HG--
extra : rebase_source : 2931dd0eec0e4206414b698a9700fc20d922eb3a
2018-05-25 17:02:29 -07:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Cameron McCormack
0ef012043a Bug 1427419 - Part 13: Move inIDOMUtils.isValidCSSColor to InspectorUtils. r=bz
MozReview-Commit-ID: DNRfmbDucdT
2018-01-11 12:38:00 +08:00
Jan de Mooij
296194e65f Bug 1414340 part 1 - Remove non-standard array/generator comprehensions from browser code. r=mossop 2017-11-10 11:52:22 +01:00
Dylan Roeh
8979799047 Bug 1412301 - Decrease save delay to ensure PWA manifests are actually written to disk before a user tries to run one. r=snorp 2017-11-01 10:17:36 -05:00
Nevin Chen
07f054650f Bug 1409191 - Prefetch manifest before install. r=snorp
This is a "hacked" fix. The key idea is to specify the value in manifest on "add to home screen confirm prompt."
We need to reuse prefetch result for  manifest.install().

The plan is to land this patch before Chrome Dev Summit(10/30) for demostration and fix the rest of the issue in a follow up bug.

MozReview-Commit-ID: A4B0ZK7UjyK

--HG--
extra : rebase_source : a91a490a08cb4ec18e5ff9f2e78f11efa6fdd98b
2017-10-19 00:59:58 +08:00
Nevin Chen
a5d75c2143 Bug 1368024 - Fall back to 'name' when 'short_name' is missing. r=daleharvey
MozReview-Commit-ID: 84jFO85dgI9

--HG--
extra : rebase_source : 4155ba96e1556f6056bd4a226094121f2757f28d
2017-10-05 15:20:04 +08:00
Andrew Halberstadt
57887f2601 Bug 1328830 - [manifestparser] Check line continuation before looking for next key, r=jmaher
Currently manifestparser will only look for line continuations *after* looking for a key. This means
that line continuations cannot contain key separators. For example, this:

    [test]
    foo=
      bar=baz

gets treated as:

    {'name': 'test', 'foo': '', 'bar': 'baz'}

Here, bar=baz will be treated as a new key/value pair despite the indentation. This patch switches
the order around, so we look for a continuation first. Now, it is only treated as a continuation if
the indent is greater than the indent of the preceding key.

So this manifest:

    [test]
    foo=bar
      baz=fleem

is a continuation and results in:

    {'name': 'test', 'foo': 'bar\nbaz=fleem'}

But this manifest:

    [test]
      foo=bar
      baz=fleem

is not a continuation, and yields:

    {'name': 'test', 'foo': 'bar', 'baz': 'fleem'}

MozReview-Commit-ID: FAMP5TUIo9q

--HG--
extra : rebase_source : 624c53cfe0565374c1224dd86a3fffc8831279d3
2017-07-19 14:48:01 -04:00
Masatoshi Kimura
8b713b2b0f Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

MozReview-Commit-ID: 4ecl3RZhOwC

--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
2017-08-04 17:49:22 +09:00
Florian Quèze
fb91723a8a Bug 1374282 - hand cleanup for the script generated patch to remove Task.jsm calls, r=Mossop. 2017-06-22 12:51:42 +02:00
Florian Quèze
66f6d259bc Bug 1374282 - script generated patch to remove Task.jsm calls, r=Mossop. 2017-06-22 12:51:42 +02:00
Christoph Kerschbaumer
e4f38c8d7c Bug 1362993 - Rewrite gBrowser.addTab() to use BrowserTestUtils.addTab(). r=florian 2017-05-15 21:49:50 +02:00
Florian Queze
4b1556a5f2 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Dale Harvey
3c0cff3807 Bug 1347154 - Set correct csp for icon fetching. r=marcosc 2017-03-17 10:55:59 +00:00
Dale Harvey
6895048221 Bug 1336355 - Open webapps in new activity. r=sebastian 2017-03-15 15:39:01 +00:00
Joel Maher
f297f17181 Bug 1339232 - annotate more dom/* moz.build files with BUG_COMPONENT. r=overholt
MozReview-Commit-ID: 2HbPxGkrVfv
2017-03-01 08:20:25 -05:00
Dale Harvey
8ad9541ad3 Bug 1321320 - Track installed manifests. r=marcos, r=s.kaspari 2017-02-17 08:24:06 +00:00