Commit Graph

734100 Commits

Author SHA1 Message Date
Ting-Yu Lin
e8798a3e43 Bug 1675852 Part 3 - Use fallback 300px width and 150px height in ComputeSizeWithIntrinsicDimensions(). r=emilio
Per spec https://drafts.csswg.org/css-sizing-3/#intrinsic-contribution,
for the replaced elements with no intrinsic size and no preferred aspect
ratio, the fallback size is '300px' for the width and '150px' for the
height, regardless of the writing-mode value.

Without this patch, Firefox fails the last two subtests when the svg
image has the vertical writing-mode with no intrinsic size and no aspect
ratio. Both Chrome and Safari render all the subtests as 300x150.

This patch fixed the last two subtests.

Differential Revision: https://phabricator.services.mozilla.com/D96259
2020-11-09 19:11:05 +00:00
Ting-Yu Lin
1ab07e787f Bug 1675852 Part 2 - Define extra fallback intrinsic sizes in app units. r=emilio
CSSPixel::ToAppUnits() requires computation at runtime. Since most of
the layout computations require `nscoord`, this patch defines extra
intrinsic sizes in app units.

Differential Revision: https://phabricator.services.mozilla.com/D96258
2020-11-09 20:31:57 +00:00
Ting-Yu Lin
b371960b3f Bug 1675852 Part 1 - Mark more methods 'constexpr' in BaseCoord and nsSize. r=emilio
This is a preparation of the next part.

Technically, we only need the nsSize's two-argument constructor and
BaseCoord's operator* to be 'constexpr', but for the sake of
completeness, I also make all other BaseCoord's methods 'constexpr'.

Differential Revision: https://phabricator.services.mozilla.com/D96257
2020-11-06 22:22:02 +00:00
Andrei Oprea
f6d99002c8 Bug 1676241 - Fix usage of ExperimentAPI in TelemetryFeed r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D96460
2020-11-09 20:15:25 +00:00
Alexis Beingessner
297ab08c2d Bug 1674773 - Use the dummy-load-as-a-fence trick for refptr.rs. r=nika
This also introduces a thread_sanitizer feature to gkrust for any other
crates that need similar special handling. (`cfg(sanitizer="thread")` is
unfortunately an unstable feature, so it isn't useful here.)

Differential Revision: https://phabricator.services.mozilla.com/D95950
2020-11-09 20:14:44 +00:00
Alexis Beingessner
2e16b14340 Bug 1674773 - make tsan builds use consistent flags. r=rstewart
This makes --enable-thread-sanitizer turn on Rust tsan (-Zsanitizer=thread).
This requires changing SpiderMonkey tsan to use the tsan rust nightly.

In future changes, more Rust tsan integration will key off of MOZ_TSAN.

Differential Revision: https://phabricator.services.mozilla.com/D96453
2020-11-09 20:12:42 +00:00
Andrew Creskey
9506358b74 Bug 1674779 - Improve documentation of GV_PAGE_LOAD_MS (describe back navigation and bimodality) r=Dexter
Add notes to metrics.yaml and Histograms.json to describe a source of bimodality in this probe.

Differential Revision: https://phabricator.services.mozilla.com/D95534
2020-11-09 19:59:51 +00:00
Bryce Seager van Dyk
5344478e40 Bug 1673007 - Add profiler markers for events that may lead to decoder recreation. r=alwu
This patch adds profiler markers to surface when
- The MediaFormatReader detects a change in stream id.
- The MediaChangeMonitor classes for h264 and/or vpx detect a stream change.

These scenarios typically take place before a decoder is recreated.

Because recreating a decoder is a non-trivial process that can fail and/or
result in performance issues, having these markers helps us relate such issues
to decoder recreation in profiles.

Differential Revision: https://phabricator.services.mozilla.com/D94621
2020-11-09 19:39:41 +00:00
Bryce Seager van Dyk
08c43b7bd5 Bug 1673007 - Add markers and logs for when we Init the WMFDecoderModule. r=alwu
We aggressively log and mark here to help diagnose hard to nail down problems
with hardware decoding.

Differential Revision: https://phabricator.services.mozilla.com/D94619
2020-11-09 19:39:31 +00:00
Bryce Seager van Dyk
9c270df9c9 Bug 1673007 - Undef WMFAudioMFTManager's LOG macro at end of file. r=alwu
This stops the log leaking into other files during the unified build this is
desirable to avoid
- Other files relying on this log macro and then breaking when unified build
  boundaries shift.
- Other files getting this LOG definition unexpectedly and logging incorrectly
  and/or emitting warnings due to macro redefinitions.

Differential Revision: https://phabricator.services.mozilla.com/D94743
2020-11-09 19:39:29 +00:00
Byron Campen [:bwc]
c6ea9724b4 Bug 1672590: Move strict jitter sanity check into a separate test, and disable that test on TSan. r=ng
Differential Revision: https://phabricator.services.mozilla.com/D95205
2020-11-09 19:35:08 +00:00
Harry Twyford
57181de5e9 Bug 1675976 - Stop recording bogus data for some urlbar.picked.searchmode.* probes. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D96321
2020-11-09 19:18:51 +00:00
Ted Campbell
a6a4b075c9 Bug 1676219 - Remove unused FunctionBox::isTopLevel_ field. r=arai
This field is equivalent to checking that FunctionBox::index() matched
CompilationInfo::TopLevelIndex.

Depends on D96445

Differential Revision: https://phabricator.services.mozilla.com/D96446
2020-11-09 18:16:35 +00:00
Ted Campbell
c3bf395bb9 Bug 1676219 - Remove unused FunctionBox::traceLink field. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D96445
2020-11-09 18:16:25 +00:00
Brindusan Cristian
ca85f574a0 Backed out changeset 3a087ad91d30 (bug 1626555) for build bustages. CLOSED TREE 2020-11-09 21:09:33 +02:00
Markus Stange
cb3b5afd46 Bug 1675887 - Respect the time value that's passed to Choreographer.FrameCallback.doFrame. r=kats
This makes the vsync times more consistent.
On a Pixel 2 running Android 11, the callback was called between 1ms and 6ms
after the vsync timestamp in my tests. Having the vsync timestamp slightly in
the past is what the rest of our vsync infrastructure expects.

Differential Revision: https://phabricator.services.mozilla.com/D96279
2020-11-09 18:32:13 +00:00
Chris H-C
7ddc009e5e Bug 1674233 - Report the Telemetry client_id in FOG fog-validation pings r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D96315
2020-11-09 18:01:47 +00:00
Chris Jackson
04b688c697 Bug 1672401 - Picture-in-Picture description is displayed incorrectly on whereby.com. r=mconley,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95166
2020-11-09 17:10:28 +00:00
Harry Twyford
9f2041a14b Bug 1675627 - Do not show alias engines in search mode. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D96256
2020-11-09 17:59:35 +00:00
Andi-Bogdan Postelnicu
6ffdaf663d Bug 1626555 - Add dom/security to the list of non-unified-build-compatible directories. r=sg
Differential Revision: https://phabricator.services.mozilla.com/D96427
2020-11-09 17:57:01 +00:00
Mitchell Hentges
d73b2e2be9 Bug 1670197: "Universal" python binaries shouldn't cause setup.py fails r=firefox-build-system-reviewers,rstewart
"distutils" builds packages to fit the architectures of the active
python.
However, the system Mac SDK doesn't always support all the same
architectures as the local Python binary.
To resolve this, we explicitly influence the build to only compile for
the specific architecture that the system runs on.

Assumes that "platform.machine()" will always line up with the "-arch"
flag of compilers.

Differential Revision: https://phabricator.services.mozilla.com/D96276
2020-11-09 18:00:58 +00:00
alwu
7a92a1e5ef Bug 1675326 - part5 : move webvtt related crashtest to dom/media/webvtt/test/crashtests. r=bryce
Depends on D96106

Differential Revision: https://phabricator.services.mozilla.com/D96107
2020-11-09 15:47:30 +00:00
alwu
ff629c2074 Bug 1675326 - part4 : move webvtt related reftest to dom/media/webvtt/test/reftest. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D96106
2020-11-09 15:47:14 +00:00
alwu
2cbf7b3920 Bug 1675326 - part3 : move webvtt related plain mochitests to dom/media/webvtt/test/mochitest. r=bryce
Depends on D96104

Differential Revision: https://phabricator.services.mozilla.com/D96105
2020-11-09 15:47:12 +00:00
alwu
9594ca92fc Bug 1675326 - part2 : move webvtt related xpcshell test to dom/media/webvtt/test/xpcshell r=bryce
Depends on D96103

Differential Revision: https://phabricator.services.mozilla.com/D96104
2020-11-09 15:47:10 +00:00
alwu
9d84da2096 Bug 1675326 - part1 : move webvtt related files into dom/media/webvtt. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D96103
2020-11-09 15:47:07 +00:00
Eitan Isaacson
e8112d4ccd Bug 1672694 - P2: Don't fire AXSelectedTextChanged if target is not selectable. r=morgan
This causes VoiceOver to mess with `AXFocused` and as a result redirect the VO cursor.

Differential Revision: https://phabricator.services.mozilla.com/D95784
2020-11-09 17:55:20 +00:00
Geoff Brown
8a52920aa9 Bug 1638947 - Run 'mach android' with python 3; r=nalexander
Switch 'mach android' to python 3. As far as I can tell, this just works.

Differential Revision: https://phabricator.services.mozilla.com/D96275
2020-11-09 17:54:33 +00:00
Aaron Klotz
54f06947cd Bug 1654817: Part 2 - Bump dom.ipc.processCount pref to 3 on Nightly; r=geckoview-reviewers,agi
I want to start with 3 so that we initially get a good look at how things run
with multiple processes, but when we easily hit the limit. We'll increase to
our final process count in a future bug.

Differential Revision: https://phabricator.services.mozilla.com/D94884
2020-11-04 17:26:16 +00:00
Aaron Klotz
773de4f33a Bug 1654817: Part 1 - Convert e10s-multi transform to an e10s-single transform; r=taskgraph-reviewers,jmaher
Since e10s-multi is going to be enabled by default, this gives us the ability
to run junit in a secondary, e10s-single configuration so that we can see them
both side-by-side for a little while, at least until we're settled in with the
e10s-multi configuration.

Differential Revision: https://phabricator.services.mozilla.com/D94883
2020-11-04 17:26:14 +00:00
Mike Conley
c7295a552a Bug 1673716 - Try to make sure the about:home startup cache worker construction Promise always resolves. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D96269
2020-11-09 17:14:58 +00:00
Csoregi Natalia
ae9d59c708 Backed out 2 changesets (bug 1675543) for marionette failures on test_refresh_firefox.py. CLOSED TREE
Backed out changeset d7af96ca92b4 (bug 1675543)
Backed out changeset d98cf0c9d34e (bug 1675543)
2020-11-09 19:50:09 +02:00
Csoregi Natalia
66c2c6c5d5 Backed out changeset ca520bfdc084 (bug 1674515) for failures on browser_autoshow_bookmarks_toolbar.js. CLOSED TREE 2020-11-09 19:32:08 +02:00
Eitan Isaacson
03f2c847ea Bug 1674273 - Consider a hyperlink with no hypertext parent as a root. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D95817
2020-11-09 17:06:44 +00:00
Dão Gottwald
1a9cbfb983 Bug 1676169 - Completely disallow dropping on sponsored tiles. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D96433
2020-11-09 16:26:30 +00:00
Andi-Bogdan Postelnicu
6c639eb537 Bug 1626555 - Add dom/script to the list of non-unified-build-compatible directories. r=sg
Differential Revision: https://phabricator.services.mozilla.com/D96401
2020-11-09 16:50:39 +00:00
Andi-Bogdan Postelnicu
04b093b6a4 Bug 1626555 - Add dom/res to the list of non-unified-build-compatible directories. r=sg
Depends on D96398

Differential Revision: https://phabricator.services.mozilla.com/D96399
2020-11-09 12:24:01 +00:00
Andi-Bogdan Postelnicu
eddf5c3167 Bug 1626555 - Add dom/reporting to the list of non-unified-build-compatible directories. r=sg
Differential Revision: https://phabricator.services.mozilla.com/D96398
2020-11-09 12:14:27 +00:00
Edgar Chen
8c4c21dae9 Bug 1676127 - Don't deactivate top-level remote browser twice when browser window is lowered; r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D96404
2020-11-09 14:57:54 +00:00
Erica Wright
097ee80074 Bug 1672476 - Add a pref to permanently show the firefox logo on the newtab page. r=prathiksha,thecount
This is preffed off for now.

Differential Revision: https://phabricator.services.mozilla.com/D94385
2020-11-06 18:36:24 +00:00
Yura Zenevich
21c81dd7e6 Bug 1675539 - add telemetry for tabbing order overlay activation. r=jdescottes,janerik
Differential Revision: https://phabricator.services.mozilla.com/D96091
2020-11-09 16:19:20 +00:00
Gijs Kruitbosch
8cb1e9b0d4 Bug 1674515 - show the bookmarks toolbar when creating a bookmark there, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96329
2020-11-09 16:00:29 +00:00
Gijs Kruitbosch
5180644f12 Bug 1675775 - fix browser_default_bookmark_location.js for beta, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96429
2020-11-09 16:01:50 +00:00
prathiksha
4c73832b4a Bug 1669150 - Add test to prevent regression of a race condition in logins backup deletion code that's preventing the login backup from getting deleted. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D96089
2020-11-09 13:22:42 +00:00
Andrew Osmond
512e2df326 Bug 1675766 - Ship WebRender on Linux/GNOME/X11 to release. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D96185
2020-11-09 14:48:21 +00:00
Andreas Pehrson
d9c5753c12 Bug 1581139 - Fire InvalidModificationError on MediaRecorder track set changes. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D95694
2020-11-05 19:57:19 +00:00
Mirko Brodesser
48b4cf3c06 Bug 1676157: fix error message in "select-all-and-delete-in-html-element-having-contenteditable.html". r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D96424
2020-11-09 15:01:17 +00:00
Jeff Muizelaar
72068a66b2 Bug 1675906 - Add more crashes when we don't find a Factory. r=jfkthame
Unlikely, but we might as well keep narrowing this down.

Differential Revision: https://phabricator.services.mozilla.com/D96303
2020-11-09 11:57:30 +00:00
Gregory Mierzwinski
137a7a6aa8 Bug 1675806 - Fix perfdocs unittest on Windows. r=perftest-reviewers,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D96425
2020-11-09 15:15:27 +00:00
Nihanth Subramanya
8982a96b46 Bug 1672986 - Set the right cookie behavior before state partitioning MVP UI test. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95526
2020-11-09 14:00:05 +00:00