Fabien Cazenave
c5be62f04a
Bug 290026 - Outdent of List does not work properly; r=ehsan
2011-09-02 12:21:33 -04:00
Fabien Cazenave
944a5d2ef2
Bug 291780 - List outdent is not working properly; r=ehsan
2011-09-02 12:19:09 -04:00
Ehsan Akhgari
b68262a622
Keep changeset 9ef862cbcc5e backed out on the reverted tree
2011-09-02 09:03:38 -04:00
Ehsan Akhgari
44916171a8
Revert to changeset e6fc4594c22e which was the last one to get a green Win7 tp run
2011-09-02 09:03:08 -04:00
Ehsan Akhgari
704a16280b
Backout changeset 9ef862cbcc5e (bug 682564) because of mochitest-oth oranges
2011-09-01 21:00:05 -04:00
arno renevier
9f50a8dae9
Bug 682564 - Prefer user set dictionary over other dictionaries when it matches spellcheck langcode; r=ehsan
2011-09-01 22:14:02 +01:00
Marco Castelluccio
a1151d128d
Bug 682744 - Sprinkle some do_QueryObject fairy dust around the tree; r=khuey
2011-08-30 22:45:31 +01:00
Ms2ger
0b1536d069
Bug 672054 - Part a: Remove nsIDOMNSUIEvent; r=smaug
2011-08-26 09:43:49 +02:00
Fabien Cazenave
e9ca41c695
Bug 677752 - [contentEditable] indent and justify* fail on editable nodes that have only one child; r=ehsan
...
Issue #1 : indent/justify* can create non-valid fragments.
When applying a block-level formatting to a text node, Gecko creates a div or
blockquote block around the text node and sets the corresponding "align" or
"style" attribute. This patch checks that the active editing host can contain
such a block-level element.
Issue #2 : indent/justify* can modify the active editing host.
On the first child of the editable element, the selection is extended outside of
the active editing host -- which causes a few issues for our test cases.
In this patch, this issue is "solved" by modifying
`nsHTMLEditRules::GetPromotedPoint' for block-level operations.
** About the tests **
Sorry for the long explanation but I prefer to be as sharp as possible when I
have to modify existing unit tests.
This patch raises 34 unit test "failures" which are improvements.
Two test files are concerned and have been modified accordingly:
* test_htmleditor_keyevent_handling
* test_richtext2.html
One test has been clarified (no real modification):
* test_bug414526.html
Of course, a specific unit test has been added, see `test_bug677752.html'.
** editor/libeditor/html/tests/test_htmleditor_keyevent_handling.html **
Outdenting now works properly, which results in 4 `FAIL'.
* 7372 ERROR TEST-UNEXPECTED-FAIL
| non-tabbable HTML editor: Shift+Tab after Tab on UL
- got "<ul><li id=\"target\">ul list item</li></ul>",
expected "<ul><ul><li id=\"target\">ul list item</li></ul></ul>"
* 7379 ERROR TEST-UNEXPECTED-FAIL
| non-tabbable HTML editor: Shift+Tab on UL
- got "ul list item",
expected "<ul><li id=\"target\">ul list item</li></ul>"
* 7415 ERROR TEST-UNEXPECTED-FAIL
| non-tabbable HTML editor: Shift+Tab after Tab on OL -
got "<ol><li id=\"target\">ol list item</li></ol>",
expected "<ol><ol><li id=\"target\">ol list item</li></ol></ol>"
* 7422 ERROR TEST-UNEXPECTED-FAIL
| non-tabbable HTML editor: Shfit+Tab on OL
- got "ol list item",
expected "<ol><li id=\"target\">ol list item</li></ol>"
** editor/libeditor/html/tests/browserscope/test_richtext2.html **
The 15 tests that now pass result in 15 `FAIL' and 15 `UNEXPECTED_PASS'.
Here's an overview of what we had before the patch:
* Section A - Apply Formatting Tests: +10 points
before patch: 21/31 (Selection: 9/31)
after patch: 28/31 (Selection: 12/31)
FB:BQ_TEXT-1_SI EXECUTION EXCEPTION
FB:BQ_TEXT-1_SI EXECUTION EXCEPTION
FB:BQ_BR.BR-1_SM EXECUTION EXCEPTION
FB:BQ_BR.BR-1_SM EXECUTION EXCEPTION
IND_TEXT-1_SI EXECUTION EXCEPTION
IND_TEXT-1_SI EXECUTION EXCEPTION
JC_TEXT-1_SC editing host is modified
JF_TEXT-1_SC editing host is modified
JL_TEXT-1_SC editing host is modified
JR_TEXT-1_SC editing host is modified
* Section AC - Apply Formatting Tests, using styleWithCSS: +5 points
before patch: 7/18 (Selection: 5/18)
after patch: 12/18 (Selection: 5/18)
IND_TEXT-1_SI editing host is modified
JC_TEXT-1_SC editing host is modified
JF_TEXT-1_SC editing host is modified
JL_TEXT-1_SC editing host is modified
JR_TEXT-1_SC editing host is modified
** editor/libeditor/html/tests/test_bug414526.html **
This test has been clarified to get more explicit report messages -- the test
themselves haven't been changed. A `todo_is' test has been added.
This test is the one that shows that `IsNodeInActiveEditor' can't be modified,
and that limiting the range promotion for block-level operations is preferrable.
2011-08-23 15:10:14 -04:00
arno renevier
e6a982f07d
bug 678842: remember spell check setting per site; r=ehsan
2011-08-23 15:03:33 -04:00
Fabien Cazenave
51ba25e02c
Bug 680279 - Splitting Gmail rich-text list with Enter misplaces the caret; r=ehsan
...
The patch for bug 674861 has introduced a regression.
When a list is splitted, a new paragraph should inserted before the new list.
2011-08-19 18:14:04 -04:00
Ehsan Akhgari
eb0c0c8650
Backout changeset 46dc0fb0b1cb (bug 674770) because of yet another mochitest-3 Windows failure
...
--HG--
extra : rebase_source : a0739cd5d2eb66015d785c107151507f8a8113e3
2011-08-18 16:25:11 -04:00
Fabien Cazenave
8a7028d704
Bug 680060 - [queryCommandEnabled] check `GetIsSelectionEditable' results; r=ehsan
2011-08-18 11:34:52 -04:00
Ehsan Akhgari
84774ab4ac
Bug 674770 - contenteditable breaks middle-click to open links when middlemouse.paste=true; r=roc
2011-07-28 17:42:38 -04:00
Jonas Sicking
e50dc8cb66
Bug 667612: Make addEventListener not throw if passed a null listener. r=smaug
2011-08-18 02:45:00 -07:00
Fabien Cazenave
730fe59635
Bug 674212 - Modifying text of a contenteditable DOM Node removes spellcheck underlinings; r=ehsan
2011-08-17 17:12:46 -04:00
Ehsan Akhgari
3bf0c576f1
Bug 318065 followup - Remove the extra finish call from the test
...
DONTBUILD
2011-08-17 16:40:31 -04:00
Fabien Cazenave
e14db8b0a8
Bug 676401 - The document.queryCommandEnabled API doesn't take the active editing host into account; r=ehsan
...
* adding an `isSelectionEditable' readonly attribute in <nsIEditor>;
* modified all ::IsCommandEnabled methods in editor/ to take it into account:
./libeditor/base/nsEditorCommands.cpp (15 commands)
nsUndoCommand 'undo'
nsRedoCommand 'redo'
nsClearUndoCommand 'clearUndo'
nsCutCommand 'cut'
nsCutOrDeleteCommand ?
nsCopyCommand 'copy'
nsCopyOrDeleteCommand ?
nsPasteCommand 'paste'
nsPasteTransferableCommand ?
nsSwitchTextDirectionCommand ?
nsDeleteCommand 'delete'
nsSelectAllCommand 'selectAll'
nsSelectionMoveCommands ?
nsInsertPlaintextCommand ?
nsPasteQuotationCommand ?
./composer/src/nsComposerCommands.cpp (15 commands)
nsBaseStateUpdatingCommand ?
nsPasteNoFormattingCommand ?
nsRemoveListCommand ?
nsIndentCommand 'indent'
nsOutdentCommand 'outdent'
nsMultiStateCommand ?
nsHighlightColorStateCommand 'hiliteColor'
nsAbsolutePositioningCommand ?
nsDecreaseZIndexCommand ?
nsIncreaseZIndexCommand ?
nsRemoveStylesCommand 'removeFormat'
nsIncreaseFontSizeCommand 'increaseFontSize'
nsDecreaseFontSizeCommand 'decreaseFontSize'
nsInsertHTMLCommand 'insertHTML'
nsInsertTagCommand ?
./composer/src/nsComposerDocumentCommands.cpp (3 commands)
nsSetDocumentOptionsCommand ?
nsSetDocumentStateCommand ?
nsDocumentStateCommand n/a (unpatched)
2011-08-17 13:28:03 -04:00
Graeme McCutcheon
f9b46f6f4f
Bug 318065 - Don't notify editor observers until bogus node state is reset. r=ehsan
2011-08-16 13:55:23 +01:00
Fabien Cazenave
7a2ab2c16d
Bug 456798 — Implement document.queryCommandSupported
...
Rationale: a command is supported if it can be converted to an internal Midas
command. `nsCommandManager::IsCommandSupported' might not be needed any more.
Corollary: document.queryCommandEnabled should return false on unsupported
commands without raising any exception.
Browserscope tests: +43 points = 258 failed tests...
* Q section: 0/48 => 42/48
42 tests used to fail (execution exception), now pass
* QE section: 36/46 => 37/46
garbage-1_TEXT-1 used to fail, now passes
In these two sections, a lot of tests that used to raise an exception now return
`false' (that's still a FAIL, but that's not the same kind of FAIL).
Other Browserscope tests are not affected by this patch.
The status of this test suite (currentStatus.js) has been updated accordingly.
2011-08-17 08:04:14 -04:00
arno renevier
abf78cfc8e
Bug 338427 followup - fix Get/SetCurrentDictionary signature; r=ehsan
2011-08-15 13:55:02 -04:00
arno renevier
c4a382824d
Bug 338427 followup - Do not override manually set dictionary; r=ehsan
2011-08-15 13:54:03 -04:00
Marco Castelluccio
d3f9d68e9e
Bug 612839 - Removed nsAHtml5FragmentParser. r=hsivonen
2011-08-14 10:39:26 -07:00
Vidar Haarr
2e082405d2
Bug 232691 - Replace nsString emptyString; with EmptyString() in nsHTMLEditRules; r=ehsan
2011-08-13 14:59:48 +02:00
Ms2ger
f1ce0d69e4
Merge m-c to m-i
2011-08-13 14:47:03 +02:00
Malini Das
132054c82e
Bug 367393 - Add a packed MochiKit that contains only SimpleTest dependencies- new tests. r=jmaher, a=test-only
2011-08-12 12:21:44 -04:00
Malini Das
c20b68638f
Bug 367393 - Add a packed MochiKit that contains only SimpleTest dependencies- plain tests 2/2. r=jmaher, a=test-only
2011-08-12 12:21:44 -04:00
Malini Das
ea71db787e
Bug 367393 - Add a packed MochiKit that contains only SimpleTest dependencies- chrome. r=jmaher, a=test-only
2011-08-12 12:21:36 -04:00
Ms2ger
56beecce2a
Bug 677340 - Return already_AddRefed instead of nsCOMPtr from various functions in editor/; r=ehsan
2011-08-11 15:29:59 +02:00
Ms2ger
3fea5b3901
Bug 677101, part c - Reduce nsIDOMText.h inclusions; r=volkmar
2011-08-11 15:29:58 +02:00
Ms2ger
4ca9cbc0f3
Bug 677101, part b - Remove nsContentUtils.h includes from headers; r=volkmar
2011-08-11 15:29:50 +02:00
Fabien Cazenave
2211444fe6
Bug 442186 - execCommand justify* fails on first line of contenteditable; r=ehsan
...
Given the way GetPromotedPoint / IsNodeInActiveEditor are designed, when the
selection is in the first child element of the active editing host the
selection is extended outside of editor node.
As a result, `GetNodesFromSelection' (which is called at the beginning of
`WillAlign') returns two nodes:
1. an empty text node, which is enclosed in a <div style="text-align: ***">;
2. the first child element, which is destroyed when it's a <div>;
Proposed solution:
#1 can be avoided by checking that the node is editable in `WillAlign';
#2 can be avoided by not dropping <div> blocks in `RemoveAlignment'.
This is an opportunity to simplify `RemoveAlignment' a bit.
2011-08-10 19:03:34 -04:00
Graeme McCutcheon
f14955fe44
Bug 483651 - Trailing <br> node not removed when it should be; r=ehsan
2011-08-12 15:53:10 -04:00
arno renevier
56a37f401e
Bug 338427 - Spellchecker should respect the langi attribute; r=ehsan
2011-08-12 15:12:45 -04:00
Ian Neal
1a531de79c
Test for Bug 291780 - List outdent is not working properly r=ehsan
2011-08-10 00:14:58 +01:00
Ian Neal
a5f7b6054c
Test for Bug 290026 - Outdent of List does not work properly r=ehsan
2011-08-10 00:14:53 +01:00
Ehsan Akhgari
356a62adb7
Merge the latest green changeset on mozilla-inbound to mozilla-central
2011-08-09 08:09:13 -04:00
Jan Varga
a298beaa2e
Bug 617528 Part 2 - Core implementation r=smaug
...
--HG--
rename : content/html/content/test/test_bug418756.html => content/html/content/test/test_checked.html
2011-08-08 19:31:32 +02:00
Michael Wu
fbcd07dca0
Bug 676465 - Replace PRBool with boolean in IDL files, r=bsmedberg
2011-08-06 22:03:32 -07:00
Marco Bonardo
b245bb61dd
Merge last green changeset from mozilla-inbound to mozilla-central
2011-08-03 10:46:22 +02:00
Kyle Huey
b5c51d1c84
Bug 675627: Fix unrecognized directive error in nsIURIRefObject.idl and make this error fatal in the future. r=bsmedberg
2011-08-01 14:26:13 -04:00
Henri Sivonen
21d32e82f3
Bug 596182 - Make fragment parsers global. Remove resulting dead code. r=Olli.Pettay, r=bzbarsky.
2011-08-01 10:48:24 +03:00
Henri Sivonen
7c13c0d93c
Bug 482909 part 2 - Implement an HTML/SVG/MathML sanitizer independently of parsers or serializers. r=bzbarsky.
2011-07-29 14:48:04 +03:00
Michael Wu
46a170c5f0
Bug 671417 - Incorrect use of PRBool when other types are more appropriate or vice versa, r=bz,ehsan,dwitte,joe,vlad,luke,mak,roc
2011-07-26 23:43:37 -07:00
Fabien Cazenave
42b75628a4
Bug 674861 - contentEditable lists should not be splittable; r=ehsan
...
In design mode, pressing [Return] twice in a list (ol, ul, dl) splits the list
and inserts a paragraph. When the list is the active editing host, it should not
be split.
2011-08-02 15:04:43 -04:00
Fabien Cazenave
5b755cb2ec
Bug 620319 - crash [@ nsHTMLEditor::GetInlinePropertyBase] if !aAttribute; r=ehsan
...
Adds a null check to avoid dereferencing a null pointer.
--HG--
extra : rebase_source : 75b97cafad2318af60956d88d12da51a00224949
2011-07-26 18:09:12 -04:00
Fabien Cazenave
a30ad7703f
Bug 620283 - crash [@ nsHTMLEditor::RemoveStyleInside] if !aAttribute; r=ehsan
...
Adds a null check to avoid dereferencing a null pointer.
--HG--
extra : rebase_source : ba8bfcabbc2f17b0b0cea1d90dbed54a8471bad9
2011-07-26 18:08:55 -04:00
Fabien Cazenave
c719b3e5e9
Bug 460740 - [contentEditable] invalid results when pressing Enter in a bunch of different cases; r=ehsan
...
In some situations, pressing Enter in a contentEditable node fails:
* in an editable paragraph, list item or header, pressing Enter
creates another editable block;
* in an inline editable node, pressing Enter does nothing.
That's because nsHTMLEditRules::WillInsertBreak doesn't check for the active
editing host. This patch should fix it.
2011-07-26 17:38:23 -04:00
Jonathan Kamens
567e511032
Bug 489202 - selection moves to top when html containing meta, link, or style elements is pasted or inserted; r=ehsan
2011-07-26 13:59:50 -04:00
Michael Wu
b34f351453
Bug 671185 - Incorrect return of NS_ERROR_* codes in functions returning PRBool, r=mak,ehsan,taras,biesi,pike,khuey,dholbert,josh,bjacob,bsmith
2011-07-25 21:57:58 -07:00
Fabien Cazenave
fd42bbeaf9
Bug 688599 - do not expand selection for deletion outside of the active editing host; r=ehsan
...
When a selection in an inline element is to be deleted, it is first expanded to
the parent block in order not to leave any empty inline element. This patch
ensures that the selection cannot be expanded outside of the contentEditable
element (active editing host).
2011-07-25 17:11:46 -04:00
Ehsan Akhgari
4a2d60fa6f
Merge mozilla-central and mozilla-inbound
2011-07-24 12:52:51 -04:00
Joel Maher
bb2e78799b
Bug 666654 - split eventutils.js functions that are chrome only into chromeutils.js. r=ted, a=test-only
2011-07-23 09:02:40 -04:00
Ms2ger
19bead777e
Bug 666665 - Remove isindex content code; r=sicking+hsivonen
2011-07-23 11:45:38 +02:00
Fabien Cazenave
72db40d008
Bug 449243 - contentEditable: insert <p> instead of <br>; r=ehsan
...
In editable elements, create a paragraph instead of a <br> node
when [Return] is pressed:
* once in a header node (<h[1..6]>);
* twice in a list item node (<li>).
2011-07-22 12:19:17 -04:00
Joel Maher
6659c4f8af
Bug 666649 - remove enablePrivilege from various places in the harness and chrome tests. r=ted, a=test-only
2011-07-21 16:21:25 -04:00
Mounir Lamouri
57fe0a2e82
Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst
2011-07-20 12:18:54 -07:00
Ehsan Akhgari
8aa36b3b5c
Revert to changeset e0ce7821fce1 because the latest push broke all of the builds DONTBUILD
2011-07-19 16:25:54 -04:00
Mounir Lamouri
b6d655dff0
Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst
2011-07-19 11:22:43 -07:00
Mounir Lamouri
58e2fd59fd
Backed out bug 669310, bug 668013, bug 667887 and bug 669886 due to build bustage.
2011-07-19 10:49:48 -07:00
Mounir Lamouri
8ae6e80c16
Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst
2011-07-18 17:05:10 -07:00
arno renevier
5995592cc2
Bug 417418 - do not treat context click as double click anymore in editor; r=ehsan
2011-07-18 14:42:56 -04:00
Ehsan Akhgari
4c25e7b62f
Backout changeset 65e0d40a57b7 (bug 417418) because of unit test failure
2011-07-18 16:29:22 -04:00
arno renevier
adc42180ca
Bug 417418 - do not treat context click as double click anymore in editor; r=ehsan
2011-07-18 14:42:56 -04:00
Ehsan Akhgari
f86a19e699
Bug 671672 - Reduce a bunch of console spam in debug builds caused by the HTML editor; r=roc
2011-07-14 17:06:37 -04:00
Ehsan Akhgari
a10316377d
Bug 434998 - Enable the usage of the execCommand API for <xul:editor> elements; r=roc
2011-07-15 08:17:56 -04:00
Ehsan Akhgari
62312843c5
Bug 414526 - Backspace at the beginning of a contenteditable element or delete at the end of one should not affect the rest of the contenteditable elements on the page; r=roc
...
The main fix here involves the introduction of the nsHTMLEditor::IsNodeInActiveEditor
API. This API returns true if the current selection in the document falls
inside the active editable section. The patch adds a bunch of checks using
this API to various places in the code to make sure that editing operations do
not escape their editing host.
There are also some unrelated fixes to range promotion code which fix the
bugs that have existed in that code before, but because of the lack of this
check were not uncovered before.
This patch also removes the nsTextEditUtils::InBody API which only made sense
in designMode documents, and was insufficient for contenteditable elements.
2011-07-14 11:25:07 -04:00
Ms2ger
8c78d3f478
Bug 670235 - Remove nsIDOMWindowInternal; r=sicking
2011-07-15 12:31:34 +02:00
Ms2ger
2213f46da8
Bug 670499 - Make nsEditor::CreateEventListeners return void; r=ehsan
2011-07-15 12:18:35 +02:00
Simon Montagu
41b695192a
Undefine caret bidi level during reflow instead of on text entry. Bug 664087, r=roc
2011-07-05 08:42:32 +03:00
Jonas Sicking
743f1281ec
Bug 661297 Part 1: Remove Add/RemoveEventListenerByIID API. r=smaug
2011-08-08 11:26:26 -07:00
Ehsan Akhgari
effbfd3c5a
Bug 549262 - Enable the (shift-)space shortcut key for scrolling up/down in pages containing editable elements; r=roc
...
--HG--
extra : rebase_source : 99706dd2e678052b345b011ea76f17370ad1a227
2010-09-06 16:59:41 -04:00
Ehsan Akhgari
44c895469d
Bug 439808 - Make sure that deleting a selection works in inline contenteditable elements which have a non-editable parent block; r=roc
...
--HG--
extra : rebase_source : 74d3df996b904032696000daa532d217140d3b2d
2011-06-29 21:01:59 -04:00
Jonas Sicking
463d460f66
Bug 663461 Part 1: Remove Add/RemoveEventListenerByIID from editor. r=smaug
2011-06-27 16:34:54 -07:00
Wolfgang Germund
82bbd81949
Bug 664095 - Remove the override stylesheets when the editor is detached from the document as opposed to when it's destroyed for compatibility with the expected behavior from Composer; r=ehsan
2011-06-24 13:55:43 -04:00
Jonas Sicking
a326e5c69f
Bug 658714 Part 10: Remove nsIDOM3EventTarget/nsIDOMEventGroup. r=smaug
2011-06-23 19:18:02 -07:00
Jonas Sicking
0c346db2ed
Bug 658714 Part 9: Don't use EventGroups for system-group. r=smaug
2011-06-23 19:18:02 -07:00
Jonas Sicking
f7e72db3bc
Bug 658714 Part 7: DeCOMtaminate nsEventListenerManager. r=smaug
2011-06-23 19:18:01 -07:00
Jonas Sicking
cd52437ea7
Bug 658714 Part 6: Fixups after search'n'replace s/nsPIDOMEventTarget/nsIDOMEventTarget/. r=smaug
2011-06-23 19:18:01 -07:00
Jonas Sicking
07c1f0b90f
Bug 658714 Part 5: Search'n'replace nsPIDOMEventTarget to nsIDOMEventTarget. r=smaug
2011-06-23 19:18:00 -07:00
Jonas Sicking
50c51df5f9
Bug 658714 Part 1: Merge nsPIDOMEventTarget into nsIDOMEventTarget. r=smaug,bent
2011-06-23 19:17:58 -07:00
Ehsan Akhgari
07e2021359
Merge the last green changeset on mozilla-inbound to mozilla-central
2011-06-20 16:06:04 -04:00
Ed Morley
8619d995ce
Bug 665359 - Remove unused variable res from nsHTMLEditor::AddPositioningOffset; r=ehsan
...
DONTBUILD
2011-06-20 14:53:51 -04:00
Ehsan Akhgari
d0dee49023
Bug 660199 - Avoid using invalid C++ casts when registering/unregistering editor event listeners; r=roc
2011-06-20 09:55:22 -04:00
Joel Maher
7ed6c2e17f
Bug 664165 - move editor/libeditor/html/tests/test_contenteditable_text_input_handling.html to mochitest-chrome. r=masayuki, a=test-only
2011-06-19 11:56:44 -04:00
Masayuki Nakano
b96a7b1afb
Bug 664437 editor should use mozilla::Preferences r=ehsan
2011-06-17 09:59:29 +09:00
Jonas Sicking
fd28a5666a
Bug 659539 Part 4: Use nsINode::NodeType where possible. r=bz
2011-06-14 00:56:50 -07:00
Jonas Sicking
48f55a5733
Bug 659053 Part 1: Merge nsIDOM3Node into nsIDOMNode. Also removes Node.getFeature. r=peterv
2011-06-14 00:56:48 -07:00
Matt Brubeck
97d5e0e637
Bug 663959 - Mark crashtests as asserting intermittently [r=ehsan]
2011-06-13 14:24:04 -07:00
Ed Morley
8aaddd0334
Bug 659621 - Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1, now that libxul is always built; r=ted
2011-06-12 03:49:00 -04:00
Joel Maher
0dc4e1543a
Bug 663215 - move test_selection_move_commands.xul to mochitest-chrome. r=roc, a=test-only
2011-06-10 11:11:45 -04:00
Dominic Fandrey
968bf5196a
Bug 645398 - Substitute PR_(MAX|MIN|ABS|ROUNDUP) macro calls; r=roc
2011-06-02 14:56:50 +02:00
Masayuki Nakano
4a5030c91a
Bug 660121 Remove all pref related methods from nsContentUtils r=roc
2011-05-29 08:42:57 +09:00
Ms2ger
86b93bb1ab
Bug 659113 - Remove nsIDOMNSHTMLDocument; r=bz
2011-05-28 09:43:57 +02:00
Ms2ger
e5cf1395fc
Bug 658906 - Remove nsIDOMNSDocument; r=sicking
2011-05-28 09:43:53 +02:00
Ehsan Akhgari
9db2091376
Bug 634406 - Don't select past the trailing BR node in text fields when performing the SelectAll operation; r=roc
2011-05-25 16:30:14 -04:00
Ehsan Akhgari
9473a7e8ed
Bug 658516 - nsHTMLEditRules.cpp:5810:52: warning: comparison between signed and unsigned integer expressions. r=roc
...
--HG--
extra : rebase_source : 6772483c9ca0eb23444850db1f30f0144516a861
2011-05-25 10:10:45 +02:00
Masayuki Nakano
7b13fbd2d9
Bug 659536 part.2 Replace nsContentUtils::GetIntPref() with Preferences::GetInt() or Preferences::GetUint() r=roc
2011-05-25 15:32:00 +09:00
Ms2ger
53c2bafa8a
Bug 657210 - Address review comment
2011-05-23 18:54:57 +02:00
Ms2ger
95946ba581
Bug 657210 - Outparamdel nsEditor::GetPresShell; r=ehsan
2011-05-22 14:43:13 +02:00
Mounir Lamouri
92de904e71
Merging cedar with mozilla-central.
2011-05-20 15:55:16 +02:00
Daniel Holbert
66ce76121f
Bug 657554: Remove call to undefined method "endTest" from test_bug519928.html. r=ehsan
2011-05-19 17:51:20 -07:00
Craig Topper
8a3f0ad8f7
Bug 658143 - Part 1: Changes nsCOMPtr<nsFrameSelection> to nsRefPtr. r=roc
2011-05-18 20:10:49 -07:00
Ed Morley
91238e76b1
Bug 316661 - Part A - Remove null-checks before delete. r=bsmedberg
2011-05-17 16:01:36 +02:00
Ms2ger
f32c8d1912
Bug 657160 - Remove NS_NewCaret; r=ehsan,roc
2011-05-15 12:17:09 +02:00
Ms2ger
ebc1fff223
Bug 657160 - Remove NS_NewTextEditRules; r=ehsan
2011-05-15 12:16:45 +02:00
Ms2ger
5855cef3c4
Bug 657160 - Remove NS_NewHTMLEditRules; r=ehsan
2011-05-15 12:15:35 +02:00
Ms2ger
d1a1efbbcb
Bug 656996 - Remove NS_NewHTMLCSSUtils; r=ehsan
2011-05-15 12:07:30 +02:00
Ms2ger
2ba2beb025
Bug 655514 - Remove nsIDOMDocumentTraversal; f=ehsan r=jonas
2011-05-15 12:07:30 +02:00
Ehsan Akhgari
e422c276a8
Bug 612129 - Set the initial selection range to the beginning of the text field in order to be more compatible with other browsers; r=roc
2011-05-12 09:52:38 -04:00
Masayuki Nakano
1ef49a007d
Bug 655918 Clean up the composition string when whole characters of it are refused due to maxlength r=ehsan
2011-05-11 13:52:45 +09:00
Ed Morley
97cc9c4eea
Bug 655756 - Remove final XP_MAC remnants; r=josh
2011-05-10 20:24:48 +02:00
Mounir Lamouri
65155b5073
Bug 514437 - Content part of the progress element. r=smaug
2011-04-09 10:22:02 -07:00
Matt Brubeck
f7ac6dd55e
Back out changeset bfb48178c8ec (finish backing out bug 514437) to fix tests on a CLOSED TREE.
2011-05-09 19:38:05 -07:00
Jonas Sicking
2160f5e6fc
Bug 643786. Don't fire DOMNodeRemoved when removing the editor created <br>. r=ehsan
2011-05-09 12:33:04 -07:00
Jonas Sicking
6835982ecc
Bug 650493 Part 1: Simplify mutation events by firing all but DOMNodeRemoved off of script runners, and DOMNodeRemoved before starting any update batches or aquiring any state. r=smaug/peterv
2011-05-09 12:33:03 -07:00
Mounir Lamouri
b962186b7c
Bug 514437 - Content part of the progress element. r=smaug
2011-04-09 10:22:02 -07:00
Sebastian Kromp
30f0d86da8
Bug 633750 - deCOM nsIHTMLEditRules and move methods to nsHTMLEditRules. r=ehsan
2011-05-07 10:04:56 +02:00
Ed Morley
074fb0d28a
Bug 654737 - Remove WinCE code from editor/*; r=ehsan
2011-05-06 11:05:57 +02:00
Ms2ger
31e3e8c5d1
Bug 616684 - Remove support for DOM Views; r=sicking,ehsan
2011-04-24 08:54:25 +02:00
Neil Rashbrook
e349342422
Bug 647682 Can't copy and paste local links in <editor> documents r=ehsan f=bz
2011-04-28 20:59:45 +01:00
Ehsan Akhgari
67e7a42892
Backout changeset 13f6847dd840 (bug 616684) because it changes code semantics in a bad way, which results in problems like the crash in bug 652580, possibly among others
2011-04-25 17:05:17 -04:00
Ms2ger
540ca93080
Bug 616684 - Remove support for DOM Views; r=sicking
2011-04-24 08:54:25 +02:00
Mounir Lamouri
84203d9e11
Merge cedar with mozilla-central.
2011-04-22 15:25:11 +02:00
David Zbarsky
a0b813679f
Bug 610305: decom nsEventStateManager r=smaug
2011-04-21 19:35:52 +02:00
Ehsan Akhgari
bc13895396
Bug 649797 - Rewrite the test for bug 600570 in a way that doesn't trigger the assertion which can never happen on the web; r=roc
...
--HG--
extra : rebase_source : 8f21974f360f1e9806a1b7cfefb7d1733513d22f
2011-04-21 10:25:34 -04:00
Mounir Lamouri
2af4853be5
Backed out changeset c1a7c1bc1aeb due to busted build.
2011-04-20 22:26:06 +02:00
David Zbarsky
732897cc3f
Bug 610305: decom nsEventStateManager r=smaug
2011-04-20 21:42:33 +02:00
Ehsan Akhgari
2759ff18ea
Bug 649012 - Fix some flaky mochitests which rely on non-zero timeout values; rs=ted
2011-04-16 19:39:34 -04:00
Ehsan Akhgari
135eb99ddb
Backed out changeset d407ee4dabcc because it causes some tests to go orange
2011-04-16 23:47:06 -04:00
Ehsan Akhgari
d6e8bc6ecd
Bug 649012 - Fix some flaky mochitests which rely on non-zero timeout values; rs=ted
2011-04-16 19:39:34 -04:00
Ehsan Akhgari
2b93d069f5
Bug 650083 - nsEditor.cpp:1147: warning: unused variable 'rv'; r=roc
2011-04-14 23:45:24 -04:00
Ehsan Akhgari
64f49c06b3
Bug 649566 - @keyframe(s) missing from <style> sanitizing code in nsHTMLFragmentContentSink; r=bzbarsky
2011-04-13 18:12:32 -04:00
Ehsan Akhgari
09eee51632
Bug 617539 - Remove nsIEditor_MOZILLA_2_0_BRANCH; r=roc
2011-04-11 16:00:32 -04:00
Peter Van der Beken
75ba54d84d
Fix for bug 584048 (Clean up cycle collection code) - remove NS_IMPL_CYCLE_COLLECTING_ADDREF_AMBIGUOUS/NS_IMPL_CYCLE_COLLECTING_RELEASE_AMBIGUOUS. r=bent.
2011-03-06 12:11:31 +01:00
Ehsan Akhgari
29ecf466fa
Bug 646194 - Fix the bound checking when deleting previous words to prevent crashes when the caret is at the beginning of an editable area; r=roc
2011-04-06 11:28:08 -07:00
Chris Jones ext:(%20and%20Kyle%20Huey%20%3Ckhuey%40kylehuey.com%3E)
2c92e3ecd5
Rollup of bug 645263 and bug 646259: Switch to mozilla:: sync primitives. r=cjones,dbaron,doublec,ehsan src=bsmedberg
...
Bug 645263, part 0: Count sync primitive ctor/dtors. r=dbaron
Bug 645263, part 1: Migrate content/media to mozilla:: sync primitives. r=doublec
Bug 645263, part 2: Migrate modules/plugin to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 3: Migrate nsComponentManagerImpl to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 4: Migrate everything else to mozilla:: sync primitives. r=dbaron
Bug 645263, part 5: Remove nsAutoLock.*. sr=bsmedberg
Bug 645263, part 6: Make editor test be nicer to deadlock detector. r=ehsan
Bug 645263, part 7: Disable tracemalloc backtraces for xpcshell tests. r=dbaron
Bug 646259: Fix nsCacheService to use a CondVar for notifying. r=cjones
2011-03-31 23:29:02 -05:00
Chris Jones
699024f868
Backed out changeset 4beec31b9ea9 for increasing frequency of intermittent orange bug 618052
2011-03-31 18:57:38 -05:00
Chris Jones ext:(%20and%20Kyle%20Huey%20%3Ckhuey%40kylehuey.com%3E)
0ce53bb598
Rollup of bug 645263 and bug 646259: Switch to mozilla:: sync primitives. r=cjones,dbaron,doublec,ehsan src=bsmedberg
...
Bug 645263, part 0: Count sync primitive ctor/dtors. r=dbaron
Bug 645263, part 1: Migrate content/media to mozilla:: sync primitives. r=doublec
Bug 645263, part 2: Migrate modules/plugin to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 3: Migrate nsComponentManagerImpl to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 4: Migrate everything else to mozilla:: sync primitives. r=dbaron
Bug 645263, part 5: Remove nsAutoLock.*. sr=bsmedberg
Bug 645263, part 6: Make editor test be nicer to deadlock detector. r=ehsan
Bug 645263, part 7: Disable tracemalloc backtraces for xpcshell tests. r=dbaron
Bug 646259: Fix nsCacheService to use a CondVar for notifying. r=cjones
2011-03-31 14:51:19 -05:00
Sebastian Kromp
d77753a5db
Bug 633066: Remove nsICiter and make nsInternetCiter a static class. r=ehsan
2011-03-31 07:32:13 -04:00
Kyle Huey
9d3d2b598a
Merge m-c to bs.
2011-03-31 07:17:15 -04:00
Ehsan Akhgari
35dd938230
Bug 645914 - Do not eat the white-space when doing word selection if the eaten whitespace is a newline character and we have been instructed not to jump between lines; r=roc
...
This fixes a bug in selecting words at the end of lines in textarea's for Windows.
2011-03-30 11:56:48 -04:00
Kyle Huey
a1dfc7ee3a
Merge m-c to bs.
2011-03-26 12:12:37 -04:00
Ehsan Akhgari
4f5080cfa0
Bug 611457 - Move the object which is supposed to survive the function's return out of the function so that a possible garbage collection doesn't collect it before it should be used; r=roc a=test-only
2011-03-12 00:07:37 -05:00
Ehsan Akhgari
bdcb5e4f05
Bug 618041 - Move the object which is supposed to survive the function's return out of the function so that a possible garbage collection doesn't collect it before it should be used; r=roc a=test-only
2011-03-12 00:11:01 -05:00
Ehsan Akhgari
52150563bc
Bug 627624 - Make the crashtest for bug 428844 actually test something; r=roc a=test-only
2011-03-11 23:11:28 -05:00
Ehsan Akhgari
76716122b8
Bug 636465 - Reset the spellchecking override status when detaching an editor object from the content node; r,a=roc
2011-03-01 15:04:42 -08:00
Neil Rashbrook
9626543cf1
Bug 635420 - Clicking on content within Normal tab of Composer and stops switching to other tabs; r=ehsan a=bsmedberg
2011-02-28 13:04:05 -08:00
Jesse Ruderman
d5953c7a20
Add bug number to comment. a=NPOTB DONTBUILD
2011-02-24 13:43:48 -08:00
Ehsan Akhgari
612a38d5d6
Bug 636074 follow-up: move the assertion count adjustment because a test was added in between
2011-02-23 15:28:33 -08:00
Kyle Huey
02e3532e3a
Bug 636107 - Part 2: Maintain better hygiene by not passing uninitialized pointer values around; r=ehsan a=blocking-final+
2011-02-23 07:20:58 -05:00
Ehsan Akhgari
e4231d6333
Bug 636074 - Part 1: Forget the transaction pointer when creating transaction objects in order to pass it to the caller instead of swapping it with random values; r=roc a=blocking-final+
2011-02-23 14:22:07 -08:00
Ehsan Akhgari
0da81d5e1a
Bug 635757 - Adjust the assertion count as a result of bug 633738; r=roc a=test
...
DONTBUILD this simple assertion annotation adjustment!
2011-02-21 23:53:40 -05:00
Mats Palmgren
173f7afaae
Bug 635636 - Don't return a value from void function. a=bustage
2011-02-21 21:43:54 +01:00
Mats Palmgren
b518ba24d4
Bug 635636 - Crash [@ nsHTMLEditRules::DocumentModifiedWorker] with navigated-away designMode document; r,a=ehsan
2011-02-21 15:34:16 -05:00
Ehsan Akhgari
ebcf3d0ac2
Bug 635532 - Don't try to hide the editor anonymous UIs during the cycle collection unlink phase needlessly. r=roc,jst, a=blocker
2011-02-19 21:43:07 -08:00
Kyle Huey
fc7735ba26
Bug 633709: Actually commit the test. r+a=ehsan
2011-02-19 18:40:52 -05:00
Kyle Huey
c4c65578ef
Bug 633709: Convert bogus assert into a warning. r+a=ehsan
...
--HG--
extra : rebase_source : 5928d5a4309bd98e0cf4cd3041f36ba64d992706
2011-02-19 17:49:23 -05:00
Kyle Huey
5e7713edd1
Bug 633709: Fix editor's handling of txn objects. r+a=ehsan
...
--HG--
extra : rebase_source : c44055ca4378a8213e3b60b61b16df8dd9758a88
2011-02-19 17:18:37 -05:00
Kyle Huey
e8fbad8336
Bug 633709: Test.
...
--HG--
extra : rebase_source : 6bae5d01331df279551577606806fc35d91993a3
2011-02-19 17:04:26 -05:00
Peter Van der Beken
b6b7136d51
Fix for bug 633738 (quora.com bloats out of control (part 3)) - mark some known assertions caused by bug 439258. r=bz, a=jst.
2011-02-17 12:19:13 +01:00
Peter Van der Beken
c4aeb00d0d
Fix for bug 633738 (quora.com bloats out of control (part 3)) - make nsHTMLEditor participate in CC, clear editor from SHistory if we're not storing anything else. r=jst, a=jst.
2011-02-16 13:07:47 +01:00
Serge Gautherie
db006f0fb1
Bug 634626 - test_bug366682 failures because spellchecking is disabled; (Bv1) s/CR+LF/LF/g, Remove ending whitespaces.
...
r=jmaher (a=test-only).
DONTBUILD
2011-02-17 20:19:35 +01:00
Daniel Holbert
9653ef51f8
(no bug) comment typo fix in 2 tests: s/the affect/the effect/ a=comment-only+test-only DONTBUILD
2011-02-15 10:10:40 -08:00
Ehsan Akhgari
52752d9e48
Back out changeset 0fd8793db7f3 (bug 633738) because of various oranges in different test suites on multiple platforms; a=orange
2011-02-14 18:45:23 -05:00
Peter Van der Beken
b478202897
Fix for bug 633738. Fix leak due to session history code keeping an editor alive too long. Patch by peterv and bz, r=jst@jstenback.com, a=blocker
2011-02-14 14:26:14 -08:00
Mounir Lamouri
fd359d7a1c
Bug 629845 (2/2) - GetRoot() returning null isn't unexpected. r=ehsan a=blocking-final
2011-02-11 02:01:49 +01:00
Mounir Lamouri
a2b5d8fea5
Bug 629845 (1/2) - Don't make nsHTMLDocument::EditingStateChanged fails if BeginningOfDocument fails. r=ehsan a=blocking-final
2011-02-11 01:59:37 +01:00
Ehsan Akhgari
dec474d494
Bug 336091 - Initialize the out parameters of nsEditor::GetStartNodeAndOffset correctly; r,a=roc
...
--HG--
extra : rebase_source : 7ae5b960263f2412c21b0cbcebf6f95a4ddb2e73
2011-02-09 14:07:56 -05:00
Ehsan Akhgari
2592310699
Bug 632326 - Synthesize a Paste command instead of calling the internal goDoCommand in the test for bug 520189; r=roc a=test-only
2011-02-08 21:50:51 -05:00
Ehsan Akhgari
cb6a971f1a
Merge cedar into mozilla-central
2011-03-25 14:21:07 -04:00
Benjamin Smedberg
6d442e547b
Bug 617539 - Remove branch interfaces, nsIHTMLEditor_MOZILLA_2_0_BRANCH, straight backout of revision e9d979b4b4a0, r=ehsan
2011-03-25 11:03:33 -04:00
Matheus Kerschbaum
4a7ba19066
Bug 634807 - Remove MOZ_PLAINTEXT_EDITOR_ONLY; r=khuey
2011-03-24 19:59:00 -04:00
arno renevier
4d7b7faedc
Bug 497115 - nsHTMLEditor.cpp contains unnecessary includes; r=peterv sr=peterv
2011-03-23 23:23:39 -04:00
Ehsan Akhgari
389876ffaa
Test case for bug 638596; r=roc
2011-03-04 13:44:25 -08:00
Ehsan Akhgari
a19b558467
Test case for bug 635636; r=roc
2011-02-21 16:58:07 -05:00
Ehsan Akhgari
944f090fc9
Bug 642704 - Part 3: Remove test_set.py because it confuses our mochitest suite runner, and we don't need it to run the BrowserScope RichText2 suite; r=roc
2011-03-19 16:45:29 -04:00
Ehsan Akhgari
1f5455967e
Bug 642704 - Part 2: Add a test driver to run the BrowserScope RichText2 test suite as a mochitest; r=roc
2011-03-19 16:44:30 -04:00
Ehsan Akhgari
9df3c1ae86
Bug 642704 - Part 1: Import the BrowserScope RichText2 test suite files into the tree; r=roc
2011-03-18 18:15:24 -04:00
Ehsan Akhgari
039f2bfcf6
Bug 642588 - Clean up the drag & drop caret on the editor correctly when the mouse leaves the editable field; r=roc
2011-03-18 14:57:02 -04:00
Ehsan Akhgari
d8016a4f53
Bug 640321 - Register the mouse event handlers for the editor in the system group; r=roc
2011-03-16 15:34:30 -04:00
Ehsan Akhgari
c82a3bc6df
Bug 641466 - Correct the array bounds checking so that the last surrogate pair in a textbox can be deleted correctly; r=roc
2011-03-16 15:34:29 -04:00
Ehsan Akhgari
841f13f519
Bug 639695 - Reconnect the HTML editor to the new presentation of a contenteditable document when it changes; r=roc
...
This fixes things such as the caret not showing up after the presshell for a
document containing a contenteditable element is recreated.
2011-03-11 18:45:20 -05:00
Ehsan Akhgari
a2c435fafa
Bug 407127 - Part 6: Remove the presshell argument to nsIEditor::Init as it's no longer necessary; r=roc
2011-03-11 00:40:31 -05:00
Ehsan Akhgari
54176ab085
Bug 407127 - Part 5: Fix the editor to not rely on cached presshells and selection controllers, because they may not always be valid; r=roc
2011-03-11 00:40:31 -05:00
Ehsan Akhgari
a991a93821
Bug 407127 - Part 4: Avoid using the presshell needlessly because it may not always be available; r=roc
2011-03-11 00:40:30 -05:00
Ehsan Akhgari
aa6ee6b6f9
Bug 407127 - Part 3: Get the selection controller for HTML editors from the presshell, instead of holding on to a presshell reference masked as a selection controller; r=roc
2011-03-11 00:40:30 -05:00
Ehsan Akhgari
eabc4ca754
Bug 407127 - Part 2: Refactor the editor so that it only touches mSelConWeak in GetSelectionController, to make removing it for HTML editors easier; r=roc
2011-03-11 00:40:30 -05:00
Ehsan Akhgari
318a97fcfd
Bug 407127 - Part 1: Refactor the editor so that it only touches mPresShellWeak in GetPresShell, to make removing it easier; r=roc
2011-03-11 00:40:30 -05:00
Boris Zbarsky
31061a9ff8
Bug 632904. Check IsEditable(), not content states, if we care about editability. r=ehsan,masayuki
2011-03-23 10:45:21 -04:00
Chris Jones
97685d6934
Rollup of bug 615386, parts 1-6. Teach the reftest harness about <browser remote>. r=dbaron,roc,ted a=a
...
--HG--
rename : layout/tools/reftest/reftest.js => layout/tools/reftest/reftest-content.js
2011-02-03 13:54:10 -06:00
Chris Leary
09f6be30b5
Merge tracemonkey to mozilla-central. (a=blockers)
2011-01-31 19:43:36 -08:00
Jonas Sicking
809bbcd2c3
Disallow content access to chrome functions without __exposedProps__ (bug 628410, r=gal).
2011-01-29 18:47:17 -08:00
Ehsan Akhgari
d257892bdf
Bug 628980 - browserscope richedit tests load http://www.google.com/intl/en_ALL/images/logo.gif over the network; r=roc a=NPOTB
2011-01-27 00:26:33 -05:00
Ehsan Akhgari
71ee52288f
Bug 629172 - Fix the regression in switching the text input direction using Cmd/Ctrl+Shift+X; r=roc a=blocking-final+
...
--HG--
extra : rebase_source : 57471865db00c1efa07bb746df42de8278027b36
2011-01-27 00:26:33 -05:00
Ehsan Akhgari
170dc1627a
Bug 626411 - Selecting a section of URL, then clicking "Delete" stays at refresh, instead of "go"; r=roc a=blocking-final+
...
--HG--
extra : rebase_source : 09c7a68d030c819afe7086fe22f2c83620e881eb
2011-01-19 19:25:03 -05:00
Ehsan Akhgari
3072499cd4
Bug 625452 - Make sure all plaintext editor commands generate trusted input events; r=roc a=blocking-final+
2011-01-15 23:16:45 -05:00
Ehsan Akhgari
a995f8eace
Bug 622371 - Only set the selection to the beginning of the editable document if the editor is being initialized by entering designMode; r=bzbarsky a=blocking-final+
2011-01-06 17:13:51 -05:00
Ehsan Akhgari
c740c0cd64
Bug 620906 - Back out part of bug 289384 to make sure that scrollbars work in CKEditor fields again; r=roc a=blocking-final+
2011-01-11 16:00:44 -05:00
timeless@mozdev.org
6b5d000cdb
Bug 620423 - nsHTMLEditor::ParseCFHTML foolishly checks aStuffToPaste instead of *aStuffToPaste; r=neil a=roc
2011-01-11 10:20:31 -05:00