Commit Graph

19352 Commits

Author SHA1 Message Date
Claudia
fad8547640 Bug 1731770 - [devtools] Persit expanded nodes state in the Response Panel. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D128190
2021-11-25 14:56:48 +00:00
Nicolas Chevobbe
3509ad57ad Bug 1605330 - [devtools] Enable context selector on Nightly. r=ochameau.
We take this opportunity to merge the browser toolbox and content toolbox preferences
into a single one.

Depends on D131600

Differential Revision: https://phabricator.services.mozilla.com/D131770
2021-11-25 13:05:39 +00:00
Julian Descottes
6cc1d8eb14 Bug 1590317 - [devtools] Fix keyboard navigation for about:profiling range inputs r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D131937
2021-11-24 13:50:52 +00:00
Cristian Tuns
ac7a567f03 Backed out 4 changesets (bug 1741808, bug 1742541, bug 1605330, bug 1742332) for causing damp failures. CLOSED TREE
Backed out changeset fe65ddb40037 (bug 1605330)
Backed out changeset d5c4c10f70d9 (bug 1742332)
Backed out changeset 9f637151059d (bug 1741808)
Backed out changeset bd54eacb2d7c (bug 1742541)
2021-11-24 06:43:20 -05:00
Nicolas Chevobbe
c0564bd019 Bug 1742392 - [devtools] Rename onBreakpointAvailable into onThreadStateAvailable. r=bomsy.
This better conveys what the function really does.

Differential Revision: https://phabricator.services.mozilla.com/D131792
2021-11-24 10:23:54 +00:00
Nicolas Chevobbe
59b28c6aa5 Bug 1605330 - [devtools] Enable context selector on Nightly. r=ochameau.
We take this opportunity to merge the browser toolbox and content toolbox preferences
into a single one.

Depends on D131600

Differential Revision: https://phabricator.services.mozilla.com/D131770
2021-11-23 18:56:55 +00:00
Nicolas Chevobbe
72a01fca06 Bug 1741811 - [devtools] Make watchTargets take a single object param. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D131755
2021-11-23 13:23:35 +00:00
Narcis Beleuzu
81698c54eb Backed out changeset 9dfd5e6601a1 (bug 1505304) as requested by nchevobbe 2021-11-23 14:56:24 +02:00
Nicolas Chevobbe
5d77281fc2 Bug 1505304 - [devtools] Make watchTargets take a single object param. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D131755
2021-11-23 12:39:19 +00:00
Julian Descottes
d86a582b80 Bug 1741797 - [devtools] Fix colorpicker click listener signature r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D131602
2021-11-23 11:50:47 +00:00
Sandor Molnar
e524498137 Backed out 2 changesets (bug 1709267) for causing dt failures in browser_about-devtools-toolbox_reload. CLOSED TREE
Backed out changeset da9d3297348d (bug 1709267)
Backed out changeset ec5eb72262cc (bug 1709267)
2021-11-22 22:17:35 +02:00
Alexandre Poirot
8f7f5f4ad4 Bug 1709267 - [devtools] Add support for target switching in about:debugging. r=jdescottes
The challenges here are:
* xpcshell tests still don't support the watcher actor and server side targets. So we have to ensure still using client side target fetched via Descriptor.getTarget RDP request. (We still also need that for WebExtension)
* some tests weren't spawning the TargetCommand while querying TabDescriptor.getTarget. I tuned them to call TargetCommand.startListening so that we start instantiating server side targets, including the top level one retrieved via TabDescriptor.getTarget.

Otherwise, thanks to this patch a few check can now be moved from `if (isLocalTab)` to `if (isTabDescriptor)`.

Differential Revision: https://phabricator.services.mozilla.com/D130761
2021-11-22 18:57:32 +00:00
Alexandre Poirot
32ab65debf Bug 1709267 - [devtools] Remove unused "target" query parameter from toolbox location. r=jdescottes
This wasn't used except for a test and wasn't working with server side targets.
Making this compatible with SST wasn't trivial, so I went for removing this.

Differential Revision: https://phabricator.services.mozilla.com/D130919
2021-11-22 18:57:32 +00:00
Alexandre Poirot
003720c295 Bug 1741669 - [devtools] Implement a faster TargetCommand.getParentTarget. r=nchevobbe
The original intent was to do a synchronous implementation,
but this is hard to do while keeping backward compat.

Differential Revision: https://phabricator.services.mozilla.com/D131398
2021-11-22 18:55:55 +00:00
Alexandre Poirot
ce06e78015 Bug 1741652 - [devtools] Expose commands to all protocol.js fronts. r=nchevobbe
This help any front to interact with commands, which is frequently useful.
In the long run, all fronts should be slowly converted to become commands.

Differential Revision: https://phabricator.services.mozilla.com/D131397
2021-11-22 18:55:55 +00:00
Nicolas Chevobbe
4ae1a542f9 Bug 1742331 - [devtools] Fix more frequent failures on browser_dbg-event-breakpoints-fission.js when EFT is enabled. r=bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D131598
2021-11-22 13:38:43 +00:00
Andreea Pavel
93376ab546 Bug 1717330 - disable browser_touch_event_iframes.js for frequent failures r?#intermittent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D131574
2021-11-19 02:14:06 +00:00
Nazım Can Altınova
fea7d30107 Bug 1741716 - Change the preset to Firefox when profiler popup is activated through web channel r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D131436
2021-11-19 13:49:35 +00:00
Alexandre Poirot
c920bd8a93 Bug 1737194 - [devtools] Strengthen browser_target_command_various_descriptors.js. r=jdescottes
Fix two possible race conditions:
* short lived processes spawn by the test ends up breaking listAllWorkers where the listWorker request
  made against a content process target is throwing because its DevToolsServerConnection is closed.
* the worker created by the test may actually still be visible to WorkerDebuggerManager,
  so use a better technique to catch the WorkerDebugger's id.

Differential Revision: https://phabricator.services.mozilla.com/D131442
2021-11-18 21:43:20 +00:00
Eemeli Aro
453a3f26f0 Bug 1733496 - Migrate key-shortcuts.properties to Fluent. r=jdescottes,fluent-reviewers
This adds `Localization` to `builtin-modules.js` to make it accessible from
`definitions.js`. It's likely that the abstractions used in `definitions.js`
will need to be revisited when `startup.properties` is also migrated to Fluent.

Differential Revision: https://phabricator.services.mozilla.com/D131219
2021-11-18 16:40:03 +00:00
Nicolas Chevobbe
b3f55dd1b1 Bug 1741808 - [devtools] Fix increased failures on browser_toolbox_backward_forward_navigation.js when EFT is enabled. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D131475
2021-11-18 13:22:35 +00:00
Nicolas Chevobbe
11bef8cace Bug 1741803 - [devtools] Fix browser_inspector_iframe-picker-bfcache-navigation with EFT. r=ochameau.
This required 2 changes:
- fixing WatcherActor notifyTargetAvailable so we get notified about the iframe
  target when doing a bfcache navigation (a test case is added in browser_target_command_bfcache.js as well)
- Checking is the target isn't destroyed in inspector onTargetSelected

Differential Revision: https://phabricator.services.mozilla.com/D131471
2021-11-18 13:22:35 +00:00
Nicolas Chevobbe
149cd3677e Bug 1740453 - [devtools] Handle onTargetSelected in accessibility panel. r=ochameau.
A couple tests are added to check that the panel works fine when using the iframe picker.

Differential Revision: https://phabricator.services.mozilla.com/D130611
2021-11-18 13:22:34 +00:00
Raphael Ferrand
702f0ad086 Bug 1498224 - [devtools] Apply new classnames as you type in the .cls section of the rule-view r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D129515
2021-11-18 12:52:22 +00:00
Alexandre Poirot
487d9677f3 Bug 1740292 - [devtools] Stop calling target front attach method. r=nchevobbe
Previous patches made attach method become a no-op, so all these callsites can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D130913
2021-11-18 10:57:01 +00:00
Alexandre Poirot
95bb482288 Bug 1740292 - [devtools] Stop calling Target actor's attach method from the frontend. r=nchevobbe,devtools-backward-compat-reviewers
Calling attach was important to bootstrap the thread actor and retrieve its actorID.
But now with server target this is done early on and we already retrieve the actorID
via form(). Except for workers, but I fixed that.

The next patch will ensure that, on the server side we fully initialize the target actors
as soon as they are created.

Differential Revision: https://phabricator.services.mozilla.com/D130842
2021-11-18 10:57:00 +00:00
Florian Quèze
bc5e79f3ae Bug 1741235 - Merge the 'Firefox Front-End' and 'Firefox Platform' profiler presets, r=julienw,fluent-reviewers,nbaumgardner,kpatenio.
Differential Revision: https://phabricator.services.mozilla.com/D131158
2021-11-17 18:37:43 +00:00
Clinton
3c6ae051d2 [devtools] Bug 1737990 - Remove lodash uniq usage r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D129965
2021-11-17 15:33:08 +00:00
Tawah Peggy
1cf3aba54d Bug 1737989 - Remove lodash union usage. r=nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D131227
2021-11-17 15:31:58 +00:00
Csoregi Natalia
63c1f53d14 Backed out 2 changesets (bug 1709267) for causing devtools failures. CLOSED TREE
Backed out changeset e4dc58404c6c (bug 1709267)
Backed out changeset 88f46043876e (bug 1709267)
2021-11-17 17:50:00 +02:00
Nicolas Chevobbe
70a89dbb2c Bug 1740455 - [devtools] Add a test for TabbingOrder highlighter. r=ochameau.
A new method is added in the HighlighterTestActor to retrieve information about
the highglighter.
The test highlights (pun intended) the issue described in Bug 1740509.

Differential Revision: https://phabricator.services.mozilla.com/D130875
2021-11-17 14:07:38 +00:00
Alexandre Poirot
aff1b7a2ce Bug 1709267 - [devtools] Add support for target switching in about:debugging. r=jdescottes
The challenges here are:
* xpcshell tests still don't support the watcher actor and server side targets. So we have to ensure still using client side target fetched via Descriptor.getTarget RDP request. (We still also need that for WebExtension)
* some tests weren't spawning the TargetCommand while querying TabDescriptor.getTarget. I tuned them to call TargetCommand.startListening so that we start instantiating server side targets, including the top level one retrieved via TabDescriptor.getTarget.

Otherwise, thanks to this patch a few check can now be moved from `if (isLocalTab)` to `if (isTabDescriptor)`.

Differential Revision: https://phabricator.services.mozilla.com/D130761
2021-11-17 14:05:15 +00:00
Alexandre Poirot
0fcb928cf6 Bug 1709267 - [devtools] Remove unused "target" query parameter from toolbox location. r=jdescottes
This wasn't used except for a test and wasn't working with server side targets.
Making this compatible with SST wasn't trivial, so I went for removing this.

Differential Revision: https://phabricator.services.mozilla.com/D130919
2021-11-17 14:05:15 +00:00
Julian Descottes
0e2fb01932 Bug 1741369 - [devtools] Import devtools require in head.js for some xpcshell test suites r=ochameau
Depends on D131218

Differential Revision: https://phabricator.services.mozilla.com/D131329
2021-11-17 12:43:27 +00:00
Julian Descottes
212faeb0c3 Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau
Depends on D131216

Differential Revision: https://phabricator.services.mozilla.com/D131217
2021-11-17 12:43:26 +00:00
Julian Descottes
2a2ef964fb Bug 1741369 - [devtools] Move all loader-related files to devtools/shared/loader r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D131216
2021-11-17 12:43:26 +00:00
Niklas Goegge
5d592a6adb Bug 1617611: Annotate each failing test individually. r=webdriver-reviewers,necko-reviewers,ckerschb,whimboo,valentin
Annotating each test individually lets us avoid introducing new failing tests
while we go through the backlog of failing tests.

Depends on D129162

Differential Revision: https://phabricator.services.mozilla.com/D129163
2021-11-17 11:04:34 +00:00
Julian Descottes
5b84fb14b0 Bug 1740281 - [devtools] Cancel node picker correctly when using client side shortcuts r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D131174
2021-11-17 10:56:39 +00:00
Markus Stange
7a7d1b26de Bug 1726281 - Allow symbolication WebChannel requests for profiler tabs that weren't opened by a profile capturing action. r=julienw
This makes it easier to symbolicate profiles that were captured to a file
without symbolication.

Differential Revision: https://phabricator.services.mozilla.com/D122928
2021-11-16 20:41:24 +00:00
Markus Stange
a9992f19f4 Bug 1625309 - Use /from-browser. r=julienw
This was implemented in https://github.com/firefox-devtools/profiler/pull/3466.

Differential Revision: https://phabricator.services.mozilla.com/D122923
2021-11-16 20:41:24 +00:00
Markus Stange
c6b6868ce0 Bug 1625309 - Make fake-frontend.html work with the WebChannel. r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D131189
2021-11-16 20:41:23 +00:00
Markus Stange
c9d0a2af2a Bug 1625309 - Remove the frame script and instead use the WebChannel to expose the profile and symbolication. r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D121933
2021-11-16 20:41:23 +00:00
Julian Descottes
d226afc848 Bug 1740438 - [devtools] Remove backward compatibility code for recordAllocations target configuration option r=devtools-reviewers,bomsy
Depends on D130847

Differential Revision: https://phabricator.services.mozilla.com/D130848
2021-11-16 14:34:27 +00:00
Julian Descottes
474ba47047 Bug 1740438 - [devtools] Remove backward compatibility code for clearPickerSupport trait r=devtools-reviewers,bomsy
Depends on D130846

Differential Revision: https://phabricator.services.mozilla.com/D130847
2021-11-16 14:34:27 +00:00
Julian Descottes
cbd04951b9 Bug 1740438 - [devtools] Remove backward compatibility code for typename browsingContextTarget r=devtools-reviewers,bomsy
Depends on D130845

Differential Revision: https://phabricator.services.mozilla.com/D130846
2021-11-16 14:34:26 +00:00
Julian Descottes
a33af7064f Bug 1740438 - [devtools] Remove backward compatibility code for useChildTargetToFetchChildren r=devtools-reviewers,bomsy
Depends on D130844

Differential Revision: https://phabricator.services.mozilla.com/D130845
2021-11-16 14:34:26 +00:00
Julian Descottes
4e5f134653 Bug 1740438 - [devtools] Remove backward compatibility code for event-breakpoints trait r=devtools-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D130844
2021-11-16 14:34:25 +00:00
criss
507f143b88 Backed out 2 changesets (bug 1617611) for causing mochitest failures on storageAccessWithDynamicFpi.js. CLOSED TREE
Backed out changeset fdb2c6bfc0c6 (bug 1617611)
Backed out changeset c3352f4b3681 (bug 1617611)
2021-11-16 13:02:05 +02:00
Niklas Goegge
5b684c7fc6 Bug 1617611: Annotate each failing test individually. r=webdriver-reviewers,necko-reviewers,ckerschb,whimboo,valentin
Annotating each test individually lets us avoid introducing new failing tests
while we go through the backlog of failing tests.

Depends on D129162

Differential Revision: https://phabricator.services.mozilla.com/D129163
2021-11-16 10:15:45 +00:00
Hubert Boma Manilla
de4e58224c Bug 1736366 - [devtools] Refactor the getBreakpointSources selector to no longer use makeShallowQuery r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D128742
2021-11-16 09:51:18 +00:00