See bug 1606660 comment 8 as to why checking it only in
Element.requestFullscreen is wrong.
Do you know how to test this? I'm not very familiar with feature-policy.
Differential Revision: https://phabricator.services.mozilla.com/D78567
Automatic update from web-platform-tests
Streams: fix IDL tests
The new idlharness tests for Streams (#22982) did not correctly instantiate all tested interfaces. This PR fixes them.
--
wpt-commits: e32f3a1e058335c5f4ad705b208f8e4610ad7b6c
wpt-pr: 24267
Automatic update from web-platform-tests
[mathml] Improve mathml/relations/html5-tree/dynamic-childlist-00*.html results
These tests add children to mspace, but mspace does not allow children. Nevertheless the internal framework, using Element.getBoundingClientRect, assert based on these disallowed children which get bounding boxes that are empty rects.
To fix this, special case mspace and only check size and that the children are empty and positioned at (0, 0).
Bug: 6606
Change-Id: Ic78720547f7e4909cf63ceeb92b3bfbf22d7e15b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256212
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#781296}
--
wpt-commits: a3c3821c5083d2fda1d00fa2a2fc577a2e2ec66e
wpt-pr: 24287
Automatic update from web-platform-tests
Test imports under more than 3 levels in different modules
--
wpt-commits: db6a91fe60f12f16540dff758abb20ee00be9d89
wpt-pr: 24284
Automatic update from web-platform-tests
Fix endianness problem in wasm-module-builder.js
--
wpt-commits: 5a8e4a343124e9ab4e9424b9ef096d7ae345080f
wpt-pr: 24308
Automatic update from web-platform-tests
Update html5lib from 1.0.1 to 1.1
--
Update html5lib from 1.0.1 to 1.1
--
wpt-commits: 469df8293287e713b4b8e1bfffea14395039b132, a877800a7788203dba2d0228bfd8f466fc821e6e
wpt-pr: 24303
Automatic update from web-platform-tests
Use the correct layout invalidation root in StyleEngine::InvalidateStyleAndLayoutForFontUpdates
The function currently uses the LayoutObject of the documentElement as
the layout invalidation root, which is incorrect because there can be
objects not in its subtree. For example, a modal dialog.
This patch fixes it by using the LayoutView, the root of the layout
tree, as the layout invalidation root.
Bug: 1092411
Change-Id: Ic2475fe1fc9fd9029699a410b4f03a9f3812e240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255738
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781132}
--
wpt-commits: 80aec473c19f40c879df56657c9c4ee6ed8959ca
wpt-pr: 24295
Automatic update from web-platform-tests
Use same/cross-site terminology for split cache WPT and minor changes
Changes the use of same/cross-origin to same/cross-site to reflect the
change in the approach. Accordingly, names helper files more
appropriately. Also makes the ordering of tests more natural and adds
descriptive names to each test.
Bug: 1092991
Change-Id: If9bebebea8b0b51db2d4f8c1c3ab1ddf1e2fb233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248867
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781090}
--
wpt-commits: 9e1358f2d09a75340b8e4b572e19f52e864f2790
wpt-pr: 24173
Automatic update from web-platform-tests
Revert "Don't reset computed 'float' for flex and grid items"
This reverts commit 906abd41e4f6c786a1927f6edd69d6926e20317b.
Reason for revert: A DCHECK was getting hit, causing a crash: https://bugs.chromium.org/p/chromium/issues/detail?id=1097595#c4
Original change's description:
> Don't reset computed 'float' for flex and grid items
>
> Floated flex and grid items have their 'float' incorrectly computed to
> "none". This change fixes this by adjusting IsFloating() for flex and
> grid items inside LayoutBox::UpdateFromStyle() instead of inside
> StyleAdjuster::AdjustStyleForDisplay().
>
> Beyond this, legend elements are not allowed to be rendered legends
> if they are floating. However, if legends are flex items, we
> adjust IsFloating() to be false. This causes legends to be
> used as rendered legends when they are flex items, even if they
> were styled as a float.
>
> This is fixed by checking ComputedStyle::IsFloating() instead
> of LayoutObject::IsFloating() when finding the rendered legend in
> order to get its non-adjusted floating value.
>
> Bug: 875235,350505
> Change-Id: Ia1e7f7c244cc0c443cd58be42854866884b7f7e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157889
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Commit-Queue: Alison Maher <almaher@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#763988}
TBR=cbiesinger@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org,almaher@microsoft.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 875235, 350505, 1097595
Change-Id: I5e5ff8a93d1e1e46908f9b640b9564e70345e9e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256772
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#780995}
--
wpt-commits: 9f6b1348c4216fb3597f1ebab3f4b06091cd7ab9
wpt-pr: 24296
Automatic update from web-platform-tests
Fixes Heap-use-after-free in ImageResourceContent::PriorityFromObservers
Prior to this CL, asynchronously applying and removing a CSS property
containing image content to an ImageInputType that's rendered as
fallback content causes heap use after use exception in
ImageResourceContent when it tries to access its ImageResourceObserver.
See minimized repro case in bug for details in the use case.
This is a regression caused by my fix [1] to bug 948066.
With the previous fix [1], the above case triggers a call into
LayoutObject [2] from ImageInputType::CreateLayoutObject() which
instead of creating a LayoutObject for its fallback content, it creates
a LayoutImage instead. This is clearly wrong. I spend some time
debugging into the lifecycle of LayoutImage, ImageResourceContent and
ImageResourceObserver but didn't track down the cause of the stale
ImageResourceObserver. Regardless, the fix is to not use
LayoutObject::CreateObject() directly, but to create layout object
subclass to render the fallback content.
[1] https://crrev.com/c/2212963
[2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/layout_object.cc;l=210;drc=0a03e5eb198d0485b8cc023dbc24fd17c16c9629;bpv=0;bpt=1
Bug: 1096002
Change-Id: If059a694c9a60fb6563a446b0250532e6d19f1c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255311
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780992}
--
wpt-commits: 4c2a6361679794417423fe7cbae70f42cc73d468
wpt-pr: 24290
Automatic update from web-platform-tests
Don't navigate to jsurls with pending form submission
In the case where a javascript: url is executed and submits a form
inside the execution and also returns a value, the form submission
should take precedence over the javascript: url's return value.
Although I could have made HasProvisionalNavigation return true instead
of adding a separate check for pending form submissions, I'm afraid to
do this because I don't know how it will affect the other places that
use HasProvisionalNavigation. I already have a bug open to track this,
and I will give it a shot after things with form submission settle down
more.
Bug: 1087431
Change-Id: If2761952b9a03f4193efb822ecf3db4fabc10f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248485
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780955}
--
wpt-commits: 4016b193377912783e86b8579eb271aff15c002f
wpt-pr: 24255
Automatic update from web-platform-tests
Origin isolation: test initial about:blank
The initial about:blank inheriting its origin from the parent is a
rather special case, and deserves its own tests when origin isolation
is involved.
Bug: 1042415
Change-Id: I6c7d41e05b601bd1044f1c70f1ee7c75a44ffb14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255519
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780830}
--
wpt-commits: e61900f7d9d57595a17f067bc3b14073bf30d366
wpt-pr: 24261
Automatic update from web-platform-tests
Origin isolation: test location.href access
location.href access is one of the things that is guarded by the
"same-origin domain" check, but it goes down a different code path
than generic synchronous property access such as we test with
window.document. So, it's worth testing it additionally.
Bug: 1042415
Change-Id: I92fc222f895bf25fc1767e7ffddd3d7f7f1f1e86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255102
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780787}
--
wpt-commits: 30dda6576f9858b77e9e3bf96a551ad135bfd2a7
wpt-pr: 24259
