Commit Graph

70283 Commits

Author SHA1 Message Date
Ting-Yu Lin
c46186dcef Bug 1514584 - Remove non-existing img src in column-balancing-overflow-003.html and its reference. r=dholbert
`image-short.png` never exists in the first place when this test was
introduced, so the intermittent happens when the test file shows a
broken image icon and the reference file without, or the other way
around.

I believe the `<img>` is served as a monolithic element to overflow
`<div class="short">`. Use an empty src should suffice.

Differential Revision: https://phabricator.services.mozilla.com/D46640

--HG--
extra : moz-landing-system : lando
2019-09-20 19:06:13 +00:00
Agi Sferro
731917effd Bug 1570115 - Allow Actors to implement WebBrowserChrome. r=kmag,snorp
Differential Revision: https://phabricator.services.mozilla.com/D44052

--HG--
extra : moz-landing-system : lando
2019-09-20 18:15:18 +00:00
Agi Sferro
ebe6d184ab Bug 1570115 - Move LoadURIDelegate to Actor. r=kmag,snorp
Differential Revision: https://phabricator.services.mozilla.com/D44051

--HG--
extra : moz-landing-system : lando
2019-09-20 18:15:25 +00:00
Lee Salzman
2770b6301a Bug 1582231 - remove Moz2D dependency on Cairo glyph extents. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D46332

--HG--
extra : moz-landing-system : lando
2019-09-20 16:30:21 +00:00
Hiroyuki Ikezoe
8bec65b647 Bug 1541256 - Returns an empty screen rect from GetFrameVisibleRectOnScreen if the given nsIFrame is in out-of-process even if the corresponding iframe is totally invisbile. r=tnikkel
We need to distinguish between the out-of-process iframe is totally invisible and
the given nsIFrame is not in out-of-process iframes.

Differential Revision: https://phabricator.services.mozilla.com/D46553

--HG--
extra : source : fc785139655e3d22d681f1419bd4c80f93460f0e
2019-09-20 11:33:00 +00:00
Jonathan Kew
9d6bf431e5 Bug 1580690 - Ensure src:local() entries in the user font set are refreshed if the platform font list is rebuilt. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D46580

--HG--
extra : moz-landing-system : lando
2019-09-20 15:24:33 +00:00
Andreea Pavel
1f18f66226 Backed out 2 changesets (bug 1541256) for failing browser_deck_has_out_of_process_iframe.js on a CLOSED TREE
Backed out changeset 691c50b5729a (bug 1541256)
Backed out changeset fc785139655e (bug 1541256)
2019-09-20 18:15:15 +03:00
Hiroyuki Ikezoe
1329c9e502 Bug 1541256 - Returns an empty screen rect from GetFrameVisibleRectOnScreen if the given nsIFrame is in out-of-process even if the corresponding iframe is totally invisbile. r=tnikkel
We need to distinguish between the out-of-process iframe is totally invisible and
the given nsIFrame is not in out-of-process iframes.

Differential Revision: https://phabricator.services.mozilla.com/D46553

--HG--
extra : moz-landing-system : lando
2019-09-20 11:33:00 +00:00
Daniel Varga
bc19cdb06d Backed out 3 changesets (bug 1578355) for build bustage at build/src/dom/base/nsSyncLoadService.h:48:21. On a CLOSED TREE
Backed out changeset d50ad759f129 (bug 1578355)
Backed out changeset 339ab54ca471 (bug 1578355)
Backed out changeset 284299dac42c (bug 1578355)
2019-09-20 14:05:12 +03:00
Edgar Chen
5b6fe53148 Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45168

--HG--
extra : moz-landing-system : lando
2019-09-20 10:31:55 +00:00
Daniel Varga
ebca709c01 Merge mozilla-central to autoland. On a CLOSED TREE 2019-09-20 12:55:32 +03:00
Andreea Pavel
e18057a961 Merge mozilla-inbound to mozilla-central. a=merge 2019-09-20 12:48:30 +03:00
Daniel Varga
f0411a344a Backed out 6 changesets (bug 1553804) for browser-chrome failure at browser/base/content/test/general/browser_fullscreen-window-open.js. On a CLOSED TREE
Backed out changeset 86b3d469b4ff (bug 1553804)
Backed out changeset 301e0d883a5f (bug 1553804)
Backed out changeset acff4a663671 (bug 1553804)
Backed out changeset 1574aecf3177 (bug 1553804)
Backed out changeset 3acf056e792e (bug 1553804)
Backed out changeset 1ed250faeb2e (bug 1553804)
2019-09-20 10:09:54 +03:00
Emilio Cobos Álvarez
b427bb0b08 No bug - Remove a silly LOG_ENABLED() check.
LOG() already checks that.

MANUAL PUSH: trivial
2019-09-20 15:36:22 +09:00
Kris Maglione
ee31fee500 Bug 1582523: Part 2 - Update tests which rely on OOP frames blocking load. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D46504

MANUAL PUSH: Still cannot update reopened Phabricator revisions.

--HG--
extra : source : 2e8fcb1718611e8ce81e7c83fb480d664000c2cc
extra : histedit_source : 29005a64bf92828ed472f378d36feff98d3d3a9f
2019-09-19 11:50:45 -07:00
Andreea Pavel
5b9c485d55 Backed out 2 changesets (bug 1582523) for build bustages at ContentChild.cpp on a CLOSED TREE
Backed out changeset 72ca7d054061 (bug 1582523)
Backed out changeset a6c10aa450ba (bug 1582523)
2019-09-20 08:45:25 +03:00
Kris Maglione
afef6a355c Bug 1582523: Part 2 - Update tests which rely on OOP frames blocking load. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D46504

--HG--
extra : moz-landing-system : lando
2019-09-19 20:57:51 +00:00
Kris Maglione
136131d397 Bug 1553804: Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D45828

--HG--
extra : moz-landing-system : lando
2019-09-20 04:44:02 +00:00
Emilio Cobos Álvarez
a2f95a081c Bug 1578151 - Factor out the "containing block did not really change" code from CalcStyleDifference. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D44351

--HG--
extra : moz-landing-system : lando
2019-09-20 05:06:49 +00:00
Daniel Holbert
99952c0744 Bug 1580012: In css 'display' blockification codepath, leave -moz-box alone and promote -moz-inline-box to -moz-box (if a new pref is set). r=emilio
This is in the interests of allowing the frontend team to experiment with
switching from XUL grid to CSS grid, without inadvertently changing the
display values for the grid items via css-grid-item blockification.

This patch's new pref is not expected to remain in the codebase for long.
We're just adding it so that the behavior remains the same by default, because
we do currently have some XUL code that inadvertently depends on -moz-box
display values being blockified to 'block'.  The plan is for folks to remove
that dependency e.g. by adding explicit 'display:block' styling to frontend
code as-needed. After we've done that, we can tentatively flip the pref to true
by default, and then remove the pref entirely.

Differential Revision: https://phabricator.services.mozilla.com/D45258

--HG--
extra : moz-landing-system : lando
2019-09-19 03:58:53 +00:00
Ting-Yu Lin
977a6275d1 Bug 1582224 - Split SIDEWAYS bit in WritingMode. r=jfkthame,emilio
Currently, there's no way to tell whether the SIDEWAYS bit is set from
`writing-mode:sideways-*` or `writing-mode:vertical-*; text-orientation:sideways;`.
To be able to tell them apart, split SIDEWAYS bits into VERTICAL_SIDEWAYS
and TEXT_SIDEWAYS. This is needed by my proposed solution in bug 1102175.

Also, provide convenience methods related to sideways writing-mode, and replace
obscure checks in the codebase.

Note that we don't have the use cases to distinguish vertical-rl from
sideways-rl in layout, but for the completeness, IsSidewaysLR() is still
defined.

Differential Revision: https://phabricator.services.mozilla.com/D46321

--HG--
extra : moz-landing-system : lando
2019-09-19 02:37:14 +00:00
Jonathan Kew
bca3c87cf1 Bug 1472328 - Check if we're already at the end of the frame's content. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D45924

--HG--
extra : moz-landing-system : lando
2019-09-16 19:07:00 +00:00
Daniel Holbert
6adb0e04b4 Bug 1580302: Treat all flex items and grid items as being block-level in ReflowInput::InitConstraints. r=mats
In particular: in our frontend code, if we happen to end up with a flex/grid
item with 'display:-moz-box', we want it to take the same sizing codepath as
other flex/grid items, which are all block-level (even though -moz-box is not
exactly block-level itself). Notably, we want to use ComputeSizeFlags::eDefault
for sizing (like we do for real block-level things), because that's necessary
in order for grid items to stretch correctly in their inline axis.

Also: this patch renames "isBlock" to "isBlockLevel" to reflect reality. Its
naming is based on the constant NS_CSS_FRAME_TYPE_BLOCK, which in fact is not
specific to 'display:block' but in fact is for frames that are "block-level in
normal flow" (which I think in practice means block-level and not
out-of-flow). That is documented here:
https://searchfox.org/mozilla-central/rev/7531325c8660cfa61bf71725f83501028178cbb9/layout/generic/ReflowInput.h#51

Differential Revision: https://phabricator.services.mozilla.com/D46539

--HG--
extra : moz-landing-system : lando
2019-09-19 23:43:55 +00:00
Timothy Nikkel
239c12b7f0 Bug 1582528. Restrict visual and dirty rect when building the display list for svg contents that cannot overflow. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D46555

--HG--
extra : moz-landing-system : lando
2019-09-20 02:05:35 +00:00
Emilio Cobos Álvarez
6c211da0ae Bug 1582374 - Add a warning when we find usage of the CSS zoom property. r=smaug,flod
Now that we count them, I think we should do this.

This property is pretty painful for various reasons:

 * It's a pretty awkward non-standard property.
 * Has a pretty short name, so people use it instead of the standard
   alternatives.
 * We cannot really even implement it easily anyhow, without breaking a whole
   bunch of stuff, because pages do things like:

```
myelement {
  zoom: 0.5;
  -moz-transform: scale(0.5);
  transform-origin: 0 0;
}
```

For now this is only recorded when CSS use counters are enabled (Nightly for
now), but I want to change it once bug 1578661 is in central.

The hope is that this warning slightly raises awareness of this property not
being standard. You get a CSS parsing error in the console, but those are
usually too noisy and disabled by default.

Differential Revision: https://phabricator.services.mozilla.com/D46430

--HG--
extra : moz-landing-system : lando
2019-09-20 01:31:35 +00:00
Bogdan Tara
4ba431cc02 Backed out changeset 928b755ef57b (bug 1539212) for backplate-bg-image-006.html failures 2019-09-20 03:59:03 +03:00
Adam Gashlin
7f498141e7 Bug 1561546 Part 2 - Update theme when nsXPLookAndFeel prefs change. r=dholbert,jmathies
Also causes removing a pref to take effect immediately, and prevents
losing all color pref overrides when the theme changes.

Differential Revision: https://phabricator.services.mozilla.com/D44416

--HG--
extra : moz-landing-system : lando
2019-09-19 19:05:01 +00:00
Alexander Surkov
322bf35c3e Bug 1555497 - Remove menupopup binding, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33282

--HG--
extra : moz-landing-system : lando
2019-09-19 02:13:43 +00:00
Morgan Reschenberg
b20a6706d3 Bug 1539212: Add readability backplate for all elements containing text when HCM or a11y theme is active. r=dholbert,mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D42979

--HG--
extra : moz-landing-system : lando
2019-09-19 21:25:12 +00:00
Emilio Cobos Álvarez
95582debce Bug 1578661 - Report counted unknown properties as well. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D44717

--HG--
extra : moz-landing-system : lando
2019-09-19 00:20:04 +00:00
Emilio Cobos Álvarez
1e858d2a04 Bug 1578661 - Fix use counter test. r=boris
By reporting the properties in MappedAttrParser that we used to (the test relies
on counting those), and by adjusting the histogram name to the new thing.

Differential Revision: https://phabricator.services.mozilla.com/D44697

--HG--
extra : moz-landing-system : lando
2019-09-19 00:20:39 +00:00
Emilio Cobos Álvarez
31755a845c Bug 1578661 - Remove old CSS use counters. r=boris
We only have two counters enabled, just for testing, and they just count from
the SVG mapped attribute code. That's not great, and they mostly complicate the
next few patches.

Differential Revision: https://phabricator.services.mozilla.com/D44695

--HG--
extra : moz-landing-system : lando
2019-09-19 00:20:35 +00:00
Randall E. Barker
421fb7c1ea Bug 1578947 - Add onFirstContentfulPaint() to GeckoView#ContentDelegate r=geckoview-reviewers,smaug,agi,snorp
Differential Revision: https://phabricator.services.mozilla.com/D46230

--HG--
extra : moz-landing-system : lando
2019-09-18 22:45:30 +00:00
Cosmin Sabou
2978a72248 Backed out 10 changesets (bug 1578661) for linting failures on layout/style/ServoCSSPropList.py. CLOSED TREE
Backed out changeset b1b5393b1099 (bug 1578661)
Backed out changeset b87eebb0cf6e (bug 1578661)
Backed out changeset 6ba2ee45f26e (bug 1578661)
Backed out changeset 4a1d45160d60 (bug 1578661)
Backed out changeset 7a5687bebc02 (bug 1578661)
Backed out changeset 33c306c9020a (bug 1578661)
Backed out changeset 89d7e6fb24b0 (bug 1578661)
Backed out changeset 42c4943e569b (bug 1578661)
Backed out changeset 88d988a80de1 (bug 1578661)
Backed out changeset 78c90f9e9eee (bug 1578661)
2019-09-19 01:50:03 +03:00
arthur.iakab
798ce0d7f2 Backed out changeset 16f534a22bc6 (bug 1578947) for causing lint failure on ServoCSSPropList.py CLOSED TREE 2019-09-19 00:56:49 +03:00
Randall E. Barker
06b876b520 Bug 1578947 - Add onFirstContentfulPaint() to GeckoView#ContentDelegate r=geckoview-reviewers,smaug,agi,snorp
Differential Revision: https://phabricator.services.mozilla.com/D46230

--HG--
extra : moz-landing-system : lando
2019-09-18 21:37:44 +00:00
Jonathan Kew
41bb7b54b7 Bug 1582016 - When text-underline-offset is auto, clamp the minimum used underline-offset to 1/16em. r=dholbert
This is to avoid skip-ink problems with fonts that leave the OpenType field at zero,
which is unlikely to ever be what is really wanted. Authors can still avoid the clamp by
explicitly using text-underline-offset:from-font.

Differential Revision: https://phabricator.services.mozilla.com/D46268

--HG--
extra : moz-landing-system : lando
2019-09-18 17:31:14 +00:00
Nicolas Silva
72cdad8784 Bug 1581804 - Adjust webrender+geckoview reftest thresholds after blob recoordination changes. r=jnicol
Differential Revision: https://phabricator.services.mozilla.com/D46142

--HG--
extra : moz-landing-system : lando
2019-09-18 16:23:59 +00:00
Emilio Cobos Álvarez
4ce6b69adf Bug 1578661 - Report counted unknown properties as well. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D44717

--HG--
extra : moz-landing-system : lando
2019-09-18 15:15:15 +00:00
Emilio Cobos Álvarez
2adb14b20a Bug 1578661 - Fix use counter test. r=boris
By reporting the properties in MappedAttrParser that we used to (the test relies
on counting those), and by adjusting the histogram name to the new thing.

Differential Revision: https://phabricator.services.mozilla.com/D44697

--HG--
extra : moz-landing-system : lando
2019-09-18 15:15:26 +00:00
Emilio Cobos Álvarez
6a2a92e98a Bug 1578661 - Remove old CSS use counters. r=boris
We only have two counters enabled, just for testing, and they just count from
the SVG mapped attribute code. That's not great, and they mostly complicate the
next few patches.

Differential Revision: https://phabricator.services.mozilla.com/D44695

--HG--
extra : moz-landing-system : lando
2019-09-18 15:15:19 +00:00
Andreea Pavel
7494b360c0 Backed out 10 changesets (bug 1578661) for lints failure at ServoCSSPropList.cpp on a CLOSED TREE
Backed out changeset ed3c619100e7 (bug 1578661)
Backed out changeset 027514a2eaf6 (bug 1578661)
Backed out changeset f2e228282b20 (bug 1578661)
Backed out changeset 67c36136dce7 (bug 1578661)
Backed out changeset 2280b27cc130 (bug 1578661)
Backed out changeset 445d13a2c452 (bug 1578661)
Backed out changeset 89caaa850049 (bug 1578661)
Backed out changeset 2f8be5db1786 (bug 1578661)
Backed out changeset 51a015a9a0f8 (bug 1578661)
Backed out changeset ad8e1f27a600 (bug 1578661)
2019-09-18 18:09:30 +03:00
Emilio Cobos Álvarez
30e754a811 Bug 1578661 - Report counted unknown properties as well. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D44717

--HG--
extra : moz-landing-system : lando
2019-09-18 12:04:48 +00:00
Emilio Cobos Álvarez
959c99b520 Bug 1578661 - Fix use counter test. r=boris
By reporting the properties in MappedAttrParser that we used to (the test relies
on counting those), and by adjusting the histogram name to the new thing.

Differential Revision: https://phabricator.services.mozilla.com/D44697

--HG--
extra : moz-landing-system : lando
2019-09-18 12:04:37 +00:00
Emilio Cobos Álvarez
d880111e86 Bug 1578661 - Remove old CSS use counters. r=boris
We only have two counters enabled, just for testing, and they just count from
the SVG mapped attribute code. That's not great, and they mostly complicate the
next few patches.

Differential Revision: https://phabricator.services.mozilla.com/D44695

--HG--
extra : moz-landing-system : lando
2019-09-18 12:04:33 +00:00
Mihai Alexandru Michis
7bed28e9e2 Merge mozilla-central to autoland. 2019-09-18 14:47:25 +03:00
Andreea Pavel
31ca3fda59 Backed out 9 changesets (bug 1578661) for lints failure at ServoCSSPropList.py a=backout
Backed out changeset d16463e5698c (bug 1578661)
Backed out changeset c6d64ac858ba (bug 1578661)
Backed out changeset db306f1467f7 (bug 1578661)
Backed out changeset 273535aab82d (bug 1578661)
Backed out changeset f643262a8c25 (bug 1578661)
Backed out changeset b0db409ada96 (bug 1578661)
Backed out changeset dc96d13728e0 (bug 1578661)
Backed out changeset 11e1e8f0a1b7 (bug 1578661)
Backed out changeset 6dd7a0d914d9 (bug 1578661)
2019-09-18 13:53:34 +03:00
Henri Sivonen
c193518677 Bug 1490601 part 2 - Move C++ entry points to encoding_c_mem to mfbt/. r=jwalden
Differential Revision: https://phabricator.services.mozilla.com/D43957

--HG--
extra : moz-landing-system : lando
2019-09-18 08:26:34 +00:00
Emilio Cobos Álvarez
5ebe1a5793 Bug 1578661 - Report counted unknown properties as well. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D44717

--HG--
extra : moz-landing-system : lando
2019-09-18 02:31:25 +00:00
Emilio Cobos Álvarez
f8337abcef Bug 1578661 - Fix use counter test. r=boris
By reporting the properties in MappedAttrParser that we used to (the test relies
on counting those), and by adjusting the histogram name to the new thing.

Differential Revision: https://phabricator.services.mozilla.com/D44697

--HG--
extra : moz-landing-system : lando
2019-09-18 02:31:19 +00:00