Commit Graph

5233 Commits

Author SHA1 Message Date
Aaron Klotz
4f7aaf1573 Bug 1542830: Part 3 - Add ntdll_freestanding.lib to freestanding; r=mhowell,froydnj
The `freestanding` library is built with specific compiler flags to signify
that it is indeed freestanding code. That is, it does not depend on a
standard library.

One of the requirements of freestanding code is that the toolchain still
expects implementations of `memcpy`, `memmove`, `memcmp`, and `memset`.

I did briefly implement my own naive versions of these functions, but that
solution is less than ideal since the implementations must be `extern` and are
thus picked up by the entire `firefox.exe` binary. This denies the rest of
`firefox.exe` the benefit of optimized implementations. On Windows, the
sandbox is linked into `firefox.exe`, so we cannot just shrug and
assume that naive implementations will not have any effect on anything.

There are, however, optimized implementations of these functions that are
exported by `ntdll.dll`. They are not included in the `ntdll.lib` that is
included in the Windows SDK. Using `llvm-dlltool`, we can build an import
library containing the missing entries and then add that library to `OS_LIBS`.

Differential Revision: https://phabricator.services.mozilla.com/D43157

--HG--
extra : moz-landing-system : lando
2019-09-20 19:43:21 +00:00
Ciure Andrei
7db4ad5d80 Backed out 8 changesets (bug 1542830) for causing spidermonkey bustages CLOSED TREE
Backed out changeset b9f7fc8d0172 (bug 1542830)
Backed out changeset b85f58fd5bbd (bug 1542830)
Backed out changeset 0a9169ab2623 (bug 1542830)
Backed out changeset 39a7c05d54ef (bug 1542830)
Backed out changeset 7a3cbd2f59f0 (bug 1542830)
Backed out changeset 268530552281 (bug 1542830)
Backed out changeset df658ffb8599 (bug 1542830)
Backed out changeset e7bef6486a38 (bug 1542830)

--HG--
rename : browser/app/winlauncher/freestanding/DllBlocklist.cpp => browser/app/winlauncher/DllBlocklistWin.cpp
rename : browser/app/winlauncher/freestanding/DllBlocklist.h => browser/app/winlauncher/DllBlocklistWin.h
rename : mozglue/dllservices/Authenticode.cpp => mozglue/build/Authenticode.cpp
rename : mozglue/dllservices/Authenticode.h => mozglue/build/Authenticode.h
rename : mozglue/misc/WinUtils.h => mozglue/build/MozglueUtils.h
rename : mozglue/dllservices/WindowsDllBlocklist.cpp => mozglue/build/WindowsDllBlocklist.cpp
rename : mozglue/dllservices/WindowsDllBlocklist.h => mozglue/build/WindowsDllBlocklist.h
rename : mozglue/dllservices/WindowsDllBlocklistCommon.h => mozglue/build/WindowsDllBlocklistCommon.h
rename : mozglue/dllservices/WindowsDllBlocklistDefs.in => mozglue/build/WindowsDllBlocklistDefs.in
rename : mozglue/dllservices/WindowsDllServices.h => mozglue/build/WindowsDllServices.h
rename : mozglue/dllservices/gen_dll_blocklist_defs.py => mozglue/build/gen_dll_blocklist_defs.py
rename : toolkit/components/telemetry/docs/data/third-party-modules-ping.rst => toolkit/components/telemetry/docs/data/untrusted-modules-ping.rst
rename : toolkit/components/telemetry/tests/unit/test_ThirdPartyModulesPing.js => toolkit/components/telemetry/tests/unit/test_UntrustedModulesPing.js
rename : toolkit/xre/UntrustedModulesProcessor.cpp => toolkit/xre/ModuleEvaluator_windows.cpp
rename : toolkit/xre/UntrustedModulesProcessor.h => toolkit/xre/ModuleEvaluator_windows.h
rename : toolkit/xre/ModuleVersionInfo.cpp => toolkit/xre/ModuleVersionInfo_windows.cpp
rename : toolkit/xre/ModuleVersionInfo.h => toolkit/xre/ModuleVersionInfo_windows.h
2019-09-20 21:21:39 +03:00
Aaron Klotz
1d681f2935 Bug 1542830: Part 3 - Add ntdll_freestanding.lib to freestanding; r=mhowell,froydnj
The `freestanding` library is built with specific compiler flags to signify
that it is indeed freestanding code. That is, it does not depend on a
standard library.

One of the requirements of freestanding code is that the toolchain still
expects implementations of `memcpy`, `memmove`, `memcmp`, and `memset`.

I did briefly implement my own naive versions of these functions, but that
solution is less than ideal since the implementations must be `extern` and are
thus picked up by the entire `firefox.exe` binary. This denies the rest of
`firefox.exe` the benefit of optimized implementations. On Windows, the
sandbox is linked into `firefox.exe`, so we cannot just shrug and
assume that naive implementations will not have any effect on anything.

There are, however, optimized implementations of these functions that are
exported by `ntdll.dll`. They are not included in the `ntdll.lib` that is
included in the Windows SDK. Using `llvm-dlltool`, we can build an import
library containing the missing entries and then add that library to `OS_LIBS`.

Differential Revision: https://phabricator.services.mozilla.com/D43157

--HG--
extra : moz-landing-system : lando
2019-09-20 16:59:57 +00:00
Andreea Pavel
31d9596a28 Backed out 8 changesets (bug 1542830) for gecko decision failure on a CLOSED TREE
DONTBUILD

Backed out changeset 4f72161be496 (bug 1542830)
Backed out changeset 7ee12138946d (bug 1542830)
Backed out changeset 9e90ee4981c6 (bug 1542830)
Backed out changeset 363039c98534 (bug 1542830)
Backed out changeset 70ffff30551a (bug 1542830)
Backed out changeset c25b7bf354d9 (bug 1542830)
Backed out changeset d156dc595b69 (bug 1542830)
Backed out changeset 9f5dbd1b2959 (bug 1542830)

--HG--
rename : browser/app/winlauncher/freestanding/DllBlocklist.cpp => browser/app/winlauncher/DllBlocklistWin.cpp
rename : browser/app/winlauncher/freestanding/DllBlocklist.h => browser/app/winlauncher/DllBlocklistWin.h
rename : mozglue/dllservices/Authenticode.cpp => mozglue/build/Authenticode.cpp
rename : mozglue/dllservices/Authenticode.h => mozglue/build/Authenticode.h
rename : mozglue/misc/WinUtils.h => mozglue/build/MozglueUtils.h
rename : mozglue/dllservices/WindowsDllBlocklist.cpp => mozglue/build/WindowsDllBlocklist.cpp
rename : mozglue/dllservices/WindowsDllBlocklist.h => mozglue/build/WindowsDllBlocklist.h
rename : mozglue/dllservices/WindowsDllBlocklistCommon.h => mozglue/build/WindowsDllBlocklistCommon.h
rename : mozglue/dllservices/WindowsDllBlocklistDefs.in => mozglue/build/WindowsDllBlocklistDefs.in
rename : mozglue/dllservices/WindowsDllServices.h => mozglue/build/WindowsDllServices.h
rename : mozglue/dllservices/gen_dll_blocklist_defs.py => mozglue/build/gen_dll_blocklist_defs.py
rename : toolkit/components/telemetry/docs/data/third-party-modules-ping.rst => toolkit/components/telemetry/docs/data/untrusted-modules-ping.rst
rename : toolkit/components/telemetry/tests/unit/test_ThirdPartyModulesPing.js => toolkit/components/telemetry/tests/unit/test_UntrustedModulesPing.js
rename : toolkit/xre/UntrustedModulesProcessor.cpp => toolkit/xre/ModuleEvaluator_windows.cpp
rename : toolkit/xre/UntrustedModulesProcessor.h => toolkit/xre/ModuleEvaluator_windows.h
rename : toolkit/xre/ModuleVersionInfo.cpp => toolkit/xre/ModuleVersionInfo_windows.cpp
rename : toolkit/xre/ModuleVersionInfo.h => toolkit/xre/ModuleVersionInfo_windows.h
2019-09-20 19:49:27 +03:00
Aaron Klotz
64eef06887 Bug 1542830: Part 3 - Add ntdll_freestanding.lib to freestanding; r=mhowell,froydnj
The `freestanding` library is built with specific compiler flags to signify
that it is indeed freestanding code. That is, it does not depend on a
standard library.

One of the requirements of freestanding code is that the toolchain still
expects implementations of `memcpy`, `memmove`, `memcmp`, and `memset`.

I did briefly implement my own naive versions of these functions, but that
solution is less than ideal since the implementations must be `extern` and are
thus picked up by the entire `firefox.exe` binary. This denies the rest of
`firefox.exe` the benefit of optimized implementations. On Windows, the
sandbox is linked into `firefox.exe`, so we cannot just shrug and
assume that naive implementations will not have any effect on anything.

There are, however, optimized implementations of these functions that are
exported by `ntdll.dll`. They are not included in the `ntdll.lib` that is
included in the Windows SDK. Using `llvm-dlltool`, we can build an import
library containing the missing entries and then add that library to `OS_LIBS`.

Differential Revision: https://phabricator.services.mozilla.com/D43157

--HG--
extra : moz-landing-system : lando
2019-09-20 00:09:39 +00:00
Mike Hommey
7a952b88db Bug 1579471 - Remove the in-tree .cargo/config. r=mshal
It was added in bug 1575760 and turns out to be causing a lot more
problems than anticipated.

However, the previous status quo is also not ideal, so we do
auto-generate .cargo/config.in instead, with a little trick that allows
to just copy it to .cargo/config instead of how individual scripts would
previously manually preprocess it.

Differential Revision: https://phabricator.services.mozilla.com/D46138

--HG--
extra : moz-landing-system : lando
2019-09-20 00:47:22 +00:00
Nicholas Nethercote
91294276b6 Bug 1579775 - Extend testing of #filter slashslash. r=glandium
Depends on D45152

Differential Revision: https://phabricator.services.mozilla.com/D45153

--HG--
extra : moz-landing-system : lando
2019-09-18 02:44:32 +00:00
Nicholas Nethercote
d2520b74ee Bug 1579775 - Improve some comments in preprocessor.py. r=glandium
In particular, there was some weird use of blank lines.

Differential Revision: https://phabricator.services.mozilla.com/D45152

--HG--
extra : moz-landing-system : lando
2019-09-18 02:43:48 +00:00
Erica Wright
b575a6d9a1 Bug 1581428 - Show tooltips for links in Protection Report. r=fluent-reviewers,johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D46215

--HG--
extra : moz-landing-system : lando
2019-09-18 21:39:43 +00:00
Andrew Halberstadt
0ff26e43bb Bug 1579455 - [mozbuild] Create distinct 'init' virtualenvs for Python 2 vs 3 r=nalexander,chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D45419

--HG--
extra : moz-landing-system : lando
2019-09-18 17:13:47 +00:00
Andrew Halberstadt
274c70df70 Bug 1579455 - [mozbuild] Fix output issues with Python 3 in virtualenv.py r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D45418

--HG--
extra : moz-landing-system : lando
2019-09-16 16:52:55 +00:00
Zibi Braniecki
f421461cc8 Bug 1581185 - Migrate pageActionContextMenu in browser.xhtml to Fluent. r=fluent-reviewers,bgrins,flod
Differential Revision: https://phabricator.services.mozilla.com/D45881

--HG--
extra : moz-landing-system : lando
2019-09-18 16:53:54 +00:00
Zibi Braniecki
ccb7771759 Bug 1581185 - Fix relative paths in migration script generation. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D45880

--HG--
extra : moz-landing-system : lando
2019-09-18 16:55:02 +00:00
Andreea Pavel
aa63cb5bb5 Backed out 2 changesets (bug 1581185) for linting failure at xul.py on a CLOSED TREE
Backed out changeset 86f77b5cc705 (bug 1581185)
Backed out changeset 5bb71874a9f3 (bug 1581185)
2019-09-18 19:43:45 +03:00
Zibi Braniecki
92b3a465b8 Bug 1581185 - Migrate pageActionContextMenu in browser.xhtml to Fluent. r=fluent-reviewers,bgrins,flod
Differential Revision: https://phabricator.services.mozilla.com/D45881

--HG--
extra : moz-landing-system : lando
2019-09-18 16:25:27 +00:00
Zibi Braniecki
24d44bff69 Bug 1581185 - Fix relative paths in migration script generation. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D45880

--HG--
extra : moz-landing-system : lando
2019-09-18 16:25:17 +00:00
Andreea Pavel
f09273c694 Backed out changeset 8c4399f3a332 (bug 1581428) for failing browser_protections_report_ui.js on a CLOSED TREE 2019-09-18 19:17:52 +03:00
Dzmitry Malyshau
ee04e8a14a Bug 1581921 - Support Solus Linux by mach bootstrap r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D46190

--HG--
extra : moz-landing-system : lando
2019-09-18 15:12:37 +00:00
Erica Wright
049e9d1b0b Bug 1581428 - Show tooltips for links in Protection Report. r=fluent-reviewers,johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D46215

--HG--
extra : moz-landing-system : lando
2019-09-18 12:33:08 +00:00
Nathan Froyd
94691b7a75 Bug 1582114 - add the Zlib license to permitted licenses for Rust crates; r=mhoye
New releases of the `adler32-rs` crate have this license, and we already
incorporate zlib into Firefox, so crates using this license should be allowed.

..and since `adler32-rs` now has an obviously acceptable license, we can
remove it from the list of build-time exceptions.

Differential Revision: https://phabricator.services.mozilla.com/D46283

--HG--
extra : moz-landing-system : lando
2019-09-18 14:02:18 +00:00
Ciure Andrei
f16f5c928d Backed out changeset 7cf84cb03658 (bug 1581921) for causing a lint issue in bootstrap.py CLOSED TREE 2019-09-18 16:55:49 +03:00
Dzmitry Malyshau
e9b3f1eaec Bug 1581921 - Support Solus Linux by mach bootstrap r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D46190

--HG--
extra : moz-landing-system : lando
2019-09-18 13:38:30 +00:00
Kevin Jacobs
671a4b685e Bug 1562773 - Add delegated credentials tests r=keeler,jcj
Add xpcshell tests for Delegated Credentials

Differential Revision: https://phabricator.services.mozilla.com/D37918

--HG--
extra : moz-landing-system : lando
2019-09-17 23:31:36 +00:00
Nick Alexander
b28d70119a Bug 1580996 - Make artifact builds fetch Android artifacts from geckoview_example.apk. r=froydnj
The underlying native libraries are identical between Fennec and
GeckoView example.  This paves the way for removing Fennec entirely.

At the same, remove the `.ini` extraction, which is no longer required.

Differential Revision: https://phabricator.services.mozilla.com/D45769

--HG--
extra : moz-landing-system : lando
2019-09-17 22:37:34 +00:00
Andrew Halberstadt
eaa4c05610 Bug 1567642 - [mozbuild] Fix flake8 under Python 3 lint issues r=firefox-build-system-reviewers,chmanchester
Depends on D45412

Differential Revision: https://phabricator.services.mozilla.com/D45413

--HG--
extra : moz-landing-system : lando
2019-09-17 18:51:43 +00:00
Andrew Halberstadt
3b6e9c57e2 Bug 1567642 - [mach] Fix flake8 under Python 3 lint issues r=firefox-build-system-reviewers,chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D45412

--HG--
extra : moz-landing-system : lando
2019-09-17 18:52:28 +00:00
Erica Wright
8b7d823b40 Bug 1561184 - Show tooltip text for protection report in app menu r=fluent-reviewers,johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D45583

--HG--
extra : moz-landing-system : lando
2019-09-17 12:56:43 +00:00
prathiksha
474ef9a0f2 Bug 1561443 - Move _getErrorMessageFromCode from NetErrorChild.jsm to aboutNetError.js. r=fluent-reviewers,flod,johannh
Differential Revision: https://phabricator.services.mozilla.com/D36542

--HG--
extra : moz-landing-system : lando
2019-09-17 09:49:59 +00:00
Andrew Halberstadt
6fc4da9266 Bug 1580280 - [mozbuild] Fix Python 3 issues in nodeutil.py r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D45437

--HG--
extra : moz-landing-system : lando
2019-09-10 22:15:36 +00:00
Andrew Halberstadt
5b5dc5542a Bug 1580280 - [lint] Support Python 3 in the flake8 integration r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D45436

--HG--
extra : moz-landing-system : lando
2019-09-11 10:00:58 +00:00
Andrew Halberstadt
e6e5e7b6fa Bug 1580280 - [mozlint] Support Python 3 in the mozlint library r=egao
Differential Revision: https://phabricator.services.mozilla.com/D45435

--HG--
extra : moz-landing-system : lando
2019-09-11 15:07:29 +00:00
Tarek Ziadé
5dd9d5bcd0 Bug 1562870 - generate conditioned profiles r=gbrown,bc,aerickson
Generates "conditioned" profiles.

Differential Revision: https://phabricator.services.mozilla.com/D38211

--HG--
extra : moz-landing-system : lando
2019-09-16 19:44:35 +00:00
Andi-Bogdan Postelnicu
1b886ecee7 Bug 1576659 - Update infer to 0.17.0. r=bastien
Differential Revision: https://phabricator.services.mozilla.com/D43471

--HG--
extra : moz-landing-system : lando
2019-09-13 14:25:32 +00:00
Brian Grinstead
e765d4cd04 Bug 1580978 - Rename browser-urlbar-identity-button to urlbar-identity-button r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D45831

--HG--
extra : moz-landing-system : lando
2019-09-13 12:14:37 +00:00
Brian Grinstead
29a25895f3 Bug 1580978 - Migrate the notification-popup-box element to ftl r=fluent-reviewers,flod,johannh
Differential Revision: https://phabricator.services.mozilla.com/D45758

--HG--
extra : moz-landing-system : lando
2019-09-13 12:14:26 +00:00
Bastien Abadie
0a3932b284 Bug 1550516 - Export clang-tidy check configuration in static-analysis json output, r=sylvestre.
Differential Revision: https://phabricator.services.mozilla.com/D45652

--HG--
extra : moz-landing-system : lando
2019-09-13 07:50:23 +00:00
championshuttler
a19f899a6f Bug 1580492 - Run mach 'core' commands with Python 3. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D45694

--HG--
extra : moz-landing-system : lando
2019-09-12 20:26:45 +00:00
Bastien Abadie
0725033ef3 Bug 1550517 - Exclude 3rd party files on static-analysis check, r=sylvestre.
Differential Revision: https://phabricator.services.mozilla.com/D45630

--HG--
extra : moz-landing-system : lando
2019-09-12 08:49:40 +00:00
Erica Wright
a9430a3f1d Bug 1579705 - Update level labels for Enhanced Tracking Protection. r=fluent-reviewers,johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D45384

--HG--
extra : moz-landing-system : lando
2019-09-11 18:14:25 +00:00
Brian Grinstead
9ccf6b264c Bug 1579540 - Migrate urlbar.viewSiteInfo.label from dtd to ftl r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D45467

--HG--
extra : moz-landing-system : lando
2019-09-11 16:36:14 +00:00
Razvan Maries
2fb41871a9 Backed out 2 changesets (bug 1562773) for build bustages. CLOSED TREE
Backed out changeset 154b23d4a214 (bug 1562773)
Backed out changeset f32f7a644981 (bug 1562773)
2019-09-11 04:40:29 +03:00
Kevin Jacobs
c2dfc6480d Bug 1562773 - Add delegated credentials tests r=keeler,jcj
Add xpcshell tests for Delegated Credentials

Differential Revision: https://phabricator.services.mozilla.com/D37918

--HG--
extra : moz-landing-system : lando
2019-09-10 20:15:12 +00:00
Mike Shal
d3b795e0d2 Bug 1575680 - Move node invocations to misc tier; r=firefox-build-system-reviewers,chmanchester
These were originally in exports because having it in the same tier as
the install rule interacted poorly with VPATH. Now that we no longer
have a generic VPATH rule, make can handle the rules properly with
everything in misc.

Differential Revision: https://phabricator.services.mozilla.com/D42969

--HG--
extra : moz-landing-system : lando
2019-09-09 17:44:56 +00:00
Brian Grinstead
8144335fd7 Bug 1579550 - Fix fluent conversion script imports;r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D45090

--HG--
extra : moz-landing-system : lando
2019-09-10 18:17:06 +00:00
Mike Hommey
e4076e2b2f Bug 1579156 - Fix binding tests after bug 1573566. r=chmanchester
The build system has no clue that there is something to build in
dom/bindings/test. It's currently all handled via make rules generated
by the backend, but ideally, this would all be handled by the frontend
emitting appropriate GeneratedFiles and Sources objects.

In the meanwhile, we just force the make backend to recurse through
dom/bindings/test.

Differential Revision: https://phabricator.services.mozilla.com/D45124

--HG--
extra : moz-landing-system : lando
2019-09-10 02:55:03 +00:00
Csoregi Natalia
453f8b162f Backed out changeset 8b5aa1f7d1f3 (bug 1579156) for bustage due to missing dom/bindings/test. CLOSED TREE 2019-09-10 02:18:51 +03:00
Mike Hommey
73e529409a Bug 1579156 - Fix binding tests after bug 1573566. r=nalexander
The build system has no clue that there is something to build in
dom/bindings/test. It's currently all handled via make rules generated
by the backend, but ideally, this would all be handled by the frontend
emitting appropriate GeneratedFiles and Sources objects.

In the meanwhile, we just force the make backend to recurse through
dom/bindings/test.

Differential Revision: https://phabricator.services.mozilla.com/D45124

--HG--
extra : moz-landing-system : lando
2019-09-07 22:45:47 +00:00
Andrew Halberstadt
e1a687b64f Bug 1579455 - [mozbuild] Fix some Python 3 incompatibilities in virtualenv.py r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D45072

--HG--
extra : moz-landing-system : lando
2019-09-09 20:38:41 +00:00
Mike Shal
f8f5fce637 Bug 1496746 - Remove VPATH; r=glandium
Having a full VPATH for the srcdir sometimes causes make to grab the
wrong prerequisite for a rule, in particular if we have a file in the
srcdir and also generate a file of the same name in the objdir. We don't
really need VPATH anymore though, since most of the information comes
from mozbuild, where we can explicitly list the path to the srcdir or
objdir as necessary.

Differential Revision: https://phabricator.services.mozilla.com/D42968

--HG--
extra : moz-landing-system : lando
2019-09-09 17:44:47 +00:00
Sylvestre Ledru
20b343675a Bug 1577726 - Move generated directories into a dedicated file (Generated.txt) from ThirdPartyPaths.txt r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D44147

--HG--
extra : moz-landing-system : lando
2019-09-05 14:24:21 +00:00