Commit Graph

2486 Commits

Author SHA1 Message Date
shindli
011ea038cb Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-01-29 23:54:31 +02:00
shindli
d5c5369355 Merge inbound to mozilla-central. a=merge 2019-01-29 23:37:33 +02:00
Gabriel Luong
8b553d4d94 Bug 1523724 - Fix the selector dom structure in the new rules view. r=rcaliman 2019-01-29 16:37:20 -05:00
Michael Ratcliffe
54775deef8 Bug 1522404 - Refactor devtools/server/actors/inspector/event-parsers.js to use ES6 classes r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D17651

--HG--
rename : devtools/server/actors/inspector/event-parsers.js => devtools/server/actors/inspector/event-collector.js
extra : moz-landing-system : lando
2019-01-29 17:30:57 +00:00
Gabriel Luong
8616aa3232 Bug 1522217 - Implement add a new CSS rule in the new rules view. r=rcaliman 2019-01-29 09:57:02 -05:00
Cosmin Sabou
599a15d354 Merge mozilla-inbound to mozilla-central. a=merge 2019-01-29 12:01:56 +02:00
Razvan Caliman
f27ade590e Bug 1522843 - Add telemetry configuration and instrumentation to Changes panel to measure usage of context menu and copy action. r=gl
Adds three new scalars for counting the numer of times:
- the default copy action is triggered, regardless of method
- the context menu is shown
- the copy option from the context menu is used

Differential Revision: https://phabricator.services.mozilla.com/D17667

--HG--
extra : moz-landing-system : lando
2019-01-29 11:53:38 +00:00
Razvan Caliman
14d8e1394e Bug 1523296 - Remove DEVTOOLS_FLEXINSPECTOR_ELEMENT_TYPE_DISPLAYED histogram and telemetry instrumentation. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D17823

--HG--
extra : moz-landing-system : lando
2019-01-28 18:58:21 +00:00
Sebastian Hengst
725402f21f Merge mozilla-central to autoland. CLOSED TREE 2019-01-29 02:05:49 +02:00
Timothy Guan-tin Chien
c013639646 Bug 1507895 - Part V, Remove dom.ua_widget.enabled pref r=smaug
With all the dependency removed this pref can be safely removed.

Depends on D17574

Differential Revision: https://phabricator.services.mozilla.com/D17575

--HG--
extra : moz-landing-system : lando
2019-01-28 18:33:25 +00:00
Gabriel Luong
d9cd332cae Bug 1523014 - Only render the rules warning and overridden rule filter if necessary. r=rcaliman 2019-01-28 09:40:03 -05:00
Gabriel Luong
dc2738771b Bug 1523171 - Remove the authoredStyles trait. r=pbro 2019-01-28 09:25:39 -05:00
Timothy Guan-tin Chien
d59f80985c Bug 1507895 - Part I, Remove the videocontrols binding r=smaug
This patch removes the XBL videocontrols binding and make <video>
to always use the UA Widget to generate controls.

DevTools tests that look for NAC is switched to use <input type=file>.

Differential Revision: https://phabricator.services.mozilla.com/D17571

--HG--
extra : moz-landing-system : lando
2019-01-25 13:12:26 +00:00
Razvan Caliman
7b68c89bf0 Bug 1518512 - (Part 2) Ensure all text in Changes panel can be copied. r=gl
Depends on D17255
Replaces CSS pseudo-elements for added/removed line markers with text
elements that can be copied with the rest of the content.

Differential Revision: https://phabricator.services.mozilla.com/D17256

--HG--
extra : moz-landing-system : lando
2019-01-25 15:50:35 +00:00
Razvan Caliman
8daa82597e Bug 1518512 - (Part 1) Add basic context menu to Changes panel. r=gl
Adds context menu with options to select all and copy text content from
the Changes panel.

Differential Revision: https://phabricator.services.mozilla.com/D17255

--HG--
extra : moz-landing-system : lando
2019-01-25 15:45:38 +00:00
Daisuke Akatsuka
5c08fb9ef5 Bug 1515265: Call stopPropagation() and preventDefault() at all places where handle contextmenu event and show the popup. r=jdescottes
Depends on D17457

Differential Revision: https://phabricator.services.mozilla.com/D17458

--HG--
extra : moz-landing-system : lando
2019-01-25 04:31:45 +00:00
Daisuke Akatsuka
2da37d4512 Bug 1515265: Move a place where add contextmenu listener to show the context menu in markup view. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D17457

--HG--
extra : moz-landing-system : lando
2019-01-24 07:04:22 +00:00
Csoregi Natalia
5c853a316a Backed out 2 changesets (bug 1518512) for devtools failures on devtools/client/inspector/changes/test/browser_changes_rule_selector.js. CLOSED TREE
Backed out changeset c8f0d19844f6 (bug 1518512)
Backed out changeset 3c03e2282b4f (bug 1518512)
2019-01-25 15:41:07 +02:00
Razvan Caliman
68c5929c0b Bug 1518512 - (Part 2) Ensure all text in Changes panel can be copied. r=gl
Depends on D17255
Replaces CSS pseudo-elements for added/removed line markers with text
elements that can be copied with the rest of the content.

Differential Revision: https://phabricator.services.mozilla.com/D17256

--HG--
extra : moz-landing-system : lando
2019-01-25 12:40:34 +00:00
Razvan Caliman
c04238dfbc Bug 1518512 - (Part 1) Add basic context menu to Changes panel. r=gl
Adds context menu with options to select all and copy text content from
the Changes panel.

Differential Revision: https://phabricator.services.mozilla.com/D17255

--HG--
extra : moz-landing-system : lando
2019-01-23 14:00:10 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Gabriel Luong
4d7072a8c4 Bug 1521678 - Implement property value editor in the new rules view. r=rcaliman 2019-01-24 15:33:52 -05:00
Oana Pop Rus
3cf09a2338 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-01-24 12:46:18 +02:00
Oana Pop Rus
3192bddd22 Backed out changeset 7f6996c8b32f (bug 1521712) for breaking firefox when devtools is opened a=backout 2019-01-24 12:39:40 +02:00
Michael Ratcliffe
13cf1df779 Bug 1519597 - Bad event handlers on DOM nodes produce bogus popups when inspected r=pbro,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D17142

--HG--
extra : moz-landing-system : lando
2019-01-24 09:54:20 +00:00
Ciure Andrei
c035ee7d3a Merge inbound to mozilla-central. a=merge 2019-01-24 05:44:33 +02:00
Cristina Coroiu
1dbb45b314 Bug 1507337 - disable browser_animation_logic_mutations_fast.js on debug for frequent failures r=jmaher 2019-01-23 07:26:00 +02:00
Gabriel Luong
5959009a10 Bug 1521674 - Implement property name editor in the new rules view. r=rcaliman 2019-01-22 22:20:05 -05:00
Gabriel Luong
5c7bf55f9a Bug 1521013 - Implement selector editing in the new rules view. r=rcaliman 2019-01-22 16:38:43 -05:00
Ciure Andrei
cd0990c959 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-01-23 20:53:05 +02:00
Patrick Brosset
de44cc12fc Bug 1521776 - Add new scrollable markup badges; r=gl
Detect when nodes are scrollable on the actor side, and use this
information to display new [scrollable] markup-badges in the inspector.
Also track this dynimically so badges are added/removed when necessary.
Hide this behind a pref for now, until this gets tested by users and
validated.

Differential Revision: https://phabricator.services.mozilla.com/D17246

--HG--
extra : moz-landing-system : lando
2019-01-23 14:07:47 +00:00
Patrick Brosset
8161663a6d Bug 1521712 - Pick on mouseup to allow picking scrollbars; r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D17234

--HG--
extra : moz-landing-system : lando
2019-01-23 12:17:41 +00:00
Oana Pop Rus
762fbfae67 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-01-22 18:39:16 +02:00
Gabriel Luong
e88c332409 Bug 1520689 - Implement the class list panel in the new rules view. r=pbro
--HG--
rename : devtools/client/inspector/rules/views/class-list-previewer.js => devtools/client/inspector/rules/models/class-list.js
2019-01-22 11:06:39 -05:00
Florens Verschelde
c86c342d77 Bug 1521044 - Remove redundant theme-fg-color classes; r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D16949

--HG--
extra : moz-landing-system : lando
2019-01-22 08:48:22 +00:00
Gabriel Luong
3572d90a2b Bug 1521270 - Add classes to the rule when it is uneditable or unmatched. r=mtigley 2019-01-21 14:39:11 -05:00
Gabriel Luong
e473720094 Bug 1521407 - Avoid rendering the computed property list if it is not necessary. r=rcaliman
- Avoid rendering the computed property list is not expanded.
- Avoid rendering the shorthand overridden computed property list if there is
no overridden properties in the computed property list.
2019-01-21 14:38:00 -05:00
Gabriel Luong
a6b6d7f526 Bug 1521243 - Show a warning for invalid declarations and filter icon for overridden declarations in the new rules view. r=mtigley 2019-01-21 14:34:49 -05:00
Csoregi Natalia
a56ec21b2b Merge inbound to mozilla-central. a=merge 2019-01-17 23:54:34 +02:00
Gabriel Luong
a5f46f0927 Bug 1520389 - Implement the selector highlighter in the new rules view. r=rcaliman 2019-01-17 10:29:38 -05:00
Michael Ratcliffe
5008c56fe4 Bug 1519443 - Change jsdoc comments in highlighter file class declarations to match others the Firefox codebase r=gl
Differential Revision: https://phabricator.services.mozilla.com/D16327

--HG--
extra : moz-landing-system : lando
2019-01-17 17:31:06 +00:00
Gabriel Luong
31709cd488 Bug 1519988 - Implement toggling on/off of a CSS declaration. r=rcaliman 2019-01-16 21:05:25 -05:00
Mike Conley
a1103de90c Bug 1519407 - Don't use promiseDocumentFlushed inside a frame that can be reparented. r=gl
Instead of using promiseDocumentFlushed, we optimistically use getBoundsWithoutFlushing to
get a recent width for the inspector-splitter-box without flushing, which is probably
sufficient to determine whether or not to enter landscape mode.

Differential Revision: https://phabricator.services.mozilla.com/D16347

--HG--
extra : moz-landing-system : lando
2019-01-15 21:38:06 +00:00
Gabriel Luong
ec25de1fe9 Bug 1519530 - Implement the pseudo class panel functionality. r=rcaliman 2019-01-14 15:14:03 -05:00
Csoregi Natalia
0d05e60603 Merge mozilla-central to mozilla-inbound. CLOSED TREE 2019-01-14 19:20:55 +02:00
Gabriel Luong
09a37fa024 Bug 1519716 - Add pseudoElement state to the Rule state. r=rcaliman 2019-01-14 12:18:53 -05:00
Razvan Caliman
95f9b0f221 Bug 1507455 - Update tab order in Inspector sidebar. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D16304

--HG--
extra : moz-landing-system : lando
2019-01-14 09:57:06 +00:00
Tim Nguyen
0bbd7c6362 Bug 1517948 - Consolidate icon styles and remove checked icon filter. r=fvsch
Differential Revision: https://phabricator.services.mozilla.com/D16179

--HG--
extra : moz-landing-system : lando
2019-01-13 21:28:51 +00:00
Razvan Maries
a8ff236833 Backed out changeset 1114f74deed5 (bug 1517948) for failures at devtools/client/inspector/rules/test/browser_rules_shapes-toggle_02.js. CLOSED TREE 2019-01-13 23:10:57 +02:00
Tim Nguyen
7c49279ced Bug 1517948 - Consolidate icon styles and remove checked icon filter. r=fvsch
Differential Revision: https://phabricator.services.mozilla.com/D16179

--HG--
extra : moz-landing-system : lando
2019-01-13 20:04:25 +00:00