Commit Graph

607 Commits

Author SHA1 Message Date
Kershaw Chang
883455945d Bug 1668851 - Try to write data to socket directly without waiting r=necko-reviewers,dragana,remote-protocol-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D92442
2020-10-08 13:26:03 +00:00
Henrik Skupin
fca264c1ec Bug 1669230 - [remote] Remove --remote-debugger command line argument. r=remote-protocol-reviewers,jgraham
Using different names for enabling the remote agent via
--remote-debugger and --remote-debugging-port adds confusion
to users. Also given that --remote-debugging is actually
not used by any client library including Puppeteer,
it can be removed.

Using --remote-debugging-port instead will bring us onpar
with Chrome and how it enables CDP.

Differential Revision: https://phabricator.services.mozilla.com/D92603
2020-10-07 13:50:57 +00:00
Razvan Maries
e97ee6395c Backed out changeset 35066da8f3c3 (bug 1666499) as per Henrik's request. CLOSED TREE 2020-10-02 10:55:34 +03:00
Maja Frydrychowicz
29d9310975 Bug 1665283 - [puppeteer] Remove datareporting.healthreport.about.reportUrl from Launcher.ts r=remote-protocol-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D91450
2020-09-25 15:55:38 +00:00
Anny G
b6286bd455 Bug 1662671 - Remove css for adding an unused resize property for Windows, r=NeilDeakin,remote-protocol-reviewers,maja_zf
Before Quantum, we needed resizer icon on Windows, because when the
add-on statusbar was hidden, we could not resize the window. This is not
needed anymore and is dead code. Consequentially, this also helps reduce
unused images loaded at startup time.

Differential Revision: https://phabricator.services.mozilla.com/D91196
2020-09-25 00:10:23 +00:00
Henrik Skupin
4e1c3a4561 Bug 1666499 - [remote] Updated expectation status for test "Page.close should *not* run beforeunload by default" r=remote-protocol-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D91022
2020-09-23 04:33:47 +00:00
Maja Frydrychowicz
1beed99193 Bug 1666325 - Update docs about remote agent preferences r=remote-protocol-reviewers,whimboo DONTBUILD
...and remove outdated examples.

Differential Revision: https://phabricator.services.mozilla.com/D90905
2020-09-22 15:46:35 +00:00
James Graham
0e2ebe15cb Bug 1660893 - Don't crash when the remote agent can't be initialized, r=remote-protocol-reviewers,whimboo
Set the command line handler to null when we can't start the service

Differential Revision: https://phabricator.services.mozilla.com/D90463
2020-09-16 19:51:54 +00:00
Henrik Skupin
13f06a6d95 Bug 1661390 - [remote] Use a UUID as session id for targets. r=remote-protocol-reviewers,jgraham
A session is defined as string in CDP but target specific commands
and events currently return a number based on the last used index.
This also makes it very easy to discover active sessions.

Differential Revision: https://phabricator.services.mozilla.com/D89352
2020-09-07 15:31:27 +00:00
Henrik Skupin
1a57f61d15 Bug 1662687 - [puppeteer] Update expectation data for Frame.waitForFunction should work when resolved right before execution context disposal. r=remote-protocol-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D89127
2020-09-02 13:07:45 +00:00
Henrik Skupin
3feec2e0e0 Bug 1662549 - [puppeteer] Don't set "toolkit.telemetry.server" to prevent side-effects. r=remote-protocol-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D89057
2020-09-01 21:43:41 +00:00
Kris Maglione
3af8c4138c Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.

Differential Revision: https://phabricator.services.mozilla.com/D82801
2020-08-17 20:20:50 +00:00
Kershaw Chang
cb8dd8e93e Bug 1640105 - Skip failed tests, r=dragana,remote-protocol-reviewers,necko-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D86224
2020-08-10 09:20:35 +00:00
Maja Frydrychowicz
e9022983f1 Bug 1632722 - IO.read hits 'too many arguments' r=remote-protocol-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D86262
2020-08-07 09:08:01 +00:00
Ricky Stewart
31755b431d Bug 1657650 - Require that Mach command providers subclass MachCommandBase. r=remote-protocol-reviewers,marionette-reviewers,maja_zf,mhentges,froydnj
Today we don't require that `mach` `CommandProvider`s subclass from any particular parent class and we're very lax about the requirements they must meet. While that's convenient in certain circumstances, it has some unfortunate implications for feature development.

Today the only requirements that we have for `CommandProvider`s are that they have an `__init__()` method that takes either 1 or 2 arguments, the second of which must be called `context` and is populated with the `mach` `CommandContext`. Again, while this flexibility is occasionally convenient, it is limiting. As we add features to `mach`, having a better idea what the shape of our `CommandProvider`s are and how we can instantiate them and use them is increasingly important, and this gives us additional control when having `mach` configure `CommandProvider`s based on data that is only available at the `mach` level. In particular, we plan to leverage this in bugs 985141 and 1654074.

Here we add validation to the `CommandProvider` decorator to ensure all classes inherit from `MachCommandBase`, update all `CommandProvider`s in-tree to inherit from `MachCommandBase`, and update source and test code accordingly.

Follow-up work: we now require (de facto) that the `context` be populated with a `topdir` attribute by the `populate_context_handler` function, since instantiating the `MachCommandBase` requires a `topdir` be provided. This is fine for now in the interest of keeping this patch reasonably sized, but some additional refactoring could make this cleaner.

Differential Revision: https://phabricator.services.mozilla.com/D86255
2020-08-07 18:24:59 +00:00
Anny Gakhokidze
d6f531d3a5 Bug 1654922 - Part 2: Remove DocumentChannel pref from mach and mochitest tools, r=mattwoodrow,remote-protocol-reviewers,maja_zf
Depends on D85483

Differential Revision: https://phabricator.services.mozilla.com/D85484
2020-07-31 13:06:08 +00:00
Jonathan Watt
b7e932192e Bug 1652270. Convert nsFrameLoader::Print to return a Promise. r=farre,remote-protocol-reviewers,marionette-reviewers,jgraham,whimboo,mixedpuppy
(Instead of requiring callers to pass an nsIWebProgressListener.)

Differential Revision: https://phabricator.services.mozilla.com/D83249
2020-07-22 23:17:45 +00:00
Narcis Beleuzu
687f235fbc Backed out changeset f95c19e45ab2 (bug 1652270) for reftest failures on test-text.html . CLOSED TREE 2020-07-22 20:36:53 +03:00
Jonathan Watt
8c0fb25348 Bug 1652270. Convert nsFrameLoader::Print to return a Promise. r=farre,remote-protocol-reviewers,marionette-reviewers,jgraham,whimboo,mixedpuppy
(Instead of requiring callers to pass an nsIWebProgressListener.)

Differential Revision: https://phabricator.services.mozilla.com/D83249
2020-07-22 15:54:01 +00:00
Dorel Luca
990d081d9f Backed out 2 changesets (bug 1651519) for WPT failures in webdriver/tests/switch_to_frame/switch.py. CLOSED TREE
Backed out changeset 7b973a0e7be9 (bug 1651519)
Backed out changeset 55e9184c5617 (bug 1651519)
2020-07-22 02:47:34 +03:00
Kris Maglione
e7d942c77f Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.

Differential Revision: https://phabricator.services.mozilla.com/D82801
2020-07-21 19:02:27 +00:00
Dorel Luca
d91c6dc40b Backed out 2 changesets (bug 1651519) for wpt failures in webdriver/tests/switch_to_frame/switch.py. CLOSED TREE
Backed out changeset 52317abc5c68 (bug 1651519)
Backed out changeset 45448dca59a4 (bug 1651519)
2020-07-21 21:55:57 +03:00
Kris Maglione
9c2c147159 Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.

Differential Revision: https://phabricator.services.mozilla.com/D82801
2020-07-21 16:59:28 +00:00
Scott
2bcdc17387 Bug 1649883 - Fix user pref for pocket toggle off. r=gvn,remote-protocol-reviewers,perftest-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D82773
2020-07-15 14:51:02 +00:00
Kris Maglione
b6be72f351 Bug 1649554: Part 1 - Move deprecated component registration helpers out of XPCOMUtils. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,whimboo,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81749
2020-07-10 23:58:30 +00:00
Kris Maglione
9d78661f88 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Andrea Marchesini
3c1b71a6e4 Bug 1651618 - Use cookie 'SameSite' attribute with capital 'S' everywhere, r=flod,fluent-reviewers,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,whimboo,sparky
Differential Revision: https://phabricator.services.mozilla.com/D82872
2020-07-09 20:40:15 +00:00
Maja Frydrychowicz
0856418749 Bug 1651469 - [puppeteer-test] Report errors in mocha hooks r=remote-protocol-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D82813
2020-07-09 14:01:50 +00:00
Henrik Skupin
74a6bd97cd Bug 1644349 - [remote] Remove usage of windowIdToFrameIdMap in the Network observer. r=remote-protocol-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D82691
2020-07-08 19:55:45 +00:00
Henrik Skupin
f8fbd2e85e Bug 1651312 - [remote] Fix invalid data type checks in browser-chrome tests. r=remote-protocol-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D82678
2020-07-08 13:47:22 +00:00
Maja Frydrychowicz
24c63a2d0c Bug 1647439 - Sync Puppeteer to v5.0.0 r=remote-protocol-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D82072
2020-07-02 18:57:38 +00:00
Maja Frydrychowicz
9b12e5b93a Bug 1647439 - [remote] Clobber puppeteer lib/ when there are .ts changes r=remote-protocol-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D82071
2020-07-02 18:52:55 +00:00
Maja Frydrychowicz
c0005663ae Bug 1647439 - Sync vendored puppeteer to v4.0.1 r=remote-protocol-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D82070
2020-07-02 18:52:52 +00:00
Maja Frydrychowicz
d12c7d9231 Bug 1647439 - [remote] Don't record unexpected skips when there's no expectation metadata r=remote-protocol-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D82068
2020-07-02 18:46:57 +00:00
Maja Frydrychowicz
3cde6129cc Bug 1647439 - [remote] Remove 'jobs' argument r=remote-protocol-reviewers,jgraham
The environment variable it sets has been removed upstream and in practice we
never run tests in parallel.

Differential Revision: https://phabricator.services.mozilla.com/D82067
2020-07-02 18:46:49 +00:00
Maja Frydrychowicz
2456548253 Bug 1647439 - [remote] Preserve custom mocha recorder when vendoring Puppeteer r=remote-protocol-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D82066
2020-07-02 18:46:42 +00:00
Gabriel Luong
2aa7a2a4f2 Bug 1595710 - Add support for "platform" to Emulation.setUserAgentOverride r=remote-protocol-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D80391
2020-06-30 21:28:29 +00:00
Henrik Skupin
a96e2000f8 Bug 1611843 - Always use an unknown entry id to check for an invalid history entry id. r=remote-protocol-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D81659
2020-06-30 12:52:36 +00:00
chocos
4a218f2c31 Bug 1648959 - Done internal linking in docs in remote Directory.r=championshuttler,remote-protocol-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D81463
2020-06-29 20:34:46 +00:00
Maja Frydrychowicz
cfaa250d14 Bug 1646923 - [remote] Update puppeteer metadata r=remote-protocol-reviewers,whimboo
Depends on D80796

Differential Revision: https://phabricator.services.mozilla.com/D80797
2020-06-24 05:03:30 +00:00
Maja Frydrychowicz
408f595e19 Bug 1646923 - [remote] Add metadata checks for skipped and extra tests r=remote-protocol-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D80796
2020-06-25 05:39:22 +00:00
Henrik Skupin
c8d948863f Bug 1637640 - [remote] Update Puppeteer expectation data. r=remote-protocol-reviewers,maja_zf
Depends on D79452

Differential Revision: https://phabricator.services.mozilla.com/D79453
2020-06-22 06:16:11 +00:00
Henrik Skupin
a1c4dfc684 Bug 1637640 - [remote] Enable page load events for frames. r=remote-protocol-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D79452
2020-06-22 04:51:46 +00:00
Henrik Skupin
221b0c6839 Bug 1644695 - [remote] Return the frameId of the frame when DOM.describeNode is called with a frame element. r=remote-protocol-reviewers,maja_zf
Depends on D79450

Differential Revision: https://phabricator.services.mozilla.com/D79451
2020-06-15 15:22:56 +00:00
Henrik Skupin
02f1323cb3 Bug 1636373 - [remote] Only emit Runtime.executionContextsCleared event for top-level execution contexts. r=remote-protocol-reviewers,maja_zf
This also fixes a hang in Puppeteer's DOMWorld.js when resolving
the current executionContext promise. With the extra event all
the Puppeteer internal contexts for the tab target have been destroyed.

Differential Revision: https://phabricator.services.mozilla.com/D79450
2020-06-16 20:49:03 +00:00
Neil Deakin
58ca41961b Bug 1645541, use outerWindowId from the windowGlobal instead of using the Browser:Init message, Also makes the BrowserTab actor specific to the main browser, r=mconley,remote-protocol-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D79609
2020-06-17 15:01:28 +00:00
Geoff Brown
e1d05bdc1d Bug 1644228 - Remove support for IMPACTED_TESTS; r=remote-protocol-reviewers,firefox-build-system-reviewers,rstewart,whimboo
IMPACTED_TESTS was added in bug 1184405, but is under-utilized in current moz.build
annotations; also bug 1516847 removed use of IMPACTED_TESTS in 'mach test'. This
patch removes remaining support for IMPACTED_TESTS.

Differential Revision: https://phabricator.services.mozilla.com/D79141
2020-06-12 08:04:08 +00:00
Emilio Cobos Álvarez
ffec6f608b Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo
It was removed from the spec.

Differential Revision: https://phabricator.services.mozilla.com/D78834
2020-06-14 23:26:04 +00:00
Paul Bone
9ae88523bb Bug 1550571 - Pref on Browsing Context preservation r=kmag,remote-protocol-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D77764
2020-06-10 06:51:36 +00:00
Henrik Skupin
2756eea4aa Bug 1639467 - [remote] Enable page events after loading initial page in browser_frameAttached.js. r=remote-protocol-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D78698
2020-06-10 21:00:45 +00:00