Commit Graph

747182 Commits

Author SHA1 Message Date
Valentin Gosu
0b0dd660db Bug 1696193 - Stop setting Firefox as default handler for FTP r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D107079
2021-03-04 08:37:02 +00:00
championshuttler
3f7cb70543 Bug 1691327 - Update sphinxcontrib-mermaid to v0.6.3 DONTBUILD. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D107057
2021-03-04 07:07:58 +00:00
Ted Campbell
297ef614c2 Bug 1687095 - Use CompilationStencil& argument to incremental-encoder. r=arai
Since merging stencils is a read-only operation for the source delazification
stencil and we already have a borrowed stencil at caller, it is more
consistent with our conventions to pass a CompilationStencil& instead of an
ExtensibleCompilationStencil&.

Differential Revision: https://phabricator.services.mozilla.com/D107014
2021-03-04 07:03:28 +00:00
Tooru Fujisawa
4e097ad213 Bug 1687095 - Part 6: Merge BaseCompilationStencil and CompilationStencil. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105157
2021-03-04 07:03:27 +00:00
Tooru Fujisawa
f18bd5587c Bug 1687095 - Part 5: Remove gcOutputForDelazification. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105156
2021-03-04 07:03:27 +00:00
Tooru Fujisawa
66692c47c3 Bug 1687095 - Part 4: Remove StencilDelazificationSet. r=tcampbell
Now all stencils don't have associated delazification.

Differential Revision: https://phabricator.services.mozilla.com/D105155
2021-03-04 07:03:26 +00:00
Tooru Fujisawa
6308cade43 Bug 1687095 - Part 3: Use CompilationStencilMerger in XDRIncrementalStencilEncoder. r=tcampbell
Also add XDRStencilEncoder for non-incremental case, and
cleanup XDRStencilDecoder.

StencilDelazificationSet and gcOutputForDelazification become unused,
and will be removed by later patches.

Differential Revision: https://phabricator.services.mozilla.com/D105154
2021-03-04 07:03:26 +00:00
Tooru Fujisawa
d0ac0ceb35 Bug 1687095 - Part 2: Add CompilationStencilMerger. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105153
2021-03-04 07:03:25 +00:00
Tooru Fujisawa
6d9103ea53 Bug 1687095 - Part 1: Add {CompilationStencil,ExtensibleCompilationStencil}::steal. r=tcampbell
To make it possible to convert them each other.

Differential Revision: https://phabricator.services.mozilla.com/D105909
2021-03-04 07:03:25 +00:00
smolnar
2b7eeddb92 Backed out changeset a64ec906ba99 (bug 1695084) for causing browser-chrome failures in browser_PermissionUI_prompts. DONTBUILD CLOSED TREE 2021-03-04 08:57:01 +02:00
Emilio Cobos Álvarez
151c1f2c8d Bug 1695084 - Update persistent storage permission prompt. r=mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D107058
2021-03-04 06:11:46 +00:00
Jared Wein
05394b1154 Bug 1690186 - Adjust the container tab styling to fit with the Proton theme. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D106844
2021-03-04 04:57:02 +00:00
Lee Salzman
21640ca40f Bug 1695405 - Remove texture array support from SWGL. r=nical
Since WebRender doesn't need texture array support anymore, neither does SWGL.
This is a massive simplification which should benefit both performance and
simplicity. This patch pretty much just removes functionality but doesn't
change any functionality that is already used and relied upon.

Differential Revision: https://phabricator.services.mozilla.com/D106718
2021-03-04 04:43:23 +00:00
Jan Varga
eeb8cf2781 Bug 1695883 - Add explicit fallible mozStorageTransaction::Start method for starting the transaction; r=dom-storage-reviewers,sg
The new method is mandatory because mozStorageTransaction constructor no longer
starts the transaction. It must be started explicitely.

All consumers have been adjusted, but only dom/quota, dom/indexedDB, dom/cache,
dom/localstorage and dom/storage handle the error. Other components like
netwerk/cache, netwerk/cookie and toolkit/components currently only warn on
failure to start a transaction. Bug 1696129, 1696130 and 1696133 have been
filed for proper handling of transaction start failures in those components.

Differential Revision: https://phabricator.services.mozilla.com/D106893
2021-03-04 04:38:06 +00:00
Nick Alexander
9ae4c9ba03 Bug 1120863 - Do not process updates when launching devtools. r=mhowell,ochameau
This implements the simple approach advocated for in
https://bugzilla.mozilla.org/show_bug.cgi?id=1120863#c26.

It's not easy to lift the duplicated chrome document URL to a shared
location, so we instead annotate both locations.

I've provided an environment variable that will allow a process that did
not itself process updates to witness that fact and used it to add a test.

Differential Revision: https://phabricator.services.mozilla.com/D106993
2021-03-04 03:39:43 +00:00
Jeff Gilbert
39129f8f9d Bug 1696075 - Match spec for webgl sampling feedback detection. r=lsalzman
I lean really hard into using the precise variable names and language
from the spec here. Previously I had more qualitative/descriptive names,
but I found this to mostly cause confusion. When we're up to our waists
in spec edge cases like we are here, descriptive qualitative names can
just be deceptive, and lead to incorrect intuitions.

Differential Revision: https://phabricator.services.mozilla.com/D107016
2021-03-04 03:14:50 +00:00
Butkovits Atila
f3ccc4e157 Backed out 8 changesets (bug 1696046, bug 1688055) for Spidermonkey failures. CLOSED TREE
Backed out changeset a656dcf28494 (bug 1696046)
Backed out changeset f2ecfa12e3d9 (bug 1688055)
Backed out changeset 5d2ed51e4959 (bug 1688055)
Backed out changeset 78cb751e99d7 (bug 1688055)
Backed out changeset ca92674badfb (bug 1688055)
Backed out changeset fc50fb18ae12 (bug 1688055)
Backed out changeset c42a776a1a13 (bug 1688055)
Backed out changeset 3866de326a0b (bug 1688055)
2021-03-04 05:19:09 +02:00
Tim Nguyen
629bf23c06 Bug 1696202 - Refactor close-icon.css to use color-mix(). r=preferences-reviewers,jaws
Differential Revision: https://phabricator.services.mozilla.com/D107081
2021-03-04 02:51:00 +00:00
Jason Orendorff
f93ec2b2b0 Bug 1696046 - Factor out implementation of JS_ExtensibleLexicalEnvironment to a non-API static method with a more specific return type. r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D107009
2021-03-04 02:34:42 +00:00
Jason Orendorff
ab84190174 Bug 1688055 - Part 7: Adjust a few comments about environments. r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D106524
2021-03-04 02:30:51 +00:00
Jason Orendorff
30e7f67aa2 Bug 1688055 - Part 6: Reorder definitions in EnvironmentObject.cpp to match declaration order. r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D106523
2021-03-04 02:30:50 +00:00
Jason Orendorff
1754a80283 Bug 1688055 - Part 5: Factor out BlockLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D106522
2021-03-04 02:30:50 +00:00
Jason Orendorff
9958ae418b Bug 1688055 - Part 4: Use existing NamedLambdaObject subclass rather than LexicalEnvironmentObject where appropriate. r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D106521
2021-03-04 02:30:50 +00:00
Jason Orendorff
f7f31319ba Bug 1688055 - Part 3: Factor out an ExtensibleLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D106520
2021-03-04 02:30:49 +00:00
Jason Orendorff
df2e0a9e14 Bug 1688055 - Part 2: Factor out a NonSyntacticLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D106519
2021-03-04 02:30:49 +00:00
Jason Orendorff
0bb9a69b8a Bug 1688055 - Part 1: Factor out a GlobalLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D106518
2021-03-04 02:30:48 +00:00
Andreea Pavel
058b6c7b23 Bug 1673527 - temporary disable media control tests r=alwu DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D107163
2021-03-04 02:25:16 +00:00
Markus Stange
4c77fa1cb4 Bug 1694853 - Stop giving the nsMenuBarX a reference to the widget. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106379
2021-03-04 01:24:58 +00:00
Markus Stange
8ce2592621 Bug 1694853 - Use return value instead of outparam for HideItem. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106378
2021-03-04 01:24:57 +00:00
Markus Stange
6674dda1ba Bug 1694853 - Rename arguments in nsMenuBarX methods to use aArgument style. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106377
2021-03-04 01:24:57 +00:00
Markus Stange
f6812daef9 Bug 1694853 - Remove nsMenuObjectX::Content() and put it on the individual subclasses instead. r=harry
This removes some polymorphism and makes it easier to understand what's actually going on.
The explicit if checks added in this patch will go away once nsMenuX and nsMenuItemX are unified.

Differential Revision: https://phabricator.services.mozilla.com/D106376
2021-03-04 01:24:57 +00:00
Markus Stange
e619b59d75 Bug 1694853 - Remove some commented out logging code. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106375
2021-03-04 01:24:56 +00:00
Markus Stange
acffc3e5ad Bug 1694853 - Use return value instead of outparam for GetMenuPopupContent. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106374
2021-03-04 01:24:56 +00:00
Markus Stange
25e6e927bf Bug 1694853 - Split mDestroyHandlerCalled into mDidFirePopupHiding and mDidFirePopupHidden, for increased clarity. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106373
2021-03-04 01:24:55 +00:00
Markus Stange
f09a47916b Bug 1694853 - Replace outdated 'in' prefix with the more common 'a' prefix. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106372
2021-03-04 01:24:55 +00:00
Markus Stange
de9c44a290 Bug 1694853 - Replace getter and setter calls with property gets and sets. r=harry
This does the same but looks more modern.

Differential Revision: https://phabricator.services.mozilla.com/D106371
2021-03-04 01:24:55 +00:00
Markus Stange
48c3f3447c Bug 1694853 - Use UniquePtr in more places. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106370
2021-03-04 01:24:54 +00:00
Markus Stange
107415a9dd Bug 1694853 - Move nsMenuX::Create into the constructor. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106369
2021-03-04 01:24:54 +00:00
Markus Stange
0bdf1ba9a1 Bug 1694853 - Move nsMenuItemX::Create into the constructor. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106368
2021-03-04 01:24:53 +00:00
Markus Stange
43f5a7408d Bug 1694853 - Make nsMenuIconX non-refcounted. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D106367
2021-03-04 01:24:53 +00:00
Butkovits Atila
dbf24a6c16 Backed out changeset 278e12bc4406 (bug 1696215) for causing failure at size-001.html. CLOSED TREE 2021-03-04 03:06:30 +02:00
Mike Conley
f1a82bcd16 Bug 1696286 - Make it possible for PopupNotifications to be visually unopinionated. r=Gijs
Being 'visually unopinionated' means not showing distinct styling for the main action.

Differential Revision: https://phabricator.services.mozilla.com/D107128
2021-03-04 00:54:01 +00:00
Mats Palmgren
4547bafea1 Bug 1695530 part 1 - Don't create an INCREMENT counter node when the increment is zero because it has no effect. r=emilio
Also, fix Dump() so that it logs the right type for INCREMENT/SET nodes.

Differential Revision: https://phabricator.services.mozilla.com/D107097
2021-03-04 00:37:59 +00:00
Makoto Kato
642a244fdf Bug 1693477 - notifyPush needs messageId. r=geckoview-reviewers,agi
This is simple typo when payload is nothing.

Also, we should add unit tests for this since we don't run mochitest in
dom/push/test. The mochitest requires mock's implementation, but we doesn't
have it.

Differential Revision: https://phabricator.services.mozilla.com/D107067
2021-03-04 00:36:44 +00:00
Ting-Yu Lin
ea9685fb41 Bug 1690701 Part 4 - Replace rarely used ReflowInput::IsFloating() with nsStyleDisplay::IsFloating(). r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D106583
2021-03-04 00:34:04 +00:00
Ting-Yu Lin
252b93c3a9 Bug 1690701 Part 3 - Check NS_FRAME_OUT_OF_FLOW bit in nsIFrame::IsFloating(). r=emilio
Similar to Part 1, I assume nsIFrame::IsFloating()'s callers really want
to check whether a frame is a real float.

Differential Revision: https://phabricator.services.mozilla.com/D106582
2021-03-04 00:34:04 +00:00
Ting-Yu Lin
7e74c47006 Bug 1690701 Part 2 - Check NS_FRAME_OUT_OF_FLOW bit in nsIFrame::IsAbsolutelyPositioned(). r=emilio
I assume nsIFrame::IsAbsolutelyPositioned()'s callers really want to
check whether a frame is a real abspos frame, not just check a frame has
a abspos style. This could potentially change the behavior, but I feel
its the right thing to do.

Differential Revision: https://phabricator.services.mozilla.com/D106580
2021-03-04 00:34:03 +00:00
Ting-Yu Lin
a58d1f2bd9 Bug 1690701 Part 1.5 - Check |frame| instead of |styleFrame| for abspos in GetUnretargetedOffsetsFor(). r=emilio
When `aElement` is a <table>, `styleFrame` is the inner table frame. It
has the abspos style, but not the `NS_FRAME_OUT_OF_FLOW bit`. The bit is
set on the table wrapper frame in the `frame` variable.

When determining whether the <table> is absolutely positioned, we should
check `frame` instead of `styleFrame`. Otherwise we'll break <table>
element's offsetParent property after applying Part 2.

Without this patch, running `./mach test dom/html/test/test_bug375003-1.html`
can generate the following exception.

  dom/html/test/test_bug375003-1.html | uncaught exception -
  TypeError: can't access property "id", p is null at
  t3@http://mochi.test:8888/tests/dom/html/test/test_bug375003-1.html:39:3

Differential Revision: https://phabricator.services.mozilla.com/D106746
2021-03-04 00:34:03 +00:00
Ting-Yu Lin
a0be0aea13 Bug 1690701 Part 1 - Check floating style when determining whether it is a floating first letter. r=layout-reviewers,emilio
IsFontSizeInflationContainer() is a helper of nsIFrame::Init(). That is,
when it is called from a caller like
nsCSSFrameConstructor::CreateFloatingLetterFrame(), the
`NS_FRAME_OUT_OF_FLOW` bit is not set yet. There is also a hint at the
call site
https://searchfox.org/mozilla-central/rev/362676fcadac37f9f585141a244a9a640948794a/layout/generic/nsIFrame.cpp#770

To fix it, we need to change the condition to check only the
floating style.

layout/reftests/bidi/with-first-letter-2b.html is one of the testcases
that can trigger the following assertion without this patch.

  ###!!! ASSERTION: should not be container for font size inflation

Differential Revision: https://phabricator.services.mozilla.com/D106579
2021-03-04 00:34:03 +00:00
Butkovits Atila
2ef5de0d65 Bug 1686884 - disable multiple.html for frequent failures. r=intermittent-reviewers,jgraham DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D106752
2021-03-04 00:24:43 +00:00