`osfile` is deprecated and `./mach lint -l eslint` shows warning message for
it. So I would like to replace it with `PathUtils`.
Differential Revision: https://phabricator.services.mozilla.com/D159343
Also assure that unregistering an accessible removes the right one and
doesn't confuse the attached document with the detached one.
Add stderr output to Accessible::DebugPrint in Android as well.
Differential Revision: https://phabricator.services.mozilla.com/D157528
This migration creates the first FTL file under mobile/android/.
As GeckoView isn't actually localised (see bug 1605358), this file
is not exposed to localisers.
A migration script is still included, as previous localisations of
the about:config view's strings are available from its Fennec days.
Running the script will fail in an m-c checkout bootstrapped for
desktop development; it's possible to hack around this by manually
setting the `l10n_toml` value in `python/l10n/test_fluent_migrations/fmt.py`.
Differential Revision: https://phabricator.services.mozilla.com/D155450
This migration creates the first FTL file under mobile/android/.
As GeckoView isn't actually localised (see bug 1605358), this file
is not exposed to localisers.
A migration script is still included, as previous localisations of
the about:config view's strings are available from its Fennec days.
Running the script will fail in an m-c checkout bootstrapped for
desktop development; it's possible to hack around this by manually
setting the `l10n_toml` value in `python/l10n/test_fluent_migrations/fmt.py`.
Differential Revision: https://phabricator.services.mozilla.com/D155450
Also assure that unregistering an accessible removes the right one and
doesn't confuse the attached document with the detached one.
Add stderr output to Accessible::DebugPrint in Android as well.
Differential Revision: https://phabricator.services.mozilla.com/D157528
Now that it's no longer used, the global.dtd file and its single remaining string `locale.dir` may be removed.
A test specifically targeting this is also removed as obsolete.
Differential Revision: https://phabricator.services.mozilla.com/D157797
After the preceding changes, brand.dtd has no more actual users and may be removed.
One mochitest is switched to use a different DTD file which will still remain in the tree.
The dependency in aboutSupport.xhtml appears to have been accidentally left in when its localization was migrated to Fluent.
Differential Revision: https://phabricator.services.mozilla.com/D156668
Although this test doesn't run on our CI since CI uses Android 7.0, I would
like to add this for the future.
Image keyboard support requires content:// uri for image, so we need content
provider for testing this feature.
Differential Revision: https://phabricator.services.mozilla.com/D157714
The android magnifier widget does not work when using our
SurfaceControl rendering path, as we no longer render in to the
Surface provided by the SurfaceView, but instead into a child Surface
we have created and attached the SurfaceControl.
To fix this, we create a SurfaceView subclass, MagnifiableSurfaceView,
which allows us to set an override Surface to be used by the
magnifier. This class works by overriding getHolder() to return a
custom SurfaceHolder, which returns our override Surface rather than
the default one when called by the Magnifier class.
Depends on D157308
Differential Revision: https://phabricator.services.mozilla.com/D157309
In order to fix the magnifier widget being broken, the previous patch
in this bug added a mechanism to disable and enable the SurfaceControl
rendering path. This caused some glitches to occur, so we removed the
calls to that code in bug 1783542, but the code remained.
As we now have an alternative solution to fix the magnifier widget, we
no longer require this code. This patch therefore reverts the original
patch, to lead the way for the new solution in the next patch.
Differential Revision: https://phabricator.services.mozilla.com/D157308
This migration creates the first FTL file under mobile/android/.
As GeckoView isn't actually localised (see bug 1605358), this file
is not exposed to localisers.
A migration script is still included, as previous localisations of
the about:config view's strings are available from its Fennec days.
Running the script will fail in an m-c checkout bootstrapped for
desktop development; it's possible to hack around this by manually
setting the `l10n_toml` value in `python/l10n/test_fluent_migrations/fmt.py`.
Differential Revision: https://phabricator.services.mozilla.com/D155450
When calling `clipboard.readText` on content script, Gecko dispatches
`MozClipboardReadPaste` event. On Desktop Firefox uses XUL pop up window
to handle it, then it shows "Paste" button whether user can allow to read
clipboard data.
But GeckoView doesn't have XUL pop up. To implement this feature, we show
"Paste" pop up using action mode as default. Also, browser side can override
delegated methods if it wants another permission pop up or to support Android L
(Android L doesn't have action mode).
Differential Revision: https://phabricator.services.mozilla.com/D151102
(Co-authored with m_kato)
GeckoView's overscroll is implemented by OS side using
`WidgetOverscrollEffect`.
When not releasing finger during overscroll, stretched animation is kept on
Android 12+ since `EdgeEffect.onRelease` isn't called. Then, when releasing
finger, this animation isn't finished on GeckoView with Android 12+.
When this situation, APZ doesn't call
`WidgetOverscrollEffect::HandleFlingOverscroll` by releasing finger due to too
small velocity value in `AsyncPanZoomController::HandleEndOfPan`. So there is
no way to detect whether releasing finger on GeckoView side.
I think We should notify GeckoView of releasing finger to finish animation.
This won't occurs on `GenericOverscollEffect` on macOS since overscoll
animation is managed by APZ and this animation will be finished by
`UpdateAnimation`.
Differential Revision: https://phabricator.services.mozilla.com/D156611
Original issue was bug 1701283, but that fix was removed by bug 1755094
unfortunately.
Some devices (autofill service?) seem to throw a `SecurityException` when
calling autofill manager. So we need try-catch block for it.
Differential Revision: https://phabricator.services.mozilla.com/D156501
These files were made available as:
- `chrome://browser/locale/netError.dtd`
- `chrome://browser/locale/appstrings.properties`
For desktop, overrides are defined in `browser/base/jar.mn` that map the corresponding `global/` paths to the above:
```
% override chrome://global/locale/appstrings.properties chrome://browser/locale/appstrings.properties
% override chrome://global/locale/netError.dtd chrome://browser/locale/netError.dtd
```
For mobile, similar overrides were earlier defined in `mobile/android/chrome/jar.mn`, but that file was removed in bug 1589182 three years ago.
Consequently, the `global/` paths for these files that are used under `docshell/` and `dom/` have resolved to the non-overridden `dom/` files since Firefox 72.
It should therefore be safe to remove them.
Differential Revision: https://phabricator.services.mozilla.com/D156403
In Geolocation.cpp, the call to start the geolocation device always
had HighAccuracyRequested() set to false because no callbacks were
listening. Changed to set the callbacks first, before listening.
In Android, this patch stops the use of checking for last known location
on high accuracy location requests, adjusts comparing locations,
and also streamlines the criteria for picking the best location provider.
Differential Revision: https://phabricator.services.mozilla.com/D153226