Commit Graph

31535 Commits

Author SHA1 Message Date
Makoto Kato
9a1a597177 Bug 1795639 - Convert GeckoViewUtils to ESM. r=geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D159490
2022-10-20 11:37:01 +00:00
Morgan Rae Reschenberg
98bda97716 Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r=Jamie,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D155903
2022-10-18 22:30:10 +00:00
Cosmin Sabou
02bc919daa Backed out 3 changesets (bug 1787274, bug 1792964, bug 1774708) for causing mochitest failures on browser_test_visibility.js. CLOSED TREE
Backed out changeset f9ec55a441c4 (bug 1774708)
Backed out changeset f942a92c1666 (bug 1792964)
Backed out changeset d60a24f2c8b8 (bug 1787274)
2022-10-18 22:54:12 +03:00
Morgan Rae Reschenberg
32271e47f7 Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r=Jamie,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D155903
2022-10-18 19:07:44 +00:00
Mark Banner
2ffde1e92f Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Makoto Kato
1dce2205ee Bug 1795183 - Replace OS.path.join with PathUtils.join in ChildCrashHandler.jsm. r=geckoview-reviewers,owlish
`osfile` is deprecated and `./mach lint -l eslint` shows warning message for
it.  So I would like to replace it with `PathUtils`.

Differential Revision: https://phabricator.services.mozilla.com/D159343
2022-10-18 00:18:56 +00:00
Eitan Isaacson
3243bf997e Bug 1789474 - Allow detached documents to be overwritten in accessible mapping. r=Jamie,geckoview-reviewers,owlish
Also assure that unregistering an accessible removes the right one and
doesn't confuse the attached document with the detached one.

Add stderr output to Accessible::DebugPrint in Android as well.

Differential Revision: https://phabricator.services.mozilla.com/D157528
2022-10-17 23:10:19 +00:00
Paul Adenot
9a01f6f628 Bug 1770940 - Ignore an exception when calling AudioManager.startBluetoothSco. r=geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D158661
2022-10-17 12:00:27 +00:00
Alexandre Poirot
a6539ba47e Bug 1793604 - [devtools] Convert Loader.jsm to ESM. r=perftest-reviewers,geckoview-reviewers,preferences-reviewers,owlish,kshampur,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158582
2022-10-14 12:19:42 +00:00
Eemeli Aro
1564027eba Bug 1786186 - Migrate mobile about:config to Fluent. r=geckoview-reviewers,fluent-reviewers,flod,owlish. CLOSED TREE
This migration creates the first FTL file under mobile/android/.
As GeckoView isn't actually localised (see bug 1605358), this file
is not exposed to localisers.

A migration script is still included, as previous localisations of
the about:config view's strings are available from its Fennec days.
Running the script will fail in an m-c checkout bootstrapped for
desktop development; it's possible to hack around this by manually
setting the `l10n_toml` value in `python/l10n/test_fluent_migrations/fmt.py`.

Differential Revision: https://phabricator.services.mozilla.com/D155450
2022-09-20 11:53:37 +00:00
Narcis Beleuzu
e16ed10e23 Backed out changeset a7e5bcf262cd (bug 1786186) - wrong backout 2022-10-14 09:49:25 +03:00
Eemeli Aro
1d7d01e03d Bug 1786186 - Backed out changeset 24e777435dea for geckoview-junit failures. CLOSED TREE
This migration creates the first FTL file under mobile/android/.
As GeckoView isn't actually localised (see bug 1605358), this file
is not exposed to localisers.

A migration script is still included, as previous localisations of
the about:config view's strings are available from its Fennec days.
Running the script will fail in an m-c checkout bootstrapped for
desktop development; it's possible to hack around this by manually
setting the `l10n_toml` value in `python/l10n/test_fluent_migrations/fmt.py`.

Differential Revision: https://phabricator.services.mozilla.com/D155450
2022-10-14 09:41:21 +03:00
Sandor Molnar
6a467e1baf Backed out changeset 431649004dd4 (bug 1789474) for causing android gv-junit-fis-o crashes CLOSED TREE 2022-10-14 07:59:55 +03:00
Cosmin Sabou
87e1282cfb Backed out changeset cb56ec6454d6 (bug 1786186) for causing Bug 1792258. 2022-10-14 05:53:47 +03:00
Eitan Isaacson
1778c775fe Bug 1789474 - Allow detached documents to be overwritten in accessible mapping. r=Jamie,geckoview-reviewers,owlish
Also assure that unregistering an accessible removes the right one and
doesn't confuse the attached document with the detached one.

Add stderr output to Accessible::DebugPrint in Android as well.

Differential Revision: https://phabricator.services.mozilla.com/D157528
2022-10-13 22:03:03 +00:00
Joel Maher
39c161dd67 Bug 1794927 - Use clear text traffic flag for android test_runner app. r=nalexander,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D159235
2022-10-13 20:21:09 +00:00
Daniel Baker
78fe69ccca Bug 1789846 - Using Stride and Height values from MediaCodec instead of assuming stride and height values. r=jolin,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D159130
2022-10-13 20:15:04 +00:00
Eemeli Aro
50d8456970 Bug 1760033 - Remove aboutReader.properties and its remaining strings as unused. r=Gijs,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158577
2022-10-13 16:28:32 +00:00
Norisz Fay
474baf5b68 Backed out 3 changesets (bug 1760033) for causing multiple failures ErrorResult.h
Backed out changeset e54df449fbad (bug 1760033)
Backed out changeset f26056c61dc2 (bug 1760033)
Backed out changeset 7f69b83013e1 (bug 1760033)
2022-10-12 17:28:18 +03:00
Eemeli Aro
df3e20d851 Bug 1760033 - Remove aboutReader.properties and its remaining strings as unused. r=Gijs,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158577
2022-10-12 13:55:28 +00:00
Eemeli Aro
a346dc468c Bug 1792461 - Drop previously removed localization files from mobile/android/locales/l10n.toml. r=geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158144
2022-10-12 10:23:04 +00:00
Eemeli Aro
f0a0871780 Bug 1675814 - Remove global.dtd as unused. r=flod,geckoview-reviewers,owlish
Now that it's no longer used, the global.dtd file and its single remaining string `locale.dir` may be removed.

A test specifically targeting this is also removed as obsolete.

Differential Revision: https://phabricator.services.mozilla.com/D157797
2022-10-07 18:40:28 +00:00
Eemeli Aro
1662ea09fa Bug 1789406 - Remove brand.dtd files as unused. r=flod,geckoview-reviewers,owlish
After the preceding changes, brand.dtd has no more actual users and may be removed.

One mochitest is switched to use a different DTD file which will still remain in the tree.

The dependency in aboutSupport.xhtml appears to have been accidentally left in when its localization was migrated to Fluent.

Differential Revision: https://phabricator.services.mozilla.com/D156668
2022-10-07 18:40:28 +00:00
Makoto Kato
a66ffe1baa Bug 1714496 - Part 2. geckoview-junit test for image keyboard support. r=geckoview-reviewers,owlish
Although this test doesn't run on our CI since CI uses Android 7.0, I would
like to add this for the future.

Image keyboard support requires content:// uri for image, so we need content
provider for testing this feature.

Differential Revision: https://phabricator.services.mozilla.com/D157714
2022-10-07 09:03:31 +00:00
Makoto Kato
8821cd8445 Bug 1714496 - Part 1. Implement Image keyboard support. r=geckoview-reviewers,calu
GBoard has image keyboard support, and spec issue is resolved [*1]. So this
adds image keyboard support via GBoard and Android 7.1+.

*1 https://github.com/w3c/input-events/issues/117

Differential Revision: https://phabricator.services.mozilla.com/D157713
2022-10-07 09:03:31 +00:00
Andreea Pavel
86cc5257f0 Bug 1754570 - temporarily disable capturePixelsAfterGpuProcessCrash on opt r=intermittent-reviewers,geckoview-reviewers,m_kato,MasterWayZ
Differential Revision: https://phabricator.services.mozilla.com/D158340
2022-10-03 12:11:51 +00:00
Ryan VanderMeulen
a5656862a6 Bug 1791878 - Update to kotlin 1.7.20 and gradle plugin 7.3.0. r=geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D157864
2022-09-29 21:05:51 +00:00
Mark Banner
8d1ebcb9d6 Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Jamie Nicol
49c0f0ed43 Bug 1780093 - Use custom SurfaceView which allows magnifier widget to work. r=geckoview-reviewers,owlish
The android magnifier widget does not work when using our
SurfaceControl rendering path, as we no longer render in to the
Surface provided by the SurfaceView, but instead into a child Surface
we have created and attached the SurfaceControl.

To fix this, we create a SurfaceView subclass, MagnifiableSurfaceView,
which allows us to set an override Surface to be used by the
magnifier. This class works by overriding getHolder() to return a
custom SurfaceHolder, which returns our override Surface rather than
the default one when called by the Magnifier class.

Depends on D157308

Differential Revision: https://phabricator.services.mozilla.com/D157309
2022-09-21 17:30:26 +00:00
Jamie Nicol
5e60f35505 Bug 1780093 - Remove code for enabling/disabling SurfaceControl rendering path. r=geckoview-reviewers,owlish
In order to fix the magnifier widget being broken, the previous patch
in this bug added a mechanism to disable and enable the SurfaceControl
rendering path. This caused some glitches to occur, so we removed the
calls to that code in bug 1783542, but the code remained.

As we now have an alternative solution to fix the magnifier widget, we
no longer require this code. This patch therefore reverts the original
patch, to lead the way for the new solution in the next patch.

Differential Revision: https://phabricator.services.mozilla.com/D157308
2022-09-21 17:30:25 +00:00
owlishDeveloper
5f3ce8227f Bug 1791046 - Remove deprecated cookie lifetime policy API and deprecated set permission API r=geckoview-reviewers,calu
Differential Revision: https://phabricator.services.mozilla.com/D157523
2022-09-20 19:32:51 +00:00
Andreea Pavel
daea5b0dd9 Backed out changeset 2c2bc5fd317f (bug 1791046) for lint failure on a CLOSED TREE 2022-09-20 19:39:47 +03:00
owlishDeveloper
7264f7ca97 Bug 1791046 - Remove deprecated cookie lifetime policy API r=geckoview-reviewers,calu
Differential Revision: https://phabricator.services.mozilla.com/D157523
2022-09-20 16:15:14 +00:00
Eemeli Aro
90bc1261e7 Bug 1786186 - Migrate mobile about:config to Fluent. r=geckoview-reviewers,fluent-reviewers,flod,owlish
This migration creates the first FTL file under mobile/android/.
As GeckoView isn't actually localised (see bug 1605358), this file
is not exposed to localisers.

A migration script is still included, as previous localisations of
the about:config view's strings are available from its Fennec days.
Running the script will fail in an m-c checkout bootstrapped for
desktop development; it's possible to hack around this by manually
setting the `l10n_toml` value in `python/l10n/test_fluent_migrations/fmt.py`.

Differential Revision: https://phabricator.services.mozilla.com/D155450
2022-09-20 11:53:37 +00:00
Dana Keeler
923d7b2029 Bug 1790451 - make nsIChannel.securityInfo concrete as nsITransportSecurityInfo r=kershaw,necko-reviewers,valentin,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D157136
2022-09-20 03:58:49 +00:00
samihda
462e29480e Bug 1510975 - Match package name with file path. r=m_kato,geckoview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D157335
2022-09-19 10:53:37 +00:00
Ryan VanderMeulen
defeab2235 Backed out changeset 6376af715fb9 (bug 1787274) for Fenix UI test failures. 2022-09-15 13:10:33 -04:00
Morgan Rae Reschenberg
5afbf8d60d Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r=Jamie,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D155903
2022-09-14 22:02:06 +00:00
Butkovits Atila
4fc48f6705 Backed out changeset 7d2bb2e5fb73 (bug 1787274) for causing geckoview failures. 2022-09-14 22:09:11 +03:00
Morgan Rae Reschenberg
f7de79f06d Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r=Jamie,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D155903
2022-09-14 17:47:43 +00:00
Makoto Kato
e73b7956db Bug 1776829 - Implement "Paste" permission action for clipboard.readText. r=geckoview-reviewers,owlish
When calling `clipboard.readText` on content script, Gecko dispatches
`MozClipboardReadPaste` event.  On Desktop Firefox uses XUL pop up window
to handle it, then it shows "Paste" button whether user can allow to read
clipboard data.

But GeckoView doesn't have XUL pop up. To implement this feature, we show
"Paste" pop up using action mode as default. Also, browser side can override
delegated methods if it wants another permission pop up or to support Android L
(Android L doesn't have action mode).

Differential Revision: https://phabricator.services.mozilla.com/D151102
2022-09-12 07:36:52 +00:00
Makoto Kato
6f6a4de1ef Bug 1786452 - Finish overscroll animation when finishing pan. r=geckoview-reviewers,owlish,m_kato
(Co-authored with m_kato)

GeckoView's overscroll is implemented by OS side using
`WidgetOverscrollEffect`.

When not releasing finger during overscroll, stretched animation is kept on
Android 12+ since `EdgeEffect.onRelease` isn't called. Then, when releasing
finger, this animation isn't finished on GeckoView with Android 12+.

When this situation, APZ doesn't call
`WidgetOverscrollEffect::HandleFlingOverscroll` by releasing finger due to too
small velocity value in `AsyncPanZoomController::HandleEndOfPan`. So there is
no way to detect whether releasing finger on GeckoView side.

I think We should notify GeckoView of releasing finger to finish animation.

This won't occurs on `GenericOverscollEffect` on macOS since overscoll
animation is managed by APZ and this animation will be finished by
`UpdateAnimation`.

Differential Revision: https://phabricator.services.mozilla.com/D156611
2022-09-12 07:25:05 +00:00
Makoto Kato
708604622a Bug 1786862 - Add try-catch block for SecurityException by autofill manager. r=geckoview-reviewers,calu
Original issue was bug 1701283, but that fix was removed by bug 1755094
unfortunately.

Some devices (autofill service?) seem to throw a `SecurityException` when
calling autofill manager. So we need try-catch block for it.

Differential Revision: https://phabricator.services.mozilla.com/D156501
2022-09-12 03:20:51 +00:00
Eemeli Aro
a293e05849 Bug 1734217 - Drop netError.dtd and appstrings.properties from mobile as unused. r=geckoview-reviewers,nalexander,calu
These files were made available as:
- `chrome://browser/locale/netError.dtd`
- `chrome://browser/locale/appstrings.properties`

For desktop, overrides are defined in `browser/base/jar.mn` that map the corresponding `global/` paths to the above:
```
 % override chrome://global/locale/appstrings.properties chrome://browser/locale/appstrings.properties
 % override chrome://global/locale/netError.dtd chrome://browser/locale/netError.dtd
```

For mobile, similar overrides were earlier defined in `mobile/android/chrome/jar.mn`, but that file was removed in bug 1589182 three years ago.

Consequently, the `global/` paths for these files that are used under `docshell/` and `dom/` have resolved to the non-overridden `dom/` files since Firefox 72.

It should therefore be safe to remove them.

Differential Revision: https://phabricator.services.mozilla.com/D156403
2022-09-09 06:47:45 +00:00
Ryan VanderMeulen
998208305e Bug 1786164 - Add more Gradle JVM memory flags. r=geckoview-reviewers,jonalmeida
See https://github.com/mozilla-mobile/fenix/pull/26542 for more discussion.
Also specify a lower maximum heap size more in line with other projects and
remove some redundant settings in other gradle.properties files.

Differential Revision: https://phabricator.services.mozilla.com/D155179
2022-08-31 22:10:39 +00:00
Ryan VanderMeulen
450ee76669 Bug 1786174 - Fix some other WebExtension warnings from the linting logs. r=geckoview-reviewers,calu
Differential Revision: https://phabricator.services.mozilla.com/D155153
2022-08-31 22:10:39 +00:00
Ryan VanderMeulen
3744dc5f92 Bug 1786174 - Update Android linter to v30.2.2 and fix newly-flagged errors. r=geckoview-reviewers,jonalmeida
Differential Revision: https://phabricator.services.mozilla.com/D155152
2022-08-31 22:10:39 +00:00
Ryan VanderMeulen
893cf3efd4 Bug 1786164 - Update gradle and plugin to the latest versions. r=geckoview-reviewers,jonalmeida
Differential Revision: https://phabricator.services.mozilla.com/D155151
2022-08-31 22:10:38 +00:00
Ryan VanderMeulen
b3938e97ab Bug 1785838 - Bump Kotlin to version 1.6.21 and a update a few other gradle dependencies. r=geckoview-reviewers,calu
Differential Revision: https://phabricator.services.mozilla.com/D154988
2022-08-31 22:10:37 +00:00
Olivia Hall
fd773b706c Bug 1765835 - Adjustments to Location Provider r=geckoview-reviewers,owlish,m_kato,smaug
In Geolocation.cpp, the call to start the geolocation device always
had HighAccuracyRequested() set to false because no callbacks were
listening. Changed to set the callbacks first, before listening.

In Android, this patch stops the use of checking for last known location
on high accuracy location requests, adjusts comparing locations,
and also streamlines the criteria for picking the best location provider.

Differential Revision: https://phabricator.services.mozilla.com/D153226
2022-08-31 18:50:16 +00:00