Cosmin Sabou
7b214fd81a
Backed out 6 changesets (bug 1518999) for geckoview failures on scrollToVerticalOnZoomedContentAuto.
...
Backed out changeset 10bf1552e301 (bug 1518999)
Backed out changeset e62cd63e3595 (bug 1518999)
Backed out changeset 1bf0b02bb0e0 (bug 1518999)
Backed out changeset 2203a9c52afa (bug 1518999)
Backed out changeset 10f07ca7a246 (bug 1518999)
Backed out changeset b90cf6b54c09 (bug 1518999)
2020-08-25 01:02:36 +03:00
Sean Feng
ef7d515ffb
Bug 1518999 - Refactor some performance.getEntries related tests r=mstange
...
Some tests made some assumptions about the number of returned entries
by performance.getEntries, and these assumptions are not valid
anymore once we added new entries.
Depends on D66463
Differential Revision: https://phabricator.services.mozilla.com/D68645
2020-08-18 21:15:18 +00:00
Nicolas Chevobbe
f09694c73f
Bug 1657310 - Attach target and thread from TargetList. r=jdescottes,ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D85398
2020-08-21 09:22:48 +00:00
Julian Descottes
09373e81c9
Bug 1642295 - Do not check property order in WebConsole stub tests r=nchevobbe
...
Depends on D86962
Differential Revision: https://phabricator.services.mozilla.com/D86963
2020-08-19 14:08:39 +00:00
Csoregi Natalia
c1ed2ba64f
Backed out 6 changesets (bug 1518999) for marionette failures on test_refresh_firefox.py. CLOSED TREE
...
Backed out changeset eb8e5411868e (bug 1518999)
Backed out changeset 0924e0169dcb (bug 1518999)
Backed out changeset b7de245b329c (bug 1518999)
Backed out changeset f2a6a3797ef1 (bug 1518999)
Backed out changeset 123403a14312 (bug 1518999)
Backed out changeset 1968b8ca14d7 (bug 1518999)
2020-08-18 23:53:26 +03:00
Sean Feng
f59ae11633
Bug 1518999 - Refactor some performance.getEntries related tests r=mstange
...
Some tests made some assumptions about the number of returned entries
by performance.getEntries, and these assumptions are not valid
anymore once we added new entries.
Depends on D66463
Differential Revision: https://phabricator.services.mozilla.com/D68645
2020-07-31 19:20:41 +00:00
Nicolas Chevobbe
6a8d6386cb
Bug 1658724 - Don't start the parser worker if it's not needed when evaluating an expression in the console. r=jdescottes. DONTBUILD
...
In `getMappedExpression`, we check if the expression contains `await `, and in
such case, transform the input to handle top-level await expressions.
The catch is that we first check the existence of this.parserService, and the
getter for parserService will start the parser worker if it wasn't the case yet.
That means we were always spawning the parser worker, even if it wasn't going
to be used, consuming unnecessary resources.
This patch removes the conditions in the if, as `parserService` will always be truthy.
Differential Revision: https://phabricator.services.mozilla.com/D86826
2020-08-17 13:22:51 +00:00
iamnk
f613ce1d3e
Bug 1658460 - Swap collapse and block icons for blocked network message. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D87083
2020-08-17 07:15:37 +00:00
Nicolas Chevobbe
8b3f8024e2
Bug 1655406 - Fix race condition when hitting Enter. r=Honza.
...
Sometimes, it might happen that the user triggered the popup
opening (by typing a letter) and hit Enter before the popup
was already shown, which would result in a blank popup being opened.
This patch addresses that by storing the popup opening promise
and if it exists in the code that handle the Enter key, wait until
the promise resolves and hide the popup.
It would be tricky to write a consistent test as this race is depending
on the server response time and the time it take for the popup to be
shown; but manual tests seemed to indicate this fixes the issue.
Differential Revision: https://phabricator.services.mozilla.com/D86548
2020-08-14 13:38:35 +00:00
Julian Descottes
f05829aa08
Bug 1629890 - Use Front/Actor::isDestroyed to replace actorID checks r=nchevobbe
...
Depends on D86325
Differential Revision: https://phabricator.services.mozilla.com/D86356
2020-08-12 11:33:44 +00:00
Richard Sherman
155b24b9c7
Bug 1581641 - Enable codemirror's code folding in editor mode r=nchevobbe
...
Adding code folding to console when in editor mode.
Differential Revision: https://phabricator.services.mozilla.com/D85901
2020-08-07 11:10:17 +00:00
Butkovits Atila
3bd0e5497c
Backed out 10 changesets (bug 1589102) for failure at browser_saveHeapSnapshot_e10s_01.js CLOSED TREE
...
Backed out changeset 0d22ad297b19 (bug 1589102)
Backed out changeset 14bcaf2a452c (bug 1589102)
Backed out changeset 20905f91e2bb (bug 1589102)
Backed out changeset 29ee0fbe855f (bug 1589102)
Backed out changeset d1f6185030af (bug 1589102)
Backed out changeset 31949872cc1d (bug 1589102)
Backed out changeset ec04e1a20597 (bug 1589102)
Backed out changeset ffe8da473b91 (bug 1589102)
Backed out changeset 3b92f7306c64 (bug 1589102)
Backed out changeset b187548e258f (bug 1589102)
2020-08-05 21:47:50 +03:00
Anny Gakhokidze
5da2f83936
Bug 1589102 - Part 5: Fix tests that relied on about:blank loads happening instantenously, r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D85083
2020-08-05 16:44:18 +00:00
Julian Descottes
32de28696d
Bug 1656825 - Fix duplicate calls to lazyRequireGetter r=nchevobbe
...
Depends on D85288
Differential Revision: https://phabricator.services.mozilla.com/D85720
2020-08-03 07:53:50 +00:00
Julian Descottes
72a1334982
Bug 1472821 - Move webconsole fixture mapping for async-storage in requireHacker r=nchevobbe
...
Depends on D85269
Differential Revision: https://phabricator.services.mozilla.com/D85288
2020-08-01 10:49:42 +00:00
Julian Descottes
3af62a1e27
Bug 1472821 - Support array of String for lazyRequireGetter r=nchevobbe,rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D85268
2020-08-03 05:43:59 +00:00
Hubert Boma Manilla
74ccbad5fb
Bug 1656388 - Send the waiting time to the UI r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D85501
2020-07-31 13:03:53 +00:00
Nicolas Chevobbe
6949d7f72c
Bug 1655951 - Fix browser/browser_jsterm_evaluation_context_selector_pause_in_debugger.js failure. r=jdescottes.
...
It seems that the test was failing because the focus wasn't on the console by
the time we were trying to evaluate the input, so the Enter keypress wasn't
registered and the input not evaluated.
This is fixed by focusing the console input in `keyboardExecuteAndWaitForMessage`,
before hitting Enter.
Differential Revision: https://phabricator.services.mozilla.com/D85368
2020-07-30 08:58:56 +00:00
Tom Schuster
c1bd3dfbba
Bug 1569123 - Re-enable strict MIME type checking for Worker/SharedWorker everywhere. r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D85138
2020-07-28 15:43:37 +00:00
Julian Descottes
6d68ed9957
Bug 1655838 - Set ERROR level for blocked request messages in Webconsole r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D85202
2020-07-29 07:50:31 +00:00
nchevobbe
f218d77123
Bug 1651402 - Use obj.isError instead of obj.class='Error' in DevTools code. r=davidwalsh
...
Depends on D82876
Differential Revision: https://phabricator.services.mozilla.com/D84958
2020-07-27 15:48:16 +00:00
Mark Banner
2c56de98ff
Bug 1620537
- Fix eslint issues in devtools .eslintrc*.js files now that ESLint 7 will lint them. r=mossop
...
Depends on D84815
Differential Revision: https://phabricator.services.mozilla.com/D84816
2020-07-24 20:39:07 +00:00
Honza Bambas
78fa1a4fc3
Bug 1654556 - Update webconsole tests to not produce cookie same-siteness rejection warnings and thus not fail, r=nhnt11
...
Depends on D84555
Differential Revision: https://phabricator.services.mozilla.com/D84706
2020-07-23 14:50:19 +00:00
Joel Maher
5d27556feb
Bug 1652440 - adjust devtools to work with object.is() instead of ==. r=rcaliman,jdescottes
...
adjust devtools to work with object.is() instead of ==
Differential Revision: https://phabricator.services.mozilla.com/D83302
2020-07-22 14:53:16 +00:00
Nihanth Subramanya
1f4855ea8d
Bug 1649280 - Create a new webconsole message group for storage isolation messages. r=timhuang,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D84456
2020-07-22 16:00:22 +00:00
Mihai Alexandru Michis
8862b6d3d6
Backed out changeset f0552bf388f1 (bug 1649280) for causing devtool leaks in DocAccessibleChild.
...
CLOSED TREE
2020-07-22 18:40:32 +03:00
Nihanth Subramanya
6b7efe37ac
Bug 1649280 - Create a new webconsole message group for storage isolation messages. r=timhuang,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D84456
2020-07-22 12:41:43 +00:00
Nicolas Chevobbe
7fa11883f2
Bug 1653598 - Add a constant for CSS Parser message category. r=jdescottes.
...
Differential Revision: https://phabricator.services.mozilla.com/D84123
2020-07-20 08:15:03 +00:00
Nicolas Chevobbe
8e74f48b9e
Bug 1644187
- Add server support for CSS warning resources. r=jdescottes.
...
This is quite similar to the error messages watcher, except that we call
ensureCSSErrorReportingEnabled after retrieving the cached messages.
Resource no longer includes `errorMessageName` and `isPromiseRejection` as it
makes little sense for the CSS warning.
The existing resource test is updated to run with and without the server support.
Differential Revision: https://phabricator.services.mozilla.com/D83047
2020-07-17 14:58:43 +00:00
Julian Descottes
307f8a6809
Bug 1651674 - Update stubs for browser_webconsole_stubs_network_event.js r=nchevobbe
...
Depends on D83703
Differential Revision: https://phabricator.services.mozilla.com/D83768
2020-07-16 11:41:51 +00:00
Christoph Kerschbaumer
3d7ee5e969
Bug 1652997: Package all devtools css files and load them using the internal chrome: protocol. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D83656
2020-07-15 16:02:28 +00:00
Johann Hofmann
9ddae4c304
Bug 1645234 - Add a test for document.requestStorageAccess error messages. r=nchevobbe
...
Depends on D79788
Differential Revision: https://phabricator.services.mozilla.com/D80972
2020-07-15 18:52:22 +00:00
Nicolas Chevobbe
a5b2ed29b9
Bug 1651726 - Add a shared performance-marker middleware. r=jdescottes,bomsy,Honza.
...
Differential Revision: https://phabricator.services.mozilla.com/D83068
2020-07-15 09:09:10 +00:00
Alexandre Poirot
9be28a6883
Bug 1649910 - Emit "switched-target" only after we fully attached to the new target. r=jdescottes
...
The previous code, emitting the event from Toolbox.onTargetAvailable,
wasn't waiting for the call to TargetList.startListening which is done
from TargetList.onTargetAvailable.
Differential Revision: https://phabricator.services.mozilla.com/D82664
2020-07-13 14:03:24 +00:00
Hubert Boma Manilla
119e4262a1
Bug 1625909 - Use the ResourceWatcher API to fetch Network Events r=ochameau,Honza,nchevobbe
...
This patch migrates to using the Resource Watcher API to handle Network events, it adds a legacy listeners for the network events
Differential Revision: https://phabricator.services.mozilla.com/D71543
2020-07-13 13:33:09 +00:00
Mihai Alexandru Michis
ce67650fd6
Backed out changeset e95324121fde (bug 1625909) for causing multiple devtool failures.
2020-07-13 04:20:41 +03:00
Hubert Boma Manilla
9bcb3649ef
Bug 1625909 - Use the ResourceWatcher API to fetch Network Events r=ochameau,Honza,nchevobbe
...
This patch migrates to using the Resource Watcher API to handle Network events, it adds a legacy listeners for the network events
Differential Revision: https://phabricator.services.mozilla.com/D71543
2020-07-12 20:38:06 +00:00
Kris Maglione
9d78661f88
Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Nicolas Chevobbe
de82cf7714
Bug 1605162 - Test that context selector is updated when pausing in a remote frame. r=Honza.
...
Differential Revision: https://phabricator.services.mozilla.com/D71527
2020-07-10 09:19:48 +00:00
Farooq AR
4fabbe2929
Bug 1646027 - Request mimeType should be sent on response start. r=Honza,bomsy,devtools-backward-compat-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D82206
2020-07-10 07:48:54 +00:00
Csoregi Natalia
55e9fe527f
Backed out 3 changesets (bug 1645234) for causing leaks. CLOSED TREE
...
Backed out changeset 6097753dbefa (bug 1645234)
Backed out changeset f74844ba692a (bug 1645234)
Backed out changeset a90a3c1efdc5 (bug 1645234)
2020-07-10 01:54:09 +03:00
Andrea Marchesini
3c1b71a6e4
Bug 1651618 - Use cookie 'SameSite' attribute with capital 'S' everywhere, r=flod,fluent-reviewers,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,whimboo,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D82872
2020-07-09 20:40:15 +00:00
Johann Hofmann
a2b45ec970
Bug 1645234 - Add a test for document.requestStorageAccess error messages. r=nchevobbe
...
Depends on D79788
Differential Revision: https://phabricator.services.mozilla.com/D80972
2020-07-09 20:13:04 +00:00
Julian Descottes
7b9705ac23
Bug 1650336 - Add the session id to the WebconsoleAddMessages marker label r=nchevobbe
...
An issue with the current approach is that labels are a bit too big for the marker chart sidebar in the profiler UI.
An issue was filed to address this at https://github.com/firefox-devtools/profiler/issues/2638
Differential Revision: https://phabricator.services.mozilla.com/D82772
2020-07-09 16:36:18 +00:00
Nicolas Chevobbe
d7fdb5bb73
Bug 1644186 - Add server support for Error messages resources. r=ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D81356
2020-07-09 12:39:22 +00:00
Razvan Maries
3ed03d134b
Backed out changeset 162bc74a2c75 (bug 1644186) for perma failures on browser_webconsole_stubs_page_error.js. CLOSED TREE
2020-07-09 15:20:24 +03:00
Andreea Pavel
4d223b739e
Backed out 3 changesets (bug 1645234) for failing browser_webconsole_requestStorageAccess_errors.js on a CLOSED TREE
...
Backed out changeset ad1f8a4d64cf (bug 1645234)
Backed out changeset 6de9007aa306 (bug 1645234)
Backed out changeset 87d5d468c7f2 (bug 1645234)
2020-07-09 13:05:14 +03:00
Nicolas Chevobbe
cf209b6c53
Bug 1644186 - Add server support for Error messages resources. r=ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D81356
2020-07-09 08:55:49 +00:00
Johann Hofmann
4d4f4b4de2
Bug 1645234 - Add a test for document.requestStorageAccess error messages. r=nchevobbe
...
Depends on D79788
Differential Revision: https://phabricator.services.mozilla.com/D80972
2020-07-09 08:55:05 +00:00
Dorel Luca
3e4da6b273
Backed out changeset 00e12ae2d596 (bug 1649910) for Browser-chrome failures in browser/browser_ext_devtools_inspectedWindow_targetSwitch.js. CLOSED TREE
2020-07-09 03:58:43 +03:00