Commit Graph

791 Commits

Author SHA1 Message Date
Marco Bonardo
cc99e09b2b Bug 1511693 - Expose base classes for providers and muxers. r=Standard8
Creates base classes for providers and muxers. All the classes are exposed
by UrlbarUtils, for 2 reasons:
1. UrlbarProvidersManager on instantiation is importing provider modules, that
   may reimport the manager module. Exposing classes from it could cause a
   recursive failure.
2. It's nicer if only one of the urlbar modules exports multiple symbols (thus
   moving the QueryContext class here too)

Differential Revision: https://phabricator.services.mozilla.com/D14760

--HG--
extra : moz-landing-system : lando
2018-12-19 12:57:43 +00:00
terrameijar
9f28cc669c Bug 1506611 - Fixed linter errors in testing/awsy and testing/geckodriver r=ahal
Before this change, testing/awsy had 94 errors and testing/geckodriver had 17. The errors have been resolved

Differential Revision: https://phabricator.services.mozilla.com/D14712

--HG--
extra : moz-landing-system : lando
2018-12-18 21:31:59 +00:00
Sylvestre Ledru
48ac5d6783 Bug 1514770 - Fix the clang-format hook for git r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D14754

--HG--
extra : moz-landing-system : lando
2018-12-17 19:12:06 +00:00
Sylvestre Ledru
bb324b9dad Bug 1514755 - lint hooks: Use local path instead of absolute r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D14745

--HG--
extra : moz-landing-system : lando
2018-12-17 14:54:11 +00:00
Mark Banner
32345283e0 Bug 1503674 - Remove unused microformats code. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D14679

--HG--
extra : moz-landing-system : lando
2018-12-17 09:32:27 +00:00
Sylvestre Ledru
e985f5ee15 Bug 1507007 - Add a clang-format hook r=ahal,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D13711

--HG--
extra : moz-landing-system : lando
2018-12-14 19:43:28 +00:00
Mark Banner
0304564ac7 Bug 1415483 - Apply the new options to reject-importGlobalProperties across the codebase, remove unnecessary importGlobalProperties. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D13754

--HG--
extra : moz-landing-system : lando
2018-12-11 21:39:40 +00:00
Mark Banner
e2234d6da6 Bug 1415483 - Extend reject-importGlobalProperties to reject any priviliged items already in scope. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D13753

--HG--
extra : moz-landing-system : lando
2018-12-11 21:39:38 +00:00
Csoregi Natalia
9e970681f2 Backed out 2 changesets (bug 1415483) for multiple failures e.g. on test_message_manager_ipc.html. CLOSED TREE
Backed out changeset d00748de66fc (bug 1415483)
Backed out changeset 8dea94258f54 (bug 1415483)
2018-12-11 19:30:57 +02:00
Mark Banner
1abdc8687f Bug 1415483 - Apply the new options to reject-importGlobalProperties across the codebase, remove unnecessary importGlobalProperties. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D13754

--HG--
extra : moz-landing-system : lando
2018-12-11 14:09:44 +00:00
Mark Banner
4d543888a6 Bug 1415483 - Extend reject-importGlobalProperties to reject any priviliged items already in scope. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D13753

--HG--
extra : moz-landing-system : lando
2018-12-11 14:09:24 +00:00
Mark Banner
ff9179a99e Bug 1507487 - Handling of importScripts by ESLint should fallback to the file name if there is no entry in modules.json. r=mossop
We already have a fallback for items that aren't in a worker scope, we should have the same for ones that are. This means we don't need single maps (foo.js -> foo) in modules.json, and also we can identify more as explicit variables, so that no-unused-vars can detect them.

Differential Revision: https://phabricator.services.mozilla.com/D13299

--HG--
extra : moz-landing-system : lando
2018-12-11 09:31:26 +00:00
Cosmin Sabou
e3d5f2a521 Backed out changeset 6f69dc19ed7c (bug 1507487) for devtools failures on browser_scratchpad_pprint.js CLOSED TREE 2018-12-10 19:04:49 +02:00
Mark Banner
d4cd673de5 Bug 1507487 - Handling of importScripts by ESLint should fallback to the file name if there is no entry in modules.json. r=mossop
We already have a fallback for items that aren't in a worker scope, we should have the same for ones that are. This means we don't need single maps (foo.js -> foo) in modules.json, and also we can identify more as explicit variables, so that no-unused-vars can detect them.

Differential Revision: https://phabricator.services.mozilla.com/D13299

--HG--
extra : moz-landing-system : lando
2018-12-06 17:27:56 +00:00
Andrew Halberstadt
ce87b08ac4 Bug 1436037 - [python] Create Windows python-test tasks, r=gps
The following python-test paths are being moved out of 'make check' and into their own task:
- python/mozlint
- testing/mozbase
- tools/lint

The following python-test paths previously did not run on Windows:
- python/mozterm
- testing/marionette
- testing/raptor
- tools/tryselect

Differential Revision: https://phabricator.services.mozilla.com/D10759

--HG--
extra : moz-landing-system : lando
2018-12-05 19:20:16 +00:00
Tom Prince
5cacb2dfc9 Bug 1509962: [mozrelease] Add mozrelease to in-tree lint config; r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D12975

--HG--
extra : moz-landing-system : lando
2018-12-03 06:44:08 +00:00
Mark Banner
da86564348 Bug 1511079 - Don't apply the node wrapper for npm when on windows. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D13456

--HG--
extra : moz-landing-system : lando
2018-11-29 21:41:13 +00:00
Dão Gottwald
859de3e25b Bug 1510579 - Load scripts in global-scripts.inc the same way browser.xul does. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D13237

--HG--
extra : moz-landing-system : lando
2018-11-28 16:13:16 +00:00
Andrew Halberstadt
7b0d039311 Bug 1509391 - [eslint] Ignore excluded files that mozlint wasn't able to handle automatically r=Standard8
Normally eslint handles its own file exclusions, but there are still some
globally excluded paths that |mach lint| passes in (e.g objdirs and things in
ThirdPartyPaths.txt).

This makes sure that if they show up in the 'config', we handle them.

Differential Revision: https://phabricator.services.mozilla.com/D12712

--HG--
extra : moz-landing-system : lando
2018-11-28 15:16:19 +00:00
Dão Gottwald
0f23fd4558 Bug 1509309 - Move most browser-*.js scripts from global-scripts.inc to browser.xul. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D13064

--HG--
extra : moz-landing-system : lando
2018-11-27 21:55:21 +00:00
Mark Banner
235ab837b2 Bug 1509270 - Allow 'location' as a writeable global property for ESLint (previously read-only). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D12748

--HG--
extra : moz-landing-system : lando
2018-11-27 18:55:11 +00:00
Tom Prince
4f07d7aa2e Bug 1482395: [mozrelease] Generate whats new blob and populate it during release; r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D12708

--HG--
extra : moz-landing-system : lando
2018-11-26 17:51:23 +00:00
Mark Banner
43e3063ea9 Bug 1509387 - When setting up ESLint, call npm via node so that node doesn't need to be in the path. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D12742

--HG--
extra : moz-landing-system : lando
2018-11-27 14:46:53 +00:00
Andreea Pavel
5208359b12 Backed out changeset f851c3e82c2b (bug 1509387) for build bustages on a CLOSED TREE 2018-11-27 12:17:23 +02:00
Mark Banner
a74ab6032f Bug 1509387 - When setting up ESLint, call npm via node so that node doesn't need to be in the path. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D12742

--HG--
extra : moz-landing-system : lando
2018-11-26 20:49:00 +00:00
Dorel Luca
37e525df6c Backed out changeset c8e417bfccfb (bug 1509391) for build bustage. CLOSED TREE 2018-11-27 00:00:46 +02:00
Andrew Halberstadt
afd8a94f03 Bug 1509391 - [eslint] Ignore excluded files that mozlint wasn't able to handle automatically r=Standard8
Normally eslint handles its own file exclusions, but there are still some
globally excluded paths that |mach lint| passes in (e.g objdirs and things in
ThirdPartyPaths.txt).

This makes sure that if they show up in the 'config', we handle them.

Differential Revision: https://phabricator.services.mozilla.com/D12712

--HG--
extra : moz-landing-system : lando
2018-11-26 14:16:59 +00:00
Mark Banner
84c4aa45ce Bug 1502048 - Update the list of ESLint globals for recent JSM scope changes. r=nika,mossop
This patch creates a new list of privileged globals, based on the webidl bindings. The list of jsm globals is reduced to only the ones specially extended to that scope.

The privileged globals are enabled everywhere for the time being - although we likely could limit scopes, doing so is difficult with our current mozilla-central layout and configuration settings.

Differential Revision: https://phabricator.services.mozilla.com/D12302

--HG--
extra : moz-landing-system : lando
2018-11-22 16:46:19 +00:00
Mathieu Leplatre
2cc780ec8e Bug 1502146 - Reduce impact of RemoteSettings synchronization on main thread r=Gijs
Move JSON dump loading and CanonicalJSON serialization to a worker to reduce impact on main thread

Differential Revision: https://phabricator.services.mozilla.com/D10064

--HG--
extra : moz-landing-system : lando
2018-11-20 14:00:06 +00:00
Andreea Pavel
ec618b5047 Backed out changeset 81abb539b39c (bug 1502146) for failing services/settings/test/unit/test_remote_settings_worker.js on a CLOSED TREE 2018-11-20 02:13:24 +02:00
Mathieu Leplatre
7c4c9e8608 Bug 1502146 - Reduce impact of RemoteSettings synchronization on main tread r=Gijs
Move JSON dump loading and CanonicalJSON serialization to a worker to reduce impact on main thread

Differential Revision: https://phabricator.services.mozilla.com/D10064

--HG--
extra : moz-landing-system : lando
2018-11-19 21:56:28 +00:00
Mark Banner
8fb3e110a9 Bug 1508322 - Define 'importGlobalProperties' variables as explicit in ESLint to help identify unused variables. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D12327

--HG--
extra : moz-landing-system : lando
2018-11-19 18:23:16 +00:00
Andrea Marchesini
e4c7d00316 Bug 1492036 - Reporting API - part 5 - tests, r=smaug 2018-11-14 20:02:33 +01:00
Junior Hsu
1dbcaab155 Bug 1504323 - P2 Enable ESLint for netwerk/test/httpserver/ (manual changes) r=Standard8,dragana
Differential Revision: https://phabricator.services.mozilla.com/D10986

--HG--
extra : moz-landing-system : lando
2018-11-09 11:28:32 +00:00
arthur.iakab
895ff2021d Merge mozilla-central to inbound 2018-11-07 23:56:03 +02:00
Mark Striemer
1f6ce6a3f9 Bug 1504890 - Restrict usage of event global r=Standard8,ahal
The event global is only available on Nightly so it should not be used.

Differential Revision: https://phabricator.services.mozilla.com/D10984
Differential Revision: https://phabricator.services.mozilla.com/D11125

--HG--
extra : rebase_source : 43d8c198a1eb9c633922d077a219f1cf17b811c1
2018-11-06 16:35:05 -06:00
Andrew Halberstadt
971c025237 Bug 1503599 - [mozlint] Default lineno to 0 in result.Issue if unset, r=jgraham
This assumes that a lineno of 0 denotes a "file-level" issue, e.g an issue
associated with the filename. In the future it might be better to treat these
"file-level" issues as first class citizens. This would involve updating things
like formatters, editor integrations and review bot to not assume a lineno.

Differential Revision: https://phabricator.services.mozilla.com/D10383

--HG--
extra : moz-landing-system : lando
2018-11-07 15:21:31 +00:00
Kris Maglione
288ea557d8 Bug 1482091: Part 1 - Add native TelemetryStopwatch implementation. r=chutten,mccr8
This implementation is considerably more memory efficient than the existing JS
implementation. Migrating to it fully saves us about 28K per base content
process.

Differential Revision: https://phabricator.services.mozilla.com/D9887

--HG--
extra : source : a19c6b3e0402d16a77185f82d9fedab83a7ca52e
extra : intermediate-source : 28a19b7290ab288a1cb2cbf6d49f905cecc9682b
2018-10-26 13:17:55 -07:00
arthur.iakab
0c81738411 Backed out 2 changesets (bug 1482091) for bc failures on browser_domFullscreen_fullscreenMode.js
Backed out changeset bc03f101937e (bug 1482091)
Backed out changeset 28a19b7290ab (bug 1482091)
2018-11-03 01:08:36 +02:00
Kris Maglione
bee3f68fdc Bug 1482091: Part 1 - Add native TelemetryStopwatch implementation. r=chutten,mccr8
This implementation is considerably more memory efficient than the existing JS
implementation. Migrating to it fully saves us about 28K per base content
process.

Differential Revision: https://phabricator.services.mozilla.com/D9887

--HG--
extra : source : a19c6b3e0402d16a77185f82d9fedab83a7ca52e
2018-10-26 13:17:55 -07:00
arthur.iakab
cf2aa54f83 Backed out 2 changesets (bug 1482091)for failing browser chrome failures on browser_panelUINotifications_fullscreen_noAutoHideToolbar.js
Backed out changeset afd0a13bcfff (bug 1482091)
Backed out changeset a19c6b3e0402 (bug 1482091)
2018-11-02 23:01:15 +02:00
Kris Maglione
4bd1fb01dd Bug 1482091: Part 1 - Add native TelemetryStopwatch implementation. r=chutten,mccr8
This implementation is considerably more memory efficient than the existing JS
implementation. Migrating to it fully saves us about 28K per base content
process.

Differential Revision: https://phabricator.services.mozilla.com/D9887

--HG--
extra : rebase_source : f358f1f7097eaa8cd62ae916d048a58489e9f5ff
extra : histedit_source : c44c42de02750d71e23e70fdf22d3c3a40b91d3d
2018-10-26 13:17:55 -07:00
Julian Descottes
260b1e16a3 Bug 1467712 - Fail if SimpleTest ok() is called with more than 2 arguments;r=Standard8
Depends on D10417

Differential Revision: https://phabricator.services.mozilla.com/D10418

--HG--
extra : moz-landing-system : lando
2018-11-01 13:50:27 +00:00
Csoregi Natalia
faba2c8c15 Backed out 4 changesets (bug 1467712) for multiple failures with: Too many arguments passed to ok. CLOSED TREE
Backed out changeset 9ce0ac2b9d71 (bug 1467712)
Backed out changeset 026eb1f6dc6e (bug 1467712)
Backed out changeset 0088a09d869a (bug 1467712)
Backed out changeset 1b19ea76aad6 (bug 1467712)
2018-11-01 15:22:52 +02:00
Julian Descottes
8e101fd73a Bug 1467712 - Fail if SimpleTest ok() is called with more than 2 arguments;r=Standard8
Depends on D10417

Differential Revision: https://phabricator.services.mozilla.com/D10418

--HG--
extra : moz-landing-system : lando
2018-11-01 11:12:37 +00:00
Tom Prince
2819b8db83 Bug 1403131: [mozharness] Run lint against tests; r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D10250

--HG--
extra : moz-landing-system : lando
2018-10-30 17:02:10 +00:00
Mark Banner
0909ebdd11 Bug 1500483 - Clarify the type of window that should be passed to UrlbarController, and tidy usages of the window in the controller. r=mak
Depends on D9926

Differential Revision: https://phabricator.services.mozilla.com/D9927

--HG--
extra : moz-landing-system : lando
2018-10-29 10:23:31 +00:00
Nika Layzell
84828b5af3 Bug 1501124 - Switch BackstagePass to use WebIDLGlobalNameHash, r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D9736
2018-10-25 10:24:36 -04:00
Mark Banner
ceaeb93550 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389

--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
Andrew Halberstadt
8dbaa4117c Bug 1375861 - [mozlint] Globally exclude paths listed in tools/rewriting/ThirdPartyPaths.txt from our linters, r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D9126

--HG--
extra : moz-landing-system : lando
2018-10-18 15:27:59 +00:00