Commit Graph

64 Commits

Author SHA1 Message Date
Gabriel Luong
b045aa35a7 Bug 1478397 - Part 11: Add a prev button to navigate from the flex item sizing view to flex container view. r=rcaliman 2018-09-18 09:46:02 -04:00
Gabriel Luong
c4de83b6c4 Bug 1478397 - Part 10: Adjust the flexbox header to match the design spec. r=rcaliman 2018-09-18 09:46:01 -04:00
Tiberius Oros
6fc40ffa3f Backed out 5 changesets (bug 1478397) for failures on browser/base/content/test/static/browser_parsable_css.js on a CLOSED TREE
Backed out changeset c7db1d98d62b (bug 1478397)
Backed out changeset 588d147e401b (bug 1478397)
Backed out changeset b11a8565deff (bug 1478397)
Backed out changeset faf1ea0e1a15 (bug 1478397)
Backed out changeset 8a5ca81f8429 (bug 1478397)
2018-09-18 18:10:34 +03:00
Gabriel Luong
c79f893c91 Bug 1478397 - Part 11: Add a prev button to navigate from the flex item sizing view to flex container view. r=rcaliman 2018-09-18 09:46:02 -04:00
Gabriel Luong
006772468b Bug 1478397 - Part 10: Adjust the flexbox header to match the design spec. r=rcaliman 2018-09-18 09:46:01 -04:00
Gabriel Luong
74d7f402ee Bug 1478397 - Part 7: Add a flex item selector in the flexbox panel. r=rcaliman 2018-09-07 20:00:27 -04:00
Gabriel Luong
7e6297bc79 Bug 1478397 - Part 6: Refactor the styles in the layout panel. r=rcaliman 2018-09-05 16:04:16 -04:00
Gabriel Luong
9fc3862325 Bug 1478397 - Part 5: Display the flex item sizing properties in the flexbox panel. r=rcaliman 2018-08-29 17:38:08 -04:00
Gabriel Luong
a1ebb667da Bug 1478397 - Part 2: Display an ordered list of flex items when the flex container is highlighted. r=rcaliman 2018-08-28 10:43:40 -04:00
Gabriel Luong
78fb8e5871 Bug 1478397 - Part 0: Reorganize the flex container checkbox and flex container properties to match new designs. r=rcaliman
--HG--
rename : devtools/client/inspector/flexbox/components/FlexContainerItem.js => devtools/client/inspector/flexbox/components/FlexContainer.js
2018-08-28 10:43:39 -04:00
Gabriel Luong
62e0916083 Bug 1484483 - Part 3: Show the list of flex container properites in the Flexbox panel. r=rcaliman
--HG--
rename : devtools/client/inspector/boxmodel/components/ComputedProperty.js => devtools/client/inspector/layout/components/ComputedProperty.js
2018-08-22 21:07:08 -04:00
Gabriel Luong
8ed2afff22 Bug 1472566 - Add a color picker to the flexbox listings to change the flexbox highlighter colour. r=jdescottes 2018-07-17 15:29:21 -04:00
Andreea Pavel
3fc22dbcb2 Backed out changeset 727a835af2ff (bug 1472566) for failing devtools at devtools/client/inspector/grids/test/browser_grids_color-in-rules-grid-toggle.js on a CLOSED TREE 2018-07-17 23:40:37 +03:00
Gabriel Luong
02a0aef58d Bug 1472566 - Add a color picker to the flexbox listings to change the flexbox highlighter colour. r=jdescottes 2018-07-17 15:29:21 -04:00
Patrick Brosset
e5e709834d Bug 1459142 - Flow the color swatch after the grid item text in the layout panel; r=gl
MozReview-Commit-ID: 5HJJvoSToYI

--HG--
extra : rebase_source : f3951acf168e26bbda0ff0b3c6fda701a89a05d2
2018-05-17 17:20:32 +02:00
Gabriel Luong
047a8388d4 Bug 1452206 - Tweak spacing and alignment of items in the Inspector Layout panel. r=jdescottes 2018-04-30 11:24:04 -04:00
Gabriel Luong
9f8c11489e Bug 1432599 - Part 2: Display the current flex container element in the flexbox panel and allow for toggling of the flexbox highlighter. r=pbro 2018-02-07 15:57:46 -05:00
Ciure Andrei
ddcf44b20a Backed out changeset a4ae1745e9d4 (bug 1432599) for mochitest devtools failures, a=backout on a CLOSED TREE 2018-02-08 00:24:44 +02:00
Gabriel Luong
a2a3d02cd4 Bug 1432599 - Part 2: Display the current flex container element in the flexbox panel and allow for toggling of the flexbox highlighter. r=pbro 2018-02-07 15:57:46 -05:00
Gabriel Luong
14c3320daf Bug 1355747 - Disable and remove layout panel promotion code in release 58. r=jdescottes 2017-10-13 10:42:32 -04:00
Sebastian Hengst
97d6d2c4a3 Backed out changeset 508179b0dad5 (bug 1355747) for linting failure at devtools/client/inspector/layout/layout.js:7: 'Services' is assigned a value but never used. r=backout
--HG--
extra : amend_source : 5bb79fd7f5c4d55500536d65ef46d5b60afc9a6c
2017-10-13 17:18:00 +02:00
Gabriel Luong
1227230888 Bug 1355747 - Disable and remove layout panel promotion code in release 58. r=jdescottes 2017-10-13 10:42:32 -04:00
Gabriel Luong
f161fe5430 Bug 1390727 - Add a consistent style for all the no result messages in the inspector sidepanel. r=bgrins 2017-08-16 10:36:55 -07:00
Micah Tigley
031a9caed5 Bug 1356474 - Add units tests for the Grid Outline component. r=gl
MozReview-Commit-ID: 85ZjxjkpIgU
2017-06-08 19:12:25 -06:00
Sebastian Hengst
7fac060768 Backed out changeset 955e237fc290 (bug 1356474) for frequently failing own test browser_grids_grid-outline-selected-grid.js. r=backout 2017-06-16 12:55:31 +02:00
Micah Tigley
c4243d211b Bug 1356474 - Add units tests for the Grid Outline component. r=gl
MozReview-Commit-ID: 85ZjxjkpIgU
2017-06-08 19:12:25 -06:00
Phil Ringnalda
2eb8aebb84 Backed out changeset ac1520300fc7 (bug 1356474) for failures in browser_grids_grid-outline-cannot-show-outline.js
MozReview-Commit-ID: 78R9AGsRIY5
2017-06-15 20:29:40 -07:00
Micah Tigley
b5c9740d92 Bug 1356474 - Add units tests for the Grid Outline component. r=gl
MozReview-Commit-ID: 85ZjxjkpIgU
2017-06-08 19:12:25 -06:00
Gabriel Luong
8cda8dcb70 Bug 1348004 - Display a new! indicator and a promote message bar to the layout panel. r=jdescottes 2017-06-14 00:52:03 -04:00
Micah Tigley
7f37d4cec1 Bug 1348471 - Display a message when the grid outline cannot effectively be fitted inside the layout panel. r=gl
MozReview-Commit-ID: 57cikdLW3IV
2017-05-24 19:40:07 -06:00
Carsten "Tomcat" Book
793a04d5d4 Backed out changeset fc3bbe02ce7d (bug 1348471) for test failures in browser_misused_characters_in_strings.js 2017-05-30 08:21:53 +02:00
Micah Tigley
d7a7ea94cf Bug 1348471 - Display a message when the grid outline cannot effectively be fitted inside the layout panel. r=gl
MozReview-Commit-ID: 57cikdLW3IV
2017-05-24 19:40:07 -06:00
Patrick Brosset
db018b15bc Bug 1359759 - 2 - Clear React warnings in GridOutline and prevent re-renders; r=gl
Made the GridOutline component work with only 1 grid at a time.
It already did, but in a not so obvious way.

Removed the setState that happened during the render call to avoid
React warnings.

Cleaned up various data attribute to use the dataset property instead.

Removed the mouseover/out that controled the background color of the
highlighted cells. This now happens in CSS :hover, using currentColor.

Avoided React warnings related to missing "key" props.

Made changes to grid-inspector to avoid loops of re-renders when the
highlighter would highlight a cell on hover.
The component would wait for highlighter's events to dispatch store
actions. Instead, we dispatch them first, then when the events come, we
check if things have really changed! This way, the events will still have
effect if they come from the rule-view for instance, but not if they
come from the grid outline itself.

MozReview-Commit-ID: 6LK8B1P8iMU

--HG--
extra : rebase_source : 473ca1e1777d4e14f4f45a0b306b8153775cb1e6
2017-05-10 16:07:12 +02:00
Stanford Lockhart
04e80c9397 Bug 1349691: Polish the grid inspector and layout tab. r=jdescottes
MozReview-Commit-ID: DPYqfcDRKcs
2017-03-29 17:31:46 -03:00
Micah Tigley
52c25ed101 Bug 1347336 - Display grid line name and position in Grid Highlighter. r=gl
MozReview-Commit-ID: EbUKzd5zqaw
2017-04-11 13:31:22 -06:00
Micah Tigley
225b5f860e Bug 1343447 - Bug 1343447 - Maintain aspect ratio of grid outline. r=pbro
MozReview-Commit-ID: 97mdXIyDhSw
2017-03-24 14:01:09 -06:00
Stanford Lockhart
a66ac2238e Bug 940275 - Part 1: Add positioning properties to box model r=gl
MozReview-Commit-ID: AB5fREjDhsD
2017-02-28 18:18:28 -04:00
Micah Tigley
7e265d8203 Bug 1337235 - Mouseover interaction for grid outline. r=gl
MozReview-Commit-ID: 4qZfle2lDMZ
2017-02-25 23:42:45 -07:00
Micah Tigley
2df911255f Bug 1308268 - Add a Grid Outline to layout panel. r=gl
MozReview-Commit-ID: 5BjnFGO5PmD
2017-02-22 22:58:56 -07:00
Julian Descottes
5551adf76e Bug 1338300 - part3: add colorpicker to update grid overlay color;r=gl
MozReview-Commit-ID: 5wgZCgx8J3u

--HG--
extra : rebase_source : 88ffb25a7737d4ea44911a7d6101454298387824
2017-02-22 12:39:04 +01:00
Gabriel Luong
d30ffce04d Bug 1308263 - Part 3: Add a grid display setting for extending the grid lines infinitely. r=jryans 2016-11-29 19:38:08 +08:00
Gabriel Luong
1452e4f287 Bug 1308260 - Part 7: Display a list of grid container elements and checkbox to toggle the grid highlighter for each grid in the CSS grid layout panel. r=jryans 2016-11-29 19:33:04 +08:00
Gabriel Luong
3d344123f0 Bug 1308260 - Part 4: Pass the grids props into the layout components and only display the layout-no-grid element when no grids are present. r=jryans 2016-11-22 02:07:44 +08:00
Gabriel Luong
12db19ad54 Bug 1315208 - Remove explicit call to ReactDOM.render in the LayoutView r=Honza 2016-11-12 22:00:48 +09:00
Carsten "Tomcat" Book
33c30ae971 Backed out changeset 487a5da50e56 (bug 1315208) for conflicting with autoland/mozilla-inbound to m-c merge
--HG--
extra : rebase_source : eae62bb9af0b2e4bca0b4dea95218a9113d58f72
2016-11-11 16:39:11 +01:00
Gabriel Luong
816e24e14b Bug 1315208 - Remove explicit call to ReactDOM.render in the LayoutView r=Honza 2016-11-11 01:31:13 +09:00
Gabriel Luong
fcb13d2ea2 Bug 1308227 - Add a CSS Grid accordion container to the layout panel r=jdescottes
MozReview-Commit-ID: ElJnsdJYXA

--HG--
extra : rebase_source : 6aa2e2955c3152530ca5c27e4360097962de5426
2016-10-14 20:31:04 -04:00
Gabriel Luong
0515d3805c Bug 1302496 - Refactor LayoutView to a Box Model component r=jdescottes
--HG--
rename : devtools/client/inspector/layout/layout.js => devtools/client/inspector/components/box-model.js
rename : devtools/client/inspector/layout/test/.eslintrc => devtools/client/inspector/components/test/.eslintrc
rename : devtools/client/inspector/layout/test/browser.ini => devtools/client/inspector/components/test/browser.ini
rename : devtools/client/inspector/layout/test/browser_layout.js => devtools/client/inspector/components/test/browser_boxmodel.js
rename : devtools/client/inspector/layout/test/browser_layout_editablemodel.js => devtools/client/inspector/components/test/browser_boxmodel_editablemodel.js
rename : devtools/client/inspector/layout/test/browser_layout_editablemodel_allproperties.js => devtools/client/inspector/components/test/browser_boxmodel_editablemodel_allproperties.js
rename : devtools/client/inspector/layout/test/browser_layout_editablemodel_bluronclick.js => devtools/client/inspector/components/test/browser_boxmodel_editablemodel_bluronclick.js
rename : devtools/client/inspector/layout/test/browser_layout_editablemodel_border.js => devtools/client/inspector/components/test/browser_boxmodel_editablemodel_border.js
rename : devtools/client/inspector/layout/test/browser_layout_editablemodel_stylerules.js => devtools/client/inspector/components/test/browser_boxmodel_editablemodel_stylerules.js
rename : devtools/client/inspector/layout/test/browser_layout_guides.js => devtools/client/inspector/components/test/browser_boxmodel_guides.js
rename : devtools/client/inspector/layout/test/browser_layout_rotate-labels-on-sides.js => devtools/client/inspector/components/test/browser_boxmodel_rotate-labels-on-sides.js
rename : devtools/client/inspector/layout/test/browser_layout_sync.js => devtools/client/inspector/components/test/browser_boxmodel_sync.js
rename : devtools/client/inspector/layout/test/browser_layout_tooltips.js => devtools/client/inspector/components/test/browser_boxmodel_tooltips.js
rename : devtools/client/inspector/layout/test/browser_layout_update-after-navigation.js => devtools/client/inspector/components/test/browser_boxmodel_update-after-navigation.js
rename : devtools/client/inspector/layout/test/browser_layout_update-after-reload.js => devtools/client/inspector/components/test/browser_boxmodel_update-after-reload.js
rename : devtools/client/inspector/layout/test/browser_layout_update-in-iframes.js => devtools/client/inspector/components/test/browser_boxmodel_update-in-iframes.js
rename : devtools/client/inspector/layout/test/doc_layout_iframe1.html => devtools/client/inspector/components/test/doc_boxmodel_iframe1.html
rename : devtools/client/inspector/layout/test/doc_layout_iframe2.html => devtools/client/inspector/components/test/doc_boxmodel_iframe2.html
rename : devtools/client/inspector/layout/test/head.js => devtools/client/inspector/components/test/head.js
rename : devtools/client/themes/layout.css => devtools/client/themes/boxmodel.css
2016-09-13 16:35:16 -04:00
Gabriel Luong
7f3e013f27 Backed out changeset 4329f53c9f9f Bug 1291638 r=gl 2016-09-16 16:53:22 -04:00
Fred Lin
b23ef220cd Bug 1291638 - Change color theme of box-model view. r=gl
MozReview-Commit-ID: AYhPUXV2tJZ

--HG--
extra : transplant_source : d%F7%8F%94%5E%8F%BB%C0%F7U%A0%C6%1D%AF%CA%FE%8B%CD%F6%DC
2016-08-17 13:12:37 +08:00