Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 19:35:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
839,103 Commits 615 Branches 98 Tags 6 GiB
a1dc478cb8
Commit Graph

10528 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
3ce1c08d5b Bug 1828413 - Fix a11y tests so that they don't hover over the rounded corner. 
MANUAL PUSH: Trivial fix CLOSED TREE
 2023-04-20 15:28:50 +02:00
Stanca Serban
c25ebc211a Backed out 4 changesets (bug 1825611) for causing mochitests failures in accessible/tests. CLOSED TREE 
Backed out changeset 169c3f65e1ce (bug 1825611)
Backed out changeset c2d6231e9361 (bug 1825611)
Backed out changeset 9152cb7808c2 (bug 1825611)
Backed out changeset e74c388d1a4e (bug 1825611)
 2023-04-20 03:03:25 +03:00
James Teh
4ea1fca123 Bug 1751943: Fix doc tree mutation during AddChildDoc. r=nlapre 
Differential Revision: https://phabricator.services.mozilla.com/D173916
 2023-04-19 23:16:15 +00:00
Morgan Rae Reschenberg
623f4ac2d3 Bug 1825611: Add test for overflow:hidden hittesting and acc creation r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175196
 2023-04-19 22:55:39 +00:00
Morgan Rae Reschenberg
3963d05927 Bug 1825611: Ensure nodes with overflow:hidden styling always create an accessible r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175195
 2023-04-19 22:55:39 +00:00
Morgan Rae Reschenberg
f6166a5774 Bug 1825611: Trim bounds when hittesting overflow:hidden containers r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175194
 2023-04-19 22:55:39 +00:00
Morgan Rae Reschenberg
513cf054fc Bug 1825611: Cache overflow r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175193
 2023-04-19 22:55:38 +00:00
Eitan Isaacson
8c6b657874 Bug 1826870 - Fix ATK extents to used cached bounds. r=morgan 
Differential Revision: https://phabricator.services.mozilla.com/D175187
 2023-04-19 16:17:31 +00:00
Nathan LaPre
ddf6d2c246 Bug 1825516: Replace one workaround with a nicer one r=Jamie 
GCC bug 109480 describes an issue we're encountering with calling protected
member functions from within protected member functions. The previous workaround,
removed in this revision, is a bit annoying, and must be repeated when we need
to capture the return value of protected functions. Making specializations of
RemoteAccessibleBase friends of other RemoteAccessibleBase specializations, while
maybe a bit heavy-handed, is a cleaner solution here, particularly since we only
specialize with RemoteAccessible itself. This is a workaround suggested by GCC
devs in the referenced bug.

Differential Revision: https://phabricator.services.mozilla.com/D175531
 2023-04-19 01:32:56 +00:00
Iulian Moraru
0b022d176d Backed out 4 changesets (bug 1825611) for causing multiple mochitest failures. CLOSED TREE 
Backed out changeset a30a125f2aea (bug 1825611)
Backed out changeset ee5e3b614f91 (bug 1825611)
Backed out changeset c79ad1ee1e32 (bug 1825611)
Backed out changeset db2d550a788b (bug 1825611)
 2023-04-19 02:24:25 +03:00
Morgan Rae Reschenberg
80cb6ab5df Bug 1825611: Add test for overflow:hidden hittesting and acc creation r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175196
 2023-04-18 21:06:11 +00:00
Morgan Rae Reschenberg
e7373d87a0 Bug 1825611: Ensure nodes with overflow:hidden styling always create an accessible r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175195
 2023-04-18 21:06:11 +00:00
Morgan Rae Reschenberg
74f85c2b15 Bug 1825611: Trim bounds when hittesting overflow:hidden containers r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175194
 2023-04-18 21:06:11 +00:00
Morgan Rae Reschenberg
719ed5d225 Bug 1825611: Cache overflow r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175193
 2023-04-18 21:06:11 +00:00
Eitan Isaacson
feaab44730 Bug 1826851 - Unify IsSearchbox in Accessible and use cache when available. r=morgan 
Differential Revision: https://phabricator.services.mozilla.com/D174970
 2023-04-18 18:14:27 +00:00
Emilio Cobos Álvarez
8b5b7ad998 Bug 1827856 - Remove nativeAnonymousChildList observers. r=smaug,credential-management-reviewers,devtools-reviewers,sgalich,nchevobbe 
You let me know if this seems appealing to you :)

Differential Revision: https://phabricator.services.mozilla.com/D175382
 2023-04-18 14:58:34 +00:00
serge-sans-paille
89cc07cf04 Bug 1828381 - Make accessible/windows/sdn buildable outside of a unified build environment r=andi 
Differential Revision: https://phabricator.services.mozilla.com/D175594
 2023-04-18 13:43:19 +00:00
serge-sans-paille
dc8420c9d8 Bug 1828380 - Make accessible/windows/msaa buildable outside of a unified build environment r=andi 
Differential Revision: https://phabricator.services.mozilla.com/D175593
 2023-04-18 13:43:19 +00:00
serge-sans-paille
9fe0b3de0d Bug 1828379 - Make accessible/windows/ia2 buildable outside of a unified build environment r=andi 
Differential Revision: https://phabricator.services.mozilla.com/D175592
 2023-04-18 13:43:19 +00:00
serge-sans-paille
abdbe44b83 Bug 1828378 - Make accessible/mac buildable outside of a unified build environment r=andi 
Differential Revision: https://phabricator.services.mozilla.com/D175591
 2023-04-18 13:43:19 +00:00
Eitan Isaacson
489d1d11a0 Bug 1826857 - Move AnchorAt to Accessible and remove sync IPC. r=Jamie 
Because the implementation only needs the accessible type and tree, we
don't need to make an IPC call here.

Differential Revision: https://phabricator.services.mozilla.com/D175288
 2023-04-17 17:54:35 +00:00
Eitan Isaacson
4a2d824c2a Bug 1826855 - Remove AnchorCount sync IPC message and implement in Accessible. r=Jamie 
AnchorCount only needs the accessible type and child count. We already
cache that with or without CtW.

Differential Revision: https://phabricator.services.mozilla.com/D175273
 2023-04-17 17:54:34 +00:00
Eitan Isaacson
55dcdc4250 Bug 1826854 - Put IsLinkValid() is base Accessible. r=Jamie 
If caching is enabled it will use the cached state, if it isn't it will
do a sync State IPDL call. Also removed the specialized sync IsLinkValid
call because it essentially just did a State() check in the child.

Differential Revision: https://phabricator.services.mozilla.com/D175270
 2023-04-17 17:54:34 +00:00
Eitan Isaacson
55ac968c09 Bug 1826858 - Eliminate LinkAt sync IPDL call. r=nlapre 
No need for this.

Differential Revision: https://phabricator.services.mozilla.com/D175291
 2023-04-14 18:38:18 +00:00
Eitan Isaacson
d70f1224fa Bug 1826264 - P2: Add range TextLeafRange::ScrollIntoView. r=Jamie 
Use it when caching is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D174977
 2023-04-13 20:40:19 +00:00
Eitan Isaacson
60909e6894 Bug 1826264 - P1: Implement TextLeafPoint::ToDOMPoint. r=Jamie 
Generalized code we already had for getting DOM points for DOM
selection.

Differential Revision: https://phabricator.services.mozilla.com/D174976
 2023-04-13 20:40:19 +00:00
Otto Länd
37c1e8285c Bug 1825891: apply code formatting via Lando 
# ignore-this-changeset
 2023-04-13 18:04:17 +00:00
Eitan Isaacson
c275c3a7d9 Bug 1825891 - P2: Remove Android's non-CTW implementation. r=Jamie,geckoview-reviewers,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D174516
 2023-04-13 17:58:57 +00:00
Emilio Cobos Álvarez
a5fdc9874c Bug 1826688 - Shrink down StyleInfo. r=morgan 
Most of the methods have only one caller that guarantees it has a
primary frame (good!).

But others didn't quite guarantee that.

Differential Revision: https://phabricator.services.mozilla.com/D175042
 2023-04-12 08:43:15 +00:00
Cosmin Sabou
89ecf0ab85 Backed out changeset d6af78936bdb (bug 1826851) for causing assertion failures on dom/base/nsAttrValueInlines.h. CLOSED TREE 2023-04-12 02:15:21 +03:00
Eitan Isaacson
04e98136b0 Bug 1826851 - Unify IsSearchbox in Accessible and use cache when available. r=morgan 
Differential Revision: https://phabricator.services.mozilla.com/D174970
 2023-04-11 21:58:46 +00:00
Eitan Isaacson
86eeb959fa Bug 1826852 - Use caching version of CharAt when available. r=nlapre 
Differential Revision: https://phabricator.services.mozilla.com/D174971
 2023-04-11 21:58:09 +00:00
Nathan LaPre
65baef59a3 Bug 1825516: Work around suspected gcc bug, r=morgan,eeejay 
This revision works around a suspected bug in gcc which was causing
build failures. The compiler would complain that ApplyScrollOffset was
protected, and therefore inaccessible, if we capture the return value
of that function within BoundsWithOffset. I don't think this actually
violates any C++ rules, and other compilers agree. To work around the
problem, this revision wraps the call to ApplyScrollOffset in an
immediately-invoked lambda, which satisfies gcc for some reason.

Differential Revision: https://phabricator.services.mozilla.com/D174697
 2023-04-05 21:35:49 +00:00
Emilio Cobos Álvarez
641fa20731 Bug 1825825 - Simplify NAC setup. r=smaug 
Make all UA widgets also NAC.

Keep the UA widget flag but break at anonymous subtree boundaries, so
that only nodes inside the UA widget directly (and not NAC from those)
get the flag.

This is important because two callers depend on this difference:

 * The style system, since we still want to match content rules from
   stylesheets in the UA widget. We also match user rules, which is a
   bit sketchy, but that was the previous behavior, will file a
   follow-up for that.

 * The reflector code, since we want the scope for UA widgets to not
   include the NAC nodes inside that UA widget. nsINode::IsInUAWidget
   got it wrong.

After this patch, ChromeOnlyAccess is equivalent to
IsInNativeAnonymousSubtree, so we should probably unify the naming.
That's left for a follow-up patch because I don't have a strong
preference.

Differential Revision: https://phabricator.services.mozilla.com/D174310
 2023-04-05 09:19:15 +00:00
Robert Longson
03d9d7fa3d Bug 1825718 - map SVG elements to a role if they have an aria-label attribute r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D174465
 2023-04-04 07:07:22 +00:00
James Teh
1f31893d00 Bug 1825523: Check IsHyperText before expecting AsHyperTextBase to work in Pivot::PrevText. r=eeejay 
The code previously checked !childAtOffset->IsText(), but this isn't sufficient to be certain that childAtOffset->AsHyperTextBase() will work.
For example, childAtOffset could be an image which can't be descended into.

Differential Revision: https://phabricator.services.mozilla.com/D174213
 2023-04-04 05:37:36 +00:00
James Teh
e0f1b9cd7d Bug 1820389: Gracefully handle unknown ARIA roles. r=eeejay,decoder 
Differential Revision: https://phabricator.services.mozilla.com/D173651
 2023-04-03 04:32:34 +00:00
serge-sans-paille
13e51277df Bug 1825324 - Make widget/* buildable outside of a unified build environment r=andi,geckoview-reviewers,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D173969
 2023-04-01 08:31:12 +00:00
Cristian Tuns
8e06a7a853 Backed out 12 changesets (bug 1825325, bug 1825336, bug 1825333, bug 1825332, bug 1825324, bug 1824557, bug 1825328, bug 1825335, bug 1825330, bug 1825329, bug 1825327, bug 1825331) for causing build bustages in nsClipboard.cpp CLOSED TREE 
Backed out changeset 9de3ed24d3a0 (bug 1825336)
Backed out changeset aef787728f19 (bug 1825335)
Backed out changeset a04c341244c1 (bug 1825333)
Backed out changeset e3ad15f762ba (bug 1825332)
Backed out changeset eed23da92a27 (bug 1825331)
Backed out changeset 8213bb54376e (bug 1825330)
Backed out changeset 747ec5ac4994 (bug 1825329)
Backed out changeset e91ff431f92d (bug 1825328)
Backed out changeset 59c18d13768b (bug 1825327)
Backed out changeset 538096d99e49 (bug 1825325)
Backed out changeset c76eb9d9b095 (bug 1825324)
Backed out changeset 8b81410eb686 (bug 1824557)
 2023-03-31 12:58:53 -04:00
Butkovits Atila
be5156b4fe Backed out changeset b653a1b8816b (bug 1820389) for causing build bustages at DocAccessibleParent.cpp 2023-03-31 18:23:42 +03:00
James Teh
bd912a9924 Bug 1820389: Gracefully handle unknown ARIA roles. r=eeejay,decoder 
Differential Revision: https://phabricator.services.mozilla.com/D173651
 2023-03-31 13:53:34 +00:00
serge-sans-paille
0702cdc836 Bug 1825324 - Make widget/* buildable outside of a unified build environment r=andi,geckoview-reviewers,m_kato 
Depends on D173637

Differential Revision: https://phabricator.services.mozilla.com/D173969
 2023-03-31 13:29:44 +00:00
James Teh
a2f622b63d Bug 1824828: Handle tree mutation during RecvHideEvent. r=nlapre 
Differential Revision: https://phabricator.services.mozilla.com/D173918
 2023-03-30 17:10:19 +00:00
ogiorgis
f59f695642 Bug 1621950 - fix some myst ref warnings r=firefox-source-docs-reviewers,devtools-reviewers,sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D173843
 2023-03-30 08:01:22 +00:00
Nathan LaPre
50ae57a7d9 Bug 1819741: Constrain acc bounds to that of scroll areas for hit testing, r=morgan 
This revision adds logic to BoundsWithOffset to ensure that bounds, when
calculated for hit testing, are constrained to the scroll areas that contain
them. This ensures that we don't return an Accessible that's covered by another
element when hit testing due to overflow: scroll situations.

This revision also contains a fix for transforms and scroll: we now apply
scroll before any transform, since transforms operate on scrolled content.

This revision contains tests for both of the above changes.

Differential Revision: https://phabricator.services.mozilla.com/D173392
 2023-03-30 00:11:14 +00:00
Eitan Isaacson
545741bece Bug 1825054 - Don't get stuck in endless loop when getting bounds. r=morgan 
Differential Revision: https://phabricator.services.mozilla.com/D173864
 2023-03-29 22:31:00 +00:00
Emilio Cobos Álvarez
2d0e69f4a1 Bug 1824957 - Remove a bunch of now completely dead XUL layout code. r=layout-reviewers,desktop-theme-reviewers,devtools-reviewers,dao,TYLin 
And some related tests.

A bunch of -moz-box* properties are web exposed, so I'll file a
follow-up for hiding them.

Differential Revision: https://phabricator.services.mozilla.com/D173819
 2023-03-29 21:23:55 +00:00
James Teh
b826e71bc9 Bug 1821448: Improve handling of reentry in MsaaAccessible::VisitDocAccessibleParentDescendantsAtTopLevelInContentProcess. r=nlapre 
Differential Revision: https://phabricator.services.mozilla.com/D173652
 2023-03-29 19:42:15 +00:00
Morgan Rae Reschenberg
df1f70a647 Bug 1809761: Introduce text bounds test for interleaving block- and inline-frame accessibles r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D171918
 2023-03-28 19:23:05 +00:00
Eitan Isaacson
385aaab8e0 Bug 1823979 - Remove strict assertion in text selection. r=morgan 
I was trying to anticipate all the conditions that would bring us
to a non-text leaf text point in a text selection. But it is hard to
account for other "correct" cases so this assertion should probably just
go away.

Differential Revision: https://phabricator.services.mozilla.com/D173760
 2023-03-28 16:24:15 +00:00