Commit Graph

43 Commits

Author SHA1 Message Date
Sylvestre Ledru
03c8e8c2dd Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-05 21:41:42 +00:00
Csoregi Natalia
ba58e936bd Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE 2019-04-05 09:48:19 +03:00
Sylvestre Ledru
d1c1878603 Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:16 +00:00
Narcis Beleuzu
24dbe577a5 Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE 2019-04-05 00:27:56 +03:00
Sylvestre Ledru
399dbd28fe Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Emilio Cobos Álvarez
50f8f6a6d3 Bug 1540180 - The role of a broken input[type="image"] doesn't depend on its display value. r=surkov,eeejay
Differential Revision: https://phabricator.services.mozilla.com/D25517

--HG--
extra : moz-landing-system : lando
2019-04-01 18:51:14 +00:00
Marco Zehe
c27465e115 Bug 1461244 - Take into account row groups when creating ARIAGridRowAccessibles, r=Jamie
If all parts of a table are non-standard display types, like all elements being display:block;, we weren't properly determining table cell indices because we weren't always taking into account thead, tbody, or tfoot elements. This patch:

* Exposes non-standard tbody, tfoot and thead elements as groupings, similar to ARIA rowgroup.
* Adjusts the one instance in nsAccessibilityService::CreateAccessible that didn't account for the table not being the direct parent of the row node, but the grandparent instead.

Differential Revision: https://phabricator.services.mozilla.com/D18333

--HG--
extra : moz-landing-system : lando
2019-02-04 06:17:33 +00:00
Marco Zehe
97310d7a60 Bug 1523931 - Always create accessibles for div elements if they contain a br element, r=Jamie
After the fix for bug 646216, we no longer create divs with no text and only a br element for a line break. This breaks blank lines in contentEditables such as Gmail.

To fix, always create accessibles for divs if such a div contains a br element either as its first or last child.

Differential Revision: https://phabricator.services.mozilla.com/D18074

--HG--
extra : moz-landing-system : lando
2019-01-31 06:58:49 +00:00
Marco Zehe
61a4918bc9 Bug 646216 - Thin out the tree by only creating accessibles for relevant divs, r=Jamie,timdream
Relevant divs are:

* Those that have an ID attribute. This is important so anchors still work.
* Those whose first or last child is a text-only node.
* Those whose first or last child has an inline frame.

We now discard divs that are not display:block; or display:inline-block;. We also discard divs that are part of an anonymous subtree.

We stop creating divs from the eHyperTextType frame type alltogether.

Note that because of shadow DOM properties in the video controls, two additional divs with IDs require role="none" in the media controls widget code.

Differential Revision: https://phabricator.services.mozilla.com/D17348

--HG--
extra : moz-landing-system : lando
2019-01-29 04:17:20 +00:00
Andreea Pavel
34963c28d8 Backed out changeset 5440a333cf4b (bug 646216) for failing bc at browser_treeupdate_cssoverflow.js on a CLOSED TREE 2019-01-29 03:43:57 +02:00
Marco Zehe
881ce52030 Bug 646216 - Thin out the tree by only creating accessibles for relevant divs, r=Jamie,timdream
Relevant divs are:

* Those that have an ID attribute. This is important so anchors still work.
* Those whose first or last child is a text-only node.
* Those whose first or last child has an inline frame.

We now discard divs that are not display:block; or display:inline-block;. We also discard divs that are part of an anonymous subtree.

We stop creating divs from the eHyperTextType frame type alltogether.

Note that because of shadow DOM properties in the video controls, two additional divs with IDs require role="none" in the media controls widget code.

Differential Revision: https://phabricator.services.mozilla.com/D17348

--HG--
extra : moz-landing-system : lando
2019-01-29 00:05:53 +00:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Marco Zehe
4ae01a5d49 Bug 1380451 - create HTML table caption accessible unconditionally, r=Jamie
Creates the HTML Caption accessible from the markup map, but only if it's the first caption. Other caption elements are ignored as before.

This also creates caption accessibles for those captions that have been collapsed to zero height and width via CSS.

Differential Revision: https://phabricator.services.mozilla.com/D12756

--HG--
extra : moz-landing-system : lando
2018-11-25 23:39:52 +00:00
Marco Zehe
f86d40d773 Bug 1508935 - Create more accessibles from the HTML markup map rather than layout frame types, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D12639

--HG--
extra : moz-landing-system : lando
2018-11-23 06:49:00 +00:00
Paolo Amadini
b2a83ffc85 Bug 1499947 - Part 1 - Remove XULProgressMeterAccessible and its base template class. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D12144

--HG--
extra : rebase_source : 81275b233770a7e9716a2b811a08060fc5006e1b
2018-11-20 14:10:38 +00:00
Marco Zehe
ab92f98230 Bug 1506041 - Code cleanup: Convert more static functions to lambdas in the markup map, r=Jamie
All static functions from nsAccessibilityService that were either only called once from the markup map, or are simple one-liners that were only called up to three times, were converted to lambdas in the markup map.

the static function that creates HyperTextAccessibleWrap has remained untouched because it is called a lot from the markup map, even though its implementation is actually just a one-liner.

The other untouched static function is the templated one for html:dt or html:dd.

Differential Revision: https://phabricator.services.mozilla.com/D11458

--HG--
extra : moz-landing-system : lando
2018-11-11 23:13:35 +00:00
Marco Zehe
a7b776042d Bug 1501273 - Expose an html:form element as a landmark role if it has an accessible name, r=Jamie
If html:form has a name given via ARIA, expose it as a landmark to platform APIS that require it. At the time of this submission, this is the case for ATK.

Differential Revision: https://phabricator.services.mozilla.com/D9552

--HG--
extra : moz-landing-system : lando
2018-11-02 01:06:56 +00:00
Marco Zehe
c5581dfc0f Bug 1210630 - Section elements with accessible names should be mapped the same as ARIA role region, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D9480

--HG--
extra : moz-landing-system : lando
2018-10-24 05:34:22 +00:00
Marco Zehe
f1a7d75388 Bug 614572 - Expose the correct new landmark role for HTML aside, header, footer, main and nav elements, r=Jamie
According to the HTML Accessibility API mappings spec, aside, footer, header, main and nav elements should be mapped to the WAI-ARIA landmark role exposure. For footer and header, this is only true if scoped to the body element.

This patch changes the exposed roles to the new landmark mapping for the various platforms.

Differential Revision: https://phabricator.services.mozilla.com/D9413

--HG--
extra : moz-landing-system : lando
2018-10-23 06:11:59 +00:00
Marco Zehe
aa436fb77a Bug 1486668 - <td> with display: block doesn't get table cell semantics, r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D6158

--HG--
extra : moz-landing-system : lando
2018-09-26 08:47:35 +00:00
James Teh
2a45f8f49d Bug 903187: Map HTML ins/del to accessible roles. r=MarcoZ
IA2 now has IA2_ROLE_CONTENT_INSERTION/DELETION.
Mac has AXInsert/DeleteStyleGroup subroles.
We now create accessibles for these elements and expose the appropriate role.
For ATK, there is no specific role for these, so we just use the generic ATK_ROLE_SECTION.

MozReview-Commit-ID: 2khzRa7BQ6z

--HG--
extra : rebase_source : e1c84bdef9a23b225e9870660050790df94c4beb
2018-07-27 16:40:50 +10:00
James Teh
9febcf7435 Bug 1476347: Fix accessibility for HTML dt/dd with a div as its parent. r=MarcoZ
It is conforming in HTML to use a div to group dt/dd elements.
Previously, we didn't create an accessible for dt/dd elements in this case.

MozReview-Commit-ID: 8GDDxU3RbLd

--HG--
extra : rebase_source : 558a67e1b21583c6fac766ee1d1a24606976177f
2018-07-18 20:13:01 +10:00
Joanmarie Diggs
df8c297289 Bug 1466822 - Implement support for new blockquote, caption, and paragraph ARIA roles r=Jamie
* Create BLOCKQUOTE internal role (also needed for correct exposure of
  blockquote element on ATK)
* Add new ARIA roles to internal ARIA map
* Add new roles to existing ARIA roles mochitest and update blockquote
  element test to reflect mapping to the new internal role
2018-06-05 09:54:00 +03:00
Tiberius Oros
bd7f417d6a Backed out changeset 671ec6415311 (bug 1466822) for failing test_txtcntr.html on a CLOSED TREE 2018-06-05 19:10:13 +03:00
Joanmarie Diggs
9ef9fae7c4 Bug 1466822 - Implement support for new blockquote, caption, and paragraph ARIA roles. r=surkov
* Create BLOCKQUOTE internal role (also needed for correct exposure of
  blockquote element on ATK)
* Add new ARIA roles to internal ARIA map
* Add new roles to existing ARIA roles mochitest and update blockquote
  element test to reflect mapping to the new internal role
2018-06-05 06:46:00 -04:00
Alexander Surkov
6faf449ca5 Bug 1455357 - Setting grid item to display:contents resets its accessible role, patch=surkov,jamie, r=marcoz 2018-05-15 09:44:21 -04:00
James Teh
9a9119e893 Bug 1460244 - For tables with CSS display properties, correctly expose table interfaces to a11y clients. r=surkov
MozReview-Commit-ID: EFyn3MCth88
2018-05-10 19:45:00 +03:00
Alexander Surkov
5d3b238323 Bug 1005271 - HTML table with display:block should expose table semantics, r=marcoz 2018-05-08 13:13:38 -04:00
Marco Zehe
9998f9ab0d Bug 1316285 - Expose role and landmark role for HTML header and footer only if they are direct descendants of the body tag, section otherwise. r=eeejay
MozReview-Commit-ID: LbelxxgHlJ6

--HG--
extra : rebase_source : 6f4bbb7672cf70f15ae00abeaa41b3edc02a03f5
2017-08-28 14:30:17 +02:00
Marco Zehe
c00da5bfe0 Bug 1392926 - Only expose the Region landmark role if a section element has been explicitly named by the author, r=surkov
MozReview-Commit-ID: 6B0TSy8lqck

--HG--
extra : rebase_source : e79e1927eadb88ba107269effbdb3072427fc9ae
2017-08-28 10:48:09 +02:00
Sebastian Hengst
4acdd37bd2 Backed out changeset c216b1ee565e (bug 1392926) for failing a11y's accessible/tests/mochitest/attributes/test_xml-roles.html and accessible/tests/mochitest/jsat/test_traversal_helper.html. r=backout 2017-08-25 17:04:47 +02:00
Marco Zehe
34e218781d Bug 1392926 - Only expose the Region landmark role if a section element has been explicitly named by the author, r=surkov
MozReview-Commit-ID: 2HIVAuQBfQx

--HG--
extra : rebase_source : e309a9d82a2ce61b399cc0da5d547740d8bdb5a9
2017-08-25 14:28:39 +02:00
Joanmarie Diggs
638636b4ef Bug 1373786 - Mapping of "article" role and element is incorrect for AX API and ATK. r=surkov 2017-06-16 16:07:23 -04:00
Mats Palmgren
a1f37b1e8f Bug 1349835 - Create accessibles for <input type=checkbox/radio> with -moz-appearance:none. r=surkov
MozReview-Commit-ID: Cot3jyZBdpU
2017-05-31 21:29:49 +02:00
Marco Zehe
194d876eb2 Bug 634004 - Implement accessibility API support for html:details and html:summary elements, r=surkov
This implements the roles, states, and action names, but omits the state change event part that is currently made impossible by us recreating the html:summary accessible once it toggles the html:details open state. This is probably due to some reframing causing us to recreate the accessible. Suggest to move that to a separate bug and implement the basics now and the event later.

MozReview-Commit-ID: FEi5RIXdkG0

--HG--
extra : rebase_source : 9b65bc28483238e2339561e6494ccc2884cb7c42
2016-06-01 17:07:56 +02:00
Frédéric Wang
bacdba5501 Bug 1175164 - Do not expose MathML semantics element in the accessibility tree. r=surkov
--HG--
extra : rebase_source : 4974b9f27e9ec09b666fce81fd9a45d7b7f757b1
2015-06-16 16:15:00 +02:00
Alexander Surkov
7f0a2bcc08 Bug 1113153 - use 'paragraph' role for paragraphs only, introduce 'text' role for small text containers, r=marcoz 2015-05-13 11:40:15 -04:00
Frédéric Wang
f5e4a8f44c Bug 1001637 - Make math tables implement the nsIAccessibleTable interface. r=surkov 2015-03-19 12:45:59 -04:00
Jonathan Wei
41e34ee857 Bug 1001634 - Add basic MathML accessibility implementation, r=surkov, marcoz, patch=jwei, surkov 2015-03-09 08:16:12 -04:00
Alexander Surkov
bb6fd0650f Bug 1140500 - add object attributes declaration into markup map, r=marcoz 2015-03-07 20:20:17 -05:00
Alexander Surkov
7b1faeab4d Bug 1140497 - add more roles into markup map, r=marcoz 2015-03-07 12:35:27 -05:00
Alexander Surkov
064a3f9b2d Bug 1139900 - make tag name based roles faster, r=marcoz 2015-03-05 13:16:12 -05:00
Alexander Surkov
5af446d8d7 Bug 1139576 - make accessible creation by tag name faster, r=marcoz 2015-03-04 22:56:57 -05:00