Commit Graph

5356 Commits

Author SHA1 Message Date
timeless%mozdev.org
cd70f66472 Bug 348627 O(N^2) or worse algorithm in error console
r=bz sr=bz

Perhaps an explanation. String concatenation is a chance for garbage collection.
If you have unbounded input, this can be pretty bad. When you start running low
on memory, the garbage collector gets desperate and won't take shortcuts. Worst of
all, the original code generates one string of garbage every iteration starting with
the second or third.

This code uses a=[] to construct an array and a[n] to set the upper array boundary,
0 being the lower, and there are n slots between a[0] and a[n].
join() will build a string with n copies of the join argument, where n is the number                                                        of slots between between cells. So for:
a=[]; a[1]=''; there's 1 slot between [0] and [1]. The array's length is actually 2,
but the joined length will be 1.

While it is possible to use new Array(x), the behavior is different because the
array has length x and there are x-1 spaces between cells. This leads to code which
would be both much longer and harder to read. And definitely not particularly
intuitive.

The code used here otoh, while magical will hopefully require you to pause, think,
and quickly understand what's going on. If not, you paused long enough for this
bubble to appear and explain it to you :).
2006-08-14 22:03:34 +00:00
bugzilla%standard8.demon.co.uk
5677fc542d Bug 348381 Tidy up browser-prefs.js and console ifdefs. r=Benjamin,sr=Neil 2006-08-14 18:01:27 +00:00
cst%yecc.com
fa6fb7c8e3 Bug 255124 Keep favicon in URL bar from getting distorted when using larger fonts
r+sr=neil
2006-08-13 20:57:38 +00:00
benjamin%smedbergs.us
e0918f935d Seamonkey-only bustage from bug 347183 - I'm currently building a tree with this, but it should be right 2006-08-08 19:05:50 +00:00
benjamin%smedbergs.us
ef6b6ab3b4 Bug 347183 - frozen-linkage access to null/singleton/union/array enumerators, r=darin 2006-08-08 18:18:50 +00:00
mats.palmgren%bredband.net
16d685538f Filepicker needs accesskey for dirTextInputLabel. b=250177 r+sr=neil 2006-08-06 03:11:09 +00:00
ajschult%verizon.net
063d8eed65 Spelling fixup for bug 311098 from stephend plus sane punctuation. r=biesi 2006-08-06 01:46:21 +00:00
ajschult%verizon.net
cebd733cbf Bug 311098: Remove .part files when cancelling downloads, ported from toolkit. r=biesi 2006-08-05 23:57:31 +00:00
ajschult%verizon.net
61a2349f72 Bug 347160: SeaMonkey crashes, when submitting request in google.de. r=timeless 2006-08-05 23:44:24 +00:00
neil%parkwaycc.co.uk
598b590a06 Bug 50504 Context menu for bookmarks in main menu and personal toolbar submenus p=paradigmk@technodrome.com r+sr=me 2006-08-05 23:18:10 +00:00
kairo%kairo.at
43a919393e cvs remove files that are unused now, due to the checkin for bug 334877, this had r+sr=Neil 2006-07-29 15:28:30 +00:00
kairo%kairo.at
a9f5b30bb0 revert temporary bustage fix for bug 334877 again, now that the missing files have been copied 2006-07-29 13:04:52 +00:00
timeless%mozdev.org
71d515cf8e Bug 346150 Fix setting an image as wallpaper in Cairo builds
patch by bugzilla@mcsmurf.de r=jag sr=jag
2006-07-28 09:02:29 +00:00
kairo%kairo.at
99be04e2ee more bustage fixing for bug 334877 - temporary revert back two other files to xpfe versions 2006-07-27 19:34:39 +00:00
kairo%kairo.at
d78104afe1 bustage fix for bug 334877 - temporary revert back to using the xpfe history.xul until we can figure out why the cvs copy didn't work 2006-07-27 19:04:26 +00:00
kairo%kairo.at
cb5ce7b5ea bug 334877 - move non-prefwindow xpfe/components chrome to suite/, r+sr=Neil 2006-07-27 18:19:38 +00:00
aaronleventhal%moonset.net
793d61f079 Bug 241015. Remote XUL is not accessible. Patch by Alexander Surkov. r=aaronlev. Chrome r='s by neil and mano 2006-07-24 16:12:08 +00:00
martijn.martijn%gmail.com
324c3de054 xpfe part of Bug 306223 - Allow to easily filter errors by category, patch by Serge Gautherie, r+sr=neil 2006-07-24 06:55:58 +00:00
gavin%gavinsharp.com
f283ebc560 Bug 289927: JS Console shouldn't show line number if line is 0, xpfe patch by Serge GAUTHERIE <gautheri@noos.fr>, r=neil 2006-07-20 00:39:04 +00:00
gavin%gavinsharp.com
d934a4a201 Bug 287392: paste in Bookmark Manager is very slow (O(n^2)), patch by Jan Darmochwal <jdarmochwal@gmx.de>, r+sr=neil 2006-07-18 16:32:56 +00:00
neil%parkwaycc.co.uk
8f0adbb67e Bug 326462 Time Elapsed column shows NaN:NaN r=biesi sr=jag 2006-07-18 09:50:43 +00:00
mnyromyr%tprac.de
a561f2dcd2 Bug 115924: removal of communicatorOverlay.xul; p=Giacomo Magnini <giacomo.magnini@portalis.it>, r=neil, sr=mscott 2006-07-09 12:49:47 +00:00
ajschult%verizon.net
740d47f8c4 Bug 334903: Seamonkey update page appears in window with no navigation or tabs. r+sr=Neil 2006-07-04 14:41:54 +00:00
timeless%mozdev.org
27eaab5dcd Bug 337917 Make consumers stop using cids from other modules 2006-06-18 21:18:22 +00:00
benjamin%smedbergs.us
53ac0b7a23 Bug 341406 - Build bookmarks as a separate component, r+sr=Neil 2006-06-15 13:35:59 +00:00
cbiesinger%web.de
1ed0be95fd bug 341006 Close registry keys that are opened, and don't check rc twice
r+sr=neil
2006-06-10 14:17:23 +00:00
Jan.Varga%gmail.com
e5158d88ef Fix for bug 296040. Cell-based selection in trees
r=Neil Deakin, sr=Neil Rashbrook, sponsored by BEToptions
2006-06-06 20:05:13 +00:00
timeless%mozdev.org
4af059b87e Bug 337917 Make consumers stop using cids from other modules
r=bienvenu sr=neil
2006-06-03 23:40:27 +00:00
timeless%mozdev.org
c6b7d48a4d Bug 337917 Make consumers stop using cids from other modules
r=dveditz sr=darin
2006-06-03 23:38:55 +00:00
timeless%mozdev.org
a768026fc9 Bug 337917 Make consumers stop using cids from other modules
r=smontagu sr=darin
2006-06-03 23:35:59 +00:00
neil%parkwaycc.co.uk
4af915f414 Fix xpfe winhooks static string abuse b=339810 r=CTho sr=jag 2006-06-03 09:48:08 +00:00
bugzilla%standard8.demon.co.uk
0cc5baca01 Fix Camino bustage from Bug 338880 2006-05-31 18:00:40 +00:00
bugzilla%standard8.demon.co.uk
22c63b8fb6 Bug 338880 SuiteRunner doesn't compile with --enable-debug (don't build appleevents and lots of tidy up). r=benjamin,sr=neil 2006-05-31 16:07:17 +00:00
gavin%gavinsharp.com
b581167b49 Bug 265871: rename JavaScript console to Error console, patch by Kurt <supernova_00@yahoo.com>, r=mconnor, ui-r=beltzner, sr=neil/bzbarsky 2006-05-25 21:22:32 +00:00
jag%tty.nl
5d38d21178 Bug 338803: Personal Toolbar overflow chevron not properly updated on resize. r=CTho, sr=Neil. 2006-05-22 14:09:56 +00:00
kairo%kairo.at
5add892b01 bug 333383 - move SeaMonkey pref window UI to suite/ - cvs remove old filesin xpfe/, r+sr=Neil 2006-05-17 19:38:42 +00:00
kairo%kairo.at
887b260269 bug 333383 - move SeaMonkey pref window UI to suite/, r+sr=Neil 2006-05-17 15:46:04 +00:00
neil%parkwaycc.co.uk
90ce6b6cde Fix dragging to personal toolbar between last visible bookmark and overflow chevron b=201854 p=gautheri@noos.fr r+sr=me 2006-05-17 09:16:16 +00:00
gavin%gavinsharp.com
490c5c03ab Bug 337962: fix nsBookmarksService's QI to include nsICharsetResolver, r=neil, sr=bzbarsky 2006-05-15 17:28:40 +00:00
martijn.martijn%gmail.com
c459374494 Remove network.image.warnAboutImages preference, r+sr=neil 2006-05-15 16:53:10 +00:00
bugzilla%standard8.demon.co.uk
a2067ddd4c Bug 232795 In <bookmarksMenu.js>, "Error: aDragSession.sourceNode has no properties" (Av2b-XPFE) <bookmarksMenu.js> p=Serge GAUTHERIE <gautheri@noos.fr>,r=neil,sr=jag 2006-05-14 09:56:46 +00:00
mnyromyr%tprac.de
e3fd37e4e7 Follow-up to bug 57510: remove erroneous <keyset>; r/sr=jag 2006-05-12 19:43:01 +00:00
kairo%kairo.at
0525eb1934 bug 336874 - Make suiterunner use the same toolkit.jar as XULRunner, step 1: move files to non-xul-app sections that are overridden by toolkit (also fix suiterunner bustage), r=Neil sr=bsmedberg 2006-05-12 10:34:13 +00:00
mnyromyr%tprac.de
314fa97a97 Bug 57510: `Del' key does not delete on Mac; r=db48x, sr=jag 2006-05-11 19:55:44 +00:00
darin%meer.net
0318b8c707 landing patch for bug 326273 "Implement nsIThreadManager" (Mac portions by Mark Mentovai) with reviews from bienvenu, bsmedberg, bzbarsky, josh, roc, and ssieb 2006-05-10 17:30:15 +00:00
timeless%mozdev.org
28fa63a8f5 Bug 335953 Make code outside intl use NS_CHARSETALIAS_CONTRACTID instead of NS_CHARSETALIAS_CID
r=bz sr=bz
2006-05-06 22:09:20 +00:00
cbiesinger%web.de
51a89a8b1e bug 335180 Remove win32.order, mozilla-bin.order, --enable-reorder, and
associated code. These options do not really work anymore.

r=bsmedberg
2006-05-06 17:53:51 +00:00
benjamin%smedbergs.us
703f94d5f7 Bug 335248 - move the XUL filepicker C++ goop into libxul, r=darin 2006-05-04 23:17:47 +00:00
benjamin%smedbergs.us
ae7a851b73 Bug 335807 - Make xpfe/components/intl its own component, r=neil (this gets rid of xpfe/components/build2 for tbird, yay!) 2006-05-02 16:47:32 +00:00
benjamin%smedbergs.us
1c04b21107 Fix #includes, bug 335714 2006-04-28 13:43:19 +00:00