Commit Graph

76 Commits

Author SHA1 Message Date
Simon Giesecke
e4bf6784c3 Bug 1613854 - Avoid copying non-trivial IPDL params. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D62023

--HG--
extra : moz-landing-system : lando
2020-02-18 16:37:49 +00:00
Simon Giesecke
e26d6083c0 Bug 1613854 - Pass nsresult/bool/int* by value instead of const &. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D61992

--HG--
extra : moz-landing-system : lando
2020-02-27 12:17:47 +00:00
Eric Rahm
124379887c Bug 1617327 - Part 2: Remove nsAutoPtr usage from ipc, security, IDB. r=mccr8,janv
This removes `nsAutoPtr` usage from ipc/. security/ failed to build due to missing includes so I fixed that as well. IDB was using `ThreadLocal` from ipc which had a member changed to a `UniquePtr` so needed to be updated as well. localstorage was missing some includes.

Differential Revision: https://phabricator.services.mozilla.com/D63745

--HG--
extra : moz-landing-system : lando
2020-02-24 19:26:40 +00:00
Jed Davis
ee171b6406 Bug 1615155 - Don't generate default Recv__delete__ if there are args. r=nika
The default method implementations cause problems when trying to
override them with different types in a direct call class.

For the `Recv__delete__` case there's a simple solution: omit it if
there are any arguments, because it doesn't make much sense to specify
arguments and then completely ignore them, and the no-arg case isn't a
problem for overriding.

Differential Revision: https://phabricator.services.mozilla.com/D62977

--HG--
extra : moz-landing-system : lando
2020-02-18 20:46:21 +00:00
Simon Giesecke
ce6596707f Bug 1613854 - De-virtualize IPDL protocol methods in ActorsChild. r=dom-workers-and-storage-reviewers,janv,jld
Differential Revision: https://phabricator.services.mozilla.com/D61991

--HG--
extra : moz-landing-system : lando
2020-02-17 14:49:27 +00:00
Mihai Alexandru Michis
13d11ce14a Backed out changeset 98a47607bb61 (bug 1613854) for causing sm failures in PBackgroundIDBCursorChild.cpp
CLOSED TREE
2020-02-17 16:03:20 +02:00
Simon Giesecke
7e65d8de67 Bug 1613854 - De-virtualize IPDL protocol methods in ActorsChild. r=dom-workers-and-storage-reviewers,janv,jld
Differential Revision: https://phabricator.services.mozilla.com/D61991

--HG--
extra : moz-landing-system : lando
2020-02-14 00:58:53 +00:00
Andrea Marchesini
ce6465d9ea Bug 1607791 - Get rid of IDBMutableFile.getFile() - part 1, r=asuth,janv
Differential Revision: https://phabricator.services.mozilla.com/D59140

--HG--
extra : moz-landing-system : lando
2020-01-15 12:02:21 +00:00
Mihai Alexandru Michis
4345a38d0d Backed out 9 changesets (bug 1607791, bug 1605566) for causing multiple wpt failures.
CLOSED TREE

Backed out changeset 39f34852842e (bug 1605566)
Backed out changeset 3427a92445c8 (bug 1605566)
Backed out changeset 36631ec96f1f (bug 1605566)
Backed out changeset 554b2bdce66c (bug 1605566)
Backed out changeset 37026beadbd8 (bug 1605566)
Backed out changeset f15835338319 (bug 1607791)
Backed out changeset 4c92f506cf62 (bug 1607791)
Backed out changeset 80707bcc8427 (bug 1607791)
Backed out changeset 75bc7533c899 (bug 1607791)
2020-01-15 13:45:33 +02:00
Andrea Marchesini
6c05c922e3 Bug 1607791 - Get rid of IDBMutableFile.getFile() - part 1, r=asuth,janv
Differential Revision: https://phabricator.services.mozilla.com/D59140

--HG--
extra : moz-landing-system : lando
2020-01-15 09:58:39 +00:00
Simon Giesecke
a5e45033f2 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993

--HG--
extra : moz-landing-system : lando
2020-01-10 15:23:52 +00:00
Csoregi Natalia
8c7b4f143a Backed out 3 changesets (bug 1600906) for bustage on StaticAnalysisFunctions.h. CLOSED TREE
Backed out changeset aae2faf1907c (bug 1600906)
Backed out changeset d61a65e2e4ac (bug 1600906)
Backed out changeset a114b9b8e6ea (bug 1600906)
2020-01-10 17:19:22 +02:00
Simon Giesecke
a48be584a9 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993

--HG--
extra : moz-landing-system : lando
2020-01-10 14:21:18 +00:00
Simon Giesecke
77ea686b98 Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55520

--HG--
extra : moz-landing-system : lando
2019-12-19 09:57:49 +00:00
Simon Giesecke
55a2f652bc Bug 1598164 - Use scoped enums in IDBTransaction. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54321

--HG--
extra : moz-landing-system : lando
2019-11-27 10:54:57 +00:00
Simon Giesecke
0d86246c8c Bug 1599420 - Ensure that strong references to newly created cursors are kept until the DOM Binding is created. r=dom-workers-and-storage-reviewers,ttung,janv
Differential Revision: https://phabricator.services.mozilla.com/D54704

--HG--
extra : moz-landing-system : lando
2019-11-26 14:38:16 +00:00
Simon Giesecke
06d137dba8 Bug 1596129 - Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one. r=dom-workers-and-storage-reviewers,ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D52859

--HG--
extra : moz-landing-system : lando
2019-11-21 16:46:08 +00:00
Simon Giesecke
a137d4ea5b Bug 1596129 - Removed code duplication between HandlePreprocess overloads. r=dom-workers-and-storage-reviewers,ttung
Differential Revision: https://phabricator.services.mozilla.com/D52844

--HG--
extra : moz-landing-system : lando
2019-11-20 13:26:16 +00:00
Simon Giesecke
ffec9b2750 Bug 1168606 - Set flag to invalidate in-flight responses as well. r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D52559

--HG--
extra : moz-landing-system : lando
2019-11-14 16:14:02 +00:00
Simon Giesecke
deb959c93c Bug 1168606 - Resolved clang-tidy warnings. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D49274

--HG--
extra : moz-landing-system : lando
2019-11-08 13:22:28 +00:00
Simon Giesecke
608f5bac34 Bug 1168606 - Replace pseudo-move constructor of StructuredCloneReadInfo by explicit DeserializeStructuredCloneReadInfo function. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46593

--HG--
extra : moz-landing-system : lando
2019-11-08 13:22:08 +00:00
Simon Giesecke
b6fc689caf Bug 1168606 - Do not use mContinueCalled for determining whether to cache a cursor response. r=ttung,asuth
Depends on D45674

Differential Revision: https://phabricator.services.mozilla.com/D45675

--HG--
extra : moz-landing-system : lando
2019-11-05 16:46:31 +00:00
Simon Giesecke
c3c98789cd Bug 1168606 - Removed duplication between different BackgroundCursorChild::HandleResponse overloads. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D45674

--HG--
extra : moz-landing-system : lando
2019-11-05 16:46:23 +00:00
Simon Giesecke
103f204d11 Bug 1168606 - Extract common function for discarding cached responses. r=ttung,asuth
Depends on D45308

Differential Revision: https://phabricator.services.mozilla.com/D45349

--HG--
extra : moz-landing-system : lando
2019-11-05 16:46:10 +00:00
Simon Giesecke
b09e7874fd Bug 1168606 - Add support for preloading key-only cursors. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D44009

--HG--
extra : moz-landing-system : lando
2019-11-05 14:40:31 +00:00
Simon Giesecke
59cd698867 Bug 1168606 - Support preloading also for index cursors. r=ttung,asuth
Depends on D43252

Differential Revision: https://phabricator.services.mozilla.com/D43461

--HG--
extra : moz-landing-system : lando
2019-11-05 14:40:35 +00:00
Simon Giesecke
9804c8f159 Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-11-05 14:40:37 +00:00
Cosmin Sabou
1211bbc800 Backed out 12 changesets (bug 1168606) for causing build bustages on ActorsParent.cpp and Assertions.h. CLOSED TREE
Backed out changeset 307bd8d24407 (bug 1168606)
Backed out changeset a2ae085f929f (bug 1168606)
Backed out changeset 8fdc4a3d3ecb (bug 1168606)
Backed out changeset 918dc7cce5e9 (bug 1168606)
Backed out changeset 8c776a5cb5db (bug 1168606)
Backed out changeset dffe1e6c58bd (bug 1168606)
Backed out changeset 41f1bef0f019 (bug 1168606)
Backed out changeset 96cb7140a4f6 (bug 1168606)
Backed out changeset 6818224b9b11 (bug 1168606)
Backed out changeset f1be81af7d6b (bug 1168606)
Backed out changeset 8dc185488801 (bug 1168606)
Backed out changeset 9d8b02674d45 (bug 1168606)
2019-11-05 16:34:22 +02:00
Simon Giesecke
95a4ff4109 Bug 1168606 - Do not use mContinueCalled for determining whether to cache a cursor response. r=ttung,asuth
Depends on D45674

Differential Revision: https://phabricator.services.mozilla.com/D45675

--HG--
extra : moz-landing-system : lando
2019-11-05 13:23:58 +00:00
Simon Giesecke
e4ad20d178 Bug 1168606 - Removed duplication between different BackgroundCursorChild::HandleResponse overloads. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D45674

--HG--
extra : moz-landing-system : lando
2019-11-05 12:48:28 +00:00
Simon Giesecke
8835742b38 Bug 1168606 - Extract common function for discarding cached responses. r=ttung,asuth
Depends on D45308

Differential Revision: https://phabricator.services.mozilla.com/D45349

--HG--
extra : moz-landing-system : lando
2019-11-05 13:23:34 +00:00
Simon Giesecke
024a6ea519 Bug 1168606 - Add support for preloading key-only cursors. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D44009

--HG--
extra : moz-landing-system : lando
2019-11-05 12:46:16 +00:00
Simon Giesecke
69cd8f61cb Bug 1168606 - Support preloading also for index cursors. r=ttung,asuth
Depends on D43252

Differential Revision: https://phabricator.services.mozilla.com/D43461

--HG--
extra : moz-landing-system : lando
2019-11-05 12:45:48 +00:00
Simon Giesecke
1db45a09bf Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-11-05 12:48:36 +00:00
Simon Giesecke
cd0b6f05a1 Bug 1168606 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43631

--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:45 +00:00
Oana Pop Rus
cb31d323be Backed out 5 changesets (bug 1168606) for xpcshell failures in dom/indexedDB/test/unit/test_temporary_storage.js on a CLOSED TREE
Backed out changeset fc5e1bee1332 (bug 1168606)
Backed out changeset 63cf0966cb41 (bug 1168606)
Backed out changeset f844afbebc6a (bug 1168606)
Backed out changeset 9e7a90dcc429 (bug 1168606)
Backed out changeset e493a6b5f125 (bug 1168606)
2019-10-02 02:28:15 +03:00
Simon Giesecke
3feb8e1ebe Bug 1168606 - Send two records with every ObjectStoreCursorResponse. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-10-01 09:15:49 +00:00
Simon Giesecke
a9cf10ae19 Bug 1168606 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43631

--HG--
extra : moz-landing-system : lando
2019-10-01 09:14:04 +00:00
Simon Giesecke
470b2174a1 Bug 1168606 - Allow current key to be provided with PBackgroundIDBCursor::Continue. r=ttung,asuth
The key is assumed to be unset for now.

Differential Revision: https://phabricator.services.mozilla.com/D43251

--HG--
extra : moz-landing-system : lando
2019-09-27 10:11:41 +00:00
Jan Varga
e12ce7d680 Bug 1561876 - Remove support for de-serializing WebAssembly.Modules in IDB; r=asuth
This patch removes support for de-serialization of WebAssembly.Modules. The
preprocessing which was added just for WebAssembly.Modules is not removed since
it can be reused for more efficient de-serialization of big structured clones
which are stored as standalone files. (standalone files can be read and
uncompressed in content process instead of the parent process). So this patch
also adjusts the preprocessing to support that. However the preprocessing is not
fully implemented (we lack support for indexes and cursors) and there's a
theoretical problem with ordering of IDB requests when preprocessing is
involved, so this feature is kept behind a pref for now.

Differential Revision: https://phabricator.services.mozilla.com/D36879

--HG--
rename : dom/indexedDB/test/unit/test_wasm_recompile.js => dom/indexedDB/test/unit/test_wasm_get_values.js
rename : dom/indexedDB/test/unit/wasm_recompile_profile.zip => dom/indexedDB/test/unit/wasm_get_values_profile.zip
2019-07-03 12:23:33 +02:00
Alex Gaynor
d3444f6ef7 Bug 1535397 - Part 4 - use native Maybe syntax in place of NullableVersion in IDPL; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D23561

--HG--
extra : moz-landing-system : lando
2019-03-15 17:10:29 +00:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Jan Varga
c8df9237b9 Bug 1410420 - Clear database actor's strong reference to IDBDatabase when opening of a database fails; r=asuth 2017-10-30 07:13:40 +01:00
Bevis Tseng
e98d22391d Bug 1366647 - Adopt NS_ASSERT_OWNINGTHREAD for PRThread equality. r=janv
MozReview-Commit-ID: 4j1ifEtrsvD
2017-06-07 13:55:00 +08:00
Jan Varga
4cc459c1a1 Bug 1370519 - Part 2: Merge FileHandle base classes with IndexedDB specific classes (except parent actors); r=btseng 2017-06-07 12:36:42 +02:00
Andrea Marchesini
f9c4fde785 Bug 1360185 - Use of IPCBlob in IndexedDB - part 1 - Replacement of PBlob with IPCBlob, r=janv 2017-05-23 07:50:33 +02:00
Bevis Tseng
69a59cfe93 Bug 1328517 - Part 2: Add Assertion to Each ActorEventTarget. r=janv
MozReview-Commit-ID: DDQ0ytBiwm3

--HG--
extra : rebase_source : d3a724e9d69e492621948436cc68cf1d59cdb3a6
2017-02-10 15:13:45 +08:00
Kan-Ru Chen
f8100451db Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.

MozReview-Commit-ID: AzVbApxFGZ0
2016-11-15 04:26:00 +01:00
Jan Varga
17a0c4983e Bug 1311466 - Part 10: Implement functionality for preprocessing multiple results, fixed objectStore.getAll() to use it including a new test; r=asuth 2016-10-26 06:51:33 +02:00
Jan Varga
9d0d2c5654 Bug 1311466 - Part 8: Implement basic functionality for preprocessing results before they are sent for synchronous deserialization; r=asuth 2016-10-25 21:19:06 +02:00