Commit Graph

1188 Commits

Author SHA1 Message Date
Valentin Gosu
5afdc02366 Bug 1694662 - Remove Appcachestorage & oldwrappers r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D106455
2021-04-30 07:20:24 +00:00
Mark Banner
75d5c0e0de Bug 1705372 - Add new Amazon search engine definitions. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D113397
2021-04-27 18:46:35 +00:00
Mark Banner
13c83e570e Bug 1706717 - Update Canonical distribution settings. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D113009
2021-04-26 13:08:30 +00:00
Mark Banner
e124f0ff38 Bug 1704850 - Update Amazon deployments. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D112382
2021-04-26 13:08:30 +00:00
Mark Banner
056daa10ad Bug 1693585 - Ensure that the default search engine can be changed, even if overriden data is missing. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D110564
2021-04-15 15:57:42 +00:00
Mark Banner
250e011a6e Bug 1704839 - Update Amazon search engine definitions. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D111863
2021-04-15 15:24:52 +00:00
Valentin Gosu
3760df94f0 Bug 1692018 - Remove support for installing OpenSearch engines via ftp r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D107790
2021-04-07 10:20:58 +00:00
Mark Banner
ae4f7314e2 Bug 1702333 - Add diagram of add-ons and default search engine prompting to docs. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D110468
2021-04-05 10:37:21 +00:00
Loek
2cd7990a13 Bug 1701950 - Replace installTestEngine with promiseNewSearchEngine in search xpcshell tests. r=Standard8
***
Bug 1701950 - Remove unused addTestEngines and installTestEngine. Move useHttpServer to setup function. r=standard8

Differential Revision: https://phabricator.services.mozilla.com/D110316
2021-04-01 14:27:13 +00:00
Loek
aee7944629 Bug 1701950 - Replace addTestEngines with promiseNewSearchEngine in search xpcshell tests. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D110315
2021-04-01 14:27:12 +00:00
Mark Banner
c91d10c118 Bug 1697477 - Use the new nsISearchEngine.isWebEngine property in the urlbar. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D109548
2021-03-29 18:10:30 +00:00
Mark Banner
d72b7d6ed2 Bug 1697477 - Expose a property on nsISearchEngine to indicate general web search engines. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D109547
2021-03-29 18:10:30 +00:00
Shane Caraveo
9cade0a613 Bug 1646338 ask to set as default again when enabling a search addon r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D107132
2021-03-29 15:42:23 +00:00
Mark Banner
51f5b41174 Bug 1700971 - Switch to using search engine extensions in urlbar xpcshell-tests. r=mak
This allows us to use random port numbers in the tests, so that they can run in parallel.

Differential Revision: https://phabricator.services.mozilla.com/D109753
2021-03-26 22:12:43 +00:00
Mark Banner
93ebcb5d2f Bug 1698584 - Add more search-config tests for search engines. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D109793
2021-03-26 16:06:59 +00:00
Butkovits Atila
326c407525 Backed out changeset 120d1b7f97d0 (bug 1692018) for casuing failures on browser_search_discovery.js. CLOSED TREE 2021-03-26 16:09:05 +02:00
Valentin Gosu
b99302c305 Bug 1692018 - Remove support for installing OpenSearch engines via ftp r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D107790
2021-03-26 12:19:34 +00:00
Michelle Goossens
5391deaa4c Bug 1671274 - Convert SearchSettings.jsm and SearchService.jsm to no longer use OS.File r=barret
Differential Revision: https://phabricator.services.mozilla.com/D97205
2021-03-24 21:07:18 +00:00
Mark Banner
c158d070c8 Bug 1649186 - Remove nsISearchService.addEngineWithDetails completely. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D108479
2021-03-19 14:06:07 +00:00
Mark Banner
5e786e8b26 Bug 1687932 - Remove use of nsISearchEngine.addEngineWithDetails from other xpcshell-tests. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D108462
2021-03-19 14:06:06 +00:00
Mark Banner
b464060db9 Bug 1687932 - Remove use of nsISearchEngine.addEngineWithDetails from search xpcshell-tests. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D108461
2021-03-19 14:06:06 +00:00
Mark Banner
3cdf615684 Bug 1687932 - Simplify use of SearchTestUtils.installSearchExtension for xpcshell-tests and clean up the search tests. r=daleharvey
Also remove addEngineWithDetails from test_TelemetryEnvironment_search.js to help resolve issues following the cleaning up SearchTestUtils.jsm.

Differential Revision: https://phabricator.services.mozilla.com/D108460
2021-03-19 14:06:05 +00:00
Mark Banner
e2fdaf98ae Bug 1687932 - Improve test_webextensions_migrate_to.js to avoid potentially triggering installation routines that we do not want for the test. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D108459
2021-03-19 14:06:05 +00:00
Mark Banner
7f76fae345 Bug 1695262 - When removing a default engine and the locale/region default is hidden, try to revert to a 'general' search engine if possible. r=mak
Currently if the region/locale default is hidden, the search service will try and revert to the first non-hidden engine, this might be a shopping or dictionary based engine which is not as useful as a general search engine.

Differential Revision: https://phabricator.services.mozilla.com/D106783
2021-03-10 15:37:55 +00:00
Mark Banner
9f7be8ed04 Bug 369739 - Add test to ensure that OpenSearch engines update correctly when the name changes. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D107673
2021-03-10 14:21:13 +00:00
Mark Banner
c37e909d81 Bug 1696027 - Remove use of nsISearchEngine.addEngineWithDetails from mochitests. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D107624
2021-03-10 14:21:12 +00:00
Bogdan Tara
621d71189b Backed out 2 changesets (bug 369739, bug 1696027) for browser_searchChangedEngine.js and test_webextensions_upgrade.js failures CLOSED TREE
Backed out changeset 2705f924b635 (bug 369739)
Backed out changeset 6e5ccf3eeaa6 (bug 1696027)
2021-03-10 15:36:28 +02:00
Mark Banner
42d1844fe7 Bug 369739 - Add test to ensure that OpenSearch engines update correctly when the name changes. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D107673
2021-03-10 12:34:43 +00:00
Mark Banner
9df3e3dc07 Bug 1696027 - Remove use of nsISearchEngine.addEngineWithDetails from mochitests. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D107624
2021-03-10 12:34:43 +00:00
Mark Banner
8e66f61a53 Bug 1690114 - When a search engine changes properly update the default and the tree in preferences. r=preferences-reviewers,Gijs
Prior to this patch we would only update the icons.

Depends on D107668

Differential Revision: https://phabricator.services.mozilla.com/D107669
2021-03-10 08:48:05 +00:00
Mark Banner
fe53636358 Bug 1690114 - Fix handling of updating the search engine name when a WebExtension updates. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D107668
2021-03-10 08:48:05 +00:00
Bogdan Tara
ebf7802e4a Backed out 2 changesets (bug 369739, bug 1696027) for test_TelemetryEnvironment.js xpcshell failures CLOSED TREE
Backed out changeset 9ea26aff5a9b (bug 369739)
Backed out changeset 395e7278e415 (bug 1696027)
2021-03-10 10:27:02 +02:00
Mark Banner
7a49598d75 Bug 369739 - Add test to ensure that OpenSearch engines update correctly when the name changes. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D107673
2021-03-10 07:40:22 +00:00
Mark Banner
62144490ad Bug 1696027 - Remove use of nsISearchEngine.addEngineWithDetails from mochitests. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D107624
2021-03-10 07:40:22 +00:00
Mark Banner
04281bb9b8 Bug 1575649 - When removing a default engine, calculate and notify the new default engine straight away. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105031
2021-03-03 22:23:20 +00:00
Mark Banner
1462541c2b Bug 1575649 - Add notification checks to default engine fallback tests. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D106626
2021-03-03 22:23:19 +00:00
Mark Banner
e41ec3c3b9 Bug 1575649 - Rewrite default search engine fallback tests to make them clearer, and add docs for removing the default engine. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D106625
2021-03-03 22:23:19 +00:00
Mark Banner
6c1040c583 Bug 1695588 - When a new search engine alias is set, only notify the engine has changed if the alias is different. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D106782
2021-03-03 22:23:19 +00:00
Mark Banner
1379a2bed3 Bug 1694183 - When loading icons, use the content type of the final target, not a redirect response. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105994
2021-02-24 14:33:57 +00:00
Mark Banner
d5b805a6e4 Bug 1692623 - When loading a search engine icon, if it is not an image/ content type then ignore it. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105483
2021-02-18 18:38:28 +00:00
Dorel Luca
3aa6613f1e Backed out 2 changesets (bug 1680104) for XPCshell failures in search/tests/xpcshell/test_addEngineWithDetails.js. CLOSED TREE
Backed out changeset 5a0f9dd0f65a (bug 1680104)
Backed out changeset a5907cd12e19 (bug 1680104)
2021-02-16 18:44:46 +02:00
Mark Banner
5f6b4fcb7d Bug 1680104 - Automatically remove search engines where the associated add-on is disabled/not installed. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105051
2021-02-16 15:45:11 +00:00
Mark Banner
b0a9c94944 Bug 1680104 - Rewrite test_webextensions_valid.js to make it simpler to extend. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105050
2021-02-16 15:45:11 +00:00
Bogdan Tara
f1451cbda6 Backed out 2 changesets (bug 1680104) for browser_newTabDrop.js mochitest failures CLOSED TREE
Backed out changeset 45f6157a879e (bug 1680104)
Backed out changeset f430e91157eb (bug 1680104)
2021-02-16 00:28:40 +02:00
Mark Banner
12ac5ab9ff Bug 1680104 - Automatically remove search engines where the associated add-on is disabled/not installed. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105051
2021-02-15 18:14:55 +00:00
Mark Banner
6d56540e76 Bug 1680104 - Rewrite test_webextensions_valid.js to make it simpler to extend. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105050
2021-02-15 18:14:55 +00:00
Mark Banner
263d555274 Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104683
2021-02-11 22:02:15 +00:00
Mark Banner
a5bf84f203 Bug 1691050 - Extend telemetry for search engine/add-on mismatches to check for name as well as parameters. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D104384
2021-02-10 20:37:03 +00:00
Mark Banner
269a6fbae9 Bug 1690750 - Simplify OpenSearchEngine to only allow loading engines from protocols where users can load them from. r=mak
The urls where an OpenSearch engine can be loaded from are already limited in LinkHandlerChild. This is cleaning up and simplifying what the OpenSearchEngine allows, and as a result allows the load path handling to be greatly simplified.

The test changes are due to no longer allowing chrome or file protocols. For future, we probably want to move away from OpenSearch for most of these, but the changes will make it easier to find the places to update.

Differential Revision: https://phabricator.services.mozilla.com/D104010
2021-02-10 18:12:08 +00:00
Drew Willcoxon
faaf1bbc04 Bug 1676469 - Convert matchBuckets to a granular list of result groups and rewrite the muxer to use it. r=preferences-reviewers,mak,harry
Summary of changes:

* Replace the `matchBuckets` pref with `resultBuckets`.
* `resultBuckets` stores a JSON'ed root result bucket object. See the big
  javadoc above `makeResultBuckets` in UrlbarPrefs for details.
* Convert existing result groups to more granular groups. This lets us remove
  the heuristic-ordering logic in the muxer. It also lets us fix a subtle
  inconsistency with regard to remote suggestions and form history; see the
  removal of the two comments that start with "Note that the second form history
  result appears after the remote suggestions" and "Note that the remote
  suggestions appear in between the two form history results" in
  test_search_suggestions.js.
* Unlike `matchBuckets`, `resultBuckets` stores *all* buckets, including the
  heuristic at the beginning. Modify the muxer so that it discards heuristic
  results that are not the first result.

Depends on D103137

Differential Revision: https://phabricator.services.mozilla.com/D99281
2021-02-09 21:53:38 +00:00