Commit Graph

95 Commits

Author SHA1 Message Date
Julian Descottes
a38e35b3bc Bug 1418952 - style updates for about:devtools;r=nchevobbe
MozReview-Commit-ID: IFaDZBgmJPh

--HG--
extra : rebase_source : 2527b60e1bd23e9fd196296089ef9c0cea449d1b
2017-11-20 11:48:38 +01:00
Julian Descottes
c186e09d03 Bug 1418952 - update about:devtools strings;r=flod,nchevobbe
MozReview-Commit-ID: B20sojPHg7H

--HG--
extra : rebase_source : 04b23af830b3fd5ce16fe76ee47e3bca4e013575
2017-11-20 10:26:43 +01:00
Julian Descottes
af2e5d5dd1 Bug 1416711 - Add registerAllActors API;r=ochameau
Most of the codebase that needs to create a debugger server
can use a server with all actors registered.

Define an additional method registerAllActors to do that.

By previous implementations, all the call sites that were
using browser: true were indirectly using tab & root: true
as well. So all the call sites using browser: true have been
migrated to registerAllActors and the specific behavior of
the browser: true case has been removed. Passing browser:true
to registerActors now only registers browser specific actors.

MozReview-Commit-ID: F3sx71eGrdG

--HG--
extra : rebase_source : 7704264e84d96e03a0c789103ff466980913d4d2
2017-11-13 21:22:15 +01:00
Julian Descottes
4cac7dcb25 Bug 1416711 - Migrate addBrowser/TabActors to registerActors;r=ochameau
DebuggerServer has old APIs addBrowserActors & addTabActors that can be
replaced by calls to registerActors.

MozReview-Commit-ID: KpYJpbSHM8I

--HG--
extra : rebase_source : c7f20edf503b944ef2582b5fe73bd6d899c0d1cc
2017-11-13 20:29:55 +01:00
Julian Descottes
cfef7be9a1 Bug 1386979 - register about-devtools-toolbox on browser startup;r=ochameau
MozReview-Commit-ID: GUBEyzg2qCw

--HG--
rename : devtools/client/framework/about-devtools-toolbox.js => devtools/shim/aboutdevtoolstoolbox-registration.js
extra : rebase_source : 77cf2036dae59c6119b0c0d2dd1ed821ace0f07d
2017-11-21 20:32:51 +01:00
Julian Descottes
bc283794a0 Bug 1418266 - update preference behavior for DevTools onboarding experiment;r=ochameau
The devtools.onboarding.experiment pref now supports 3 states:
- off (default)
- on
- force

When set to "on" or "force" the preference will flip devtools
enabled to false.

When set to "force" the devtools.enabled pref can no longer be
flipped to true by looking at devtools.selfxss.count, users
have to go through the onboarding flow.

To make sure the devtools.enabled pref is only flipped once, we
use a supporting pref devtools.onboarding.experiment.flipped

MozReview-Commit-ID: B5fPKuGxPW2

--HG--
extra : rebase_source : 6da6cc41f6388871cdfc66c04bef3b54ccfabcbf
2017-11-16 19:56:15 +01:00
Julian Descottes
5b2c0adf24 Bug 1408339 - measure onboarding devtools user detection with telemetry;r=ochameau, datareview=francois
MozReview-Commit-ID: G3edBYlyH8f

--HG--
extra : rebase_source : 6cd721dca7e2bfc6e5cbf1938c47d3851ecfb6fc
2017-11-08 17:51:19 +01:00
Julian Descottes
f5d0be6f79 Bug 1408339 - add a preference to drive the devtools onboarding experiment;r=ochameau
MozReview-Commit-ID: I4uGf1MFbI9

--HG--
extra : rebase_source : 22372a8f8fb59c47ad7f75e7fb55e937d721a884
2017-11-05 16:34:26 +01:00
Julian Descottes
d1a9d0eb6d Bug 1412504 - Style updates for about:devtools;r=nchevobbe
MozReview-Commit-ID: BjCimCRFYWr

--HG--
extra : rebase_source : ce071050361e703501e912609f90d894d4deed1d
2017-11-11 10:28:22 +01:00
Gijs Kruitbosch
8c1b02e3d4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
MozReview-Commit-ID: L017kRfHfOv

--HG--
extra : rebase_source : c9dcbb76d787281ac2dcf18c59786205aeaacaf9
2017-11-07 12:15:18 +00:00
Julian Descottes
6ba9f761e9 Bug 1413844 - add utm parameters to about:devtools links;r=pbro
MozReview-Commit-ID: EjgklOeYQ2g

--HG--
extra : rebase_source : b54123549878f8f0e571e7dadbfb462559634961
2017-11-09 19:17:35 +01:00
Julian Descottes
e90066e5c9 Bug 1408337 - set devtools.enabled to true if toolbox was recently opened;r=bgrins
MozReview-Commit-ID: RKprmycu6b

--HG--
extra : rebase_source : c881f5342071ee212d438802bdf80556c251891c
2017-10-31 15:52:58 +01:00
Julian Descottes
f55b078bf6 Bug 1408369 - move back aboutdevtools.dtd to devtools/shim/locales;r=flod
Add localization notes to aboutdevtools.dtd and move it back to the locales
folder where it can be picked up by localization teams.

MozReview-Commit-ID: 8fDimFwdBXv

--HG--
rename : devtools/shim/aboutdevtools/tmp-locale/aboutdevtools.dtd => devtools/shim/locales/en-US/aboutdevtools.dtd
extra : rebase_source : a39410806d2fc930eaaf74c7894371aa041b0dfe
2017-11-06 15:36:28 +01:00
Julian Descottes
d0d415d3b0 Bug 1408369 - create about:devtools welcome message dynamically;r=flod,nchevobbe
The welcome message used to be defined in DTD. Since it has a dynamic part (the
toggle toolbox shortcut) it's easier for localization purposes to have it in a
properties file and dynamically insert it.

MozReview-Commit-ID: FhgQjbs8Dw0

--HG--
extra : rebase_source : 35efe9ccd3ce17931edbba5e0deac32c81fc7609
2017-11-07 21:53:55 +01:00
Julian Descottes
2695e6bb98 Bug 1412029 - add probes to about:devtools;r=bgrins,datareview=francois
This changeset adds 3 scalars:
- devtools.aboutdevtools.opened -> logged every time the page is loaded
- devtools.aboutdevtools.installed -> logged when the user clicks on the
  install button
- devtools.aboutdevtools.noinstall_exits -> logged when leaving the page
  if devtools is not enabled

And 2 keyed histograms:
- DEVTOOLS_ABOUT_DEVTOOLS_OPENED_REASON (is it a shortcut, is it a menu
  item etc...)
- DEVTOOLS_ABOUT_DEVTOOLS_OPENED_KEY (in case of a keyshortcut, what is
  the keyshortcut id)


MozReview-Commit-ID: 1DET1ozf8i4

--HG--
extra : rebase_source : f2f96e29a8849dec83b03d6daacbf6c6ca7fce2f
2017-11-01 18:41:42 +01:00
Julian Descottes
9d5d22f390 Bug 1412029 - pass key shortcut id to aboutdevtools page;r=bgrins
MozReview-Commit-ID: 4Fmj1p1bgsB

--HG--
extra : rebase_source : f236777ea914ebad6cc7a0e61be97491b6eb97c2
2017-11-01 14:47:31 +01:00
Narcis Beleuzu
0f581d68da Backed out 2 changesets (bug 1412029) for ESLint failure "/devtools/shim/aboutdevtools/aboutdevtools.js" r=backout on a CLOSED TREE
Backed out changeset ab41b0060a87 (bug 1412029)
Backed out changeset d3a84e128c3c (bug 1412029)
2017-11-08 13:38:10 +02:00
Julian Descottes
418a668f0e Bug 1412029 - add probes to about:devtools;r=bgrins,datareview=francois
This changeset adds 3 scalars:
- devtools.aboutdevtools.opened -> logged every time the page is loaded
- devtools.aboutdevtools.installed -> logged when the user clicks on the
  install button
- devtools.aboutdevtools.noinstall_exits -> logged when leaving the page
  if devtools is not enabled

And 2 keyed histograms:
- DEVTOOLS_ABOUT_DEVTOOLS_OPENED_REASON (is it a shortcut, is it a menu
  item etc...)
- DEVTOOLS_ABOUT_DEVTOOLS_OPENED_KEY (in case of a keyshortcut, what is
  the keyshortcut id)


MozReview-Commit-ID: 1DET1ozf8i4

--HG--
extra : rebase_source : 5038fcb6741653b7f66581cd601ba9dea58a847f
2017-11-01 18:41:42 +01:00
Julian Descottes
2e31574d55 Bug 1412029 - pass key shortcut id to aboutdevtools page;r=bgrins
MozReview-Commit-ID: 4Fmj1p1bgsB

--HG--
extra : rebase_source : f236777ea914ebad6cc7a0e61be97491b6eb97c2
2017-11-01 14:47:31 +01:00
Julian Descottes
692bf7d21f Bug 1408334 - add form to subscribe to mozilla developer newsletter in about:devtools;r=nchevobbe
MozReview-Commit-ID: JuJqNS3r6NH

--HG--
extra : rebase_source : 61c19cadbff27365ba62d8afd000a78974ac67bc
2017-10-31 10:19:00 +01:00
Margareta Eliza Balazs
e0c4e35f57 Backed out changeset 3a8295d1ff40 (bug 1408334) for failing bc in /browser_misused_characters_in_strings.js r=backout on a CLOSED TREE 2017-11-07 21:04:54 +02:00
Julian Descottes
10e099779f Bug 1408334 - add form to subscribe to mozilla developer newsletter in about:devtools;r=nchevobbe
MozReview-Commit-ID: JuJqNS3r6NH

--HG--
extra : rebase_source : 20b9f294cb60873bfa6edc975d4688c1a2365eef
2017-10-31 10:19:00 +01:00
Julian Descottes
07ff2d75b1 Bug 1413840 - add a link to MDN on each about:devtools feature;r=flod,nchevobbe
MozReview-Commit-ID: J9BXHha9SPe

--HG--
rename : devtools/shim/aboutdevtools/images/feature-responsive-mode.svg => devtools/shim/aboutdevtools/images/feature-responsive.svg
rename : devtools/shim/aboutdevtools/images/feature-visual-editing.svg => devtools/shim/aboutdevtools/images/feature-visualediting.svg
extra : rebase_source : c705d48007ac27d129d280d0da8bb5e0541dd37e
2017-11-02 23:21:50 +01:00
Julian Descottes
2c5cda8646 Bug 1411906 - add close button to about:devtools if devtools are disabled;r=nchevobbe
A close button on the starting page of the devtools onboarding flow
will be helpful for users who triggered the shortcut by mistake and
would like to escape the flow.

MozReview-Commit-ID: 7rZ50jFepJ3

--HG--
extra : rebase_source : 9f0dadf3a68f084d05e9f0098a8a7ac90becf964
2017-11-02 21:56:26 +01:00
Julian Descottes
b88fd1ec3c Bug 1408331 - add license header to about:devtools svg files;r=nchevobbe
MozReview-Commit-ID: 3GEL9HTqzDA

--HG--
extra : rebase_source : 1be30233935210f67f4bef994d9636133a7d9a73
2017-10-31 11:37:18 +01:00
Julian Descottes
eb12efebaf Bug 1408331 - add footer to about:devtools page;r=nchevobbe
Add a footer containing a link to download Firefox developer
edition in about:devtools after devtools have been enabled.

MozReview-Commit-ID: KFefF6qB9tO

--HG--
extra : rebase_source : 73155c83264bfb26ca25dfc9c7a2fc6f4655f460
2017-10-25 20:48:24 +02:00
Julian Descottes
16719acdc0 Bug 1410360 - add mochitest for about:devtools tab selection behavior;r=ochameau
MozReview-Commit-ID: 8eX13qJ1jt8

--HG--
extra : rebase_source : 1b4c4f0e1d078f88ab9f4b305d791dfebdb132d5
2017-10-27 18:13:18 +02:00
Julian Descottes
097acc3d05 Bug 1410360 - reselect original tab after closing about:devtools;r=ochameau
MozReview-Commit-ID: 3bInaF7Zeg9

--HG--
extra : rebase_source : d31509b2264a82d091cfdeacf8e889635f4a65b8
2017-10-26 19:03:11 +02:00
Julian Descottes
c166f24405 Bug 1410360 - open about:devtools tab next to the current tab;r=ochameau
MozReview-Commit-ID: Cw0zFAeH7r2

--HG--
extra : rebase_source : 8afa81f0a700ddee3873e5fafc77daa39bb9dfd4
2017-10-26 19:07:58 +02:00
Julian Descottes
7bc1b2d4eb Bug 1413246 - devtools-startup should add event listeners only on initial launch;r=bgrins
MozReview-Commit-ID: HmTWm5jw50Q

--HG--
extra : rebase_source : e08477640d7c2d2f5731e7f091b9f97f3af398e9
2017-10-31 23:15:43 +01:00
Julian Descottes
74e5729dd5 Bug 1412504 - update styling for about:devtools;r=nchevobbe
MozReview-Commit-ID: 42Pe9BD7dVa

--HG--
extra : rebase_source : 06ae7de7791f7d87b14f810db7b3791e66207d8f
2017-10-28 12:47:23 +02:00
Julian Descottes
c1073d72a0 Bug 1412504 - update otter image in about:devtools;r=nchevobbe
MozReview-Commit-ID: FjdDDzcj6BL

--HG--
extra : rebase_source : acb45d0478966e8dd8f3a1c74ba86e1d518f2aaf
2017-10-28 12:22:39 +02:00
Julian Descottes
20dcf62319 Bug 1410361 - reuse existing tab of about:devtools;r=nchevobbe
MozReview-Commit-ID: 2cTjzmrcLYb

--HG--
extra : rebase_source : f2faf7cf176f008f25f8b4e3e972c49b48378147
2017-10-26 15:11:51 +02:00
Julian Descottes
60ad2e8979 Bug 1412050 - session restore should not initialize devtools when unnecessary;r=bgrins
MozReview-Commit-ID: BEQBZsXREoQ

--HG--
extra : rebase_source : 137ffca2e8ebdee6056e6746f54afa3e0c4539aa
2017-10-27 10:13:27 +02:00
Julian Descottes
0ce2bfb273 Bug 1412050 - avoid devtools onboarding flow when restoring session;r=ochameau
MozReview-Commit-ID: 8fJOPaOnkQe

--HG--
extra : rebase_source : 533d576fc094290e89feb7a4feb77b83054d458c
2017-10-26 20:16:05 +02:00
Julian Descottes
b6c8ab7cc9 Bug 1408330 - remove mentions about styleeditor, webaudio and scratchpad;r=nchevobbe
MozReview-Commit-ID: 5QZDZb39cYV

--HG--
extra : rebase_source : c88f33d768101fd7825b26fd5d513e7b32e4f630
2017-10-18 12:33:32 +02:00
Julian Descottes
325c347f6c Bug 1408330 - UI polish on DevTools onboarding page;r=nchevobbe
MozReview-Commit-ID: 5JE7ZErxCxG

--HG--
extra : rebase_source : 448dbd30a273169685880362622ab27985ef7e7b
2017-10-16 16:53:55 +02:00
Julian Descottes
9c81a6382f Bug 1408368 - move aboutdevtools.dtd out of localized folder;r=nchevobbe,Pike
MozReview-Commit-ID: 6jHqNcqONh3

--HG--
rename : devtools/shim/locales/en-US/aboutdevtools.dtd => devtools/shim/aboutdevtools/tmp-locale/aboutdevtools.dtd
extra : rebase_source : 0f83692849147d3f68404fea8a808fa3ddc1f561
2017-10-13 14:21:31 +02:00
Alexandre Poirot
9b47b7dc68 Bug 1405584 - Add telemetry to track toolbox open time. r=francois,jdescottes datareview=francois
MozReview-Commit-ID: EuaYQBx8rbE

--HG--
extra : rebase_source : deabc16b5b2df1f5d9767eaa0b83874d48306953
2017-10-11 11:43:25 +02:00
Julian Descottes
86e29220a8 Bug 1361080 - add unit test for aboutdevtools page;r=ochameau
MozReview-Commit-ID: CZV1MIj80Zf

--HG--
extra : rebase_source : e806c2cf1301eec1510f6d5476941ba100affd04
2017-10-03 23:34:44 +02:00
Julian Descottes
21c8547fe5 Bug 1361080 - Add "Enable DevTools..." menu item if devtools.enabled is false;r=ochameau
MozReview-Commit-ID: IL09o4xve64

--HG--
extra : rebase_source : b1dd8e4163fb6cbec236f8a1e3b64ab65b15577c
2017-08-29 23:09:21 +02:00
Julian Descottes
4b682362c2 Bug 1361080 - display devtools onboarding screen if devtools.enabled if false;r=ochameau
MozReview-Commit-ID: 6TtOAGc9Zzl

--HG--
extra : rebase_source : 29b9149cecfc6c1087bce42b3afdd6b88c82e62e
2017-08-28 15:12:03 +02:00
Julian Descottes
59e766b047 Bug 1361080 - add aboutdevtools component;r=ochameau
MozReview-Commit-ID: GuyQfXRKFpb

--HG--
extra : rebase_source : 808377154712b98c1bab76ee83ecbd72cb0ddc47
2017-10-04 15:16:37 +02:00
Alexandre Poirot
b4a4015145 Bug 1397452 - Remove all SDK compatiblity code from DevTools. r=jdescottes
MozReview-Commit-ID: IRhZeIS97cy

--HG--
extra : rebase_source : 31c638ef35d60368d676d855310cdfd26aa86428
2017-09-25 16:04:26 +02:00
Oriol Brufau
dfe71a8ffa Bug 1384572 - Prevent JSON Viewer from loading in iframes. r=Honza
MozReview-Commit-ID: Cj79fMt5oAO

--HG--
extra : rebase_source : d129395d6029d3b86730e3854bef723efb48a923
2017-09-20 00:01:21 +02:00
Alexandre Poirot
3675c8a0f9 Bug 1382377 - Make Console API be a no-op until DevTools are opened at least once. r=baku,jdescottes
MozReview-Commit-ID: 4xuzRQKH3Vg

--HG--
extra : rebase_source : f388a7222df314c988c3af20afb59684cc1045e5
2017-08-08 16:29:34 +02:00
Kris Maglione
821308e4d1 Bug 1391110: Part 4 - Remove unnecessary nsIFrameLoaderOwner QIs. r=smaug
The FrameLoaderOwner interface has been implemented in WebIDL for several
years now, so these QIs are simply unnecessary overhead.

MozReview-Commit-ID: LAzvfm5Qhy0

--HG--
extra : rebase_source : 2495c07df21c474f5fabc257ff4db43b0d8047e4
2017-08-19 13:32:58 -07:00
Julian Descottes
024a25f592 Bug 1386616 - dt-addon: move key-shortcuts.properties to devtools/shim/locales;r=ochameau
MozReview-Commit-ID: 9zUqnuYIdWS

--HG--
rename : devtools/client/locales/en-US/key-shortcuts.properties => devtools/shim/locales/en-US/key-shortcuts.properties
extra : rebase_source : 806a6baa5886fbad2b50df80a7560b5300bd25b5
2017-08-02 16:20:58 +02:00
Julian Descottes
1e72d11d7b Bug 1386616 - dt-addon: create new devtools/shim locale;r=Pike
MozReview-Commit-ID: JVnBlBSPpw1

--HG--
extra : rebase_source : 1a8239167f5bfc98a170907e1337ac19b27e0799
2017-08-03 16:57:19 +02:00
Julian Descottes
68384c971b Bug 1392531 - create dedicated tab target instance for web-extensions;r=jdescottes
MozReview-Commit-ID: G7EOfYnZuZw

--HG--
extra : rebase_source : f363f9cb0027b20d9c8c5cb684af3b295b9ad289
2017-08-22 16:31:44 +02:00