Commit Graph

18094 Commits

Author SHA1 Message Date
Jim Chen
caaf58697a Bug 1333589 - 3. Convert SiteIdentityPopup observers to events; r=sebastian
Convert the "Permissions:*" and "Session:Reload" observers to events
that go through GlobalEventDispatcher.
2017-01-25 18:57:32 -05:00
Jim Chen
174b21ef30 Bug 1333589 - 2. Convert SiteIdentityPopup events to bundle events; r=sebastian
Convert the events used in SiteIdentityPopup to bundle events. UI thread
events are used because the listeners perform operations on the UI
thread.
2017-01-25 18:57:31 -05:00
Jim Chen
a8edf60a6c Bug 1333589 - 1. Use GeckoBundle for DoorHanger.OnButtonClickListener; r=sebastian
Convert the onButtonClick method to provide GeckoBundle as the response.
2017-01-25 18:57:31 -05:00
Jim Chen
f6a51590a8 Bug 1333588 - Convert PageActions events to bundle events; r=sebastian
Convert events used in PageActions to bundle events. UI thread events
are used because the listeners require the UI thread. The observer
notifications from Java to Gecko are converted to events as well.
2017-01-25 18:57:31 -05:00
Jim Chen
2e56d7739e Bug 1333586 - Convert AccountsHelper events to bundle events; r=sebastian
Convert events used in AccountsHelper to bundle events. Most events are
kept as Gecko thread events, but a couple events that start activities
are converted to UI thread events.
2017-01-25 18:57:31 -05:00
Jim Chen
a396212751 Bug 1333581 - Convert IntentHelper events to bundle events; r=sebastian
Convert events used in IntentHelper to bundle events. UI thread events
are used for most events because the listeners perform operations on
Intent objects, which is best done on the UI thread. For
"Intent:GetHandlers", use a Gecko thread event because it's possible we
want a synchronous callback response.
2017-01-25 18:57:31 -05:00
Jim Chen
296c0b8b43 Bug 1330439 - 4. Convert home panel observers to events; r=sebastian
Convert nsIObserverService observers used in home panels to events that
go through EventDispatcher.
2017-01-25 18:53:58 -05:00
Jim Chen
dfcdeb5ce1 Bug 1330439 - 3. Convert HomePanelsManager events to bundle events; r=sebastian
Convert events used in HomePanelsManager to bundle events. Background
thread events are used because HomePanelsManager processes panel changes
in the background thread. Changing to background thread events also lets
us make the change queue a simple ArrayList instead of a
ConcurrentLinkedQueue, because there is no longer multiple threads
involved.
2017-01-25 18:53:58 -05:00
Jim Chen
768eb3905e Bug 1330439 - 2. Convert HomeBanner events to bundle events; r=sebastian
Convert the events in HomeBanner to bundle events. "HomeBanner:Shown" is
removed in favor of using a callback.
2017-01-25 18:53:58 -05:00
Jim Chen
6738ee9866 Bug 1330439 - 1. Convert PanelInfoManager events to bundle events; r=sebastian
Convert the "HomePanels:Data" event to a GeckoBundle/BundleEventListener
event. UI thread event is used because the listener invokes the callback
on the UI thread.
2017-01-25 18:53:58 -05:00
Jim Chen
a1a65941ef Bug 1330411 - 2. Convert FindInPageBar events to bundle events; r=sebastian
Convert events used in FindInPageBar to GeckoBundle/BundleEventListener
events. UI thread events are used because the listener performs UI
operations. FindInPageBar also sends some events like "FindInPage:Find"
from Java to Gecko; those events will be converted in another bug.
2017-01-25 18:53:58 -05:00
Jim Chen
59b3ffa09c Bug 1330411 - 1. Convert ActionBarHandler observers to events; r=sebastian
Convert observers in ActionBarHandler.js to events that go through
WindowEventDispatcher. "TextSelection:Get" now replies through the
callback interface rather than a "TextSelection:Data" event. The patch
also adds new lazy-loading events in browser.js to replace the
lazy-loading observers that ActionBarHandler relied on.
2017-01-25 18:53:58 -05:00
Jim Chen
9a9702cab0 Bug 1330409 - Convert CastingApps events to bundle events; r=sebastian
Convert the events used in MediaCastingBar and ChromeCastPlayer to
GeckoBundle/BundleEventListener events. UI thread events are used
because the listener performs operations on the UI thread.
2017-01-25 18:53:57 -05:00
Grigory Kruglov
4f96795b02 Bug 1331091 - Document behaviour of special "experiment" telemetry sessions r=liuche
MozReview-Commit-ID: KKT2maMyDqj

--HG--
extra : rebase_source : 338e6b7cdde9cf61c1e2b7ab74d02d68c512363a
2017-01-25 12:28:41 -08:00
Tooru Fujisawa
ddd36fec56 Bug 1332245 - Move nsScriptError from js/xpconnect to dom/bindings. r=bz
--HG--
rename : js/xpconnect/idl/nsIScriptError.idl => dom/bindings/nsIScriptError.idl
rename : js/xpconnect/src/nsScriptError.cpp => dom/bindings/nsScriptError.cpp
rename : js/xpconnect/src/nsScriptErrorWithStack.cpp => dom/bindings/nsScriptErrorWithStack.cpp
2017-01-28 00:42:47 +09:00
Edouard Oger
0c915a6f46 Bug 1296767 part 1 - Remove J-PAKE from Sync. r=markh
MozReview-Commit-ID: iD4OJv436i

--HG--
extra : rebase_source : 1653284a3b2e014719a7eb37588f99df868e2060
2017-01-10 13:47:24 -05:00
Tomer Cohen
4ea01a8b63 Bug 1335010 - mobile/android/themes/core/config.css uses float: inline-* r=sebastian
MozReview-Commit-ID: A9yYnF5U2f0

--HG--
extra : rebase_source : 3e6bf0cb49bea547d57dde152bc37844b44dfe14
2017-01-30 15:48:38 +02:00
Jan Henning
de6d526e3c Bug 1062859 - Part 1 - Restore scroll position when going back through bookmark folders. r=ahunt
When going down one folder level, we store the current scroll position of the list view and then scroll to the top of the list, so that we always show a child folder starting from the beginning. When navigating back up to its parent, we then restore the previously stored scroll position.

MozReview-Commit-ID: 9C2RMXrlUm1

--HG--
extra : rebase_source : 7ec5a3f1d602db9454efa52603e0f50704c1418d
2017-01-22 22:02:35 +01:00
Jan Henning
9ae155958c Bug 1062859 - Part 0 - Bookmarks panel cleanups. r=ahunt
Fix up javadoc so it matches the actual function parameter and remove unneeded imports.

MozReview-Commit-ID: I91NuqLlpL1

--HG--
extra : rebase_source : 13366049ee9fe1487b3cf24f4e6f610f66bee5ee
2017-01-23 19:23:55 +01:00
Andrzej Hunt
68b1cebd29 Bug 1120441 - Don't try to show tab-history panel if app has been shutdown r=sebastian
Showing the tab history panel involves a gecko call to retrieve tab history. This
can be slow, meaning we have no idea what state the app will be in when the tab
history data is returned. Thus we need to protect the code that shows the tab
history fragment against a number of scenarios to avoid crashes in those cases
where the app might be shutting down:

1. If onSaveInstanceState() has been called (which might happen before or after onPause(),
   and might be linked to app shutdown - but the docs don't appear to give any guarantees),
   fragment transactions cannot be performed. We protect against this by accepting loss
   of state in fragment transactions.
2. If the Activity has been completely destroyed, trying to perform a fragment transaction
   will likewise fail. We protect against this by not even trying to perform the transaction
   if we definitively know that the Activity is being shut down (ie isFinishing()).

In both of these cases, we simply must accept that we're potentially losing UI state: i.e.
a user could request the tab history panel via long-back-press, followed by exiting the app;
we now end up never ever showing the panel. This scenario doesn't seem like a major loss - and
fixing this issue properly would require significant investment (i.e. we would need to either
cache tab history on frontend side, or cache the tab-history panel request - and it's not clear
users will still care about seeing the panel the next time they open firefox).

MozReview-Commit-ID: JsAK1By8yqn

--HG--
extra : rebase_source : 9a3b64d2829a969e4de2775c2714874aa8708031
2017-01-18 22:09:20 +01:00
Jan Henning
db207e8e6c Bug 1333567 - Send the notification expected by the session store when restarting, too. r=sebastian
Since bug 1228593, the mobile session store
- once again flushes its data when we are quitting, to make sure the latest state (including any potential cleaning of history/tabs) is flushed to disk
- ignores windows/tabs closing as a byproduct of shutdown

The latter point is dependent on a new shutdown notification introduced in that bug. Because we forgot to add that notification to the restart code used for add-on updates, in that case the session store currently doesn't enter shutdown mode and therefore records the window being closed during shutdown before flushing its data to disk, which means that all open tabs are lost.

MozReview-Commit-ID: LgtdQoYwacM

--HG--
extra : rebase_source : 1bf6c544d9e25961a0e64236678ca5938e8a69fe
2017-01-25 20:31:30 +01:00
Carsten "Tomcat" Book
65f7bfd24d Merge mozilla-central to autoland 2017-01-30 16:21:32 +01:00
Andrzej Hunt
121fe4fced Bug 1325375 - Make PopupContextMenu visible on Android 4 Asus tablets r=sebastian
MozReview-Commit-ID: 1XSiiyQPAXb

--HG--
extra : rebase_source : 6d04d2642129b6e4e5822bd5580b2ff53145a011
2017-01-24 12:28:57 -08:00
Edouard Oger
2458eff863 Bug 1333494 - Bump Android Sync tab records TTL to 21 days. r=Grisha
MozReview-Commit-ID: DpuIkqPlztd

--HG--
extra : rebase_source : b869f21a78b5de1001d58777e8604faaa05b66d3
2017-01-24 13:25:09 -05:00
Carsten "Tomcat" Book
58b6101373 Merge mozilla-central to autoland 2017-01-26 12:37:41 +01:00
Jan Henning
5812dc3cb2 Bug 1333386 - Use {once: true} for session store window "load" listener. r=sebastian
MozReview-Commit-ID: Kc9ydTUrLy1

--HG--
extra : rebase_source : 5dd77f5bff248c305674ef0f7cfbef53675d0a90
2017-01-25 20:19:14 +01:00
Jan Henning
668da1fdc7 Bug 1333046 - Part 2 - Move zombification function into the tab object. r=ahunt
A tab object should know how to zombify itself instead of having to rely on the MemoryObserver. This also simplifies the situation for anybody else who wants to call this function since it is no longer necessary to figure out how to load the MemoryObserver for this.

MozReview-Commit-ID: 5IX114QUjBT

--HG--
extra : rebase_source : 964186678848b804e5f0550e1b6a328d7fcfbc50
2017-01-19 21:45:03 +01:00
Jan Henning
8464eb0fcf Bug 1333046 - Part 1 - Expose a method to restore delay-loaded tabs via the tab object. r=ahunt
Actors outside of the session store shouldn't have to poke around within the session store's data structure and end up reimplementing parts of the session store code (and cause data loss if the implementation is incomplete) in order to restore delay loaded zombie tabs. Therefore, we simply expose a method for this via BrowserApp's tab object.

To simplify handling and make the method a little more fool-proof for external callers, the check whether the tab is actually zombified is moved into the restoreZombieTab() function.

Later on, we can also hook up this method to the appropriate web extension API (see bug 1322485).

MozReview-Commit-ID: 85lnbCpMcP3

--HG--
extra : rebase_source : a6f1cfa11debcb18471b49804776521c60655fce
2017-01-25 21:33:33 +01:00
Carsten "Tomcat" Book
182312677f merge mozilla-inbound to mozilla-central a=merge 2017-01-25 13:47:25 +01:00
Makoto Kato
812588087b Bug 1332792 - Add mozIntl.xpt to Android package for xpcshell test failure. r=gandalf
With --with-intl-api, xpcshell test for MozIntl is always failure on Android.  So we should add mozIntl.xpt to package.

MozReview-Commit-ID: BWBKSG3gSqr

--HG--
extra : histedit_source : d4091b91221bc2ef282d0855dbf4856adb403c9b
2017-01-25 15:31:15 +09:00
Florian Quèze
0e0865f4fc Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Tomer Cohen
b670b52324 Bug 1298913 - [RTL] RTL the preferences in about:config r=sebastian
MozReview-Commit-ID: 132jVEEFH2W

--HG--
extra : rebase_source : 0bbe5586abdb82b2abb41d0be71ca8debff9e056
2017-01-19 22:52:07 +02:00
Phil Ringnalda
1b60bc19eb Merge m-c to autoland 2017-01-24 18:56:54 -08:00
Phil Ringnalda
bf98cd4315 Merge m-i to m-c, a=merge 2017-01-24 18:53:29 -08:00
Wes Kocher
a65c1b1dfe Merge inbound to central, a=merge
MozReview-Commit-ID: BeGxZAeguBr
2017-01-24 16:08:16 -08:00
Eugen Sawin
e03bb44096 Bug 1333241 - [1.0] Initialize screen orientation on instantiation. r=jchen 2017-01-24 21:47:08 +01:00
James Cheng
a72c2a70e2 Bug 1332981 - [EME][Fennec] Pref on EME API not only for Nightly build. r=cpearce
MozReview-Commit-ID: 77MrnKZRtoN

--HG--
extra : rebase_source : ca59175b50c5b17623f913be36854473bb8d8bed
2017-01-23 12:31:34 +08:00
Wes Kocher
8439919627 Merge m-c to autoland, a=merge
MozReview-Commit-ID: 7eiveonzAo4
2017-01-24 16:11:28 -08:00
Phil Ringnalda
9823741350 Merge m-c to m-i 2017-01-23 18:57:15 -08:00
Michael Kaply
506dc7f883 Bug 1107942 - Allow zh-CN distribution to add Quit menu. r=sebastian 2017-01-23 17:43:47 -06:00
Jim Chen
8b160783a8 Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug
Bug 1319660 - 1. Don't take shortcut if old replacement ranges don't match; r=esawin

The block at [1] is a shortcut we take when we reconcile Java text
changes with Gecko text changes. However, we only checked that the new
ranges are the same, i.e. that the new Gecko text is the same as the new
Java text. We should also be checking that the old ranges are the same,
i.e. that the replaced Gecko text is the same as the replaced Java text.

[1] https://dxr.mozilla.org/mozilla-central/rev/bbbd2f7539f224a482cc6d2dd10e6a5f31c8baf3/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java#1233

Bug 1319660 - 2. Use previous node instead of sibling when adjusting last node; r=masayuki r=smaug

nsContentIterator in pre mode adjusts its last node if the node is a
childless node like <br>. However, right now it's using GetPrevSibling,
which can lead to error in some edge cases such as:

<p></p><div><br></div>

In this case, if the last node is <br> with offset 0, GetPrevSibling
will return <p> because <p> is <br>'s parent's previous sibling, and the
last node will be set to <p>. However, the correct last node in this
case is <div>, because <br> with offset 0 refers to the position to the
left of <br>, which is <div> with offset 0. In this case, PrevNode
returns the correct <div> value, so we should set the last node to the
result of PrevNode.

For the first node, for a childless node in pre mode, GetNextSibling and
NextNode are the same, so there is no bug in this case. Nevertheless,
this patch changes the call to NextNode to be consistent with calling
PrevNode for the last node.

Bug 1319660 - 3. Add test for correctly adjusting last node in content iterator; r=masayuki

Add a test for the previous patch that makes sure querying selected text
in an edge case works correctly.

Bug 1319660 - 4. Add test for start node regression; r=me

Add a new test case for the NextNode() regression. r=me for trivial
test-only patch.

Bug 1319660 - 5. Restore GetNextSibling call for first node of pre-content-iterator; r=smaug

The last patch changed the `GetNextSibling()` call to `NextNode()`
because I assumed they're equivalent in this case. That turned out to
not be the case because we can reach this line even if the node has
children -- the index just has to be after the last child. So this patch
restores the `GetNextSibling` call to restore the correct behavior.

I also added some comment to clarify that we can reach this line due to
one of two conditions: 1) the node has no children; 2) the node has
children but the index is after the last child.

This patch also replaces the `HasChildren()` check when setting
`cChild`.  If the index is after the last child (i.e. index ==
childCount), `GetChildAt()` fails and we erroneously log an assertion
warning, even though the input was valid. The new check handles all
cases whether start node has children or not.
2017-01-23 14:35:04 -05:00
Ralph Giles
6af75bbd06 Bug 1332759 - Update android builders to rust 1.15.0-beta.4. r=rillian
Bump the Android builders to the latest beta release to reduce
the variance when we update Firefox 53 to 1.15.0 stable early
in the Aurora phase.

Android builds were moved to 1.15 early to address a code generation
issue with devices without neon.

Work around an issue with tarball naming in the cargo packages.

MozReview-Commit-ID: KQfkWmXV9hQ

--HG--
extra : rebase_source : 9448e0b948740fc3905ef70c8df316dc7342d52e
2017-01-20 15:18:26 -08:00
Tomer Cohen
3dcaa6b2cd Bug 1332694 - Add chevron-rtl.png to android chrome manifest r=sebastian
MozReview-Commit-ID: 8jtEMtqZWOg

--HG--
extra : rebase_source : 1a2e5c86b9d6df77f9f92131cd8328a56db0003d
2017-01-20 20:24:03 +02:00
Tomer Cohen
a5c096dde5 Bug 1332396 - [about:config] Unable to store non latin-1 characters r=sebastian
MozReview-Commit-ID: 3JBTcHePyl3

--HG--
extra : rebase_source : d7dde5561bcb186020456d4c390d1975ee97d584
2017-01-19 21:07:26 +02:00
Tomer Cohen
a3277b929b Bug 1332471 - about:config on Android is missing a page title r=sebastian
MozReview-Commit-ID: 81jNo9jxNNY

--HG--
extra : rebase_source : 60a71b5604b2aeee1e8f087f93fcaadb6d15ba1a
2017-01-20 00:19:20 +02:00
Jan Henning
7f37054663 Bug 1332863 - Turn on strict mode for mobile session store. r=sebastian
MozReview-Commit-ID: 20KRW4yxPm4

--HG--
extra : rebase_source : 31cda3723011281523468643a5a48da22066fc6f
2017-01-21 19:58:57 +01:00
Makoto Kato
c69d395f8b Bug 1332806 - Check AppConstants.MOZ_ENABLE_PROFILER_SPS to use Profiler object on browser.js. r=sebastian
When turning off SPS profiler by configure option, or we build non-SPS arch build  such as android/aarch64, Tab.prototype.onStateChange already throws the exception because Profiler isn't defined.

So we should check AppConstants.MOZ_ENABLE_PROFILER_SPS to use Profiler object.

MozReview-Commit-ID: A9ISurxiRmc

--HG--
extra : rebase_source : 25103e97cd4827edef33335e3aec9384a6695526
2017-01-21 12:41:22 +09:00
cnevinc
8dde17828f Bug 1333006 - Add localization note explaining that "Open" here is not an action, like a button, but an adjective. r=sebastian
MozReview-Commit-ID: 8y8g8CfpdzJ

--HG--
extra : rebase_source : bc56c27f41277909d5d3016c7e43e7365f735bb6
2017-01-23 16:05:25 +08:00
Jan Henning
7886887a86 Bug 1330422 - Use arrow functions instead of capturing "this" in the session store. r=sebastian
MozReview-Commit-ID: AlLHJipN6kL

--HG--
extra : rebase_source : f279021f013bcfb4e671b9c6d609f342b57faac9
2017-01-12 21:36:01 +01:00
Jan Henning
c90cc004dc Bug 1317079 - Avoid spurious exception when snackbar is dismissed. r=jchen
When a snackbar with a button callback is dismissed, this translates to a rejected promise from sendRequestForResult(). We need to catch this in order to avoid a spurious 'JavaScript Error: "uncaught exception: undefined"' message appearing in the console and possibly causing confusion.

MozReview-Commit-ID: 7hsAOAMTeDP

--HG--
extra : rebase_source : 6c5eb28d2e0dcf39a35b310d1e1c45cfc47f272b
2017-01-21 21:47:08 +01:00
Jan Henning
629cf290d4 Bug 1329330 - Remove old session store code that's no longer needed. r=sebastian
We've been parsing the session store file and doing the initial tab creation on the Java side for a long time now, so the code to open completely new tabs on the session store side instead of using tab stubs is no longer necessary.

Besides, because of bug 1301160 the on-disk session file is now containing tab IDs as well, so this distinction between tabs read directly from the raw session file and those contained in a session string passed over from the Java UI is no longer available.

MozReview-Commit-ID: Hmq0TwClqMQ

--HG--
extra : rebase_source : 1f9ab6da18a7fd0f40a1cb0784082abb2384404f
2017-01-07 22:26:51 +01:00
Nevin Chen
333884f49b Bug 1320900 - Do not show Reader View icon on error pages. r=sebastian
MozReview-Commit-ID: GrQqKqccicf

--HG--
extra : rebase_source : 1cd6b57ad7958f607da17101b9b313f9cd508759
2016-12-30 11:11:09 +08:00
cnevinc
506742c281 Bug 1317632 - If the bookmark to add is a reader mode page, defer db action till it cache completely and save the same url in bookmarks and uriannotations table to avoid URL chagne between two http requests. r=sebastian
MozReview-Commit-ID: 8ZwteTOKe1G

--HG--
extra : rebase_source : 1ca9d9a24d3dca32dd394414ffad88304d06a28c
2017-01-14 12:05:48 +08:00
Nicholas Nethercote
22b6d342d7 Bug 1333296 (part 1) - Rename MOZ_ENABLE_PROFILER_SPS as MOZ_GECKO_PROFILER. r=mstange,glandium.
--HG--
extra : rebase_source : 223f3a17f009645369be503392cc1f0cea7f19a1
2017-01-24 14:15:12 +11:00
Swaroop Rao
7e12d23496 Bug 1328837 - Move 'Switchboard' code into our module/package. Refactored SwitchBoard component to pull it into the app module. r=sebastian
MozReview-Commit-ID: HfypfVFdPwP

--HG--
rename : mobile/android/thirdparty/com/keepsafe/switchboard/AsyncConfigLoader.java => mobile/android/base/java/org/mozilla/gecko/switchboard/AsyncConfigLoader.java
rename : mobile/android/thirdparty/com/keepsafe/switchboard/DeviceUuidFactory.java => mobile/android/base/java/org/mozilla/gecko/switchboard/DeviceUuidFactory.java
rename : mobile/android/thirdparty/com/keepsafe/switchboard/Preferences.java => mobile/android/base/java/org/mozilla/gecko/switchboard/Preferences.java
rename : mobile/android/thirdparty/com/keepsafe/switchboard/Switch.java => mobile/android/base/java/org/mozilla/gecko/switchboard/Switch.java
rename : mobile/android/thirdparty/com/keepsafe/switchboard/SwitchBoard.java => mobile/android/base/java/org/mozilla/gecko/switchboard/SwitchBoard.java
extra : rebase_source : 696e6169c616f7a7540d452b27318c9647f620ee
2017-01-28 16:26:13 -05:00
Andrew Swan
f04f785725 Bug 1203330 Part 1 Fix SingletonEventManager r=kmag
This patch adds the ability to run SingletonEventManager handlers in
different modes: sync, async, raw (no exception handling, arg cloning,
or asynchrony), or asyncWithoutClone. When you call the handler,
you're required to specify which variant you want.

Existing uses of SingletonEventManager are all converted to async calls.
Note that some of them were previously synchronous, but it didn't appear
to be necessary.

Also added a callOnClose for SingletonEventManager when the last listener
is removed.

MozReview-Commit-ID: ATHO97dWf3X

--HG--
extra : rebase_source : 43988ee453e965e1c591b1c64603c22f5a103cff
2017-01-26 13:43:12 -08:00
John Lin
dfdaf47766 Bug 1333323 - remove nightly flag to enable OOP decoding for all versions. r=snorp
MozReview-Commit-ID: AjOsDiSmuz2

--HG--
extra : rebase_source : 63f7384bbe54077e5bbfd89016be2188856ae1de
2017-01-24 14:28:55 +08:00
Phil Ringnalda
bcbe2e1fcc Merge m-c to autoland 2017-01-20 19:15:16 -08:00
Dave Townsend
c5f0e2be67 Bug 1331968: Implement the moz: protocol handler to redirect to a fixed website. r=gijs
The protocol handler is intentionally simple. It works for the entering into the
urlbar case but not a lot else. Included some basic tests.

MozReview-Commit-ID: 4FQ1irdt3Nj

--HG--
extra : rebase_source : 30d9fc7ba2c500f268d282e47d291724d9899ba4
2017-01-18 14:10:46 -08:00
Andrzej Hunt
1e0cff53d2 Bug 1311555 - Use filled bookmark star in ActivityStream context menu r=sebastian
Unfortunately tinting the bookmark star is highly complicated due to the tinting
that NavigationView performs (i.e. we'd likely have to disable NavigationView
tinting, and do manual tinting on every icon - alternatively we could hack
the tint-list to use blue for "checked" items, and set the bookmark item
as checked). Since it's unclear if we even want the star to be blue,
we'll leave it grey (but filled) for now.

MozReview-Commit-ID: DekRZJayKIz

--HG--
extra : rebase_source : 1e3443e5f09c60bd0d7295bc35ecc08ca17b3dab
2017-01-18 12:20:50 +01:00
Andrzej Hunt
9bd6a8b199 Bug 1311555 - Pre: remove unused imports r=ahunt
MozReview-Commit-ID: 6Xk7Z01m41A

--HG--
extra : rebase_source : cfe5a302b9795ae5ae15af00452b39ef8d9db737
2017-01-18 12:18:06 +01:00
Andrzej Hunt
e75d6e42c4 Bug 1330986 - Override proguard config to fix VectorDrawable corruption on Android 4 r=sebastian
See https://code.google.com/p/android/issues/detail?id=209558 . On Devices
running Android 4 and below, VectorDrawable's can be corrupted due
to overzealous proguarding. This doesn't appear to have been
fixed in the support library yet, and even if it were fixed we
still wouldn't be able to switch to the most modern support
library without significant work.

MozReview-Commit-ID: 3ByogGygCEd

--HG--
extra : rebase_source : 2adeed63f88ca39a71feec60627fb812b76d3bb4
2017-01-17 12:16:42 +01:00
Nevin Chen
a2bee3f570 Bug 1331431 - Use baseline and FontMetrics instead of textview's center and text size to get the real text height. r=sebastian
MozReview-Commit-ID: 4HJKZP0F0ow

--HG--
extra : rebase_source : ef8a6a8b333733e3e07a23cc6bd0c19fe179d282
2017-01-18 17:59:23 +08:00
Nevin Chen
790b6fa100 Bug 1275662 - Close all tabs and clean up session files when "Open Tabs" is selected in "Clear private data on exit" or "Clear private data" pref. r=JanH,sebastian
MozReview-Commit-ID: GoUQVDIzYbI

--HG--
extra : rebase_source : 13bbf3477a29cf301df72b521a0e02875bb5ef14
2016-12-29 14:22:45 +08:00
Nevin Chen
bcd1e464ce Bug 1275662 - Add "Open tabs" as an item in [Clear Private data on exit] dialog. r=JanH,sebastian
MozReview-Commit-ID: 6KJvCfYTJSZ

--HG--
extra : rebase_source : 7e408b01c632536fac4fd02d3262376293c0e706
2016-12-29 11:44:36 +08:00
John Lin
25bf73baef Bug 1332177 - handle ICodec.configure() failure. r=jchen
MozReview-Commit-ID: KPhI04EA9n3

--HG--
extra : rebase_source : ceb40b48a1cb1e1a1458626c1ef2adbbc472d58e
2017-01-19 16:11:01 +08:00
jwu
9f9d605eea Bug 1325586 - Prevent creating IconDescriptor with null url, r=sebastian
MozReview-Commit-ID: 4y6fKR49DGG

--HG--
extra : rebase_source : c91f81e887ff59a11b80b407944ee943dd763e52
2017-01-16 15:56:43 +08:00
Wes Kocher
336f27142f Merge m-c to autoland, a=merge
MozReview-Commit-ID: 3pEpsd3DljH
2017-01-19 16:47:25 -08:00
Carsten "Tomcat" Book
3b3ce27e84 Merge mozilla-central to mozilla-inbound 2017-01-19 16:35:21 +01:00
Dylan Roeh
9d83c8ce5e Bug 1303362 - Set a flag on custom tabs so that links do not open in a new tab. r=snorp 2017-01-19 09:18:40 -06:00
maliu
b67796ca12 Bug 1332258 - Reset text fading gradient to null when text direction changed, r=sebastian
MozReview-Commit-ID: EaUUO8aegzj

--HG--
extra : rebase_source : 47c719ec9d464208c48191e96c1227d0333dc083
2017-01-19 15:09:14 +08:00
Sebastian Kaspari
255526a131 Bug 1331808 - IconRequest.moveToNextIcon(): Throw exception if removing current item failed. r=Grisha
MozReview-Commit-ID: 2dfgG7N9bX6

--HG--
extra : rebase_source : b0d9e6b5734e082fb0008e12d841b6d4e489d9b7
2017-01-18 15:06:44 +01:00
Sebastian Kaspari
7c526adbf9 Bug 1331808 - IconDescriptorComparator: Return consistent order for compared items. r=Grisha
Previously if we could not compare two icon descriptions we'd always return the "right" one. This does
not create a consistent order if the parameters are flipped. As a result some operations on a TreeSet
can fail (like remove()).

MozReview-Commit-ID: EYPlhzGUEnD

--HG--
extra : rebase_source : f8918c022188401e21a03ac666628cff3e87f317
2017-01-18 14:50:35 +01:00
Julian_Chu
ee4031267e Bug 1322114 - Add test cases for MediaControlService r=sebastian
Also refactor MediaControlService to be test-friendly.

MozReview-Commit-ID: 344cEEuVroG

--HG--
extra : rebase_source : 14042bc3225538f621605b7aadb9d729c01ac62b
2017-01-12 15:44:19 +08:00
Julian_Chu
1037846788 Bug 1322114 - Part 2: handle more media state change r=alwu
When the playing-media changes (ie. in Youtube click another
video when it is alreay playing one), there will be one more
event MEDIA_PLAYING_CHANGE, and the tab is still playing media.

This fix is to handle this situation then update state.

MozReview-Commit-ID: Aje2BBqFZKE

--HG--
extra : rebase_source : f7c8f80c1d49e3a9aef868d11a4cd9d722a5c221
2017-01-12 14:54:05 +08:00
Julian_Chu
dad1b5861b Bug 1322114 - Part 1: Change UI updating flow r=alwu
This patch involve State into MediaControlService.

ACTION is behaviour for an intention, and so far we use it for storing
media state. Now involve enum to distinguish State from Action.

So flow becomes: Action happens -> Change State -> UI reflect state
changing.

MozReview-Commit-ID: FBHn02tgVO6

--HG--
extra : rebase_source : e1c57502a13669fad0ee2848c6cff420ebbe064f
2017-01-11 18:24:53 +08:00
Michelangelo De Simone
7baf165ae7 Bug 1313155 - Remove dom/settings and related code. r=Ehsan
MozReview-Commit-ID: Gi7frPFQ6yW

--HG--
extra : rebase_source : 69bb31fe3bc96ca460f0e35abb0b0f82d03defb6
2016-12-29 11:26:49 -08:00
Wes Kocher
656a71a520 Merge m-c to autoland, a=merge
MozReview-Commit-ID: 2KR6yXYC2xj
2017-01-18 15:39:12 -08:00
Ryan VanderMeulen
9e4ddf00bd Backed out 3 changesets (bug 1319660) for causing bug 1329446.
Backed out changeset d506d3c193c9 (bug 1319660)
Backed out changeset 93353b53a706 (bug 1319660)
Backed out changeset 9a7c2edd54b8 (bug 1319660)

--HG--
extra : rebase_source : 43ad1287462697f2312aa18925a462eb85c52495
2017-01-18 10:55:53 -05:00
Michael Kaply
c0992b79c3 Bug 1331080 - Switch suggestedSites.hidden to be marked as Android pref. r=sebastian 2017-01-18 09:44:05 -06:00
Ryan VanderMeulen
4eacb032f5 Merge autoland to m-c. a=merge 2017-01-18 09:24:55 -05:00
Randall Barker
440ada1d59 Bug 1331116 - part 2, Remove unused SnapMetrics class r=jchen 2017-01-17 18:47:20 -08:00
Randall Barker
937209439a Bug 1331116 - part 1, Remove unused ProgressiveUpdateData.java r=jchen 2017-01-17 18:47:20 -08:00
Wes Kocher
602c930ba0 Merge m-c to inbound, a=merge
MozReview-Commit-ID: 10MpA6zwIWr
2017-01-17 17:59:26 -08:00
John Lin
9d6dc35064 Bug 1326026 - use bufferless samples for outputs when rendering to surface. r=snorp
MozReview-Commit-ID: 8gC0QdJUoEk
2017-01-18 09:23:03 +08:00
Jim Chen
ea0faaf540 Bug 1329268 - 3. Convert Tabs observers to events; r=sebastian
Convert the "Tab:*" observers in browser.js, which go through the observer
service, to events that go through GlobalEventDispatcher.

FindHelper.js uses "Tab:Selected" through a lazy loader, but I don't
think FindHelper should listen to "Tab:Selected" at all until it is
being used. THerefore, this patch adds "Tab:Selected" registration to
FindHelper.js itself.
2017-01-17 20:06:08 -05:00
Jim Chen
ba440de455 Bug 1329268 - 2. Convert Tabs events to bundle events; r=sebastian
Convert events used in Tabs to GeckoBundle/BundleEventListener events.

All of the events are converted to UI thread events, because a lot of
the listeners modify states in Tab (e.g. through
`Tab.handleLocationChange()`), and those states are later accessed on
the UI thread. We used to modify the states on the Gecko thread, and
then access them on the UI thread, which introduces potential race
conditions. Therefore, I think it's best to convert these events
wholesale to UI thread events to avoid races.

Tabs.notifyListeners now calls the listeners directly if it's already on
the UI thread, instead of posting to the UI thread again. This is meant
as an optimization because the events are now coming in on the UI thread
already.

The "Tab:SelectAndForeground" and "Tab:Select" events are merged into
one "Tab:Select" event, and a "foreground" option is added.

The "Tab:StreamStart" and "Tab:StreamStop" events are merged into one
"Tab:RecordingChange" event, and a "recording" option is added to
indicate starting or stopping.
2017-01-17 20:06:07 -05:00
Jim Chen
940c5b25cc Bug 1329268 - 1. Refactor SiteIdentity to use GeckoBundle; r=sebastian
Make SiteIdentity.update use GeckoBundle, and also simplify the enums
in SiteIdentity, by using Enum.valueOf to get enum values from names,
instead of custom code.
2017-01-17 20:06:07 -05:00
Jim Chen
ddc86569ce Bug 1328991 - Convert ZoomedView events to bundle events; r=sebastian
Convert events used in ZoomedView to GeckoBundle/BundleEventListener
events.

"Window:Resize", "Browser:ZoomToPageWidth", and
"Browser:ZoomToRect" listeners are removed because they are not sent
anywhere.

The "Content:LocationChange" listener is merged into the
"Gesture:CloseZoomedView" listener, so that we can leave
"Content:LocationChange" alone for now. Otherwise we would have to
convert the "Content:LocationChange" listener in Tabs as well.

The listeners are changed from global listeners to per-GeckoApp
listeners, because two of the events, "FormAssist:AutoCompleteResult" and
"FormAssist:Hide", are per-GeckoApp events also used by FormAssistPopup.
Because the events are now per-GeckoApp events, they are now registered
from onAttachedToWindow and onDetachedFromWindow.
2017-01-17 20:06:07 -05:00
Jim Chen
58eee87559 Bug 1328990 - Convert FormAssistPopup events to bundle events; r=sebastian
Convert "FormAssist:*" events in FormAssistPopup to
GeckoBundle/BundleEventListener events.  UI thread events are used
because the listener performs operations on the UI thread.

Also convert the "FormAssist:*" observers in browser.js to use
WindowEventDispatcher.

The "FormAssist:AutoComplete" event that goes from Gecko to Java is
renamed to "FormAssist:AutoCompleteResult" to prevent conflict with the
event with the same name that goes from Java to Gecko.
2017-01-17 20:06:07 -05:00
Dale Harvey
0a37fafed0 Bug 1234558 - Use icons from app manifest. r=marcosc, r=sebastian 2017-01-17 18:24:53 +00:00
Mike Hommey
5f5c4c0bc0 Bug 1331858 - Avoid bug 1289974 breaking the build when it reaches beta/release. r=mshal
While here, fix abuses of GRE_MILESTONE in moz.build and use
RELEASE_OR_BETA instead.

--HG--
extra : rebase_source : 2a8c6501b0fe3bb603a65d52dda13c609a75b033
2017-01-18 14:47:08 +09:00
Francisco Aguiar
7e0255c5c1 Bug 1330009 - Remove unused setToolBarButtonsAlpha() method. r=sebastian
MozReview-Commit-ID: A7PIZDck82h

--HG--
extra : rebase_source : 13dda1be7f29c2cebd907616fad3a514c65eb58a
2017-01-16 00:57:53 +00:00
friedger
2db16d7fc8 Bug 1317933 - CustomTabsActivity: Set theme based on toolbar color. r=sebastian
MozReview-Commit-ID: 7cVsgDGPNXW

--HG--
extra : amend_source : ba6847d3c04b5fbe7dcb17da0fe2076ebb557877
2016-12-21 11:54:06 +01:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Ryan VanderMeulen
78cc07597f Merge m-c to autoland. a=merge 2017-01-17 11:32:39 -05:00
maliu
e830e5cda0 Bug 1320072 - Support direct search from intent, r=sebastian
MozReview-Commit-ID: GAoC4jKVyl7

--HG--
extra : rebase_source : 1df217a86397aac7958885bd9ee7853d47c33e5a
2016-11-30 20:25:32 +08:00
Sebastian Kaspari
475fe07452 Bug 1330280 - Refactor testActivityStreamContextMenu to use new Highlight/TopSite model classes. r=ahunt,Grisha
MozReview-Commit-ID: 8pwUVQHwPu6

--HG--
extra : rebase_source : 519842e24c85e600e3b470dc6a842136be6acd74
2017-01-12 17:30:20 +01:00
Georg Fritzsche
a6d7adc430 Bug 1331169 - Fix Android ActivityStream docs. r=gkruglov 2017-01-14 15:12:29 +07:00
Jan Henning
0075616fae Bug 1330079 - Collect window data one more time if a new tab arrives before application-quit. r=sebastian
This is relevant when a new tab is opened (e.g. through an intent from an external app) just as the user has pressed the Quit button (see bug 1266594), in which case the TabOpen event might reach the session store after Gecko shutdown has already started. If we're still in the preliminary phase and the browser window hasn't yet been closed, we can persist this new tab by collecting the session store data from the browser window once more.

Additionally, we now reset the time of the last backup when clearing the session store data, so the backup file is recreated as soon as possible after a history/tabs sanitisation, especially for users who are cleaning private data on exiting Firefox.

MozReview-Commit-ID: 9BmqrSIUJ42

--HG--
extra : rebase_source : be3c413db16523aac69d8283f36057713c1e9367
2017-01-11 22:26:30 +01:00