Commit Graph

6 Commits

Author SHA1 Message Date
Benoit Jacob
1727f110cb Bug 659842 comment 86 - accidentally removed a glXDestroyContext call + fix a warning in opt build - r=trivial-fix 2011-06-17 21:42:31 -04:00
Benoit Jacob
4500b8e8dc Bug 659842 - [topcrash] release the GL context before calling glXDestroyContext - r=karlt
See the glXDestroyContext man page:

  If GLX rendering context ctx is not current to any thread,
  glXDestroyContext  destroys it immediately.  Otherwise, ctx is destroyed
  when it becomes not current to any thread.  In either case, the resource ID
  referenced by ctx is freed immediately.

In other words, if we want glXDestroyContext to have the well-defined semantics
of destroying the context before future X commands take effect, we must first
release the GL context before calling it. We were failing to do that, but we
were destroying the drawable immediately after that call, and as a result, the
context was outliving its underlying drawable. This eventually resulted in
X_GLXMakeCurrent: GLXBadContextTag X errors on subsequent glXMakeCurrent calls.
2011-06-17 11:49:27 -04:00
Benoit Jacob
52a0dd4eeb Bug 658840 - let glxtest process return from XRE_main rather than calling exit() - r=bsmedberg
Calling exit() resulted in two strings being considered leaked by valgrind. Returning from XRE_main() should fix that.
2011-06-10 15:07:54 -04:00
Benoit Jacob
74758ffbcb Bug 660466 - segfault in glxtest - check if a visual was found - r=karlt 2011-06-10 15:05:10 -04:00
Benoit Jacob
0123ed0bf8 Bug 660466 - segfault in glxtest - check if any fbconfig was found - r=karlt 2011-06-10 15:04:20 -04:00
Benoit Jacob
5728b278e4 Bug 639842 - implement glxtest probe running as separate process - r=bsmedberg,joe 2011-05-03 16:07:17 -04:00