Commit Graph

13 Commits

Author SHA1 Message Date
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Mike Conley
441aadf5f8 Bug 1492950 - Get browser-fullZoom.js and ZoomUI.jsm off of getBrowserForDocument. r=florian
Depends on D6710

Differential Revision: https://phabricator.services.mozilla.com/D6711

--HG--
extra : moz-landing-system : lando
2018-10-02 17:51:11 +00:00
Brad Werth
1de7e2d845 Bug 1451115 Part 1: Make UpdateZoomUI not throw an exception if gBrowser is not set on window. r=mossop
MozReview-Commit-ID: 6N51Dqxt3jk

--HG--
extra : rebase_source : 55813db8d6dbab8cc53912015256714b0577db2e
2018-04-03 13:36:24 -07:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Gijs Kruitbosch
8c1b02e3d4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
MozReview-Commit-ID: L017kRfHfOv

--HG--
extra : rebase_source : c9dcbb76d787281ac2dcf18c59786205aeaacaf9
2017-11-07 12:15:18 +00:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Jared Wein
7231c8759e Bug 1383662 - Return early from onZoomChange if the document being referenced by the TextZoomChange event is missing a documentElement since we will not be able to find the related browser for the document in this case. r=florian
MozReview-Commit-ID: 34Ium8oqZmb

--HG--
extra : rebase_source : ba648ff412ba20e94a30d64d0811f7e375d7cd26
2017-07-24 11:16:37 -04:00
Jared Wein
b9f5336377 Bug 1378784 - Listen for TextZoomChange in addition to the FullZoomChange events to update the zoom UI when the zoom changes. r=dao
We were already listening for FullZoomChange. TextZoomChange is very similar, but is only triggered when the user has chosen 'Zoom Text Only' from the View > Zoom menu.

MozReview-Commit-ID: H8orEwS1ZhE

--HG--
rename : browser/modules/FullZoomUI.jsm => browser/modules/ZoomUI.jsm
extra : rebase_source : 1f77a3d994d34387ad8fa87ea9d403b1dfbd0a6f
2017-07-18 17:39:11 -04:00