on UNIX, when we don't have a newsrc root value, use ~/.mozilla/<profile>/News, like we do on the other platforms.
until now, we had been using $(HOME)
initialize some uninitialized variables.
remove nsMsgNewsFolder::GetChildNamed(), the base class has the same implementation.
when posting, if the host name is not explictly given, look for the news
host that is subscribed to the group.
fix a free memory read. (thanks to suresh for finding it)
implemented or they were just stubs. I added CanRename and CanCreateSubfolder
(which follow the naming convention, so we'll keep them) without knowing these were there. I move over the additional logic for special folders (like INBOX, TRASH, etc) in CanBeRenamed to CanRename, and put the logic in one place, in nsMsgFolder::CanRename(), instead of in multiple places. thanks to alecf for pointing out that CanBeRenamed and CanCreateChildren were already there.
r=alecf
major fixes for the new folder / rename folder / subscribe dialogs.
we no longer use an html select for the folder picker.
now we use cascading menu popups, like the copy and move menus.
this fixes a lot of bugs, and allows pre-flighting to finally work.
our folder data source has some new properies:
CanFileMessages, CanSubscribe, CanRename, and CanCreateSubfolders
we use these to determine what cascading menu to build, what to disable, etc.
also, nsMessenger::NewFolder() and nsMessenger::RenameFolder() were changes to
take a nsIRDFResource instead of a nsIDOMXULElement. Before we were
passing through to the back end the selected xul element, now we pass
the resource in.
other cool side effects:
in the copy & move menus, you don't get the choice to file or copy to a server, on folders
in the rename dialog, you can't pick a server, on a folder
in the new folder dialog, you can't pick the imap inbox. (* more needs to be done here.)
bugs fixed: #14773, #14254, #20599, #20646
r=alecf
a couple bullet proofing fixes to prevent some crashes reported on fullcircle
r=bienvenu
- get rid of GetAccountManager call (it's now a service)
- move hacks GetCurrentIdentity and GetCurrentServer into the account manager for now
- eliminate these calls from nsMsgMailSession
- update all call sites (C++ and JS)
r=mscott
from putterman, who gave me the fix:
"Whenever you add something to RDF through an observer notification, RDF
verifies that you really have it by calling HasAssertion. Our implementation of HasAssertion for adding a folder to a folder consists of seeing if the the
child folder's parent is equal to the parent passed in. Because we weren't setting the parent, the child's parent was null which wasn't equal to the parent
passed in and the whole operation failed. This prevents that from happening."
instead of setting the action for the url, check if we have a channel listener.
this is a cleaner fix, and now the quoting back end doesn't need to know about
the nntp url.
the problem was when we ran the nntp url to get the message we weren't
calling OnDataAvailabe() on the channel listener. the reason is the channel
listener only got poked when ActionDisplayArticle was set as the action on
the nntp url. but this wouldn't be the case when we got run from the Quoting backend. I added a new action, and made sure to set it when running the url from the quoting back end, and then made sure the nntp backend did the right thing.
r=alecf, a=chofmann
- define new nsModuleComponentInfo and use it instead of components_t
- use size_t instead of unsigned int
- add some docs
- allow user to define own module name
