This does not change user-visible behavior, though the MruCache may perform slightly better
than the previous hashtable implementation. Primarily this is preparation for using the same
cache in conjunction with the new ICU4X-based line segmenter.
Differential Revision: https://phabricator.services.mozilla.com/D225460
In 1908418 and 1915172 I attempted to make tab group sessionstore tests create new windows so that anything they did would be cleaned up. However, it looks like calling SessionStoreTestUtils.init on the newly created windows ended up having SessionStoreTestUtils holding onto a reference to the window. This patch creates and closes windows inside of each test.
Differential Revision: https://phabricator.services.mozilla.com/D225721
This patch updates the CSS styling for quick action results shown when the user
has entered searchmode. It modifies the selector to specifically target
the dynamicType "actions."
Previously, without this specificity, the CSS was unintentionally applied to
non-action results during quick actions search preview mode.
Differential Revision: https://phabricator.services.mozilla.com/D225313
This is an accumulation of all the changes to tests made by the patches
in this stack.
`color-invalid-relative-color.html.ini` tests that percentages are used
correctly inside `calc(..)` nodes. There are some edge cases we are not
passing. See: `https://bugzilla.mozilla.org/show_bug.cgi?id=1894263`
`relative-color-out-of-gamut.html.ini` does conversions from an out of
gamma color to the `rgb(..)` syntax. Relative colors should not use the
`rgb(..)` syntax any more, but the `color(srgb ..)` syntax instead. See:
`https://bugzilla.mozilla.org/show_bug.cgi?id=1921766`
`color-computed-relative-color.html.ini` has some errors where the
`none` keyword is not forwarded from the origin color to the final
color according to the spec. It also has the same out of gamma tests
that is in `relative-color-out-of-gamut.html.ini`. See:
`https://bugzilla.mozilla.org/show_bug.cgi?id=1899009` which is
dependent on clarification of the spec here:
`https://github.com/w3c/csswg-drafts/issues/10360`
`color-valid-relative-color.html.ini` contains serialization
discrepencies where the `calc(..)` keyword is used if the origin values
were specified with `calc(..)`, but according to the color spec, the
`calc(..)` is not needed for color components. These tests are dependent
on the outcome of:
`https://github.com/web-platform-tests/wpt/issues/47921`
Differential Revision: https://phabricator.services.mozilla.com/D224117
We now fully support the full ColorFunction in the ComputedStyle struct
in layout. This solves an issue where colors are copied on the C++
side.
Some structs had to be renamed to avoid name collisions in the generates
C++ code.
Some specified structs has the #[repr(C)] attribute now to include them
in the ComputedStyle struct. This is not really correct as they are
specified values and only computed values should be there. Splitting all
the unit structs into specified and computed is a lot of changes so
there is a follow up bug here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1924483
Differential Revision: https://phabricator.services.mozilla.com/D225080
When an alpha component is omitted, instead of defaulting to opaque,
colors with an origin color used the alpha from there.
Differential Revision: https://phabricator.services.mozilla.com/D223134
When we have a color that can't be resolved at parse time (or should not
be resolved) then we store the data that was parsed as is to preserve
all the data for round tripping.
Differential Revision: https://phabricator.services.mozilla.com/D220268
Color components can now preserve parsed data, including calc nodes, if
required.
Some of the computed color tests fail, because we don't have the origin
color readily available to determine which color format to use. (e.g.
color instead of rgb). Fixes are in a follow up patch: D220268
Differential Revision: https://phabricator.services.mozilla.com/D220124
We haven't seen significant fallout from bug 1901497, so this seems
worth trying, and avoids the weird "always enabled" JS APIs that we had
to add for zoom.
Differential Revision: https://phabricator.services.mozilla.com/D225784
- Simplifies the resize tracking logic so that it hooks the splitter, rather than the browser. This removes the need to debounce and solves the issue of reporting automatic resizes.
- Rounds resize event data to the nearest integer.
- Records hide events whenever current panel is switched.
Differential Revision: https://phabricator.services.mozilla.com/D225435
The UI test failed yesterday on API 34 because the save logins prompt wasn't displayed.
As seen before, this might be caused by the fact that the autofill actions are performed to qucikly.
To overcome this problem, I've added a 1s wait between the autofilling actions.
The UI test successfully passed 200x on Firebase. ✅
Differential Revision: https://phabricator.services.mozilla.com/D225774
Created a new UI test that verifies the "Set as default browser" dialog items based on a high priority manual test from TestRail.
The UI test successfully passed 100x on both API 30 and 34. ✅
Differential Revision: https://phabricator.services.mozilla.com/D225772
This allows vendors to write their own websockets handlers for
non-shared tests.
Note that the handlers still all share the same namespace, so vendor
handlers must have a globally unique name, not just unique in the
vendor directory.
Differential Revision: https://phabricator.services.mozilla.com/D222758
Up until this patch, the only way to show the content scripts was via `devtools.chrome.enabled` pref,
or via "Enable browser chrome and add-on debugging toolboxes" option.
This patch introduces a new settings menu, in the Debugger Source Tree component,
to help better control what is displayed in it.
We were already having a setting controlling the visibility of files hidden via Source Maps,
we can benefit from various settings to fine tune what is displayed in the debugger.
Users using about:config should migrate from `devtools.chrome.enabled` to `devtools.debugger.show-content-scripts`.
Differential Revision: https://phabricator.services.mozilla.com/D220949
This does not change user-visible behavior, though the MruCache may perform slightly better
than the previous hashtable implementation. Primarily this is preparation for using the same
cache in conjunction with the new ICU4X-based line segmenter.
Differential Revision: https://phabricator.services.mozilla.com/D225460
We're not resizing the window, so we shouldn't change mBounds.
These are all super-hacky btw, ideally we expose some code to
sessionrestore to do the right thing, then remove this.
But for now this would do.
Differential Revision: https://phabricator.services.mozilla.com/D225101
Allows to let them pass on Gecko too, given a Gecko-specific bug (see
the test). The text-to-HTML transformation, which is what the test is
supposed to test, is still tested.
Differential Revision: https://phabricator.services.mozilla.com/D219639
<Element.cpp> already contains around 5000 lines, it doesn't need more.
`GetTrustedTypeCompliantString` requires further extension which will be
implemented in a separate patch.
Differential Revision: https://phabricator.services.mozilla.com/D220239
Add a ToTArray version that works with LinkedList.
This is much like what we do for other containers, but without walking the list
twice.
Differential Revision: https://phabricator.services.mozilla.com/D225001
