nsIDialogParamBlock isn't a great API, and is best avoided.
MozReview-Commit-ID: 2B0HkKNJizo
--HG--
extra : rebase_source : a05e7a05ff0745f26d08616a74b532bc8a37c4fd
nsIDialogParamBlock isn't a great API, and is best avoided.
This patch also updates downloadcert.js to match modern PSM style, and adds a
test.
MozReview-Commit-ID: J2g2H0iBAn4
--HG--
extra : rebase_source : 9365f7b1c7a88caef84f0353e18510dcab9a5d32
Previously PSM would load EV information on-demand (i.e. just before verifying a
certificate). This simplifies this operation, removes a dubious optimization
(loading the EV information on another thread while opening a network
connection), and relocates the loading operation to when we are likely to have
good disk locality (i.e. when we've just loaded the built-in roots module).
This also removes the now-unused MOZ_NO_EV_CERTS build flag.
MozReview-Commit-ID: 8Rnl4ozF95V
--HG--
extra : rebase_source : 5b2e76079c256f7e3c55b1d4ec0d9f654fec44f6
The cert viewer currently supports two ways to pass a handle to the cert:
1. Passing the nickname of the cert via window.name.
2. Via an nsIDialogParamBlock, which is itself accessed through window.arguments.
Method 1 is unused and unnecessary.
Method 2 is overly complex: the relevant nsIX509Cert can just be passed directly.
This patch does the following:
1. Makes it so that there is only a single, straightforward way to pass a handle
to the cert.
2. Makes the cert viewer title localisable while we're nearby.
3. Renames viewCertDetails.js to better reflect the current use of the file.
MozReview-Commit-ID: pqtfNgvImT
--HG--
rename : security/manager/pki/resources/content/viewCertDetails.js => security/manager/pki/resources/content/certViewer.js
extra : rebase_source : 776a27111ab26cdcdc91b002890c43a3fe4f48e8
Also updates the relevant test (TestCertDB) to ensure that we actually are
loading builtin root certificates.
MozReview-Commit-ID: LXA4TqTzy8T
--HG--
extra : rebase_source : d217556e84a7e205e0f9e767b759d1b637d201a7
test_signed_dir.js was previously disabled for perma-failing after a year or so.
The reason was that the signature for sslcontrol.xpi (the test extension used in
the test) expired. Bug 1267318 fixed this expiry problem in general by simply
ignoring expired signatures.
This patch does the following:
1. Replaces sslcontrol.xpi with a newer extension.
Lightbeam is now used for this purpose, since it is still hosted on AMO, is
a Mozilla extension, and is MPL2 code.
2. Moves the test extension outside of test_signed_apps/.
The extension and the test itself have nothing to do with the rest of the files
in that directory.
3. Makes misc improvements to the test file.
MozReview-Commit-ID: 8uLDS5ypycO
--HG--
extra : rebase_source : 71eb9c560e5ced80e05e9672c27923e87e0bee3f
editcacert.xul/editcerts.js currently requires the |dbKey| attribute of an
nsIX509Cert to be passed to it via the window name so it can get a handle to the
nsIX509Cert.
This has two problems:
1. This used to trigger warnings, and is unwise to do in any case.
2. It's unnecessary complexity - the nsIX509Cert can be passed directly.
This patch:
1. Addresses the two problems.
2. Adds a test to ensure the functionality of editcerts.js actually works.
3. Rewrites editcerts.js to better fit modern PSM style.
4. Updates the name of editcerts.js so it's more consistent with the general
convention under security/pki/resources/content
MozReview-Commit-ID: ECxziXq5TmL
--HG--
rename : security/manager/pki/resources/content/editcerts.js => security/manager/pki/resources/content/editcacert.js
extra : rebase_source : ae140466dccf947cd28cbda102c1e5b3ea0eb9d4
head.js is run/included for every test file in the same folder, so having it
keep track of and clean up imported certs reduces the amount of duplication.
MozReview-Commit-ID: 23482qadMiy
--HG--
extra : rebase_source : e74ebc2d38b4abc58cc344742c98919e137e08ba
