Commit Graph

13436 Commits

Author SHA1 Message Date
Botond Ballo
a61744ca91 Bug 1564195 - Group the results of APZInputBridge::ReceiveInputEvent() into a struct. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D46376

--HG--
extra : moz-landing-system : lando
2019-09-19 02:45:21 +00:00
Jeff Muizelaar
27b7b84144 Bug 1573569. Add some debugging code. r=aosmond
This should help us figure what's going on.

Differential Revision: https://phabricator.services.mozilla.com/D46327

--HG--
extra : moz-landing-system : lando
2019-09-18 18:47:05 +00:00
Gerald Squelart
dc8ac83ba6 Bug 1578329 - Use profiler_can_accept_markers() where appropriate - r=gregtatum
In places where profiler_is_active() was used around a profiler_add_marker() (or
similar) call, replace it with profiler_can_accept_markers().

Differential Revision: https://phabricator.services.mozilla.com/D44435

--HG--
extra : moz-landing-system : lando
2019-09-18 01:22:12 +00:00
Gerald Squelart
fc93e3d9da Bug 1575448 - De/serialize ProfilerMarkerPayload derived objects - r=gregtatum
Payloads will serialize themselves into a `BlocksRingBuffer` entry when first
captured.
Later they will be deserialized, to stream JSON for the output profile.

Differential Revision: https://phabricator.services.mozilla.com/D43428

--HG--
extra : moz-landing-system : lando
2019-09-18 01:20:10 +00:00
Jeff Muizelaar
f29ce99be0 Bug 1581953. Don't invalidate everything when the visible rect changes.
Differential Revision: https://phabricator.services.mozilla.com/D46218

--HG--
extra : moz-landing-system : lando
2019-09-17 20:06:39 +00:00
Jeff Muizelaar
db1c09ed99 Bug 1580062. Fixup invalidation for resize. r=nical
This works by keeping track of the previous visible rect and
computing a preserved rect by intersecting with the new visible
rect.

We force the dirty rect to be inside this preserved area.

Differential Revision: https://phabricator.services.mozilla.com/D45284

--HG--
extra : moz-landing-system : lando
2019-09-17 19:59:29 +00:00
Jamie Nicol
35886dcefd Bug 1580153 - Call NotifyFirstPaint on next composite after RecvResumeAndResize. r=jrmuizel
Previously after RecvResumeAndResize() we would set a flag on the root
WebRenderBridgeParent, which in turn sets a flag on the next display list it
receives that it should be treated as a first paint. Then when that display list
is finally composited, we call UiCompositorControllerParent::NotifyFirstPaint(),
which in turn tells GeckoView to uncover the widget.

After switching tabs in GeckoView browsers, however, the root
WebRenderBridgeParent does not always receive a new display list, so the widget
would not be uncovered. Instead of waiting for the next received display list to
be composited, we simply want to uncover the widget on the next composite. To
achieve this we instead set the forced-first-paint flag on the root
CompositorBridgeParent then we call NotifyFirstPaint() during
CompositorBridgeParent::NotifyPipelineRendered().

Differential Revision: https://phabricator.services.mozilla.com/D46157

--HG--
extra : moz-landing-system : lando
2019-09-17 14:57:59 +00:00
Nicolas Silva
b80a2c908a Bug 1570081 - Put the blob dirty rect in the same space as the drawing commands and visible rect. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D43223

--HG--
extra : moz-landing-system : lando
2019-09-17 09:13:18 +00:00
Nicolas Silva
dfe0f0cf10 Bug 1570081 - Don't insert blob images with empty visible rects. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D43222

--HG--
extra : moz-landing-system : lando
2019-09-17 09:13:06 +00:00
Bogdan Tara
361c83c1a9 Backed out 21 changesets (bug 1578327, bug 1575448, bug 1580091, bug 1576554, bug 1581049, bug 1576551, bug 1578329, bug 1576555) for platform.cpp related bustage CLOSED TREE
Backed out changeset 27afea20c396 (bug 1581049)
Backed out changeset be1ec4577d37 (bug 1581049)
Backed out changeset b4b6bbb18cc1 (bug 1581049)
Backed out changeset b30942f9db54 (bug 1581049)
Backed out changeset 473c431866f7 (bug 1578329)
Backed out changeset ac492dc3df20 (bug 1578329)
Backed out changeset f51875652f6f (bug 1578327)
Backed out changeset 512b7cbd18f6 (bug 1576555)
Backed out changeset 2d63a9934c00 (bug 1576555)
Backed out changeset ff73f648ab6c (bug 1576555)
Backed out changeset 49f49079bbb5 (bug 1576555)
Backed out changeset e8323157c6f3 (bug 1575448)
Backed out changeset 3b0d726f2dd6 (bug 1575448)
Backed out changeset 5924790abc4b (bug 1576554)
Backed out changeset a14ac9bb5338 (bug 1576554)
Backed out changeset b6d73f5042a7 (bug 1576551)
Backed out changeset 366030bd2d84 (bug 1576551)
Backed out changeset d7ee4148aad9 (bug 1576551)
Backed out changeset ec72dfc7301e (bug 1576551)
Backed out changeset 79b29286f906 (bug 1580091)
Backed out changeset 6f34c2e57ccf (bug 1580091)
2019-09-17 10:16:14 +03:00
Gerald Squelart
6b49069f3e Bug 1578329 - Use profiler_can_accept_markers() where appropriate - r=gregtatum
In places where profiler_is_active() was used around a profiler_add_marker() (or
similar) call, replace it with profiler_can_accept_markers().

Differential Revision: https://phabricator.services.mozilla.com/D44435

--HG--
extra : moz-landing-system : lando
2019-09-17 01:53:56 +00:00
Gerald Squelart
5b86107991 Bug 1575448 - De/serialize ProfilerMarkerPayload derived objects - r=gregtatum
Payloads will serialize themselves into a `BlocksRingBuffer` entry when first
captured.
Later they will be deserialized, to stream JSON for the output profile.

Differential Revision: https://phabricator.services.mozilla.com/D43428

--HG--
extra : moz-landing-system : lando
2019-09-17 01:51:41 +00:00
sotaro
33aa5e8fda Bug 1581307 - Remove wr::WrExternalImageId r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D45937

--HG--
extra : moz-landing-system : lando
2019-09-16 22:13:16 +00:00
Botond Ballo
ad9e06d1e5 Bug 1578777 - Remove the builder parameter from nsDisplayFilters::CreateWebRenderCommands(). r=jrmuizel
It was unused.

Depends on D46057

Differential Revision: https://phabricator.services.mozilla.com/D46058

--HG--
extra : moz-landing-system : lando
2019-09-16 21:50:16 +00:00
Botond Ballo
48a06f502f Bug 1578777 - Remove non-ASCII character from comment in WebRenderCommandBuilder.cpp. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D46057

--HG--
extra : moz-landing-system : lando
2019-09-16 21:57:56 +00:00
Botond Ballo
2641cbd682 Bug 1577859 - Additional post container scrolling removal cleanup in APZ code. r=tnikkel
With container scrolling, layers that are fixed wrt. the RCD-RSF are no
longer descendants of layers with RCD-RSF metadata. This allows us to remove
some code that handles this case in AsyncCompositionManager.

In particular, when ApplyAsyncContentTransformToTree() calls
AlignFixedAndStickyLayers():

  - If we are currently processing a layer with RCD-RSF metadata,
    AlignFixedAndStickyLayers() will not do anything (because there will be
    no descendants fixed wrt. the RCD-RSF), so it doesn't matter what
    transform we pass to AlignFixedAndStickyLayers().

  - If we are processing a different layer, then Metrics().IsRootContent()
    will be false, so GetCurrentAsyncTransformForFixedAdjustment()
    simplifies to just GetCurrentAsyncTransform().

As a result, GetCurrentAsyncTransformForFixedAdjustment() (and its helper
GetCurrentAsyncViewportTransform()) can be removed, and its use replaced
with GetCurrentAsyncTransform().

Differential Revision: https://phabricator.services.mozilla.com/D45595

--HG--
extra : moz-landing-system : lando
2019-09-15 23:34:13 +00:00
Botond Ballo
f94ae56498 Bug 1577859 - Stop handling scrollbar layers that are descendants of the scrolled content. r=tnikkel
With containerless scrolling, scrollbar layers and their target scrolled layers
will be in sibling subtrees.

Depends on D45596

Differential Revision: https://phabricator.services.mozilla.com/D45918

--HG--
extra : moz-landing-system : lando
2019-09-15 21:50:10 +00:00
Hiroyuki Ikezoe
9ca5e64e7d Bug 1581113 - Explicitly set dom.animations-api.timelines.enabled in browser_test_group_fission.js. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D45942

--HG--
extra : moz-landing-system : lando
2019-09-15 18:32:08 +00:00
Botond Ballo
3a1c85bca4 Bug 1577859 - Remove the layout.scroll.root-frame-containers pref and code that depends directly on it. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D45198

--HG--
extra : moz-landing-system : lando
2019-09-15 17:01:22 +00:00
Andrew Osmond
ab39496ccc Bug 1574493 - Part 6. Add reftest annotations for newly failing/passing tests. r=jrmuizel,kvark
Differential Revision: https://phabricator.services.mozilla.com/D45539

--HG--
extra : moz-landing-system : lando
2019-09-14 16:16:59 +00:00
Andrew Osmond
fce484c34f Bug 1574493 - Part 3. Stop rounding rects/clips during display list building. r=jrmuizel
Rounding in layout pixels is very close to snapping in raster pixels if
there are no transforms involved. This is why it worked most of the time
and fell flat in many edge cases. In future parts of this series, we
will trust scene building and frame building to do the heavy lifting for
snapping purposes.

Differential Revision: https://phabricator.services.mozilla.com/D45058

--HG--
extra : moz-landing-system : lando
2019-09-14 16:17:04 +00:00
Botond Ballo
03b31cec00 Bug 1581233 - Add a helper function to reduce repetition at the call sites of HitTestingTreeNode::SetHitTestData(). r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D45916

--HG--
extra : moz-landing-system : lando
2019-09-14 09:01:22 +00:00
Hiroyuki Ikezoe
dbf5343dd1 Bug 1581113 - Set dom.animations-api.getAnimations.enabled pref. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D45897

--HG--
extra : moz-landing-system : lando
2019-09-13 21:46:49 +00:00
Ciure Andrei
a4046ec458 Backed out 6 changesets (bug 1574493) for causing nested-sticky-2.html to perma fail CLOSED TREE
Backed out changeset 358746636448 (bug 1574493)
Backed out changeset 34aef5498237 (bug 1574493)
Backed out changeset 1f88e2031c76 (bug 1574493)
Backed out changeset 07c588b5ea10 (bug 1574493)
Backed out changeset 0685e8d3510e (bug 1574493)
Backed out changeset 15d4390220c4 (bug 1574493)
2019-09-13 19:26:50 +03:00
Andrew Osmond
35a0f13ba2 Bug 1574493 - Part 6. Add reftest annotations for newly failing/passing tests. r=jrmuizel,kvark
Differential Revision: https://phabricator.services.mozilla.com/D45539

--HG--
extra : moz-landing-system : lando
2019-09-13 14:03:28 +00:00
Andrew Osmond
25866edb78 Bug 1574493 - Part 3. Stop rounding rects/clips during display list building. r=jrmuizel
Rounding in layout pixels is very close to snapping in raster pixels if
there are no transforms involved. This is why it worked most of the time
and fell flat in many edge cases. In future parts of this series, we
will trust scene building and frame building to do the heavy lifting for
snapping purposes.

Differential Revision: https://phabricator.services.mozilla.com/D45058

--HG--
extra : moz-landing-system : lando
2019-09-13 14:03:23 +00:00
Ciure Andrei
8c3feea58a Backed out 6 changesets (bug 1574493) for causing nested-sticky-1.html to perma fail CLOSED TREE
Backed out changeset fdc25a90b0ef (bug 1574493)
Backed out changeset 0ce3c48c1f79 (bug 1574493)
Backed out changeset 326b9f96614b (bug 1574493)
Backed out changeset b0817c0aee77 (bug 1574493)
Backed out changeset 70d99c264df9 (bug 1574493)
Backed out changeset e5217ab4b668 (bug 1574493)
2019-09-13 16:17:47 +03:00
Andrew Osmond
4d96fe56c4 Bug 1574493 - Part 6. Add reftest annotations for newly failing/passing tests. r=jrmuizel,kvark
Differential Revision: https://phabricator.services.mozilla.com/D45539

--HG--
extra : moz-landing-system : lando
2019-09-13 10:48:37 +00:00
Andrew Osmond
b2d4e121cb Bug 1574493 - Part 3. Stop rounding rects/clips during display list building. r=jrmuizel
Rounding in layout pixels is very close to snapping in raster pixels if
there are no transforms involved. This is why it worked most of the time
and fell flat in many edge cases. In future parts of this series, we
will trust scene building and frame building to do the heavy lifting for
snapping purposes.

Differential Revision: https://phabricator.services.mozilla.com/D45058

--HG--
extra : moz-landing-system : lando
2019-09-13 10:48:31 +00:00
Andreea Pavel
730793a2ef Backed out 5 changesets (bug 1570081) for assertion failure at WebRenderCommandBuilder.cpp on a CLOSED TREE
Backed out changeset 8d4baf4d063a (bug 1570081)
Backed out changeset 14a4451b2781 (bug 1570081)
Backed out changeset ba19640abf33 (bug 1570081)
Backed out changeset 214c815015a8 (bug 1570081)
Backed out changeset 548e4395ee1a (bug 1570081)
2019-09-13 11:24:59 +03:00
Nicolas Silva
04ec40580d Bug 1570081 - Put the blob dirty rect in the same space as the drawing commands and visible rect. r=jrmuizel
Depends on D43222

Differential Revision: https://phabricator.services.mozilla.com/D43223

--HG--
extra : moz-landing-system : lando
2019-09-12 15:59:58 +00:00
Nicolas Silva
563b86112a Bug 1570081 - Don't insert blob images with empty visible rects. r=jrmuizel
Depends on D41389

Differential Revision: https://phabricator.services.mozilla.com/D43222

--HG--
extra : moz-landing-system : lando
2019-09-12 15:53:41 +00:00
Boris Zbarsky
1128b8dee8 Bug 1578173 part 6. Remove remaining uses of [Constructor] from bindings. r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D45394

--HG--
extra : moz-landing-system : lando
2019-09-12 11:01:17 +00:00
Gurzau Raul
fe4bb6d539 Backed out 6 changesets (bug 1574493) for wrench failures at stacking-context-clip.yaml on a CLOSED TREE.
Backed out changeset 8a8736ac4e25 (bug 1574493)
Backed out changeset 4a3294e88823 (bug 1574493)
Backed out changeset 0c26ecdc1ddc (bug 1574493)
Backed out changeset 11257f7b3ad3 (bug 1574493)
Backed out changeset dcedc286ad9d (bug 1574493)
Backed out changeset 87f216e0753d (bug 1574493)
2019-09-12 18:34:07 +03:00
Andrew Osmond
ff567c5ddb Bug 1574493 - Part 6. Add reftest annotations for newly failing/passing tests. r=jrmuizel,kvark
Differential Revision: https://phabricator.services.mozilla.com/D45539

--HG--
extra : moz-landing-system : lando
2019-09-12 12:42:52 +00:00
Andrew Osmond
320cbbf828 Bug 1574493 - Part 3. Stop rounding rects/clips during display list building. r=jrmuizel
Rounding in layout pixels is very close to snapping in raster pixels if
there are no transforms involved. This is why it worked most of the time
and fell flat in many edge cases. In future parts of this series, we
will trust scene building and frame building to do the heavy lifting for
snapping purposes.

Differential Revision: https://phabricator.services.mozilla.com/D45058

--HG--
extra : moz-landing-system : lando
2019-09-12 12:42:41 +00:00
Hiroyuki Ikezoe
0eeb21e17f Bug 1541705 - Introduce nsLayoutUtils::FrameIsScrolledOutOfViewInCrossProcess and use it for the check whether animating element is scrolled out of view or not. r=botond,boris
Differential Revision: https://phabricator.services.mozilla.com/D44421

--HG--
extra : moz-landing-system : lando
2019-09-12 08:08:57 +00:00
Hiroyuki Ikezoe
f61192f0f0 Bug 1541705 - Notify areas of out-of-process subframes from the compositor to the corresponding process. r=botond
Note that the areas are clipped out by all ancestor scroll ports and
their coordinate systems are the screen coordinate.  So that we can tell
arbitrary elements in out-of-process iframes are scrolled out or not with
this area and the transform matrix of the iframe on screen coodinate.

Differential Revision: https://phabricator.services.mozilla.com/D44420

--HG--
extra : moz-landing-system : lando
2019-09-12 08:08:45 +00:00
Hiroyuki Ikezoe
5221523b46 Bug 1541705 - Introduce remote document rect. r=botond
The rect will be used for calculating the result of the composition of the
remote display item on the compositor.

Differential Revision: https://phabricator.services.mozilla.com/D44419

--HG--
extra : moz-landing-system : lando
2019-09-12 08:08:32 +00:00
Jeff Muizelaar
ecc722c789 Bug 1568227. Change to using the visual rect for the blob bounds. r=nical
This also makes sure that we invalidate for any visible rect bounds changes.
This makes more sense even if it's more conservative.

Differential Revision: https://phabricator.services.mozilla.com/D45325

--HG--
extra : moz-landing-system : lando
2019-09-10 17:48:43 +00:00
Jeff Muizelaar
3f94bd9625 Bug 1568227. Remove offset from visible rect. r=nical
This stops making the visible rect relative to the bounds of the image.

Differential Revision: https://phabricator.services.mozilla.com/D45324

--HG--
extra : moz-landing-system : lando
2019-09-10 17:48:41 +00:00
Jeff Muizelaar
4e2ce23730 Bug 1568227. Use the visible rect as the display items bounds for fallback items. r=nical
Differential Revision: https://phabricator.services.mozilla.com/D45323

--HG--
extra : moz-landing-system : lando
2019-09-10 17:48:39 +00:00
Jeff Muizelaar
5ce9334259 Bug 1568227. Render blobs at visibleRect.x,y instead of 0,0. r=nical
Differential Revision: https://phabricator.services.mozilla.com/D45322

--HG--
extra : moz-landing-system : lando
2019-09-10 17:48:37 +00:00
Razvan Maries
913fce80bb Backed out 2 changesets (bug 1568227) for perma fails on paint-order-001.tentative.html. CLOSED TREE
Backed out changeset fef155ac9c60 (bug 1568227)
Backed out changeset bb324781c1e3 (bug 1568227)
2019-09-10 20:38:46 +03:00
Ryan Hunt
56dcc94078 Bug 1578075 - Increase stack size of paint thread/workers on OSX Catalina or higher to workaround crash from recursion in CoreText. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D45370

--HG--
extra : moz-landing-system : lando
2019-09-10 15:20:34 +00:00
Jeff Muizelaar
c61d2bd386 Bug 1568227. Use the visible rect as the display items bounds for fallback items. r=nical
Differential Revision: https://phabricator.services.mozilla.com/D45323

--HG--
extra : moz-landing-system : lando
2019-09-10 15:14:37 +00:00
Jeff Muizelaar
b74d61d223 Bug 1568227. Render blobs at visibleRect.x,y instead of 0,0. r=nical
Differential Revision: https://phabricator.services.mozilla.com/D45322

--HG--
extra : moz-landing-system : lando
2019-09-10 15:12:05 +00:00
Coroiu Cristina
5928204cd2 Bug 1575874 - Fix ESlint failure a=me on a CLOSED TREE
--HG--
extra : amend_source : 99ee40f9c4bab8f3cdc9f4dc7517dc6be77e32ac
2019-09-10 14:14:20 +03:00
Bob Owen
f5e4873899 Bug 1575874: Create the CanvasTranslator on the Compositor thread to prevent race with WaitForSurfaceDescriptor. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D43774

--HG--
extra : moz-landing-system : lando
2019-09-10 02:06:28 +00:00
Bob Owen
4a393ad08e Bug 1575828: Ensure that CanvasChild::GetDataSurface is called on the main thread. r=jrmuizel
This also makes sure the SourceSurfaceCanvasRecording clean-up is done on the
main thread where required.

Differential Revision: https://phabricator.services.mozilla.com/D43077

--HG--
extra : moz-landing-system : lando
2019-09-10 02:06:46 +00:00