Commit Graph

860948 Commits

Author SHA1 Message Date
hsingh
a68c2ad072 Bug 1835298: Encrypt CacheAPI data on disk in PBM.r=dom-storage-reviewers,janv
Depends on D180296

Differential Revision: https://phabricator.services.mozilla.com/D180297
2023-10-27 14:10:08 +00:00
hsingh
0890b51845 Bug 1835300: Allow CacheAPI in PBM if pref is toggled. r=dom-storage-reviewers,asuth
Depends on D180295

Differential Revision: https://phabricator.services.mozilla.com/D180296
2023-10-27 14:10:07 +00:00
Luca Greco
8735c02c0b Bug 1859035 - Prevent AOM tests to hit intermittent failures in a11y jobs due to Harness.popupReady clicking to panel buttons while panel state is still "showing". r=ayeddi,robwu
While investigating more the a11y intermittent failure being hit using exploratory try pushes (because the failure couldn't be hit locally), we determined
that when a failure was being hit, the panel state was still "showing" (instead of "open") by the time the AccessibilityUtils were about to check
if the clicked element (a panel button) was focusable.

After looking into a couple other approaches to make Harness.popupReady to wait for the panel to get to the "open" state (which were not working and ended up
triggering other issues, like test timeouts), I tried the approach proposed in this patch (after reading some more of the related internals and noticed that
we emit a popup-shown topic from nsXULPopupShownEvent::Run right after having set the panel state to "open" a few lines before, see
https://searchfox.org/mozilla-central/rev/ffdc4971dc18e1141cb2a90c2b0b776365650270/layout/xul/nsMenuPopupFrame.cpp#404,411).

The push to try using that approach did pass successfully (as in "it didn't hit the a11y related failures it was hitting before"):

    https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=d9fd889aae3d54cf721be22c4d67459e0f946034

And the temporary debugging logs added in that try push confirmed that we were hitting the panel in the "showing" state at least a few times:

    https://treeherder.mozilla.org/logviewer?job_id=433768474&repo=try&lineNumber=64039
    https://treeherder.mozilla.org/logviewer?job_id=433777958&repo=try&lineNumber=58787
    https://treeherder.mozilla.org/logviewer?job_id=433777956&repo=try&lineNumber=61263
    https://treeherder.mozilla.org/logviewer?job_id=433777874&repo=try&lineNumber=59122

Differential Revision: https://phabricator.services.mozilla.com/D191898
2023-10-27 13:52:13 +00:00
Victor Boivie
b94d8ddf90 Bug 1464914: Relax sending ordered until OPEN_ACK r=bwc,jesup
RFC8832: "However, before the DATA_CHANNEL_ACK message or any other message
has been received on a data channel, all other messages ... MUST be sent
ordered, ... After the DATA_CHANNEL_ACK or any other message has been received
on the data channel, messages containing user data MUST be sent ordered on
ordered data channels and MUST be sent unordered on unordered data channels."

Before this commit, it always expected DATA_CHANNEL_ACK, but as some clients
don't send it (spec violation, but that's how it is), it would then always send
ordered even on unordered channels.

What is mentioned above from the RFC shouldn't apply to pre-negotiated data
channels, as those don't explicitly send DATA_CHANNEL_OPEN/ACK. This commit
also ensures that those send unordered on unordered channels from the start.

Differential Revision: https://phabricator.services.mozilla.com/D191300
2023-10-27 13:50:09 +00:00
sunil mayya
af8ceaf22c Bug 1851992 - ensure all of the OnProgress updates are sent before triggering OnDataFinished in HttpChannelChild. r=necko-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D192056
2023-10-27 13:30:13 +00:00
sunil mayya
ec558bbf4d Bug 1851992 - move assignment of mTransferSize,mEncodedBodySize from HttpChannelChild::OnStopRequest to HttpChannelChild::OnStopRequest::ProcessOnStopRequest. r=necko-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D191291
2023-10-27 13:30:13 +00:00
sunil mayya
7dca7f348a Bug 1851992 - implement empty nsIThreadRetargetableStreamListener::OnDataFinished for stream loader. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D191097
2023-10-27 13:30:12 +00:00
sunil mayya
9a6ec90e93 Bug 1851992 - send onDataFinished notifications from nsInputStreamPump. r=necko-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D188757
2023-10-27 13:30:12 +00:00
sunil mayya
8ce40ef93d Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl
Differential Revision: https://phabricator.services.mozilla.com/D187833
2023-10-27 13:30:11 +00:00
edgul
827cd75825 Bug 1851992 - moving html5 stream parser's OnStopRequest off main thread. r=necko-reviewers,edgul,jesup,valentin,hsivonen
Depends on D187668

Differential Revision: https://phabricator.services.mozilla.com/D187689
2023-10-27 13:30:11 +00:00
sunil mayya
6b70b22566 Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to send OMT data stop notification to thread retargetable stream listeners. r=necko-reviewers,jesup,valentin
Differential Revision: https://phabricator.services.mozilla.com/D187668
2023-10-27 13:30:10 +00:00
Alexandra Borovova
4d9ac61cb6 Bug 1861635 - Fix TestRoot object is not subscriptable error in ./mach wpt-serve, r=jgraham
Differential Revision: https://phabricator.services.mozilla.com/D192060
2023-10-27 13:26:21 +00:00
David Shin
650fcdd340 Bug 1861668: Annotate has-complexity timeout on asan/tsan builds. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D191982
2023-10-27 13:21:03 +00:00
Jan-Niklas Jaeschke
1b5cec1cfe Bug 1860377: Allow selections of different kind to overlap visually. r=emilio
Since features such as Custom Highlight API or `::target-text` are implemented
as a selection, multiple selections can be present on a section of text.

This patch paints all selections ordered by their priority instead of only painting the top-priority one,
so that colors will be combined if selections are not opaque.

Differential Revision: https://phabricator.services.mozilla.com/D191557
2023-10-27 13:12:42 +00:00
Nicolas Silva
480948101a Bug 1856371 - Reimplement Pipeline::getBindGroupLayout. r=webgpu-reviewers,ErichDonGubler
The new implementation is simpler: It just forwards messages to wgpu on the parent process using the usual mechanism. It also better aligns with the spec because it works whether or not the pipeline has an implicit layout (current implementation is only implemented for implicit layouts). And finally it fixes a bug in the current implementation causing undefined behavior due to zero IDs being cast into NonZero rust types at the ffi boundary.

Differential Revision: https://phabricator.services.mozilla.com/D189942
2023-10-27 13:06:18 +00:00
Nicolas Silva
e7766e3c9e Bug 1856306 - Crash when an object is created with an invalid ID. r=webgpu-reviewers,ErichDonGubler
Differential Revision: https://phabricator.services.mozilla.com/D189941
2023-10-27 13:06:18 +00:00
Ziran Sun
54f7be0077 Bug 1858912 - Refine popover focusing steps to follow the specs. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D190917
2023-10-27 13:02:17 +00:00
Mark Banner
833fc90714 Bug 1860988 - Enable all ESLint rules on the rest of dom/**/*.xhtml files that were renamed from xul. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D191850
2023-10-27 12:43:04 +00:00
Mark Banner
21e52b9399 Bug 1860988 - Enable ESLint rule object-shorthand on remaining parts of dom/*. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D191849
2023-10-27 12:43:04 +00:00
Mark Banner
6119729476 Bug 1860988 - Enable ESLint rule no-useless-return on all of dom/*. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D191848
2023-10-27 12:43:03 +00:00
Dan Minor
73de873f4c Bug 1858496 - Crash on OOM in ICU; r=jandem,platform-i18n-reviewers,gregtatum
This has been on Nightly for several cycles without serious problems, I think
it makes sense to let it ride the trains, and continue to keep an eye on
crash reports.

Differential Revision: https://phabricator.services.mozilla.com/D191892
2023-10-27 12:29:43 +00:00
Kagami Sascha Rosylight
178e49d103 Bug 1860848 - Turn echo-large-bidirectional-streams into any.js r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D191766
2023-10-27 12:27:22 +00:00
Kagami Sascha Rosylight
2966d6ea84 Bug 1860516 - Part 2: Use QMResult for Notification::ConstructFromFields r=asuth
... which also fix the error check being too late. (SetStoredState should happen after the check)

Differential Revision: https://phabricator.services.mozilla.com/D191748
2023-10-27 12:26:06 +00:00
Kagami Sascha Rosylight
d6c4385f16 Bug 1860516 - Part 1: Remove unused headers from Notification.cpp/h r=asuth
... at least the ones that clangd complains about.

Differential Revision: https://phabricator.services.mozilla.com/D191747
2023-10-27 12:26:06 +00:00
Florian Quèze
e0b6c75e62 Bug 1861560 - ignore errors when SystemResourceMonitor receives partial incorrect data, r=releng-reviewers,jcristau.
Differential Revision: https://phabricator.services.mozilla.com/D192057
2023-10-27 12:23:01 +00:00
Robert Longson
42f3b82240 Bug 669865 - Calling clear() on list types should set mIsBaseSet to false so that we ignore the transform r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D192063
2023-10-27 11:52:05 +00:00
Julian Descottes
02e26c5d93 Bug 1861637 - [devtools] Remove options for waitForNetworkEvents in browser_net_image_cache.js r=bomsy,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D192062
2023-10-27 11:47:35 +00:00
Gijs Kruitbosch
0e79b6a654 Bug 1845727 - move mozSupportLink.ftl into toolkit as that's where the component lives, r=reusable-components-reviewers,fluent-reviewers,tgiles,flod
Differential Revision: https://phabricator.services.mozilla.com/D191945
2023-10-27 10:18:23 +00:00
Henrik Skupin
b519b75aa9 Bug 1861000 - [wdspec] Improve WebDriver BiDi tests when serializing nodes within an Array, Map, or Set. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D191939
2023-10-27 10:03:49 +00:00
Henrik Skupin
84b1092524 Bug 1861000 - [webdriver-bidi] Always pass extraOptions when serializing a remote value. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D191938
2023-10-27 10:03:49 +00:00
Paul Adenot
1cc58bbb5e Bug 1860423 - Reapply patches on top of libcubeb. r=cubeb-reviewers,kinetik
Differential Revision: https://phabricator.services.mozilla.com/D191726
2023-10-27 09:53:02 +00:00
Paul Adenot
6e86a4942e Bug 1860423 - Update libcubeb to revision 5f0d1737. r=cubeb-reviewers,kinetik
Differential Revision: https://phabricator.services.mozilla.com/D191725
2023-10-27 09:53:01 +00:00
Tiaan Louw
eae164606d Bug 1860513 - Clamp alpha NAN values to 0.0. r=emilio,layout-reviewers
Depends on: D191626

Differential Revision: https://phabricator.services.mozilla.com/D191629
2023-10-27 09:37:11 +00:00
Alexandre Lissy
c6286f0f8f Bug 1666084 - Build MPRIS name with DBus unique name r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D191858
2023-10-27 09:29:31 +00:00
Natalia Csoregi
b1b9460910 Backed out changeset d4349b4d125e (bug 1858854) for causing Bug 1861621. CLOSED TREE 2023-10-27 11:54:09 +03:00
Emilio Cobos Álvarez
07b0055ecc Bug 1861027 - Handle editor readonly mask update based on element state instead of attributes. r=masayuki
An element can be disabled even if it doesn't have the disabled
attribute.

Differential Revision: https://phabricator.services.mozilla.com/D191947
2023-10-27 08:31:29 +00:00
Emilio Cobos Álvarez
4dcca913a5 Bug 1861027 - Make nsTextControlFrame -> TextControlElement casts less verbose. r=masayuki
No behavior change.

Differential Revision: https://phabricator.services.mozilla.com/D191946
2023-10-27 08:31:29 +00:00
Emilio Cobos Álvarez
7696b5a35e Bug 1784931 - Allow 4 restyles in progress pseudo test. r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D191954
2023-10-27 08:23:05 +00:00
Karl Tomlinson
241af1cdbc Bug 1860954 add a conversion operator from MediaTrackGraphImpl to Lookup for HashSet.lookup(*graph) r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D191920
2023-10-27 07:52:45 +00:00
Alexandra Borovova
6431e9277a Bug 1859258 - [bidi] Replace "ViewportOptions" with "BoxOptions" for "browsingContext.captureScreenshot" command. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D191843
2023-10-27 07:51:53 +00:00
Karl Tomlinson
726438b26a Bug 1860954 replace AsyncCubebTask with NS_NewRunnableFunction() r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D191919
2023-10-27 07:44:54 +00:00
Emilio Cobos Álvarez
c91ee34d5b Bug 1861253 - Draw select's menulist arrow in the select's color. r=dholbert
In the regressing bug 1849793 I removed a hunk like this because we
don't use any of the parent state on the parent properly:

```
  if (aAppearance == StyleAppearance::MozMenulistArrowButton) {
    // HTML select and XUL menulist dropdown buttons get state from the
    // parent.
    nsIFrame* parentFrame = aFrame->GetParent();
    aFrame = parentFrame;
    elementState = GetContentState(parentFrame, aAppearance);
  }
```

However that aFrame = parentFrame also changed the frame we read the
color for the fill. This is not an issue for menus because those don't
override the colors, but for the select menulist button we need to
explicitly inherit.

Differential Revision: https://phabricator.services.mozilla.com/D192002
2023-10-27 07:34:43 +00:00
Mozilla Releng Treescript
a441ab3705 no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD CLOSED TREE
kk -> 22e2095b7029f5dd4285024b79c9b35e5021417f
si -> 27f9ebaf52cf6dfc965d2890e2a6126f9cbbddea
sq -> 892f3294d694403446f5e204676d7b15aa216eb4
sv-SE -> ecf73b3d7024f3b0a76cd6b5822903677c8d55c1
2023-10-27 07:00:55 +00:00
Nicolas Chevobbe
9021eb95d0 Bug 1861389 - [devtools] Prevent source-list-footer to shrink. r=bomsy,devtools-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D191969
2023-10-27 06:00:41 +00:00
Karl Tomlinson
7212c381e8 Bug 1860954 remove AsyncCubebTask::mShutdownGrip r=padenot
This was added in
https://hg.mozilla.org/mozilla-central/rev/dcd375e2750d425af210fee36962219a97a334fd#l2.58
but no longer necessary as the driver keeps the graph alive since
https://hg.mozilla.org/mozilla-central/rev/5a0ddea9ad624286eb863e8419e144d5cbae4d58#l2.17

Depends on D191917

Differential Revision: https://phabricator.services.mozilla.com/D191918
2023-10-27 05:52:41 +00:00
Karl Tomlinson
1f14e11c93 Bug 1860954 remove mIterationEnd and mStateComputedTime from FallbackWrapper r=pehrsons
Depends on D191837

Differential Revision: https://phabricator.services.mozilla.com/D191917
2023-10-27 05:52:41 +00:00
Karl Tomlinson
bcc6c0bd6a Bug 1860954 name GraphDriver audio streams with document title r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D191837
2023-10-27 05:52:41 +00:00
Vinny Diehl
e4bd447bd9 Bug 1858854 - Validate input to setTimeZone r=arai
Differential Revision: https://phabricator.services.mozilla.com/D191935
2023-10-27 05:48:57 +00:00
Nicolas Chevobbe
98522e12ba Bug 1857722 - [devtools] Handle Proxy objects in custom formatter. r=devtools-reviewers,ochameau.
We were catching Proxy object in the ObjectActor before
we're calling the custom formatter machinery, so we weren't
calling the custom formatter hooks with Proxy objects.
A test is added to ensure these are handled now.
I had to switch the test to use findMessageVirtualizedByType
as the new logged message might be outside of the viewport.

Differential Revision: https://phabricator.services.mozilla.com/D191936
2023-10-27 05:46:28 +00:00
Mike Hommey
94aaf5f3de Bug 1861510 - Force cargo to run when Cargo.lock changes. r=firefox-build-system-reviewers,ahochheiden
There are a number of occasions where changes to rust code doesn't
trigger cargo to run on an incremental build. In most cases, these
changes are accompanied with a change in Cargo.lock, so let's make cargo
run every time Cargo.lock changes.

Differential Revision: https://phabricator.services.mozilla.com/D192018
2023-10-27 05:23:32 +00:00