Commit Graph

5481 Commits

Author SHA1 Message Date
Toby Ward
a69d8ab823 Bug 1496082: Enable ESLint for docshell/test/navigation and docshell/test/unit (manual fixes) r=bzbarsky
Implemented the manual linting fixes for docshell/test/navigation, docshell/test/unit and docshell/test/unit_ipc
Depends on D9430

Differential Revision: https://phabricator.services.mozilla.com/D10080

--HG--
extra : moz-landing-system : lando
2018-11-06 17:03:39 +00:00
Toby Ward
4083f33603 Bug 1496082: Enable ESLint for docshell/test/navigation and docshell/test/unit (automatic fixes only). r=bzbarsky
Enabled ESLint for:

* docshell/test/navigation/**
* docshell/test/unit/**
* docshell/test/unit_ipc/**

Changed .eslintignore to allow for this and ran ./mach eslint --fix on the above directories and checked automatic fixes

Differential Revision: https://phabricator.services.mozilla.com/D9430

--HG--
extra : moz-landing-system : lando
2018-11-06 17:05:39 +00:00
Bogdan Tara
98c46b95b5 Backed out 2 changesets (bug 1496082) for test_bug270414.html failures CLOSED TREE
Backed out changeset 74780d0a4848 (bug 1496082)
Backed out changeset 4f87e383a807 (bug 1496082)
2018-11-06 17:58:24 +02:00
Toby Ward
dec5a37fbe Bug 1496082: Enable ESLint for docshell/test/navigation and docshell/test/unit (manual fixes) r=bzbarsky
Implemented the manual linting fixes for docshell/test/navigation, docshell/test/unit and docshell/test/unit_ipc
Depends on D9430

Differential Revision: https://phabricator.services.mozilla.com/D10080

--HG--
extra : moz-landing-system : lando
2018-11-06 14:54:38 +00:00
Toby Ward
415ae552bb Bug 1496082: Enable ESLint for docshell/test/navigation and docshell/test/unit (automatic fixes only). r=bzbarsky
Enabled ESLint for:

* docshell/test/navigation/**
* docshell/test/unit/**
* docshell/test/unit_ipc/**

Changed .eslintignore to allow for this and ran ./mach eslint --fix on the above directories and checked automatic fixes

Differential Revision: https://phabricator.services.mozilla.com/D9430

--HG--
extra : moz-landing-system : lando
2018-11-06 14:48:43 +00:00
Margareta Eliza Balazs
8471089552 Backed out changeset c5cf88fb02d1 (bug 1498526) for causing multiple failures e.g. browser/extensions/formautofill/test/mochitest/test_address_level_1_submission.html CLOSED TREE 2018-11-06 14:49:52 +02:00
Jonathan Kingston
63ff18762d Bug 1498526 - add in user pref to prevent loading implied triggeringPrincipal loads for dev and nightly builds. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D8546

--HG--
extra : moz-landing-system : lando
2018-11-06 11:51:51 +00:00
Andreas Farre
89cb220346 Bug 1480198 - Construct nsDocShell objects inside BrowsingContext. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D7400

--HG--
extra : moz-landing-system : lando
2018-11-05 12:43:10 +00:00
Jonathan Kingston
ca7afcc659 Bug 1490257 - Add in asserts for missing triggeringPrincipal. r=ckerschb
Depends on D10884

Differential Revision: https://phabricator.services.mozilla.com/D10885

--HG--
extra : moz-landing-system : lando
2018-11-05 14:03:28 +00:00
Jonathan Kingston
4248b4c554 Bug 1490257 - Pass triggeringPrincipal to test code. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D10882

--HG--
extra : moz-landing-system : lando
2018-11-05 14:05:47 +00:00
Margareta Eliza Balazs
df311518fe Backed out 3 changesets (bug 1417976) for bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/GeckoProfiler.h CLOSED TREE
Backed out changeset 908f30faf4b6 (bug 1417976)
Backed out changeset 44ae0b8569b2 (bug 1417976)
Backed out changeset 801cdde1f597 (bug 1417976)
2018-11-02 18:42:21 +02:00
Nazım Can Altınova
8432e48060 Bug 1417976 - Part 2: Include DocShell IDs to marker payloads r=mstange
MozReview-Commit-ID: AML1ESUnFlu

Depends on D4914

Differential Revision: https://phabricator.services.mozilla.com/D4915

--HG--
extra : moz-landing-system : lando
2018-11-02 16:17:54 +00:00
Nazım Can Altınova
95f5ae9b3a Bug 1417976 - Part 1: Store the information of DocShells in CorePS r=bzbarsky,mstange
Added a mechanism to register and unregister the DocShells from the CorePS depending
on the state of the profiler. Registering mechanism is straightforward. During
unregistration, if profiler is not active, we remove the DocShell information
immediately. If profiler is active, we don't remove and we keep the profiler buffer
position at that moment. During another DocShell registration we Discard the
unregistered DocShells. If the profiler buffer position is greater than the position
when we captured during unregistration, we delete the DocShell since that means there
can't be any markers associated to this DocShell anymore.

MozReview-Commit-ID: IVuKQ6drvkR

Differential Revision: https://phabricator.services.mozilla.com/D4914

--HG--
extra : moz-landing-system : lando
2018-11-02 16:17:23 +00:00
Daniel Varga
e86b1d05f8 Merge mozilla-inbound to mozilla-central. a=merge
--HG--
rename : mobile/android/chrome/geckoview/GeckoViewNavigationContent.js => mobile/android/chrome/geckoview/GeckoViewNavigationChild.js
2018-11-02 00:27:53 +02:00
Daniel Varga
77036132f7 Merge autoland to mozilla-central. a=merge 2018-11-02 00:26:12 +02:00
James Willcox
1e1cda1530 Bug 1500541 - Disable about:config in GeckoView on Release and Beta r=ehsan
Differential Revision: https://phabricator.services.mozilla.com/D10410
2018-11-01 09:52:36 -05:00
Julian Descottes
079a123093 Bug 1467712 - Simplify calls to ok to use only 2 arguments;r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D10416

--HG--
extra : moz-landing-system : lando
2018-11-01 13:48:48 +00:00
Csoregi Natalia
faba2c8c15 Backed out 4 changesets (bug 1467712) for multiple failures with: Too many arguments passed to ok. CLOSED TREE
Backed out changeset 9ce0ac2b9d71 (bug 1467712)
Backed out changeset 026eb1f6dc6e (bug 1467712)
Backed out changeset 0088a09d869a (bug 1467712)
Backed out changeset 1b19ea76aad6 (bug 1467712)
2018-11-01 15:22:52 +02:00
Julian Descottes
b50a5ba4dc Bug 1467712 - Simplify calls to ok to use only 2 arguments;r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D10416

--HG--
extra : moz-landing-system : lando
2018-11-01 11:09:48 +00:00
Gurzau Raul
424b125b93 Backed out changeset 523ff2753dea (bug 1490257) for causing Bug 1503757 a=backout 2018-11-01 15:27:30 +02:00
Ehsan Akhgari
7895387cd7 Bug 1503465 - Part 2: Add a docshell API for retrieving the top-level content blocking log r=baku
Depends on D10362

Differential Revision: https://phabricator.services.mozilla.com/D10363

--HG--
extra : moz-landing-system : lando
2018-10-31 21:21:36 +00:00
Gabriele Svelto
266ef73c96 Bug 1503207 - Remove nsWeakPtr.h and cleanup all files including weak reference-related headers r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D10251

--HG--
extra : moz-landing-system : lando
2018-10-31 20:39:03 +00:00
Jonathan Kingston
873b26107e Bug 1490257 - Add asserts into loadURI where we imply SystemPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D10221

--HG--
extra : moz-landing-system : lando
2018-10-31 18:00:40 +00:00
Ehsan Akhgari
5fef8e924c Bug 1501978 - Part 1: Stop honouring the browser.contentblocking.enabled pref in Gecko r=baku
Differential Revision: https://phabricator.services.mozilla.com/D10074

--HG--
extra : moz-landing-system : lando
2018-10-30 14:30:15 +00:00
Andreas Farre
719ab63a7d Bug 1500869 - Test that BrowsingContexts work with BFCache. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D9367

--HG--
extra : moz-landing-system : lando
2018-10-30 09:58:47 +00:00
Gurzau Raul
42ed3a7d97 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-10-30 07:32:36 +02:00
Kyle Machulis
6d3b4e7492 Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState; r=bz, nika
Creates the nsDocShellLoadState object, which is basically
nsDocShellLoadInfo plus a few extra fields to make it usable as a
single argument to nsDocShell::LoadURI (and eventually
nsDocShell::InternalLoad).

Subframe history handling is a huge logic block in
nsDocShell::LoadURI, which is only used on history loads. This patch
also extracts the logic out into its own function to make the body of
LoadURI clearer.
2018-10-29 17:13:29 -07:00
Gurzau Raul
08a80deaa6 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-10-30 00:04:59 +02:00
Kyle Machulis
ee8ccacb05 Backed out changeset fa8487b94a38 due to a=BUSTAGE on comm-central 2018-10-29 12:28:02 -07:00
Ehsan Akhgari
7191917660 Bug 1500543 - Only inform windows that their parent is changing when being removed from their parent r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D10085

--HG--
extra : moz-landing-system : lando
2018-10-29 19:15:32 +00:00
Kyle Machulis
ca0550b32b Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState r=bzbarsky,nika
Creates the nsDocShellLoadState object, which is basically
nsDocShellLoadInfo plus a few extra fields to make it usable as a
single argument to nsDocShell::LoadURI (and eventually
nsDocShell::InternalLoad).

Subframe history handling is a huge logic block in
nsDocShell::LoadURI, which is only used on history loads. This patch
also extracts the logic out into its own function to make the body of
LoadURI clearer.

Differential Revision: https://phabricator.services.mozilla.com/D6944

--HG--
rename : docshell/base/nsDocShellLoadInfo.cpp => docshell/base/nsDocShellLoadState.cpp
rename : docshell/base/nsDocShellLoadInfo.h => docshell/base/nsDocShellLoadState.h
extra : moz-landing-system : lando
2018-10-26 03:50:37 +00:00
Nicholas Hurley
2319ff8d81 Bug 1050329 - part 2 - Add error page for h2 goaway. r=dragana,bzbarsky
This is kind of like the previous patch (where we had a not-very-friendly user experience shutting down misbehaving h2 sessions), but in this case the server has proven to us that it can speak a minimum of h2, so we don't want to just fallback. Instead, when we send a GOAWAY frame because we have detected some error on the part of the server, if it's a top-level page load, we'll show an error page explaining that the server spoke bad http/2, and the site admin(s) need to be contacted. We already did this for INADEQUATE_SECURITY (which is its own special case still), but that didn't cover all the cases.

Differential Revision: https://phabricator.services.mozilla.com/D8436

--HG--
extra : moz-landing-system : lando
2018-10-25 20:46:46 +00:00
Julian Descottes
73e3a16c0d Bug 1499096 - Use ok() with 2 arguments instead of 3 when possible;r=Standard8
Depends on D8740.
This changeset replaces calls to ok with 3 arguments to calls with 2 arguments
in situations where the switch does not have a significant impact on the assert.

Differential Revision: https://phabricator.services.mozilla.com/D8741

--HG--
extra : moz-landing-system : lando
2018-10-23 07:13:35 +00:00
Julian Descottes
2fcd6cb020 Bug 1499096 - Update tests using ok() to is();r=Standard8
This changeset updates all the test that were wrongly using ok() and wanted to
use is() AND for which the assert is still passing without any modification
required.

Differential Revision: https://phabricator.services.mozilla.com/D8739

--HG--
extra : moz-landing-system : lando
2018-10-23 07:12:23 +00:00
Andreas Farre
8a334bc798 Bug 1498222 - Add BrowsingContext.docShell webidl. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D8381

--HG--
extra : moz-landing-system : lando
2018-10-18 06:52:30 +00:00
Narcis Beleuzu
5d00f78a13 Backed out changeset 8dd09fad1f35 (bug 1492648) for bc failures on browser_auto_close_window.js
--HG--
rename : docshell/base/nsDocShellLoadState.cpp => docshell/base/nsDocShellLoadInfo.cpp
rename : docshell/base/nsDocShellLoadState.h => docshell/base/nsDocShellLoadInfo.h
2018-10-19 10:11:33 +03:00
Kyle Machulis
0bb3246aa5 Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState r=bzbarsky,nika
Creates the nsDocShellLoadState object, which is basically
nsDocShellLoadInfo plus a few extra fields to make it usable as a
single argument to nsDocShell::LoadURI (and eventually
nsDocShell::InternalLoad).

Subframe history handling is a huge logic block in
nsDocShell::LoadURI, which is only used on history loads. This patch
also extracts the logic out into its own function to make the body of
LoadURI clearer.

Differential Revision: https://phabricator.services.mozilla.com/D6944

--HG--
rename : docshell/base/nsDocShellLoadInfo.cpp => docshell/base/nsDocShellLoadState.cpp
rename : docshell/base/nsDocShellLoadInfo.h => docshell/base/nsDocShellLoadState.h
extra : moz-landing-system : lando
2018-10-18 22:14:54 +00:00
Johann Hofmann
a63c05f4b8 Bug 1484255 - Add Telemetry Events for the certificate error pages. r=nhnt11,keeler
Differential Revision: https://phabricator.services.mozilla.com/D8281

--HG--
extra : moz-landing-system : lando
2018-10-17 13:10:26 +00:00
Ciure Andrei
673efa0461 Backed out changeset 1119f9458b5d (bug 1484255) for browser_aboutCertError_telemetry.js failures CLOSED TREE 2018-10-16 03:33:42 +03:00
Johann Hofmann
9f4cd70201 Bug 1484255 - Add Telemetry Events for the certificate error pages. r=nhnt11,keeler
Differential Revision: https://phabricator.services.mozilla.com/D8281

--HG--
extra : moz-landing-system : lando
2018-10-15 23:00:08 +00:00
Ehsan Akhgari
0324774e90 Bug 1498720 - Ensure that we revoke a subframe's storage access when it is removed from the DOM r=baku
Differential Revision: https://phabricator.services.mozilla.com/D8615

--HG--
extra : moz-landing-system : lando
2018-10-15 10:37:11 +00:00
Dorel Luca
451e26f0c6 Backed out changeset 8d7987ea4fb1 (bug 1490257) for causing android failures. CLOSED TREE 2018-10-15 14:39:00 +03:00
Jonathan Kingston
8bcd10a7ab Bug 1490257 - Add asserts and remove implied system triggering principal code r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D8368

--HG--
extra : moz-landing-system : lando
2018-10-15 06:29:45 +00:00
Mats Palmgren
faeddacfac Bug 1494745 part 5 - Don't check the result from ns[Auto]TObserverArray insertions since they're infallible. r=bz 2018-10-14 18:12:23 +02:00
Sylvestre Ledru
dd5741407b Bug 1498586 - Add clang-format off to avoid the reformatting of the data structures r=Ehsan
Too hard/impossible for the tool to format correctly these structs

Differential Revision: https://phabricator.services.mozilla.com/D8569

--HG--
extra : moz-landing-system : lando
2018-10-12 20:48:24 +00:00
Gijs Kruitbosch
e61cc054ca Bug 1493634 - make docshell responsible for outer window IDs, r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D7702

--HG--
extra : moz-landing-system : lando
2018-10-10 10:20:36 +00:00
Boris Zbarsky
24dfa1120c Bug 1497598. Stop using GetCurrentJSContext in loadcontext code. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D8122

--HG--
extra : moz-landing-system : lando
2018-10-09 18:28:17 +00:00
aceman
7da0d504e1 Bug 1496524 - add CSP to docshell/resorces/content/netError.xhtml. r=ckerschb
--HG--
rename : docshell/resources/content/netError.xhtml => docshell/resources/content/netError.js
2018-10-05 14:56:00 +03:00
Brad Werth
6ceb1e8b1e Bug 1290420 Part 4: Make the PresShell create a MobileViewportManager on demand. r=botond,smaug
Depends on D3376

Differential Revision: https://phabricator.services.mozilla.com/D3377

--HG--
extra : moz-landing-system : lando
2018-10-04 03:28:40 +00:00
Botond Ballo ext:(%2C%20Brad%20Werth%20%3Cbwerth%40mozilla.com%3E)
46f528a48a Bug 1290420 Part 1: Add a docshell flag for overriding meta viewport handling. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D3373

--HG--
extra : moz-landing-system : lando
2018-10-04 00:19:40 +00:00