Commit Graph

133 Commits

Author SHA1 Message Date
Cameron McCormack
7498850f28 Bug 1453877 - Remove unused RestyleHintData struct. r=xidorn
And fix a comment mentioning nsCSSSelectorList that I came across.

MozReview-Commit-ID: 1BOcDqV5dUr

--HG--
extra : rebase_source : 5fbdae6da74cf4fac145fbdd721723e81839e4b3
2018-04-13 15:16:13 +10:00
Jonathan Watt
82ebebe276 Bug 1448714 - Fix up comments referring to 'style context' after the rename of nsStyleContext. r=emilio 2018-03-23 13:49:21 +00:00
Emilio Cobos Álvarez
e341b20ec4 Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez
5dd797f154 Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.

MozReview-Commit-ID: 5skESBseEvo
2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez
ca5ac79cca Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt
MozReview-Commit-ID: JPopq0LudD
2018-03-22 19:48:42 +01:00
Hiroyuki Ikezoe
40907715ce Bug 1237454 - Add VisibilityChange change hint. r=emilio
This new change hint doesn't influence layout so that it can be regarded
as nsChangeHint_Hints_CanIgnoreIfNotVisible.  Note that if visibility changed
from collapse or to collapse, we set NS_STYLE_HINT_REFLOW separetely.

MozReview-Commit-ID: AirDWeBYVKG

--HG--
extra : rebase_source : a462845ac2d8280986bb8db5e6482bf401f65322
2018-02-09 10:43:10 +09:00
Narcis Beleuzu
b0e8772dcd Backed out 6 changesets (bug 1237454) for bc failures on /browser_toolbariconcolor_restyles.js. CLOSED TREE
Backed out changeset f8d771835fd2 (bug 1237454)
Backed out changeset 2dbbfc331bdf (bug 1237454)
Backed out changeset c481f409feaa (bug 1237454)
Backed out changeset 0b9872865f0e (bug 1237454)
Backed out changeset 43ca55e7c93b (bug 1237454)
Backed out changeset 027b0c65d944 (bug 1237454)
2018-02-06 11:19:56 +02:00
Hiroyuki Ikezoe
0de04971ef Bug 1237454 - Add VisibilityChange change hint. r=emilio
This new change hint doesn't influence layout so that it can be regarded
as nsChangeHint_Hints_CanIgnoreIfNotVisible.  Note that if visibility changed
from collapse or to collapse, we set NS_STYLE_HINT_REFLOW separetely.

MozReview-Commit-ID: AirDWeBYVKG

--HG--
extra : rebase_source : 1cd03a78a522b1a6965ba73ebf002ddacb0ab4f2
2018-02-06 08:43:52 +09:00
Hiroyuki Ikezoe
dba3425d42 Bug 1190721 - Throttle animations that produce any transform change hint if the target element is out-of-view. r=birtles
And unthrottle them on every 200ms just like we do for transform animations on
the compositor.  To unthrottle the transform animations properly, we need to
update UpdateLastTransformSyncTime each time we compose the style for the
animations instead of updating it when we send the transform animation to the
compositor.  That's because display item for transform is built even while we
are throttling the transform animations for some reasons, so if we updated the
last transform sync time there, the time will not match what it should be.

MozReview-Commit-ID: GwMzJqUlzd2

--HG--
extra : rebase_source : 09e379191970687a9f35aead871acf450c63813e
2017-10-31 09:45:41 +09:00
Daniel Holbert
680815cd6e Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py

For every file that is modified in this patch, the changes are as follows:
 (1) The patch changes the file to use the exact C++ mode lines from the
     Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line

 (2) The patch deletes any blank lines between the mode line & the MPL
     boilerplate comment.

 (3) If the file previously had the mode lines and MPL boilerplate in a
     single contiguous C++ comment, then the patch splits them into
     separate C++ comments, to match the boilerplate in the coding style.

MozReview-Commit-ID: EuRsDue63tK

--HG--
extra : rebase_source : 3356d4b80ff6213935192e87cdbc9103fec6084c
2017-10-27 10:33:53 -07:00
Jonathan Watt
341ea5e4f1 Bug 1401356, part 2 - Rename nsSVGEffects to SVGObserverUtils. r=longsonr 2017-08-30 15:58:31 +01:00
Neerja Pancholi
b12bf0cae2 Bug 1389029 - Create custom change hint and post restyle event for rowspan, colspan attribute changes. r=dbaron
MozReview-Commit-ID: IwUlgDa3DAj

--HG--
extra : rebase_source : e99732f1173eba16f2cf42453c6418d72591ce7e
2017-09-05 13:30:40 -07:00
Brad Werth
dce3ff515e Bug 1359834 Part 2: Define a new nsChangeHint_ReflowHintsForFloatAreaChange hint and use it for float changes. r=dholbert
MozReview-Commit-ID: 692GBiRUTab

--HG--
extra : rebase_source : 4b3413bb0468037ab5eb25101b7c2a54cdc63d9e
2017-07-14 17:20:35 -07:00
Sylvestre Ledru
4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Markus Stange
ccaf464b9e Bug 1370034 - Add -moz-window-opacity property, style system parts (excluding stylo). r=dbaron
MozReview-Commit-ID: J2SPMzh0I9C

--HG--
extra : rebase_source : b8c5f267f99fb7bab560af82a386cd3f3a9af5f3
2017-06-18 21:04:40 -04:00
Cameron McCormack
1849ea4995 Backout bug 1291457 and bug 1370034 for bustage. 2017-06-19 13:55:15 +08:00
Markus Stange
9ec017c7c6 Bug 1370034 - Add -moz-window-opacity property, style system parts (excluding stylo). r=dbaron
MozReview-Commit-ID: J2SPMzh0I9C

--HG--
extra : rebase_source : b8c5f267f99fb7bab560af82a386cd3f3a9af5f3
2017-06-18 21:04:40 -04:00
Daniel Holbert
69eda9c026 Bug 1367568 part 2: Rewrite nsChangeHint_ReflowHintsForBSizeChange in terms of nsChangeHint_AllReflowHints. r=bz
This patch doesn't affect behavior at all.  It's simply adjusting the way we
express a bitmask, without modifying the actual value of that bitmask.  The
intent of this change is to make this bitmask's definition as similar as
possible to the definition for its ISize (inline-axis) analog, so that it's
easy to compare the two.

MozReview-Commit-ID: FUJnBQm8hmJ

--HG--
extra : rebase_source : 400972b9af447721183769b603eedb9a9fd4c939
2017-05-25 17:53:23 -04:00
Daniel Holbert
a84ae4bec1 Bug 1367568 part 1: Create reusable macros that represent our change hints for tweaks to CSS width or height (ISize/BSize). r=bz
This patch doesn't affect behavior at all; it's simply moving code (and
moving/extending some associated code comments).

MozReview-Commit-ID: JiX53R9e9GW

--HG--
extra : rebase_source : 96fca2c0ca59cc5bbfc48cf81abe5515bb62f372
2017-05-25 17:46:03 -04:00
Daniel Holbert
ad52211150 Bug 1344398 part 2: React to some CSS 'overflow' changes on body/html by simply calling UpdateViewportScrollbarStylesOverride() instead of reframing. r=bz,tnikkel
MozReview-Commit-ID: Lpr9aNv9hAB

--HG--
extra : rebase_source : c8cccf8e6495ab1d57f9680c07b3e43a488e8691
2017-05-10 13:53:27 -07:00
Wes Kocher
8f6058b583 Backed out 3 changesets (bug 1344398) for assertion failures at Element.cpp a=backout
Backed out changeset d0e5a5ba01b5 (bug 1344398)
Backed out changeset d70f9de401d1 (bug 1344398)
Backed out changeset 647d0bb3714d (bug 1344398)

MozReview-Commit-ID: DTVWf28NcNb
2017-05-10 17:43:50 -07:00
Daniel Holbert
b216b7b0e8 Bug 1344398 part 2: React to some CSS 'overflow' changes on body/html by simply calling UpdateViewportScrollbarStylesOverride() instead of reframing. r=bz,tnikkel
MozReview-Commit-ID: Lpr9aNv9hAB

--HG--
extra : rebase_source : c8cccf8e6495ab1d57f9680c07b3e43a488e8691
2017-05-10 13:53:27 -07:00
Xidorn Quan
2fdfbf90b0 Bug 1360467 - Change nsChangeHint and nsRestyleHint to use a fixed integer type. r=heycam
MozReview-Commit-ID: I2lZW01ylhr

--HG--
extra : rebase_source : 0d621ffe31ef447ef4b8226dccbfa6bdf521f888
2017-04-28 15:47:23 +08:00
Boris Chiou
892d75ecb7 Bug 1349834 - Remove eRestyle_SVGAttrAnimations declartion. r=xidorn
MozReview-Commit-ID: KhB4G7v3hn9

--HG--
extra : rebase_source : 3dcefbb99901c0e0c2d7f391f5a591ca409924fa
2017-03-24 10:59:54 +08:00
Mantaroh Yoshinaga
90f3d3d4d0 Bug 1062106 part 2 - Remove unused SVG Attribute Animations cascade level. r=birtles,dbaron,xidorn
The previous patch in this series converted all uses of mapped attributes
for animation to be animated as CSS properties (that is, to be treated
as presentation hints in the cascade).

As result, we no longer need the SVG Animation presentation hints level
of the cascade, the corresponding rule processor(SVGAttrAnimationRuleProcessor),
or the corresponding eRestyle_SVGAttrAnimations restyle hint. So this patch
removes these unused rule processor and restyle hint.

MozReview-Commit-ID: Hm8IDaqc3ym

--HG--
extra : rebase_source : 339ad209f37ea84857577001c7385323f2187d46
2017-03-21 15:43:26 +09:00
Cameron McCormack
767a077d73 Bug 1301258 - Part 2: Remove all subsumed hints when generating changes from restyles. r=dbaron
This changes ElementRestyler::CaptureChange so that it avoids generating the
current frame's entire set of change hints, if only some of the hints were
handled by ancestors, and instead to remove the hints that we know are
subsumed.

MozReview-Commit-ID: JvhxeQC6MmQ
2017-03-21 16:33:05 +08:00
Cameron McCormack
2a3ed57d71 Bug 1301258 - Part 1.5: Tweak some comments around change hints. r=dbaron
MozReview-Commit-ID: Gze6SFaXvSA
2017-03-21 16:33:05 +08:00
Cameron McCormack
d2bf6adc7c Bug 1301258 - Part 1: Define macros for change hints always, never and sometimes handled for descendants. r=dbaron
MozReview-Commit-ID: 1lOl7U6rlC5
2017-03-21 16:33:05 +08:00
Bobby Holley
eaee1dbb37 Bug 1340022 - Implement "handled for descendants" tracking for RestyleDamage. r=emilio
MozReview-Commit-ID: Bbk99ogILXC

--HG--
extra : rebase_source : 2998f39a67c39073ea66e3e12815e1a7a25f7c9d
2017-02-15 19:36:57 -08:00
Bobby Holley
f8c9d884fc Bug 1317016 - Basic infrastructure for RestyleHint-driven traversal. r=emilio
MozReview-Commit-ID: 7wH5XcILVmX
2016-11-25 10:06:39 -08:00
L. David Baron
13bc05d1b6 Bug 1301500 - Separate change hint for adding/removing transform from UpdateContainingBlock. r=heycam
MozReview-Commit-ID: FwEQDA327EI

--HG--
extra : transplant_source : a0cf%B4b%0FXxq%A2ZP%A5G%D1%E7H%E1%C0
2016-09-29 14:15:32 -07:00
L. David Baron
611f172de6 Bug 1251075 - Optimize away nsChangeHint_UpdateContainingBlock in nsStyleContext::CalcStyleDifference when possible. r=bz
MozReview-Commit-ID: 4Owobm1vZLn
2016-08-29 11:43:29 -07:00
Xidorn Quan
ff0f0fef3b Bug 1295111 part 2 - Add static_assert to ensure that is updated properly. r=dbaron
MozReview-Commit-ID: G2RNUcXs4yQ

--HG--
extra : rebase_source : 0ecbe3e09a8783c7149959c3580116d9e3ecd449
2016-08-15 20:52:05 +10:00
Jeremy Chen
3f03fe838d Bug 1287308 - part2: remove old NS_STYLE_HINT_NONE constant. r=dbaron
Remove NS_STYLE_HINT_NONE definition in nsChangeHint.
Fix related debug log in RestyleManager.

MozReview-Commit-ID: 4pA8u8MQDnv

--HG--
extra : rebase_source : 66bbfa54eb35f1de2318787a610b6e401262b28a
2016-07-17 22:20:22 +08:00
Jeremy Chen
9d8ddf9b2d Bug 1287308 - part1: replace uses of NS_STYLE_HINT_NONE with nsChangeHint(0). r=dbaron
MozReview-Commit-ID: CN66AimiuEu

--HG--
extra : rebase_source : 6caaa30e9afa8645ea31c4918230ba2ec53bc74a
2016-07-17 22:20:21 +08:00
Chris Peterson
43c2748f66 Bug 1277775 - Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj 2016-07-08 14:39:53 -07:00
Jeremy Chen
a02cef6a08 Bug 906116 - part4: Remove NS_STYLE_HINT_FRAMECHANGE. r=dbaron
MozReview-Commit-ID: IXPWY2B6k48

--HG--
extra : rebase_source : 0156bbbc463a6e532cfdc0e007b470cb595c52d1
2016-07-06 13:06:14 +08:00
Jeremy Chen
0094cd236f Bug 906116 - part2: Fix comment for nsChangeHint_ReconstructFrame. r=dbaron
The comment for nsChangeHint_ReconstructFrame is out-of-date.

In RestyleManager::ProcessRestyledFrames, we actually ignore all of the other
hints if ReconstructFrame is set. The old version was written when
ReconstructFrame was listed last. So, update the comment.

MozReview-Commit-ID: 97wMrW6S6ID

--HG--
extra : rebase_source : d76815f8cadd7ddc6babc65e24d197717269625f
2016-07-06 13:06:13 +08:00
Carsten "Tomcat" Book
de3628dc26 Backed out changeset d84c0edb6912 (bug 906116) 2016-07-06 05:40:08 +02:00
Carsten "Tomcat" Book
c9dc6a368d Backed out changeset 1ec6e0357c42 (bug 906116) 2016-07-06 05:40:05 +02:00
Jeremy Chen
b915e25c11 Bug 906116 - part4: Remove NS_STYLE_HINT_FRAMECHANGE. r=dbaron
MozReview-Commit-ID: IXPWY2B6k48

--HG--
extra : rebase_source : 63c31419f19c6fdfaebab4947cb881fe9ed7a820
2016-07-06 09:59:56 +08:00
Jeremy Chen
010cb33d92 Bug 906116 - part2: Fix comment for nsChangeHint_ReconstructFrame. r=dbaron
The comment for nsChangeHint_ReconstructFrame is out-of-date.

In RestyleManager::ProcessRestyledFrames, we actually ignore all of the other
hints if ReconstructFrame is set. The old version was written when
ReconstructFrame was listed last. So, update the comment.

MozReview-Commit-ID: 97wMrW6S6ID

--HG--
extra : rebase_source : f1556012073e088af96c2e389532f1ae04b165af
2016-07-06 09:59:55 +08:00
Hiroyuki Ikezoe
eec4931934 Bug 1166500 - Part 3: Add KeyframeEffectReadOnly::CanIgnoreIfNotVisible(). r=dbaron 2016-05-24 12:57:42 +09:00
Jeremy Chen
685cf4c3d8 Bug 1273766 - part3: purge NS_UpdateHint inline. r=heycam
MozReview-Commit-ID: IIOT9jq8hOl

--HG--
extra : rebase_source : dfb3d874ce4419f32f13e662bd495e97ac9cac10
2016-05-23 11:26:03 +08:00
Jeremy Chen
0f24420a8f Bug 1273766 - part2: purge NS_SubtractHint inline. r=heycam
MozReview-Commit-ID: 1UX1wZJNnat

--HG--
extra : rebase_source : e74d1cf5ca0866897634339a0fe6df65e0d249ae
2016-05-23 11:26:03 +08:00
Jeremy Chen
1a607ceb9d Bug 1273766 - part1: purge NS_CombineHint inline. r=heycam
MozReview-Commit-ID: CWlyjREgoEk

--HG--
extra : rebase_source : 452a425fe4c722d7d5e15118ecb0e59c54908f37
2016-05-23 11:26:03 +08:00
Markus Stange
0aa0fa1e2b Bug 1227327 - Invalidate table parts and MathML frames when background-position changes on them. r=dbaron
Theoretically we should do the same for nsTreeBodyFrame, but that frame type is
harder to detect and I'm not sure it's worth adding code to support updating
background-position on XUL trees.

MozReview-Commit-ID: 8HPT53MX6bO

--HG--
extra : rebase_source : 1e84e83616832debe8f6da394630a5a2e014e7df
2016-04-28 13:01:22 -04:00
Phil Ringnalda
f74761a568 Back out 6 changesets (bug 1227327) for Android reftest failures in 942672-1.html, background-position-2b.html and background-position-2c.html
CLOSED TREE

Backed out changeset c9b0ba301426 (bug 1227327)
Backed out changeset c857ad1fa01c (bug 1227327)
Backed out changeset 4ba58cd94310 (bug 1227327)
Backed out changeset 30e394faeb23 (bug 1227327)
Backed out changeset ce7fd04cc749 (bug 1227327)
Backed out changeset e0fe45294034 (bug 1227327)
2016-05-03 21:49:07 -07:00
Markus Stange
ea8e203822 Bug 1227327 - Invalidate table parts and MathML frames when background-position changes on them. r=dbaron
Theoretically we should do the same for nsTreeBodyFrame, but that frame type is
harder to detect and I'm not sure it's worth adding code to support updating
background-position on XUL trees.

MozReview-Commit-ID: 8HPT53MX6bO

--HG--
extra : rebase_source : 1e84e83616832debe8f6da394630a5a2e014e7df
2016-04-28 13:01:22 -04:00
Phil Ringnalda
5387bf0160 Back out 6 changesets (bug 1227327) for failures in est_fixed_bg_scrolling_repaints.html
Backed out changeset 529ff32ced48 (bug 1227327)
Backed out changeset b726c30c4290 (bug 1227327)
Backed out changeset 5453b1ce4e85 (bug 1227327)
Backed out changeset 462dc0904d05 (bug 1227327)
Backed out changeset 1515512d3731 (bug 1227327)
Backed out changeset 2276fc059bf7 (bug 1227327)
2016-05-02 22:23:10 -07:00