Commit Graph

7941 Commits

Author SHA1 Message Date
shindli
a8e8126805 Backed out changeset 439db957d3e2 (bug 1525760) for linux64 toolchains bustages in toolkit/library/gtest/target CLOSED TREE 2019-02-09 07:19:32 +02:00
Mike Hommey
011c259380 Bug 1525760 - Add a clang-based base toolchains task. r=froydnj
These are copies of the corresponding gcc-based base toolchain tasks,
with FORCE_GCC and the gcc dependency removed.

We also tweak things a little for those builds to actually end up green.

Differential Revision: https://phabricator.services.mozilla.com/D18903

--HG--
extra : moz-landing-system : lando
2019-02-08 14:40:22 +00:00
Mike Hommey
39bdbdd823 Bug 1525999 - Default to arm instead of armv7a for android builds. r=nalexander
That makes target.toolchain match what the NDK provides.

Differential Revision: https://phabricator.services.mozilla.com/D19116

--HG--
extra : moz-landing-system : lando
2019-02-08 22:37:25 +00:00
arthur.iakab
27c92bb1ae Backed out changeset 51697f8232c5 (bug 1525999) for causing multiple Android failures on build/target.raptor.tests.tar.gz CLOSED TREES 2019-02-08 19:48:55 +02:00
Mike Hommey
f36d444aa0 Bug 1525999 - Default to arm instead of armv7a for android builds. r=nalexander
That makes target.toolchain match what the NDK provides.

Differential Revision: https://phabricator.services.mozilla.com/D19116

--HG--
extra : moz-landing-system : lando
2019-02-08 16:45:55 +00:00
Mike Hommey
c5bfd96206 Bug 1524467 - Fix and refactor basic_bindgen_cflags. r=froydnj
basic_bindgen_cflags's function is to set some flags for use with
rust-bindgen through clang/libclang for C++ code. Part of the flags it
sets are for the C++ standard, and the target.

Unfortunately, some of the logic wrt target-specific flags is currently
broken. It wants to apply per-compiler flags on Windows, but fails to do
so. First, because the condition test is wrong, and second, because it
only cares about msvc and not clang-cl.

OTOH, we already have those flags when the compiler is clang or
clang-cl. And we already have code to get the right flags for a given
compiler. So when the compiler is not clang or clang-cl, we can use that
to get the right flags for the clang we're going to use for bindgen.

Depends on D18316

Differential Revision: https://phabricator.services.mozilla.com/D18317

--HG--
extra : moz-landing-system : lando
2019-02-05 00:27:33 +00:00
Mike Hommey
33a69b7eea Bug 1524467 - Use -m32/-m64 in more cases. r=froydnj
In upcoming changes, we're going to use the normal compiler flags for
bindgen instead of having a separate logic for essentially the same
flags (and there's not much reason not to use the same flags after all).

One hiccup, though is that for some reason, --target=i686-linux-gnu
doesn't work with bindgen while it works with clang in the same setup.
But -m32 does.

Considering -m32 and -m64 are standard flags and that we're using them
in many cases, it doesn't hurt to use them instead of --target with
clang.

While we're doing that, we might as well refactor a little to avoid the
multiple branches handling the use of -m32/-m64, and fix the theoretical
compile-x86_64-with-x86-clang-cl case, as well as the weird check for
aarch64.

And because only two cases actually require -Xclang, only one of which
requires a condition, and the control flow is not too complex to avoid
flag duplication, we just remove the append_flag function; it was too
confusing, with all the cases we skipped it when -Xclang was not wanted.

Differential Revision: https://phabricator.services.mozilla.com/D18316

--HG--
extra : moz-landing-system : lando
2019-02-04 17:22:58 +00:00
Andrew Halberstadt
01ca807367 Bug 1515746 - [flake8] Unsupport subdir .flake8 files and use new 'per-file-ignores' config instead, r=egao
This removes all .flake8 files except for the one at the root of the repo.
Instead we use the new 'per-file-ignores' config introduced in 3.7. To ignore
specific errors in a subdirectory, add a line like this to the root .flake8:

[per-file-ignores]
    path/to/subdir/*: E100, F200, ...

The reasons for this change are:

1. Unblock flake8 blacklist (bug 1367092).
2. Simplify configuration and code.
3. Encourage more consistent styling.
4. Improve performance.
5. Greater editor consistency.

Differential Revision: https://phabricator.services.mozilla.com/D18354

--HG--
extra : moz-landing-system : lando
2019-02-07 20:17:02 +00:00
Mike Hommey
247022a791 Bug 1525510 - Add a trampoline to call original_init when it's not possible directly. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D18807

--HG--
extra : moz-landing-system : lando
2019-02-07 16:23:49 +00:00
Mike Hommey
2cce1ce974 Bug 1525196 - Apply https://reviews.llvm.org/D57636 to clang r=dmajor
Differential Revision: https://phabricator.services.mozilla.com/D18886

--HG--
extra : moz-landing-system : lando
2019-02-07 13:58:43 +00:00
Razvan Maries
e5944cdd0e Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-02-07 23:49:13 +02:00
Tom Ritter
b06907665c Bug 1525588 - Do not enable CFG on ARM builds, as it causes undiagnosed failures. r=dmajor
--HG--
extra : rebase_source : c305609f0d5a08958e9901b2b02867ea7fa200c7
2019-02-06 11:42:24 -06:00
Johann Hofmann
731692a30b Bug 1522565 - Tests for cryptominers and fingerprinters sub-panels. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D18827

--HG--
extra : rebase_source : f1e874a43c204f807259cc5249d4e872e25fba26
2019-02-06 14:12:20 +01:00
Mike Hommey
bdaa5d90e4 Bug 1522609 - Pass compilers and flags down to cargo on sanitizer/fuzzying/ccov builds. r=ted
Depends on D18280

Differential Revision: https://phabricator.services.mozilla.com/D18281

--HG--
extra : moz-landing-system : lando
2019-02-06 03:05:52 +00:00
Cosmin Sabou
8bd3dcb455 Merge mozilla-inbound to mozilla-central. a=merge 2019-02-05 23:58:20 +02:00
Razvan Maries
f86459d5dc Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-02-05 18:59:13 +02:00
Razvan Maries
3ad4eb8f48 Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2019-02-05 12:27:07 +02:00
Wes Kocher
c03a82f8b5 Bug 1525191 - Regenerate certs CLOSED TREE a=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18632

--HG--
extra : amend_source : 028e3e34ede69bc05f9f8ea147bee02a4e9e2de5
2019-02-04 17:09:59 -08:00
David Major
a01a1ced08 Bug 1525113: Disable two crashy Binscope checks. r=froydnj 2019-02-04 16:00:57 -05:00
Sylvestre Ledru
e887b2193c Bug 1515356 - Do not fail the build in case of warning with -Wdeprecated-copy r=froydnj
New warning with gcc 9

Differential Revision: https://phabricator.services.mozilla.com/D18318

--HG--
extra : moz-landing-system : lando
2019-02-04 14:32:13 +00:00
Makoto Kato
b93b9a8c45 Bug 1515004 - Move --with-android-sdk to moz.configure. r=nalexander
Since ./mach bootstrap installs Android SDK into ~/.mozbuild, we should detect
this location as default SDK install path.

Also, --with-android-max-sdk and --with-android-min-sdk are still in android.m4
because confvars.sh sets MOZ_ANDROID_MIN_SDK_VERSION.

Differential Revision: https://phabricator.services.mozilla.com/D15463

--HG--
extra : moz-landing-system : lando
2019-02-01 21:12:51 +00:00
Razvan Maries
2428b56054 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-02-05 12:24:54 +02:00
Andrew Halberstadt
83e75a8676 Bug 1483228 - [mozboot] Add ability to get a srcdir specific state dir r=nalexander
Sometimes we want to store state that only applies to a particular srcdir, but
there isn't a standard directory where this lives. Let's add an argument to
'get_state_dir()' to provide an "official" place.

The new API to get the local state dir is 'get_state_dir(srcdir=True)'. Like
the global state dir, this directory is not guaranteed to exist. A reference to
this value can also be obtained via 'self._mach_context.local_state_dir' from
within a mach command (in this case it will be created automatically if it
doesn't exist).

Note: we should probably just make sure both exist at mach startup, but it felt
outside the scope of this change.

Differential Revision: https://phabricator.services.mozilla.com/D15724

--HG--
extra : moz-landing-system : lando
2019-02-04 21:07:25 +00:00
Andrew Halberstadt
8bc7850637 Bug 1483228 - [mozboot] Simplify get_state_dir()'s return value r=nalexander
mozboot.util.get_state_dir() returns a tuple of (<path>, <bool). The bool
denotes whether or not the state dir came from an environment variable.

But this value is only used in a single place, and is very easy to test for
anyway. It's not worth the added complexity it imposes on all other consumers
of this function. Let's just make this function return the path.

Differential Revision: https://phabricator.services.mozilla.com/D15723

--HG--
extra : moz-landing-system : lando
2019-02-04 20:52:31 +00:00
Ted Mielczarek
dacb17a7c0 bug 1506848 - remove some no-longer-necessary bits from mozconfig.cache. r=nalexander,glandium
Differential Revision: https://phabricator.services.mozilla.com/D18265

--HG--
extra : moz-landing-system : lando
2019-02-01 11:22:16 +00:00
Ted Mielczarek
8a4288a193 bug 1506848 - switch Windows debug flags from -Zi to -Z7. r=nalexander
We default to -Zi for Windows debug flags, which is for generating debug info
into a PDB file, but clang-cl doesn't actually implement that so -Zi is
an alias for -Z7 in clang-cl:
http://clang.llvm.org/docs/UsersManual.html#id9

sccache has special handling for -Zi because multiple compiles writing
to the same PDB file is not cacheable, so we've always overridden -Zi with -Z7
in CI when using sccache.

Given that everyone should be using clang-cl nowadays and MSVC will no longer
be supported soon, this patch changes the default and removes some PDB
file name flag setting from rules.mk, as well as the no-longer-necessary
overrides from mozconfig.cache.

Differential Revision: https://phabricator.services.mozilla.com/D18264

--HG--
extra : moz-landing-system : lando
2019-02-01 11:12:06 +00:00
Mike Hommey
6c620a55e7 Bug 1523341 - Allow to only pass the CPU to --target and get the right thing for Fennec builds. r=nalexander
Also use armv7a as the default when no target is given at all.

Also change bootstrap to create a simpler mozconfig. The downside is
that the resulting mozconfig would not work when building older
revisions.

Add unit tests for this as well as the simplications added in bug
1523341.

Differential Revision: https://phabricator.services.mozilla.com/D17906

--HG--
extra : moz-landing-system : lando
2019-01-31 18:08:44 +00:00
Mike Hommey
0936da9a4a Bug 1523851 - Make ac_cv_prog_*_works act as a cache. r=froydnj
Depends on D18057

Differential Revision: https://phabricator.services.mozilla.com/D18058

--HG--
extra : moz-landing-system : lando
2019-01-31 02:11:50 +00:00
Mike Hommey
21c3b16892 Bug 1523851 - Remove AC_PROG_GCC_TRADITIONAL test. r=froydnj
While not related, it turns out this test was opted in by ourselves,
while it's practically useless. Recent autoconf documentation says it's
obsolescent, and even autoconf 2.13 documentation said with "recent
versions of the GNU C compiler", the issue it's detecting "is becoming
a less prevalent problem". Recent as of 20 years ago.

Differential Revision: https://phabricator.services.mozilla.com/D18054

--HG--
extra : moz-landing-system : lando
2019-01-30 14:39:01 +00:00
Mike Hommey
80ff55b932 Bug 1524059 - Fix Windows artifact builds on try after bugs 1523145 and 1523201. r=chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D18152

--HG--
extra : moz-landing-system : lando
2019-01-30 23:53:26 +00:00
Mike Hommey
bf0e86a9dc Bug 1523540 - Remove WIN64_LIB and WIN64_LINK. r=ted
Now that everything is lined up nicely, we don't need those anymore.

We can fill cargo-linker.bat with HOST_LINKER and HOST_LINKER_LIBPATHS,
which, unfortunately, can't be used as is, so we add a variant for
substitution in .bat files.

Differential Revision: https://phabricator.services.mozilla.com/D18034

--HG--
extra : moz-landing-system : lando
2019-01-30 21:46:39 +00:00
Gurzau Raul
7555c5cdea Merge inbound to mozilla-central. a=merge 2019-01-30 19:03:12 +02:00
Tom Ritter
55eb3434be Bug 1523003 - Remove the force-ms-compatibility for clang-cl r=glandium 2019-01-27 17:19:57 -06:00
Alex Chronopoulos
0c15094a05 Bug 1522035 - Set HAVE_ALIGNED_MALLOC as global macro and avoid redefining in libdav1d. r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D17632

--HG--
extra : moz-landing-system : lando
2019-01-30 09:06:52 +00:00
shindli
f7752f11b1 Merge inbound to mozilla-central. a=merge 2019-01-30 06:07:01 +02:00
shindli
011ea038cb Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-01-29 23:54:31 +02:00
shindli
8f92eb66a3 Merge autoland to mozilla-central. a=merge 2019-01-29 23:35:35 +02:00
Mike Hommey
de5dfda48c Bug 1520232 - Preset some of the autoconf config.cache values from python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D17914

--HG--
extra : moz-landing-system : lando
2019-01-29 14:17:29 +00:00
Mike Hommey
327319fd40 Bug 1523537 - Remove WIN_DIA_SDK_BIN_DIR as a thing that can be set manually. r=dmajor
Now that it's automatically derived and that in-tree mozconfigs are
setting DIA_SDK_PATH, we don't need to set WIN_DIA_SDK_BIN_DIR on
automation, or elsewhere, for that matter.

Differential Revision: https://phabricator.services.mozilla.com/D17915

--HG--
extra : moz-landing-system : lando
2019-01-29 14:22:26 +00:00
Mark Banner
3a4a57f3fa Bug 1523593 - Pass arguments to check_cmd_output as simple arguments rather than a list. Bustage fix from bug 1523153. r=Gijs a=Aryx
Reviewers: Gijs

Reviewed By: Gijs

Subscribers: Gijs

Bug #: 1523593

Differential Revision: https://phabricator.services.mozilla.com/D17932

--HG--
extra : rebase_source : 8e6098c9a53a2dbb8411c645b24cd045537ce42b
extra : amend_source : ef98541406c0bb72e920a1df6c28fe3272fcacb6
2019-01-29 15:42:05 +02:00
Cosmin Sabou
599a15d354 Merge mozilla-inbound to mozilla-central. a=merge 2019-01-29 12:01:56 +02:00
Sebastian Hengst
b78e4e8667 Merge mozilla-central to mozilla-inbound
--HG--
rename : browser/components/urlbar/tests/legacy/browser_urlbar_search_no_speculative_connect_with_client_cert.js => browser/components/urlbar/tests/browser/browser_urlbar_speculative_connect_not_with_client_cert.js
2019-01-29 02:55:55 +02:00
Tom Prince
0b741aa881 Bug 1521584: [win64-aarch64] Add win64-aarch64 release mozconfigs; r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D17452

--HG--
extra : moz-landing-system : lando
2019-01-26 09:50:27 +00:00
Kartikaya Gupta
6969f0ccfb Bug 1523082 - Remove assertion and more robustly handle destructor decls. r=emilio
Clang 8 seems to generate destructor decls from different source
locations which breaks an assertion in the code. This patch updates the
code to remove the assertion and more robustly handle the new
declarations.

Differential Revision: https://phabricator.services.mozilla.com/D17902

--HG--
extra : moz-landing-system : lando
2019-01-29 03:06:35 +00:00
Mike Hommey
38189d89a7 Bug 1523146 - Remove checks for MSVC < 2017. r=dmajor
We reject MSVC compilers < 2017 already, there's no point checking for
smaller versions after that.

Differential Revision: https://phabricator.services.mozilla.com/D17770

--HG--
extra : moz-landing-system : lando
2019-01-28 03:30:03 +00:00
Cosmin Sabou
ee75c9f2c6 Backed out 6 changesets (bug 1516228) for causing bug 1523056. a=backout
Backed out changeset 24ebb52d21fa (bug 1516228)
Backed out changeset 53d93ee3ad84 (bug 1516228)
Backed out changeset 4f53ede33517 (bug 1516228)
Backed out changeset 2e6bec87c9f3 (bug 1516228)
Backed out changeset 09ee05a4cc30 (bug 1516228)
Backed out changeset 8456feb780f7 (bug 1516228)
2019-01-26 21:12:33 +02:00
Sebastian Hengst
9ece29fd9b Merge mozilla-central to autoland. CLOSED TREE 2019-01-29 12:59:48 +02:00
Mike Hommey
54831bbdf9 Bug 1523201 - Set VC_PATH and DIA_SDK_PATH in in-tree mozconfigs. r=froydnj
And remove all the variables that configure will figure out for us as a
consequence. This has the side effect of making the automation builds a
little more like local builds, in that they don't rely on preset PATH,
LIB, etc. for the build to work.

Differential Revision: https://phabricator.services.mozilla.com/D17789

--HG--
extra : moz-landing-system : lando
2019-01-28 22:41:57 +00:00
Mike Hommey
4913b1c2d2 Bug 1523204 - Streamline the DIA SDK setup. r=chmanchester
We currently rely on WIN_DIA_SDK_BIN_DIR being passed, but we can
actually derive it from the DIA SDK directory. So we now do that, except
when it's given explicitly.

While in the vicinity, move the dia2.h check to python configure.

With WIN_DIA_SDK_BIN_DIR being derived and not set when dia2.h is not
found, we don't really need MSVC_HAS_DIA_SDK anymore, so we just check
for WIN_DIA_SDK_BIN_DIR to determine whether to build dump_syms or not.

One exception to the above is when WIN_DIA_SDK_BIN_DIR is passed in,
which we only keep for the in-tree mozconfigs for now. We'll remove that
possibility after bug 1523201.

Depends on D17892

Differential Revision: https://phabricator.services.mozilla.com/D17893

--HG--
extra : moz-landing-system : lando
2019-01-29 07:38:14 +00:00
David Major
fffbdc0db1 Bug 1522771: Use -brepro to build clang-plugin.dll deterministically. r=mshal 2019-01-25 11:09:13 -05:00