This relies on no other scrollbox being in the subtree, but that's already the
case, so...
This can be seen in the add-on detail page.
The difference between applying it to #detail-view directly or not is not
perceptible, except for the case the add-on description is too large and we
don't fit into the screen.
MozReview-Commit-ID: Fg4Zx5e2A2o
All of our .proto are optimized for LITE_RUNTIME so we can use
libprotobuf-lite instead of the full libprotobuf.
devtools does need something that's not part of libprotobuf-lite
(gzip streams) and so we add that to our builds.
MozReview-Commit-ID: BW8WnTC6pv
--HG--
extra : rebase_source : ad5f3832c29f1337ecfd4d7d88d09563c1794bca
Original patch authored by Tim Nguyen (:ntim).
MozReview-Commit-ID: 6qQnRMQXPTH
--HG--
extra : rebase_source : 319d160f3057173359f02adba44bdcc12a68e209
* In the first stage, we fetch changed records, newest first, up to the
download limit. We keep track of the oldest record modified time we
see.
* Once we've fetched all records, we reconcile, noting records that
fail to decrypt or reconcile for the next sync. We then ask the store
to apply all remaining records. Previously, `applyIncomingBatchSize`
specified how many records to apply at a time. I removed this because
it added an extra layer of indirection that's no longer necessary,
now that download batching buffers all records in memory, and all
stores are async.
* In the second stage, we fetch IDs for all remaining records changed
between the last sync and the oldest modified time we saw in the
first stage. We *don't* set the download limit here, to ensure we
add *all* changed records to our backlog, and we use the `"oldest"`
sort order instead of `"index"`.
* In the third stage, we backfill as before. We don't want large deltas
to delay other engines from syncing, so we still only take IDs up to
the download limit from the backlog, and include failed IDs from the
previous sync. On subsequent syncs, we'll keep fetching from the
backlog until it's empty.
Other changes to note in this patch:
* `Collection::_rebuildURL` now allows callers to specify both `older`
and `newer`. According to :rfkelly, this is explicitly and
intentionally supported.
* Tests that exercise `applyIncomingBatchSize` are gone, since that's
no longer a thing.
* The test server now shuffles records if the sort order is
unspecified.
MozReview-Commit-ID: 4EXvNOa8mIo
--HG--
extra : rebase_source : 13605dd3a43569a6d83dc2eb15a578a7bbd5c1ca
Code changes will land separately in github[1], and will be exported to
Firefox in a separate commit.
[1] https://github.com/mozilla-services/screenshots/pull/3711
MozReview-Commit-ID: 91sA1vqN1Il
--HG--
extra : rebase_source : af3409ab56d4d9a7470c748cc6a2ce89a6f63659
If the busy attribute was not set by (STATE_IS_NETWORK & STATE_START), and the
loading results in an error, it's possible that the busy flag never gets
cleared. In this case we can clear it when receiving location change with
LOCATION_CHANGE_ERROR_PAGE.
When digging into this bug I found nsBrowserStatusFilter::mFinishedRequests
and mTotalRequests counters can be incorrect on parent side since we've applied
the filter on both child and parent processes. This hasn't seem to be causing
a bug yet but it's potentially problematic, so adding a warning in
nsBrowserStatusFilter.
MozReview-Commit-ID: H25R60ozGtM
--HG--
extra : rebase_source : 3b6f9b6c974e65d540fdae495017dd3b7fffdbb6
This was created for B2G and isn't really useful otherwise. It only works on
Linux, and it's behind the memory.system_memory_reporter pref, which is false
by default.
The patch also removes LinuxUtils.{h,cpp}, which is no longer used.
--HG--
extra : rebase_source : b97a018be11a79f83855a73b88020bfa86e60f78
And remove unreachable code after MOZ_CRASH_UNSAFE_OOL().
MOZ_CRASH_UNSAFE_OOL causes data collection because crash strings are annotated to crash-stats and are publicly visible. Firefox data stewards must do data review on usages of this macro. However, all the crash strings this patch collects with MOZ_CRASH_UNSAFE_OOL are already collected with NS_RUNTIMEABORT.
MozReview-Commit-ID: IHmJfuxXSqw
--HG--
extra : rebase_source : 031f30934b58a7b87f960e57179641d44aefe5c5
extra : source : fe9f638a56a53c8721eecc4273dcc074c988546e
And remove unreachable code after MOZ_CRASH().
MozReview-Commit-ID: 6ShBtPRKYlF
--HG--
extra : rebase_source : 0fe45a59411bda663828336e2686707b550144ae
extra : source : 8473fd7333d2abe1ea1cc176510c292a5b34df45
